| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=ProfileSyncServiceSessionTest
BUG=30519
Original patch by jerrica@chromium.org
Original review: http://codereview.chromium.org/3168009
Review URL: http://codereview.chromium.org/3184004
TBR=tim@chromium.org
Review URL: http://codereview.chromium.org/3127017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56426 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=ProfileSyncServiceSessionTest
BUG=30519
Original patch by jerrica@chromium.org
Original review: http://codereview.chromium.org/3168009
Review URL: http://codereview.chromium.org/3184004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56423 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Unit tests in file_watcher_unittest.cc.
Review URL: http://codereview.chromium.org/3149004
TBR=mnissler@chromium.org
Review URL: http://codereview.chromium.org/3165027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56349 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Unit tests in file_watcher_unittest.cc.
Review URL: http://codereview.chromium.org/3149004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Implementation of a location provider that uses the Windows 7 Location API. Currently uses polling to get the users location, I will update this to use signals provided by the API in a future patch.
BUG=45535
TEST=Two test files included.
Review URL: http://codereview.chromium.org/3015053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Original review: http://codereview.chromium.org/3005033
Patch by Ahmad Sharif <asharif@google.com>.
Review URL: http://codereview.chromium.org/3134014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is a simple offline startup integration test. This change also includes the groundwork for more complex offline startup test cases, including the ability to enable and disable network connectivity as well as configure the mock sync server with a username.
BUG=47918
Review URL: http://codereview.chromium.org/3078031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removed Unnescessary code and also refactored some.
Added tests.
Added example AppleScripts.
original patch from shreyas.
BUG=none
TEST=updates some unit tests and adds some.
Review URL: http://codereview.chromium.org/3163008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=51703
BUG=30178
BUG=25106
TEST=none
Review URL: http://codereview.chromium.org/3129003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
recognize speech.
Also added a unit test for checking the callbacks fire as expected.
TEST=unit_tests --gtest_filter=SpeechRecognizerTest.*
BUG=none
Review URL: http://codereview.chromium.org/3124009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'm renaming the platform-specific content setting bubble classes to the uniform naming scheme content_setting_bubble_{views,gtk,cocoa}.{h,cc}
XIB changes: Rename ContentBlockedBubbleController in ContentBlocked*.xib to ContentSettingBubbleController.
BUG=none
TEST=everything compiles
Review URL: http://codereview.chromium.org/3099002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=indexed_db_browsertest.cc
Review URL: http://codereview.chromium.org/3061057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Get rid of linux_fpic gyp variable.
BUG=26625
TEST=all linux builds should compile
Review URL: http://codereview.chromium.org/3135001
TBR=nirnimesh@chromium.org
Review URL: http://codereview.chromium.org/3150006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55836 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added two class for use with service process:
ServiceProcessControl
Used by the browser to launch and connect to the service process, also used
to receive messages from the service process.
ServiceProcessControlManager
A singleton to manage multiple ServicProcessControl.
BUG=50244
TEST=browser_tests --gtest_filter=ServiceProcess*
Review URL: http://codereview.chromium.org/3032061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55826 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2969005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55822 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Get rid of linux_fpic gyp variable.
BUG=26625
TEST=all linux builds should compile
Review URL: http://codereview.chromium.org/3135001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add the plumbing needed for communicating with the Device Orientation code in WebKit.
RenderView provides an implementation of WebKit::WebDeviceOrientationClient: DeviceOrientationDispatcher. This communicates with the browser-side class device_orientation::DispatcherHost.
device_orientation::Provider, responsible for providing the orientation data, is just an empty shell for now.
BUG=44654
TEST=browser_tests --gtest_filter=DeviceOrientationBrowserTest.BasicTest
Review URL: http://codereview.chromium.org/2858049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
server and parse response.
Also added a unit test.
This code will be used in upcoming CLs for speech input.
TEST=unit_tests --gtest_filter=SpeechRecognitionRequestTest.*
BUG=none
Review URL: http://codereview.chromium.org/3164002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added a method to get the next node ID for bookmarks managed by the bookmark
model.
Added AppleScript support.
Added scripting definition file.
Added support for saving tab.
Added localization support.
Added consistent error nos/error messages.
(patch developed by v.a.shreyas@gmail.com)
BUG=27468
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=50548
TEST=compiles
Review URL: http://codereview.chromium.org/3110002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55503 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
don't have to do it when running the test.
Remove all the code in the test for copying files since it's no
longer needed.
The difference from before is we only copy over the pepper test
plugin on windows because it's the only platform with tests for
it. On Linux, unloading the plugin was causing random crashes
in tcmalloc.
Review URL: http://codereview.chromium.org/3015064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Adding ServiceProcessTest so I can add test for the service process.
TEST=This is a test dude!
BUG=none
Review URL: http://codereview.chromium.org/3081020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55312 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This reverts commit r55235.
Review URL: http://codereview.chromium.org/3090020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
have to do it when running the test.
Remove all the code in the test for copying files since it's no longer needed.
Review URL: http://codereview.chromium.org/3048048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
overlay.
We should've used "set" rather than "vector" to remove duplicates.
TEST=manually
BUG=chromium-os:4573
Review URL: http://codereview.chromium.org/3043058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
{ASSERT,EXPECT}_NS{NE,EQ}. These test ObjC objects using |-isEqual:| and
prints failures using the |-description| selector. This allows for better
debugging output with ObjC++ test cases.
BUG=http://code.google.com/p/googletest/issues/detail?id=303
TEST=Covered by unit tests.
Review URL: http://codereview.chromium.org/3028047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
when the test is running.
Review URL: http://codereview.chromium.org/3028045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- move filename generation parts and related code out of DownloadManager
download_util is not the best place for it, but it's better than
DownloadManager which we're trying to minimize
- clean up posting tasks to different threads. There's no need to create
separate methods for that, it was cluttering the file needlessly
- other minor cleanups, like using static_cast instead of C-style cast
TEST=unit_tests, browser_tests, ui_tests
BUG=48913
Review URL: http://codereview.chromium.org/3043048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55088 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3031046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55018 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The AllStatus is now strictly used for status reporting in UI.
Motivation is that the ST can get what it needs from other sources it already depends on, and less dependencies is a good thing (easier to get to MLs, and but also AllStatus is pretty complicated and makes it hard to follow what's going on when looking at the SyncerThread code). And GetRecommendedDelay just didn't belong in there in the first place IMO.
AllStatus is complicated as it tries to keep an instantaneously up-to-date status, which is a) error prone and buggy and b) not needed by the syncer thread, which only needs to check things after a session has completed. The one subtle fact is on exit, calling Syncer::RequestEarlyExit means we may not hit SyncerEndCommand so previous_session_snapshot() will be out of date. In this case though we don't care, since we don't need SyncerThread::CalculatePollingWaitTime to do anything.
BUG=26339
TEST=SyncerThreadTest
Review URL: http://codereview.chromium.org/3078022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This changes the two-tone background to an even gradient and changes the push
state of the buttons to use the blue selected menu item color.
BUG=none
TEST=visual
Review URL: http://codereview.chromium.org/3072021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55007 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebKit.
Please advise if any of the code needs to be within "#if ENABLE_INPUT_SPEECH", since most of the speech input code in webkit is under "#if ENABLE(INPUT_SPEECH)"
- Created renderer/SpeechInputDispatcher, implements WebKit::WebSpeechInputController which is used by WebView for invoking speech input.
- Created browser/speech/SpeechInputDispatcherHost to receive IPC messages from the above SpeechInputDispatcher. Nothing done yet apart from receiving the messages.
- Creates new directory chrome/browser/speech, this will be used for SpeechInputDispatcherHost, network based speech recognizer, speech audio recording/buffering code as well as speech output (Text-to-speech) code in future.
BUG=none
TEST=no functionality to test yet.
Review URL: http://codereview.chromium.org/3035035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Incorporate 'quick' history provider index as an autocomplete provider in preparation for the replacement of the current history_url_provider. This step refactors the history provider code a bit, introduces the replacement class (history-quick_provider), and adds a unittest template. Note that the 'quick' provider will only support the fast, synchronous autocomplete pass. Once the quick provider has been completed the current history_url_provider will be replaced. In the meantime, the latter will remain in operation in order to provide the slower history results.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3005050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Sorry about that, a little oversight from yesterday's CL, since it's in another repo.
BUG=0
TEST=Look at the windows coverage dashboard, it should start being meaningful soon. :-)
Review URL: http://codereview.chromium.org/3090008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds a basic API that will cover the features available with the --proxy-server command-line switch,
once the underlying proxy config is rewritten to actually access the pref dynamically rather than
only ever loading a proxy config on startup.
BUG=48930
TEST=covered by browser_tests (ExtensionApiTest.Proxy*)
Review URL: http://codereview.chromium.org/3074013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Divider shows when the mouse is not hovering.
BUG=50575
TEST=divider shows when the mouse is not hovering.
Review URL: http://codereview.chromium.org/3014049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54843 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
XIB changes:
* Replace the edit item's segmented control with 3 buttons
* Make the root view of both items a MenuTrackedRootView
* Use the custom MenuTrackedButton for all the buttons
BUG=49356
TEST=Click open the Wrench menu, hold, and drag over the buttons and they perform their function.
Review URL: http://codereview.chromium.org/3072014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The webRequest API doesn't support the planned filter and extraInfoSpec parameters yet, these will be added later.
BUG=50943
TEST=ExtensionApiTest.WebRequest,ExtensionApiTest.WebNavigation
Review URL: http://codereview.chromium.org/3061041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The sync integration tests are missing some dependencies on mac, as a
result of which they crash when they are run. Adding this build flag
seems to fix the problem elsewhere in chrome_tests.gypi.
BUG=50789
TEST=sync_integration_tests
Review URL: http://codereview.chromium.org/3057030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3012017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54612 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also do some cleanup of context menu tests, including adding a generic
mechanism to let javascript pass a test message and have C++ test code wait
for and retrieve those messages.
BUG=49744
TEST=Follow steps in bug report
Review URL: http://codereview.chromium.org/3017047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54514 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Flip the compile-time enable switch for speech input to on and add a
command-line switch to put the functionality behind. The command-line
flag will be used both on the Chromium side and in WebKit via
WebRuntimeFeatures.
This CL depends on the webkit patch https://bugs.webkit.org/show_bug.cgi?id=43146
BUG=none
TEST=browser_tests --gtest_filter=SpeechInputEnableSwitchTest.*
Originally Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54235, but reverted due to tests failure.
Review URL: http://codereview.chromium.org/3064017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Broke AutocompleteEditViewTest.DesiredTLD and AutocompleteEditView.EscapeToDefaultMatch on Linux.
TBR=mrossetti
Review URL: http://codereview.chromium.org/3052031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
preparation for the replacement of the current history_url_provider. This step refactors the history provider code a bit, introduces the replacement class (history-quick_provider), and adds a unittest template. Note that the 'quick' provider will only support the fast, synchronous autocomplete pass. Once the quick provider has been completed the current history_url_provider will be replaced. In the meantime, the latter will remain in operation in order to provide the slower history results.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3017008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The window doesn't have any contents yet, which makes its appearance look a bit janky for now.
BUG=50307
TEST=
* All the following happens only if --enable-expose-for-tabs is passed in, else all of it should be disabled.
* In a browser window, hit cmd-f10 or three-finger-swipe down. A grey overlay with a gradient at the top should appear.
* The overlay should cover tab contents, eventual info bars, the bookmarks bar if it's detached (but not the bookmarks bar if it's not detached), and eventual attached inspector windows. It should not cover the download shelf if it's open.
* The window should block clicks on the tab strip and the download shelf for now.
* The overlay should close on three-finger-swipe up, click, esc, enter, and space.
* Every open browser window should have its own overlay, and they should be independent of each other.
* If a browser window with an overlay window is active, most menu items should be greyed out, and all browser-related keyboard shortcuts should be disabled.
* In particular, hitting cmd-f10 twice should open only one overlay per browser window
* The overlay should have the correct size with a UI scale factor > 1
Review URL: http://codereview.chromium.org/2819070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54349 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
view which provides an image based button that changes on hover and press.
Refer to the bug for screenshots of the current and desired UI.
Screenshot of what results from this patch is visible at http://www.corp.google.com/~johnnyg/49490patch.png
XIB change: change height of title bar, change bindings of buttons.
BUG=49190
TEST=notifications on the mac
Review URL: http://codereview.chromium.org/3014004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
This reverts commit r54235.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Flip the compile-time enable switch for speech input to on and add a
command-line switch to put the functionality behind. The command-line
flag will be used both on the Chromium side and in WebKit via
WebRuntimeFeatures.
This CL depends on the webkit patch https://bugs.webkit.org/show_bug.cgi?id=43146
BUG=none
TEST=browser_tests --gtest_filter=SpeechInputEnableSwitchTest.*
Review URL: http://codereview.chromium.org/3064017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=50548
Review URL: http://codereview.chromium.org/3043030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:4485
TEST=unit tests
Review URL: http://codereview.chromium.org/3058021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54199 0039d316-1c4b-4281-b951-d872f2087c98
|