| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
This change supports component actions in the toolbar, which previously only supported extension actions. ExtensionToolbarModel now keep track of extension ids (strings) rather than Extensions.
This change also fixes the blank placement for the Media Router Action icon in new windows.
BUG=511292, 511427, 511302
Review URL: https://codereview.chromium.org/1241063003
Cr-Commit-Position: refs/heads/master@{#343808}
|
|
|
|
|
|
|
|
| |
BUG=517489
Review URL: https://codereview.chromium.org/1284423003
Cr-Commit-Position: refs/heads/master@{#343728}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Entry point from blink is PermissionDispatcher::requestPermission
- IPC is handled internally by the permission service
- Permission service stores user's choice in content settings
Corresponding Blink change, which must land first, is
https://codereview.chromium.org/1154573005/
BUG=482814
Review URL: https://codereview.chromium.org/1164073005
Cr-Commit-Position: refs/heads/master@{#343468}
|
|
|
|
|
|
|
|
|
|
|
|
| |
The counting is restarted whenever the deletion preference or the contents of the password store change.
This CL also contains some polishing of the parent BrowsingDataCounter class.
BUG=510028
Review URL: https://codereview.chromium.org/1275593002
Cr-Commit-Position: refs/heads/master@{#343254}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Introduce cross_site_iframe_factory.html, and use it to test the site isolation code in MemoryMetricsDetails under chrome/.
[ See crbug.com/515672 for a screenshot ]
/cross_site_iframe_factory.html?a(b(c, d)) gives you a simple three-level,
four-site iframe test. The trick it uses, is that the query parameter
is parsed and passed recursively to children, so the first level is:
<iframe src="b.com:1234/cross_site_iframe_factory.html?b(c(),d())">
Which then contains the two leaf iframes:
<iframe src="c.com:1234/cross_site_iframe_factory.html?c()">
<iframe src="d.com:1234/cross_site_iframe_factory.html?d()">
To to cut down on noise. ".com" is automatically affixed to the hostname
if a TLD isn't present.
As a convenience, the page supports local preview if loaded via file:// URI.
file:// URIs are technically cross-origin, although --site-per-process doesn't
isolate them today.
Each site has a random (but consistent) background color as a visual aid.
The page contains some crude layout logic to make sure the outer levels
are big enough to fit the inner levels.
The parsing logic is in tree_parser_util.js, which has unittests.
MetricsMemoryDetailsBrowserTest.TestSiteIsolation is a new test
that uses the above facility to creates a bunch of complex iframe
cases, and tests that our process-counting UMA stats are as expected.
BUG=515672
CQ_INCLUDE_TRYBOTS=tryserver.chromium.mac:mac_chromium_10.6_rel_ng;tryserver.chromium.win:win_chromium_vista_rel_ng
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/1264923002
Cr-Commit-Position: refs/heads/master@{#342447}
Review URL: https://codereview.chromium.org/1288433002
Cr-Commit-Position: refs/heads/master@{#343132}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds support for some of test binaries needed in the
'archive_gpu_tests=true' config of a GYP build:
- content_gl_tests
- gles2_conform_tests
- gl_tests
- tab_capture_end2end_tests
There is still more work to be done (telemetry_gpu_tests,
angle_end2end_tests, angle_deqp_*_tests).
R=brettw@chromium.org
BUG=519778
Review URL: https://codereview.chromium.org/1285063002
Cr-Commit-Position: refs/heads/master@{#343095}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This test doesn't cover route detail dialog, since I don't know how to
get the object model for route detail dialog, added a TODO for that.
Moreover, it also doesn't cover the failure case, since IssueManager
hasn't been implemented, we should add failure cases to cover it once
IssueManager has been done.
BUG=464227
Review URL: https://codereview.chromium.org/1244993002
Cr-Commit-Position: refs/heads/master@{#342940}
|
|
|
|
|
|
|
|
|
|
|
| |
Introduce AshInteractiveUITestBase for setting up gl, resources, aura for interactive
ui-tests that live in ash.
BUG=none
Review URL: https://codereview.chromium.org/1282433003
Cr-Commit-Position: refs/heads/master@{#342622}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moved: drive_pref_names.*, drive_test_util.*, file_change.*,
file_error.*, local_file_reader.*
Other changes:
- Removed unnecessary include/dependency inside file_change.h
- ChromeOS if-def guards in drive_test_util.h
- Necessary DEPS tweaks
Test steps:
1. Verify that things still build via GYP (and unit tests pass).
$ GYP_DEFINES="use_goma=1 gomadir=... chromeos=1" gclient sync
$ ninja -C out/Debug -j 150 chrome unit_tests \
interactive_ui_tests browser_tests drive
$ out/Debug/unit_tests
2. git cl try
TBR=satorux@chromium.org,benchan@chromium.org
TEST=Please see "Test steps" above.
BUG=257943, 498951
Review URL: https://codereview.chromium.org/1246753003
Cr-Commit-Position: refs/heads/master@{#342492}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #9 id:150001 of https://codereview.chromium.org/1264923002/ )
Reason for revert:
Fails on Windows Vista and Mac 10.6
http://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20(1)/builds/58432
http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests/builds/5408
../../chrome/browser/site_details_browsertest.cc:121: Failure
Value of: details->uma()->GetAllSamples( "SiteIsolation.IsolateAllSitesTotalProcessCountEstimate")
Expected: has 1 element that is equal to Bucket 11: 1
Actual: { Bucket 10: 1 }, whose element #0 doesn't match
Original issue's description:
> Introduce cross_site_iframe_factory.html, and use it to test
> the site isolation code in MemoryMetricsDetails under chrome/.
>
> [ See crbug.com/515672 for a screenshot ]
>
> /cross_site_iframe_factory.html?a(b(c, d)) gives you a simple three-level,
> four-site iframe test. The trick it uses, is that the query parameter
> is parsed and passed recursively to children, so the first level is:
>
> <iframe src="b.com:1234/cross_site_iframe_factory.html?b(c(),d())">
>
> Which then contains the two leaf iframes:
>
> <iframe src="c.com:1234/cross_site_iframe_factory.html?c()">
> <iframe src="d.com:1234/cross_site_iframe_factory.html?d()">
>
> To to cut down on noise. ".com" is automatically affixed to the hostname
> if a TLD isn't present.
>
> As a convenience, the page supports local preview if loaded via file:// URI.
> file:// URIs are technically cross-origin, although --site-per-process doesn't
> isolate them today.
>
> Each site has a random (but consistent) background color as a visual aid.
> The page contains some crude layout logic to make sure the outer levels
> are big enough to fit the inner levels.
>
> The parsing logic is in tree_parser_util.js, which has unittests.
>
> MetricsMemoryDetailsBrowserTest.TestSiteIsolation is a new test
> that uses the above facility to creates a bunch of complex iframe
> cases, and tests that our process-counting UMA stats are as expected.
>
> BUG=515672
>
> Committed: https://crrev.com/02292e994c9ec62deecec3bec2132500ca68a5de
> Cr-Commit-Position: refs/heads/master@{#342447}
TBR=dcheng@chromium.org,asvitkine@chromium.org,jam@chromium.org,nick@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=515672
Review URL: https://codereview.chromium.org/1282623002
Cr-Commit-Position: refs/heads/master@{#342473}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the site isolation code in MemoryMetricsDetails under chrome/.
[ See crbug.com/515672 for a screenshot ]
/cross_site_iframe_factory.html?a(b(c, d)) gives you a simple three-level,
four-site iframe test. The trick it uses, is that the query parameter
is parsed and passed recursively to children, so the first level is:
<iframe src="b.com:1234/cross_site_iframe_factory.html?b(c(),d())">
Which then contains the two leaf iframes:
<iframe src="c.com:1234/cross_site_iframe_factory.html?c()">
<iframe src="d.com:1234/cross_site_iframe_factory.html?d()">
To to cut down on noise. ".com" is automatically affixed to the hostname
if a TLD isn't present.
As a convenience, the page supports local preview if loaded via file:// URI.
file:// URIs are technically cross-origin, although --site-per-process doesn't
isolate them today.
Each site has a random (but consistent) background color as a visual aid.
The page contains some crude layout logic to make sure the outer levels
are big enough to fit the inner levels.
The parsing logic is in tree_parser_util.js, which has unittests.
MetricsMemoryDetailsBrowserTest.TestSiteIsolation is a new test
that uses the above facility to creates a bunch of complex iframe
cases, and tests that our process-counting UMA stats are as expected.
BUG=515672
Review URL: https://codereview.chromium.org/1264923002
Cr-Commit-Position: refs/heads/master@{#342447}
|
|
|
|
|
|
|
|
|
|
|
| |
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
R=nick@chromium.org
BUG=470994
TEST=
Review URL: https://codereview.chromium.org/1254103002
Cr-Commit-Position: refs/heads/master@{#342377}
|
|
|
|
|
|
|
|
|
|
|
| |
chrome.enterprise.DeviceAttributes.getDirectoryDeviceId().
An API to allow extensions to get the cloud directory API device Id.
BUG=502330
Review URL: https://codereview.chromium.org/1240283002
Cr-Commit-Position: refs/heads/master@{#342331}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fake out key status to make Widget::Activate/IsActive work in the unit test.
If-def out the part that requires Widget::Deactivate as it's not supported on
Mac.
The test was also failing because Mac checks WidgetDelegate::CanActivate()
when activating whereas NativeWidgetAura defers this to `ShouldActivate`
which is only checked by wm::BaseFocusRules.
Also improve c/b/ui/test/scoped_fake_nswindow_main_status to handle
key status as well and move it to ui/base/test/.
BUG=378134
Review URL: https://codereview.chromium.org/1268293002
Cr-Commit-Position: refs/heads/master@{#342289}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Introduces a ProfileIOData::SetCertVerifierForTesting() hook, called by
the CertVerifierBrowserTest class. CertVerifierBrowserTest tests can use
mock_cert_verifier() to set mock cert verify results.
BUG=
Review URL: https://codereview.chromium.org/1227943002
Cr-Commit-Position: refs/heads/master@{#342038}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This resource is used by Omnibox code to be componentized.
This CL also adds iOS-specific versions of the resource; these differ
from the version used on other platforms.
BUG=515889
TBR=grt
Review URL: https://codereview.chromium.org/1266103006
Cr-Commit-Position: refs/heads/master@{#341888}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Finch test 'CDL1VsCLD2' is a test to make sure that CLD2 is not
worse than CLD1 in terms of performance or accuracy. This test is no
longer executed on any platforms. Let's remove this for code health.
CLD version '0' is used to represent to use the Finch trial, and this
CL removes the cases of version 0 from gn, gypi and C++ files.
BUG=515358
Review URL: https://codereview.chromium.org/1259883007
Cr-Commit-Position: refs/heads/master@{#341496}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Only BrowserWindowController implements this. Other implementors just
turn it into a no-op. ChromeEventProcessingWindow (CEPW) now simply
checks whether it's a Browser window and executes the command.
This is the first step to factor out keyboard shortcut handling in CEPW into
a component that can be reused in Views as it removes one (of two)
dependencies on -[NSWindow windowController], which cannot be used
to implement browser-side behavior under Views.
Added new browser_test for shortcuts in global_keyboard_shortcuts_mac.
Some history:
BrowserCommandExecutor was added in r30619 (6 years ago) to allow a
non-browser window to execute browser commands, but became obsolete
a month later in r32445 when HtmlDialogWindowController (now
WebDialogWindowController) decided to ignore those commands instead.
BUG=508438
Review URL: https://codereview.chromium.org/1250533003
Cr-Commit-Position: refs/heads/master@{#341062}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds a power source dropdown to the power overlay, and enables the
overlay on devices that support dual-role USB devices.
BUG=419509,426886
TEST=chrome/browser/ui/webui/options/chromeos/power_overlay_browsertest.js
Review URL: https://codereview.chromium.org/1257963002
Cr-Commit-Position: refs/heads/master@{#341004}
|
|
|
|
|
|
|
|
|
|
|
| |
This will allow us to put the GLES3 tests on the GPU FYI bots.
Also remove the old expectations file from the isolate.
BUG=510822
Review URL: https://codereview.chromium.org/1249623006
Cr-Commit-Position: refs/heads/master@{#340082}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change moves the files in the root content folder to a new
browser folder. This is to help differentiate future code that
will run on the renderer.
BUG=
Review URL: https://codereview.chromium.org/1227123002
Cr-Commit-Position: refs/heads/master@{#339927}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will allow us to make a new angle_deqp_gles3_tests target.
Temporarily include two expectations files in the isolate, until we can
make the switch in ANGLE, then disable the older file.
Will require us to take the deqp_tests offline temporarily, or switch
them very quickly after this lands, so we don't get any broken builds
which look for the older names.
BUG=510822
TEST=bots, manual testing with isolates.
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/1249693003
Cr-Commit-Position: refs/heads/master@{#339903}
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=412331
NOTRY=true
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/1228863005
Cr-Commit-Position: refs/heads/master@{#339708}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This results in incorrect context menu positioning in pdf in webview or
webview inside appview.
If a guest A is nested within an embedder B, which in turn is nested inside
an embedder C, then we used to add offset twice to calculate the bounds of A
because BrowserPluginGuest::GetScreenCoordinates would add:
1. offset of C from A and
2. offset of B from A.
This CL removes step #2.
From logs, it seems to be there from the beginning of appview implementation.
BUG=507223
Test=Load a PDF inside <webview> and check context menu inside the PDF.
Easier to test with the browser sample:
https://github.com/GoogleChrome/chrome-app-samples/tree/master/samples/webview-samples/browser
You should observe the context menu is shown in the right place instead of
it being shifted.
Review URL: https://codereview.chromium.org/1237343002
Cr-Commit-Position: refs/heads/master@{#339635}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This implements the PanelTag to tag WebContents owned by a Panel in the
PanelManager so that panel can show up in the task manager.
R=nick@chromium.org
BUG=470992
TEST=interactive_ui_tests
--gtest_filter=PanelBrowserTest.TaskManagement*
Review URL: https://codereview.chromium.org/1230113011
Cr-Commit-Position: refs/heads/master@{#339538}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The header is now meant to be an interface for any
system that would like to use its own spellchecker
instead of the hunspell library.
Split the implementation into two source files, one for mac and one for android.
The android implementation is just method stubs for now.
Updated related build files and #include references.
Part 1 of a 3 part breakdown of https://codereview.chromium.org/1204293003.
The breakdown will also include some changes to the original CL.
BUG=415302
Review URL: https://codereview.chromium.org/1230933002
Cr-Commit-Position: refs/heads/master@{#339195}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
workers
Service Workers require a secure origin, such as HTTPS. chrome-extension:// pages are not HTTP/HTTPS, but are secure so this change becomes a necessary step to allow extensions to register a Service Worker.
"chrome-extension" is added as a scheme allowing service workers.
BUG=501569
Review URL: https://codereview.chromium.org/1211243010
Cr-Commit-Position: refs/heads/master@{#338708}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These tests don't depend on the specifics of ChromeShell, so they're
trivial to move from ChromeShell to ChromePublic: just remove them from
the dependency list for ChromeShellTest and add them to the deps list
for ChromePublicTest.
This also removes invalidation_javatests and precache_javatests from
ChromeShellTest, since they're already included in ChromePublicTest.
BUG=505040
Review URL: https://codereview.chromium.org/1235023002
Cr-Commit-Position: refs/heads/master@{#338611}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL splits OomPriorityManager into OomPriorityManager and OomPriorityManagerDelegate, the former being the shared functionality on all platforms and the latter being OS specific (only CrOS for now).
It is still only enabled on CrOS, other platforms will be enabled behind flags once everything is in place (still missing chrome://discards).
Note: This is CL #7 towards expanding Chromeos tab killing to other platforms.
BUG=463597
R=jamescook@chromium.org
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/1221883005 .
Cr-Commit-Position: refs/heads/master@{#338504}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #2 id:20001 of https://codereview.chromium.org/1221333013/)
Reason for revert:
Speculative revert: appreas to have broken the GPU mac builders.
http://build.chromium.org/p/chromium.webkit/builders/GPU%20Mac%2010.9%20%28Intel%29%20%28dbg%29/builds/11045 .. 11141
Original issue's description:
> Add support for escaped target names in isolate driver (4th try)
>
> Currently the isolate_driver.py which creates the dependency files
> used by the isolate system, does a simple split on all spaces when
> trying to identify targets.
>
> This can fail if the target name contains a space in the name. In
> ninja, spaces are escaped with a $-prefix. An example would be
> 'Content$ Shell$ Helper.app'.
>
> This CL adds support for such target names and ensures that they
> stay as one item. Doing this uncovered a few missing dependencies
> and a missing file in some .isolate-files for the component build
> on Mac.
>
> 1st try: https://codereview.chromium.org/970203003/
> 1st revert: https://codereview.chromium.org/985753002/
> 2nd try: https://codereview.chromium.org/1103793002/
> 2nd revert: https://codereview.chromium.org/1129493003/
> 3rd try: https://codereview.chromium.org/1130523003/
> 3rd revert: https://codereview.chromium.org/1131363003/
> BUG=462248
>
> Committed: https://crrev.com/c58992cc880b5bff5813276ee9d20a79be70b31f
> Cr-Commit-Position: refs/heads/master@{#338402}
TBR=thakis@chromium.org,vadimsh@chromium.org,nyquist@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=462248
Review URL: https://codereview.chromium.org/1227843004
Cr-Commit-Position: refs/heads/master@{#338497}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously GN would put object files in a similar place to GYP. They would go in a corresponding directory as the source file and would be prefixed with the target name for uniqueness.
Since GN target names are not unique, this doesn't work as well. Instead use a simpler scheme and put all the object files in a directory for each target.
This causes a few object file name collisions which this patch fixes in various ways:
- Renamed chrome/browser/ui/views/find_bar_host_interactive_uitest.cc to have "views" in the name (collided with chrome/browser/ui/find_bar/find_bar_host_interactive_uitest.cc)
- Renamed chrome/browser/apps/speech_recognition_browsertest.cc to have "app" in the name (collided with chrome/browser/speech/speech_recognition_browsertest.cc).
- Renamed chrome/common/extensions/api/extension_api_unittest.cc to have "common" in the name (collided with chrome/browser/extensions/extension_api_unittest.cc which is actually a test harness with that name).
- Moved the extensions files that were in the chrome interactive UI tests and browser tests to source sets in the extensions directory. These are things that should be cleaned up and moved there anyway.
- Net has some messy duplication in quic files. I made a dummy target for them. Apparently each copy of this file (same code, different namespace) is supposed to match something different upstream and this should be fixed.
- Moved chrome/browser/chromeos unit tests to its own target.
- Renamed chrome/browser/favicon/favicon_helper to favicon_utils. It conflicted with chrome/browser/android/favicon_helper which has an actual class named "FaviconHelper.
- Renamed service.* and service_factory.* in chrome/browser/chromeos/launcher_search_provider to have a launcher_search_provider prefix to avoid collisions with the file_system_provider one.
- Added a "chromeos" prefix to chrome/browser/chromeos/first_run/first_run_browsertest.cc to avoid collisions with the one in browser/first_run.
- Added "chromeos" to chrome/browser/chromeos/preferences_browsertest.cc to avoid collision with browser/ui/webui/options.
- Rename "chrome/browser/chromeos/drive/test_util.*" to "drive_test_util.*". Update includes. Rename chrome/browser/chromeos/file_manager/drive_test_util* to mount_test_util to avoid colliding with above new file.
The deps->public_deps changes in components/policy and content/test is because those targets were used externally in a way that this patch uncovered.
Review URL: https://codereview.chromium.org/1208963003
Cr-Commit-Position: refs/heads/master@{#338408}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently the isolate_driver.py which creates the dependency files
used by the isolate system, does a simple split on all spaces when
trying to identify targets.
This can fail if the target name contains a space in the name. In
ninja, spaces are escaped with a $-prefix. An example would be
'Content$ Shell$ Helper.app'.
This CL adds support for such target names and ensures that they
stay as one item. Doing this uncovered a few missing dependencies
and a missing file in some .isolate-files for the component build
on Mac.
1st try: https://codereview.chromium.org/970203003/
1st revert: https://codereview.chromium.org/985753002/
2nd try: https://codereview.chromium.org/1103793002/
2nd revert: https://codereview.chromium.org/1129493003/
3rd try: https://codereview.chromium.org/1130523003/
3rd revert: https://codereview.chromium.org/1131363003/
BUG=462248
Review URL: https://codereview.chromium.org/1221333013
Cr-Commit-Position: refs/heads/master@{#338402}
|
|
|
|
|
|
|
|
|
|
|
| |
Fix the focus manager JS error and a couple other errors.
BUG=501138
TEST=BluetoothPairingUITest.Basic
Review URL: https://codereview.chromium.org/1227133003
Cr-Commit-Position: refs/heads/master@{#338225}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch enables the user to select multiple languages for
spellchecking using the right click menu, as well as through the
chrome://settings/languages. It can be enabled through a command
line flag "--enable-multilingual-spellchecker". It also adds the
option to enable or disable this flag using the chrome://flags page.
TEST=*SpellcheckService*
TEST=*Multilanguage*
Original patch from Klemen Forstnerič (klemen.forstneric@gmail.com).
BUG=5102
Review URL: https://codereview.chromium.org/1156473007
Cr-Commit-Position: refs/heads/master@{#338174}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Part 3 of 3: Implementing a task-manager representation of WebContents
owned
by the TabStripModel.
R=nick@chromium.org
BUG=470990
TEST=browser_tests --gtest_filter=TabContentsTagTest.*
Committed: https://crrev.com/543b07d4fb0b807639e8d29a0249794f240db091
Cr-Commit-Position: refs/heads/master@{#337936}
Review URL: https://codereview.chromium.org/1212663002
Cr-Commit-Position: refs/heads/master@{#338101}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Providing (patchset #3 id:40001 of https://codereview.chromium.org/1212663002/)
Reason for revert:
Reverting this because it makes the following test flaky: BackgroundContentsTagTest.PreExistingTasksAreProvided
See example of failure here: https://commondatastorage.googleapis.com/chromium-build-logs/logs/2015/7/ahVzfmNocm9taXVtLWJ1aWxkLWxvZ3NynAELEgVCdWlsZCJ7MSAtIGh0dHA6Ly9idWlsZC5jaHJvbWl1bS5vcmcvcC9jaHJvbWl1bS5jaHJvbWl1bW9zL2pzb24gLSBMaW51eCBDaHJvbWl1bU9TIFRlc3RzIChkYmcpKDEpIC0gNDM4OCAtIDE0MzYzOTkyODIgLSAxNDM2NDAwNzQxDAsSCUJ1aWxkU3RlcBiAgICAgOSVCQw
Error message:
../../chrome/browser/task_management/providers/web_contents/background_contents_tag_browsertest.cc:117: Failure
Value of: task->title()
Actual: Tab: about:blank
Expected: GetBackgroundTaskExpectedName(extension)
Which is: Background Page: app_process_background_instances
Original issue's description:
> New Task Manager - Phase 1.3.2: Implement Tab Contents Task Providing
>
> Part 3 of 3: Implementing a task-manager representation of WebContents
> owned
> by the TabStripModel.
>
> R=nick@chromium.org
> BUG=470990
> TEST=browser_tests --gtest_filter=TabContentsTagTest.*
>
> Committed: https://crrev.com/543b07d4fb0b807639e8d29a0249794f240db091
> Cr-Commit-Position: refs/heads/master@{#337936}
TBR=nick@chromium.org,gavinp@chromium.org,pkasting@chromium.org,avi@chromium.org,davidben@chromium.org,afakhry@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=470990
Review URL: https://codereview.chromium.org/1229923002
Cr-Commit-Position: refs/heads/master@{#338051}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Two things added:
1) Call SetNonBrowserUIDisplayed() in the ShowMessageBox implementation.
2) Break and return if non-browser UI was displayed when recording either of the two metrics: Startup.FirstWebContents.NonEmptyPaint, Startup.FirstWebContents.MainFrameLoad
BUG=495017
Review URL: https://codereview.chromium.org/1169503002
Cr-Commit-Position: refs/heads/master@{#338048}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently if the password manager fills a username and the user tries to
change it, we delete the password associated with this username. This causes
problems in the case where the password manager has an incorrect username
associated with the password for whatever reason. This change will keep the
password until another one is chosen via the autofill dropdown. This requires removing
inline autocomplete as the password can no longer change to match the previewed username.
This change also removes logging for OtherPossibleUsernamesUsage as a side effect, as the complication that it introduced in PasswordAutofillAgent no
longer seems worth the effort to keep around.
BUG=496167
Review URL: https://codereview.chromium.org/1205693003
Cr-Commit-Position: refs/heads/master@{#337943}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Part 3 of 3: Implementing a task-manager representation of WebContents
owned
by the TabStripModel.
R=nick@chromium.org
BUG=470990
TEST=browser_tests --gtest_filter=TabContentsTagTest.*
Review URL: https://codereview.chromium.org/1212663002
Cr-Commit-Position: refs/heads/master@{#337936}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*re-land to only build on testing configs*
The dEQP tests provide extensive OpenGL ES2 coverage, and we plan to run
them continuously on a Windows GPU FYI. Other platforms forthcoming.
BUG=500736
TEST=bots, manual testing with run_isolated.py
Review URL: https://codereview.chromium.org/1206373008
Cr-Commit-Position: refs/heads/master@{#337651}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
0 configs already ran on Swarming
19 used to run locally and were converted:
- chromium.fyi.json: Linux Trusty
- chromium.fyi.json: Linux Trusty (dbg)
- chromium.linux.json: Linux Tests
- chromium.linux.json: Linux Tests (dbg)(1)
- chromium.linux.json: Linux Tests (dbg)(1)(32)
- chromium.mac.json: Mac10.10 Tests
- chromium.mac.json: Mac10.6 Tests
- chromium.mac.json: Mac10.8 Tests
- chromium.mac.json: Mac10.9 Tests
- chromium.mac.json: Mac10.9 Tests (dbg)
- chromium.memory.fyi.json: Linux ChromeOS MSan Tests
- chromium.memory.fyi.json: Linux MSan Tests
- chromium.memory.fyi.json: Linux TSan Tests
- chromium.memory.json: Mac ASan 64 Tests (1)
- chromium.win.json: Vista Tests (1)
- chromium.win.json: Win 7 Tests x64 (1)
- chromium.win.json: Win7 Tests (1)
- chromium.win.json: Win7 Tests (dbg)(1)
- chromium.win.json: XP Tests (1)
Ran:
./manage.py --convert chromedriver_unittests
R=thakis@chromium.org
BUG=98637
Review URL: https://codereview.chromium.org/1222713003
Cr-Commit-Position: refs/heads/master@{#337456}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Modifies the existing socket_permissions test to do both UDP and TCP, and verify that UDP multicast is not accessible without permission.
Adds a no_permissions test to make sure TCP and UDP sockets are not accessible without permissions.
Adds a multicast_permissions test to make sure UDP multicast is accessible with permission.
BUG=464452
Review URL: https://codereview.chromium.org/1220053005
Cr-Commit-Position: refs/heads/master@{#337327}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The PermissionBubbleManager merges request that happened before the load
event when the load event happens. This was actually broken because the
boolean used was never reset to 0, even after the main frame was navigated.
Note that it means that this feature was never really working so we might
end up with permission prompts being delayed a lot because the load event
takes too long to happen.
BUG=434104
Review URL: https://codereview.chromium.org/1187923005
Cr-Commit-Position: refs/heads/master@{#336954}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1219623008/)
Reason for revert:
Looks like deqb.gypi requires exceptions, deqp.gypi sets _HAS_EXCEPTIONS=1 and whatnot. This causes crbug.com/505888 and we generally don't enable exceptions anywhere in chrome code.
Original issue's description:
> Add angle_deqp_tests target and isolate.
>
> The dEQP tests provide extensive OpenGL ES2 coverage, and we plan to run
> them continuously on a Windows GPU FYI. Other platforms forthcoming.
>
> BUG=500736
> TEST=bots, manual testing with run_isolated.py
>
> Committed: https://crrev.com/965a48279e0e60226118234b7fdfd00db215e754
> Cr-Commit-Position: refs/heads/master@{#336806}
TBR=piman@chromium.org,maruel@chromium.org,kbr@chromium.org,jmadill@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=500736
Review URL: https://codereview.chromium.org/1211833003
Cr-Commit-Position: refs/heads/master@{#336834}
|
|
|
|
|
|
|
|
|
|
|
|
| |
The dEQP tests provide extensive OpenGL ES2 coverage, and we plan to run
them continuously on a Windows GPU FYI. Other platforms forthcoming.
BUG=500736
TEST=bots, manual testing with run_isolated.py
Review URL: https://codereview.chromium.org/1219623008
Cr-Commit-Position: refs/heads/master@{#336806}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The invalidation component has dependencies due to specific
implementations of the inv_client, inv_service etc.
Consumers of invalidations do not need to depend on these.
This change exports the InvalidationHandler interface in a separate target
'invalidation_public' which only depends on //google/cacheinvalidation
Thus the signin component can implement to InvalidationHandler to refresh
account information without introducing a cyclic dependency.
The crux of the change is:
Move {components/invalidation/ => components/invalidation/public}:
-ack_handle.cc
-ack_handle.h
-ack_handler.cc
-ack_handler.h
-invalidation.cc
-invalidation.h
-invalidation_export.h
-invalidation_handler.cc
-invalidation_handler.h
-invalidation_service.h
-invalidation_util.cc
-invalidation_util.h
-invalidator_state.cc
-invalidator_state.h
-object_id_invalidation_map.cc
-object_id_invalidation_map.h
-single_object_invalidation_set.cc
-single_object_invalidation_set.h
Move {components/invalidation/ => components/invalidation/impl}:
other files
Thus the dependency chain is:
//chrome/browser/ -> //components/invalidation/impl -> components/invalidation/public
Now invalidation consumers can directly depend on //components/invalidation/public
which has only //google/cacheinvalidation has a dependency.
BUG=503131
Review URL: https://codereview.chromium.org/1191393008
Cr-Commit-Position: refs/heads/master@{#336413}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will make it easier to run this test suite on the bots.
Refactored Telemetry isolates into:
- telemetry.isolate: contains just Telemetry's logic and
dependencies (bitmaptools). Moved this from chrome/ into content/
to match its dependencies.
- telemetry_chrome_test.isolate: describes Telemetry tests which run
using the Chromium browser. Currently telemetry_gpu_test.isolate
is the only consumer of this isolate.
The new test target will be added to the bots in a subsequent commit;
some more work is needed to do so.
BUG=495868
R=zmo@chromium.org,phajdan.jr@chromium.org,maruel@google.com
TBR=maruel@chromium.org
Review URL: https://codereview.chromium.org/1212113003
Cr-Commit-Position: refs/heads/master@{#336392}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since file_manager_browsertests.cc is so large file now, it's good time to split it into the separated files along with each application.
This patch should not change any functionality.
BUG=none
TEST=browser tests passes
Review URL: https://codereview.chromium.org/1206273003
Cr-Commit-Position: refs/heads/master@{#336357}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This moves files from chrome/test/android/javatests_staging into
chrome/test/android/javatests and merges the
chrome_staging_test_support_java build target into
chrome_test_support_java.
BUG=501140
Review URL: https://codereview.chromium.org/1199263006
Cr-Commit-Position: refs/heads/master@{#336245}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For now it's behind chrome://flags#app-window-cycling.
This is to hopefully give a better UX for App Shims. It also solves a
tricky problem with Chrome Remote Desktop: Since CRD swallows Cmd+`, it
breaks browser window cycling since the cycling will stop as soon as a
CRD window is encountered.
This works by hooking in to the same mechanism that changes the menu
bar. Switching to or away from a packaged app window will now also update
the window cycle list. The CL intentionally does *not*:
- try to distinguish between the same app running in different profiles,
- update the `Window` menu, nor
- try to do anything for Cmd+Tab switching.
The hard part: AppKit does not immediately apply changes to
NSWindowCollectionBehaviorIgnoresCycle after a window is already shown.
An effective workaround seems to be call to [[NSApp keyWindow]
makeKeyAndOrderFront:nil]. However, this may have other consequences.
Lots of other things were tried (see code comments).
Adds an interactive UI test. Tests on mac using
ui_test_utils::ShowAndFocusNativeWindow(..) have a history of flakiness,
so this CL attempts to address that by combining with a notification
observer. This approach has successfully addressed flakiness around
key-window transitions elsewhere. It would commonly occur when multiple
windows are in the process -- a single RunLoop().RunUntilIdle() couldn't
guarantee that the window server had completed the switch.
BUG=484737, 278408
Review URL: https://codereview.chromium.org/1186803003
Cr-Commit-Position: refs/heads/master@{#336063}
|