| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
Tooltips for requestAutocomplete should use the Chrome bubble look.
BUG=315966
Review URL: https://codereview.chromium.org/84343002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reason for revert: broke compile
TBR=joaodasilva@chromium.org,jochen@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/99333002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This facilitates the refactoring of chrome/browser/policy into a layered
component.
BUG=271392
NOTRY=true
Review URL: https://codereview.chromium.org/92153002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238097 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=304354
Review URL: https://codereview.chromium.org/85263004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=nhiroki@chromium.org
Review URL: https://codereview.chromium.org/96993003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change...
- adds LocalToRemoteSyncerTest
- separates FakeDriveUploader into its own file
- fixes MetadataDatabase bugs (LocalToRemoteSyncerTest covers them)
BUG=240165
TEST=unit_tests --gtest_filter=LocalToRemoteSyncerTest.*
NOTRY=true
R=kinuko@chromium.org, tzik@chromium.org
Review URL: https://codereview.chromium.org/87853003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Screenshot: https://drive.google.com/file/d/0B1B1Up4p2NRMdS1NNkNHZndrNFU/edit?usp=sharing
BUG=324036
TEST=Launch Chrome with the --new-profile-management flag. Clicking on
the avatar button should show the new avatar bubble.
Review URL: https://codereview.chromium.org/78233004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds the CloudExternalDataPolicyObserver. This helper can be used
to observe a policy referencing external data for all users on a device,
covering both device-local accounts (whose policy is available and may
change anytime) and regular accounts (whose policy is available and may
change only when the user is logged in).
The helper emits notifications when an external data reference is set,
cleared or an external data fetch completes successfully.
The helper will be used to implement a policy for setting the avatar image
and a policy for setting the wallpaper.
The CL also adds the first policy referencing external data. The policy is
not wired up yet but having it defined unblocks server-side work and makes
testing easier. The policy will be implemented in a follow-up CL coming
soon.
BUG=152957,152959,220418
TEST=Full unit test coverage
TBR=askvitkine@chromium.org
Review URL: https://codereview.chromium.org/88423002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237806 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
EntryUpdatePerformer is a simple class which is responsible to request UpdateResource to the server.
BUG=260538
TEST=unit_tests
Review URL: https://codereview.chromium.org/90893002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237579 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reason for revert: broke win again :/
TBR=jochen@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/91103004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237562 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=jochen@chromium.org
Review URL: https://codereview.chromium.org/78603003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237551 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In this case, the code is parsing update responses, and precise
naming improves the readability and undestanding of the code.
This also avoids a conflict with similar names in the extension updater.
Similar file names even if they are in different directories can break
some gyp targets (https://code.google.com/p/gyp/issues/detail?id=384)
GYP_GENERATORS set to 'ninja'
Updating projects from gyp files...
Using overrides found in /include.gypi
static library src/clank/src/chrome/chrome.gyp:unit_tests#target has several files with the same basename:
update_manifest_unittest: browser/component_updater/test/update_manifest_unittest.cc common/extensions/update_manifest_unittest.cc
Some build systems, e.g. MSVC08, cannot handle that.
gyp: Duplicate basenames in sources section, see list above
BUG=314521
Review URL: https://codereview.chromium.org/87413002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move ManifestHandlers for:
- CSP
- Kiosk Mode
- Offline Enabled
- Requirements
- Sandboxed Page
to top-level extensions/common/manifest_handlers.
Rename all handlers to be foo_info.h/cc, if necessary.
TBR=davemoore@chromium.org (c/b/chromeos/app_mode/startup_app_launcher.cc)
TBR=finnur@chromium.org (c/b/ui/webui/extensions/extension_basic_info.cc)
BUG=159265
Review URL: https://codereview.chromium.org/83843002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237426 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Move PreferencesMac to components/policy/.
>
> This facilitates the refactoring of chrome/browser/policy into a layered
> component.
>
> BUG=271392
>
> Review URL: https://codereview.chromium.org/78603003
TBR=dconnelly@chromium.org
Review URL: https://codereview.chromium.org/89223003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This facilitates the refactoring of chrome/browser/policy into a layered
component.
BUG=271392
Review URL: https://codereview.chromium.org/78603003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This facilitates the refactoring of chrome/browser/policy into a layered
component.
BUG=271392
Review URL: https://codereview.chromium.org/79063003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237330 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
These files do not have any dependencies to the rest of chrome so can
move down immediately.
TBR=miket, sky
BUG=298537
Review URL: https://codereview.chromium.org/82773002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237299 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move events test-related code into a separate target so that these don't get
used in non-test code. Notable changes:
* Move nested TestApi classes out of Event, LocatedEvent and EventTarget,
and into separate classes. The new classes become friends with their old
parents.
* Move events_x_utils out of x/ into test/
R=sky@chromium.org, tfarina@chromium.org
TBR=jam@ for content_tests.gypi and render_view_browsertest.cc changes.
BUG=none
Review URL: https://codereview.chromium.org/82903005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change https://codereview.chromium.org/74893002 introduced chrome/browser/component_updater/test/update_manifest_unittest.cc,
but a file with the same basename already exists in common/extensions/.
This causes runhooks to fail when running android_gyp on downstream bots.
TBR=waffles@chromium.org,cpu@chromium.org,cdn@chromium.org
BUG=323139
Review URL: https://codereview.chromium.org/85603002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237081 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=240165
TEST=unit_tests --gtest_filter=RemoteToLocalSyncerTest.*
Review URL: https://codereview.chromium.org/82943003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was added to components_unittests target in r232764
(crrev.com/232764), but I forgot to remove it from unit_tests target at the same
time. Removing now.
BUG=181277
TEST=components_unittests
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/83273008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
test_support_common. The latter is where we already put all test-harness specific code, even if it's only used in browser tests.
R=phajdan.jr@chromium.org
Review URL: https://codereview.chromium.org/83863005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236856 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is based on scottmg's https://codereview.chromium.org/25377002/.
BUG=308773
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/82713004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These files have no dependencies on chrome/ so they can be safely moved
to the components/ directory.
This is part of an effort to componentize NaCl code.
BUG=244791
R=brettw@chromium.org, cpu@chromium.org, jochen@chromium.org, mseaborn@chromium.org
Review URL: https://codereview.chromium.org/75463005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236821 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This facilitates the refactoring of chrome/browser/policy into a layered
component.
Depends on https://codereview.chromium.org/78823004/
BUG=271392
Review URL: https://codereview.chromium.org/78453005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236785 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Based on https://codereview.chromium.org/22295002/,
but moves WiFiService to components/ and runs it in browser process instead of utility process.
Windows implementation is in http://crrev.com/68503019.
BUG=267667
Review URL: https://codereview.chromium.org/54323003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This facilitates the refactoring of chrome/browser/policy into a layered
component.
Depends on https://codereview.chromium.org/78763002/
BUG=271392
Review URL: https://codereview.chromium.org/78823004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=314521
Review URL: https://codereview.chromium.org/74893002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=321164
TEST=unittest (and visual)
Review URL: https://codereview.chromium.org/65983004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236580 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This facilitates the refactoring of chrome/browser/policy into a layered
component.
BUG=271392
Review URL: https://codereview.chromium.org/78763002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236575 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that its dependencies on Profile, ActivityLog, RuntimeAPI and
WebRequestAPI have been removed it can move into the extensions module.
This is part of the AppShell extensions refactoring project.
BUG=316367
TEST=compiles
R=yoz@chromium.org
TBR=mukai@chromium.org for mechanical file move in c/b/notifications, dmazzoni@chromium.org for mechanical file move in accessibility code
Review URL: https://codereview.chromium.org/78483003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236549 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ExtensionAppModelBuilder
Some code paths currently result in an AppListSyncableService being
created for a profile before the profile is fully initialized. In this
case, the ExtensionSystem can be used, but the Extension*Service* is not
yet created, and has not finished loading all the extensions. Attempting
to populate the app launcher model at this point results in no apps
being found.
This CL adds a check in AppListSyncableService to see if the
ExtensionSystem is ready. If not, wait for it to become ready and
populate apps then.
BUG=321514
TEST=(On mac)Have two signed-in profiles; Have app launcher showing
Profile "A", Close all browser windows except for a browser showing
profile "B", Quit Chrome, Show app launcher [Chrome starts], Switch app
launcher to profile "B". App launcher should show apps, and not be
blank.
Review URL: https://codereview.chromium.org/77773002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236513 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/77733004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The logic was previously applied at the UpdatePolicy level of every
ConfigurationPolicyProvider, but this needs to move to facilitiate the
refactoring of chrome/browser/policy into a layered component. Instead
a fixup function can be injected into a PolicyService at construction
time and is applied before policies from the various PolicyProviders
are merged.
There are three tests for this:
- PolicyTransformationsTest.FixDeprecatedPolicies tests that the proxy
policy fixup function works properly.
- PolicyServiceTest.PolicyPreprocessing tests that the preprocessor
function is applied during policy merge.
- PolicyTest.PolicyPreprocessing tests that the proxy fixup function
is added BrowserPolicyConnector and ProfilePolicyConnector.
TEST=unit test, integration test, browser test
BUG=271392
Review URL: https://codereview.chromium.org/59243005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Create an AppSorting interface in extensions/browser/ and
make ChromeAppSorting (formerly ExtensionSorting) implement
it.
BUG=313284
Review URL: https://codereview.chromium.org/74613003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236500 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=313117
TEST=unit_tests --gtest_filter=LanguageStateTest.*
Review URL: https://codereview.chromium.org/73173007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This required a small amount of refactoring to separate the testable
part from the non-testable calls to the system.
BUG=317944
Review URL: https://codereview.chromium.org/70383006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
disabled because it/they didn't come from the webstore.
Also removing a few stray remnants of the Sideload Wipeout initiative, which are
no longer needed.
This is a retry of landing
https://codereview.chromium.org/70253002
... with only an if-check in the controller different (service_ can be null during testing).
BUG=318120
TBR=kalman
Review URL: https://codereview.chromium.org/77913005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a dependency of EventRouter, which is almost ready to move.
Also convert the unit test to use BrowserContext instead of Profile.
BUG=316367
TEST=unit_tests
Review URL: https://codereview.chromium.org/59823011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236190 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Introduce a WebRequestAPI BrowserContextKeyedService to observe EventRouter
for EventListener additions and removals.
This is part of the AppShell extensions refactor and will make it easier to
move extensions::EventRouter into src/extensions.
BUG=316367
TEST=unit test added, existing browser_tests
R=yoz@chromium.org
TBR=davemoore@chromium.org for trivial change to chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc
Review URL: https://codereview.chromium.org/73193008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
maximized.
This is done via the Ash WindowPositioner class. The change is in the WindowPositioner::GetBoundsAndShowStateForNewWindow
function which for windows returns SHOW_STATE_MAXIMIZED if this is the first window being opened.
Based on a discussion with oshima, I enabled the WindowSizerAshTest ash unit tests for Windows. There were a number
of places in the WindowSizer class where we were allowing browsers to be in ASH only for Chrome OS. Checking for
the host desktop type should be enough. This was needed to get the window to be maximized for ASH.
Fixes bug http://crbug.com/231603
BUG=231603
R=cpu@chromium.org, oshima@chromium.org, sky@chromium.org, cpu, oshima, sky
Review URL: https://codereview.chromium.org/62333015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236134 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the first step for moving ui.gyp into ui/base/
After this lands, Blink will be updated to reference the new file under
ui/resources.
Then the by-pass target will be removed from ui.gyp. And then we can
move it to its finall location.
BUG=299841
TEST=None
R=ben@chromium.org
Review URL: https://codereview.chromium.org/74853003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236099 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Implement most methods of GCMProfileService with right threading support.
2) Define GCMEventRouter interface for event routing purpose.
3) Add a mock version of GCMClient for testing purpose.
BUG=284553
TEST=new tests added
R=fgorski@chromium.org, zea@chromium.org
Review URL: https://codereview.chromium.org/69953009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236086 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Add a bubble that lets the user know that one or more extensions have been disabled because it/they didn't come from the webstore.
>
> Also removing a few stray remnants of the Sideload Wipeout initiative, which are no longer needed.
>
> BUG=318120
> R=kalman@chromium.org, sky@chromium.org
>
> Review URL: https://codereview.chromium.org/70253002
TBR=finnur@chromium.org
Review URL: https://codereview.chromium.org/59183003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236013 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
disabled because it/they didn't come from the webstore.
Also removing a few stray remnants of the Sideload Wipeout initiative, which are no longer needed.
BUG=318120
R=kalman@chromium.org, sky@chromium.org
Review URL: https://codereview.chromium.org/70253002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The shelf anchoring calculations are now platform-neutral, and much more
general. The platform-specific client code can now request that the app
launcher be anchored to a specific screen corner, the shelf corner, or
the mouse position on the shelf.
BUG=317944
Review URL: https://codereview.chromium.org/62103007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Use simple setters rather than With* methods.
* Explicitly transfer memory ownership.
* Rename "Builder" to "Factory"
* Eliminate the side-effect of resetting the builder from the Create* methods.
Along the way, fix a memory leak in the Android WebView.
BUG=315499
TEST=none (code should continue to compile and tests should continue to pass)
R=joi@chromium.org
Review URL: https://codereview.chromium.org/64193003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is in preparation for upcoming changes - the bubble controller
will have more than just error bubble responsibilities, so the name is
not appropriate any more
R=isherman@chromium.org
BUG=none
Review URL: https://codereview.chromium.org/61583004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
components/nacl/browser
These files have no dependencies on chrome/ so they can be safely moved
to the components/ directory.
This is part of an effort to componentize NaCl code.
BUG=244791
Review URL: https://codereview.chromium.org/61763026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235735 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This mimics the organization of chrome/browser/ui as well.
R=pkasting@chromium.org
Review URL: https://codereview.chromium.org/71743002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235677 0039d316-1c4b-4281-b951-d872f2087c98
|