summaryrefslogtreecommitdiffstats
path: root/chrome/common/automation_messages.h
Commit message (Collapse)AuthorAgeFilesLines
* Refactor Pickle Read methods to use higher performance PickleIterator.jbates@chromium.org2012-03-071-2/+2
| | | | | | | | | | | | | | | | There was a lot of redundant error checking and initialization code in all Pickle Read methods because of the void** iterator type. This change replaces the void* iterator with PickleIterator, which encapsulates the read pointer so that less error checking and initialization code is needed for reading. PickleIterator has all the necessary data to do the actual reading. The advantage of having it provide Read methods (as opposed to leaving them solely in the Pickle interface) is that the callers do not need to pass around the const Pickle* once they have a PickleIterator. Followup CLs will refactor the call sites to remove const Pickle* arguments where they are now unnecessary. Then the Pickle::Read* methods can be removed entirely. The alternative approach would have been to change the Pickle::Read methods to non-const and remove the iterator parameter (making Read methods advance an internal read pointer). Unfortunately, the const Read with iterator design is entrenched throughout the chromium code, making this a much more complex change with the same performance outcome. BUG=13108 Review URL: https://chromiumcodereview.appspot.com/9447084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125447 0039d316-1c4b-4281-b951-d872f2087c98
* Move ContextMenuParams struct from webkit/glue to content/public/common. The ↵jam@chromium.org2012-02-121-2/+1
| | | | | | | | | | | | | reasons are: -this struct wasn't used at all in webkit layer, so no need to have it there -we can avoid exposing content layer's serialization of SSLInfo to embedders -avoid mentioning routing_ids in the webkit layer BUG=98716 Review URL: https://chromiumcodereview.appspot.com/9382037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121673 0039d316-1c4b-4281-b951-d872f2087c98
* Move common_param_traits and webkit_param_traits to content/public/common.jam@chromium.org2011-10-211-2/+2
| | | | | | | BUG=98716 Review URL: http://codereview.chromium.org/8368004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106766 0039d316-1c4b-4281-b951-d872f2087c98
* Update automation messages to use the new way of declaring message structs, ↵jam@chromium.org2011-10-211-291/+99
| | | | | | | | to cut back on unnecessary code. Review URL: http://codereview.chromium.org/8356020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106734 0039d316-1c4b-4281-b951-d872f2087c98
* Move SecurityStyle enum into content/public/common and put it into the ↵jam@chromium.org2011-10-211-4/+4
| | | | | | | | content namespace.BUG=98716 Review URL: http://codereview.chromium.org/8361019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106642 0039d316-1c4b-4281-b951-d872f2087c98
* Move the PageType enum to content/public/common, put it into the content ↵jam@chromium.org2011-10-181-21/+9
| | | | | | | | | | namespace, and also make it conform to the Content API enum naming convention. BUG=98716 TBR=ananta Review URL: http://codereview.chromium.org/8336013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106076 0039d316-1c4b-4281-b951-d872f2087c98
* Preliminary work to allow Chrome to build with USE_AURA.ben@chromium.org2011-09-061-2/+2
| | | | | | | | | | This gets browser.lib to build. http://crbug.com/93947 TEST=none Review URL: http://codereview.chromium.org/7834048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99787 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor: Make PyAuto InstallExtension() take a string. Delete dead code.dtu@chromium.org2011-08-041-9/+0
| | | | | | | | | | BUG=chromium:86890 TEST=Run the modified PyAuto tests on all platforms. Review URL: http://codereview.chromium.org/7548024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95490 0039d316-1c4b-4281-b951-d872f2087c98
* Convert RenderViewContextMenu to MenuItemView.rhashimoto@chromium.org2011-07-121-0/+47
| | | | | | | | | | | | | | This CL is part of general GTK removal for ChromiumOS. Menu2 uses GTK on linux so we are replacing it with MenuItemView. Chrome Frame currently passes the context menu between processes by using the HMENU. Because MenuItemView does not use HMENU, we need to use another mechanism. This CL creates a ContextMenuModel struct that is serialized into an automation message for Chrome Frame. ContextMenuModel contains the context menu definition in-band replacing the out-of-band HMENU. BUG=chromium-os:13887 TEST=none Review URL: http://codereview.chromium.org/7167002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92182 0039d316-1c4b-4281-b951-d872f2087c98
* Add the feature "Add as seach engine..." when right clicking on a form text ↵philippe.beauchamp@gmail.com2011-07-011-0/+5
| | | | | | | | | | | | | | field. Note: POST forms are not supported with this patch BUG=6872 TEST=none Review URL: http://codereview.chromium.org/335023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91253 0039d316-1c4b-4281-b951-d872f2087c98
* Move security_style.h to content. It seems like useful information that an ↵jam@chromium.org2011-05-261-1/+1
| | | | | | | | embedder would want. Review URL: http://codereview.chromium.org/7062036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86928 0039d316-1c4b-4281-b951-d872f2087c98
* Moved ParamTraits specializations that depend on WebKit out of ↵grt@chromium.org2011-04-151-1/+2
| | | | | | | | | | | content/common/common_param_traits and into webkit_param_traits. Also pulled some specializations out of chrome/common/render_messages and into chrome/common/common_param_traits. This is done so that the MS toolchain can succeed in discarding more code at link time. This halves the size of npchrome_frame.dll in ordinary "Release" builds. I hope for a similar reduction in official builds. BUG=77445 TEST=Everything should just work(TM). Review URL: http://codereview.chromium.org/6840044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81803 0039d316-1c4b-4281-b951-d872f2087c98
* Move the rest of the renderer->browser messages that belong in content. ↵jam@chromium.org2011-03-241-1/+1
| | | | | | | | | | | | | Also do a bunch of cleanup: -move safe browsing messages together -get rid of webkit_param_traits and common_param_trait since they're no longer needed -remove the multiple include of IPC files from places that don't need it TBR=tsepez Review URL: http://codereview.chromium.org/6713084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79235 0039d316-1c4b-4281-b951-d872f2087c98
* Move the remaining files in chrome\common to content\common.jam@chromium.org2011-03-171-1/+1
| | | | | | | TBR=avi Review URL: http://codereview.chromium.org/6672070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78516 0039d316-1c4b-4281-b951-d872f2087c98
* Removed 'off the record' references from ExternalTabSettings and ↵vipul.bhasin@gmail.com2011-03-171-2/+2
| | | | | | | | | | ProfileIOData::ProfileParams. BUG=3333 Review URL: http://codereview.chromium.org/6700001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78485 0039d316-1c4b-4281-b951-d872f2087c98
* Convert dom_storage, pepper, pepper_file, and automation messages to new format.tsepez@chromium.org2011-03-161-5/+11
| | | | | | | | | | | dom_storage now generated by the common generator. Pepper and pepper_file still have dedicated .cc files rather than using the common generator because they still contain a small amount of hand-coded code. Automation_messages has its own .cc file, since it appears this may well link into other places. Review URL: http://codereview.chromium.org/6695032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78330 0039d316-1c4b-4281-b951-d872f2087c98
* Move GPU messages to content. I've also switched the IPC structs to use the ↵jam@chromium.org2011-03-101-1/+1
| | | | | | | | new IPC macros that generate serialization code. Review URL: http://codereview.chromium.org/6673003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77721 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for the HTTPSGetTest and GetTest net test failures with ChromeFrame. ↵ananta@chromium.org2011-02-241-1/+4
| | | | | | | | | | | | | | | | | | These failures occurred because of new expectations in these tests which match the server ip address and port being connected to. We need to return that information from ChromeFrame. Fix is to send over the corresponding HostPortPair structure in the AutomationMsg_RequestStarted IPC message. A major part of this CL is basically the groundwork to pass this information over via automation. BUG=none TEST=chrome frame net tests should pass. Review URL: http://codereview.chromium.org/6575027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75942 0039d316-1c4b-4281-b951-d872f2087c98
* Change includes of gfx/* to ui/gfx/*sail@chromium.org2011-02-051-1/+1
| | | | | | | | | BUG=71063 TEST=compiled Review URL: http://codereview.chromium.org/6312156 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73890 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up Automation and Chrome Frame IPC code.-only use routed messages when ↵jam@chromium.org2010-12-231-156/+161
| | | | | | | | needed-use routing IDs to avoid manually unpacking messages-remove data structures from IPC namespace (that should only be used for IPC code, and param traits)Note that I temporarily commented out part of a test in external_tab_test.cc because I couldn't figure out how to get the updated gmock macros to compile. Review URL: http://codereview.chromium.org/5998006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70105 0039d316-1c4b-4281-b951-d872f2087c98
* Keep deinlining stuff.erg@google.com2010-12-151-390/+99
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/5783004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69273 0039d316-1c4b-4281-b951-d872f2087c98
* ipc: Simplify the magic required to create IPC message headers.This gets rid ↵jam@chromium.org2010-12-081-3/+1
| | | | | | | | | of having to include the files in a magic place because of xcode dependency issues, and just makes it simpler to create new IPC message classes. It also gets rid of including the X_messages_internal.h file multiple times, which simplifies things and should make the build a little faster. In a future change, I will remove the "internal.h" files since they're no longer needed. Review URL: http://codereview.chromium.org/5526008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68664 0039d316-1c4b-4281-b951-d872f2087c98
* Part 3 of reapplying r64637.erg@google.com2010-11-121-8/+9
| | | | | | | | | | | | | This moves SecurityStyle and PageType into chrome/common/ and removes the chrome_frame dependency on chrome/browser/tab_contents/. This undoes the temporary DEPS hack on chrome/common/. BUG=51409 TEST=compiles Review URL: http://codereview.chromium.org/4697005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65965 0039d316-1c4b-4281-b951-d872f2087c98
* Part 2 of reapplying r64637.erg@google.com2010-11-101-0/+644
| | | | | | | | | | | | | Move the automation message files from chrome/test/automation to chrome/common/. This requires a temporary override to chrome/common/DEPS until Part 3 lands. BUG=51409 TEST=compiles Review URL: http://codereview.chromium.org/4758001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65695 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Refactor automation messages." due to mysterious problems on mac.erg@google.com2010-11-011-644/+0
| | | | | | | | | | | | | This reverts commit c1c1fed998ee4d839bfe256150e5e59220ebc0ef (r64637). TBR=nirnimesh@ BUG=51409 TEST=none Review URL: http://codereview.chromium.org/4194007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64644 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor automation messages.erg@google.com2010-11-011-0/+644
automation_messages used to live in chrome/test/automation, when it's needed by browser and chrome_frame. When I started lifting code out of headers and into implementation files, I was getting link errors and temporarily solved the problem by compiling the cc files manually into libbrowser.a. Now this is part of chrome/common/ which is included by all targets needed. While doing this, discover that automation IPC redefines the ContextMenuParams struct. Rename it to MiniContextMenuParams. BUG=51409 TEST=none Review URL: http://codereview.chromium.org/4200007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64637 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-31 08:25:22 +0000