summaryrefslogtreecommitdiffstats
path: root/chrome/common/chrome_constants.cc
Commit message (Collapse)AuthorAgeFilesLines
* Make the browser survive massive data: URIs, via various techniques:cevans@chromium.org2010-04-011-1/+2
| | | | | | | | | | | | | | | | | | | | | | | 1) Drop the URL limit from 10MB to 2MB. The browser survives without this, but that final tweaks makes the whole data: URI attack fairly smooth (on my admittedly powerful machine). 2) Elide the title string at kMaxTitleChars. We already have a hard title limit but there was a path whereby the title is implied by the URL (e.g. file: and data: etc). 3) For massive URLs, limit the length shown in URL bar. We need to support them, because someone might redirect to a data: URI with e.g. an image in it. However, attempting to show them would kill the browser. We can't elide them because eliding URLs is a security risk (and would lead to correctness issues with an edit/press enter cycle). So we show at least the origin (minus path) or just the scheme for data: URIs BUG=33952 TEST=NONE Review URL: http://codereview.chromium.org/1569011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43319 0039d316-1c4b-4281-b951-d872f2087c98
* Calling OpenGL from the renderer processapatrick@chromium.org2010-03-251-0/+2
| | | | | | | | | | | | | | - Added ability for renderer processes to render to a real window (Windows only so far). - Added ability to create offscreen frame buffer objects that can be resized later. - OpenGL context can have a "parent" context that can access its last swapped back buffer through a texture ID. - Moved code to establish GPU channel from RenderWidget to RenderThread. - Changed way service size command buffer object lifetimes are managed. TEST=trybot and visual verification that OpenGL can clear the browser window to magenta. BUG=none Review URL: http://codereview.chromium.org/1136006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42679 0039d316-1c4b-4281-b951-d872f2087c98
* Implement status icons on windows.atwilson@google.com2010-03-241-0/+1
| | | | | | | | | | | Refactor existing status icon code to allow platform-specific StatusTray implementation to track common state for all status icons. BUG=37375 TEST=new unit tests Review URL: http://codereview.chromium.org/1136005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42538 0039d316-1c4b-4281-b951-d872f2087c98
* Send session history offset and length parameters in the Navigate message todarin@chromium.org2010-03-181-0/+2
| | | | | | | | | | | | | keep the renderer's notion of those values properly synchronized with the NavigationController. R=brettw BUG=18062 TEST=see session_history_uitest.cc Review URL: http://codereview.chromium.org/1090002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42022 0039d316-1c4b-4281-b951-d872f2087c98
* Deprecate file_util::AppendToPath() on non-Windows.evan@chromium.org2010-02-261-1/+1
| | | | | | | | | | | | We still have ~150 callers to AppendToPath in our code, but most of them are in the installer and I'm reluctant to fiddle with that code without having an easy way to test it. BUG=24672 Review URL: http://codereview.chromium.org/654013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40120 0039d316-1c4b-4281-b951-d872f2087c98
* Rename the DLL and the executable used by NaCl on Win64 ↵gregoryd@google.com2010-02-251-1/+1
| | | | | | | | | | | (chrome_nacl_win64.dll -> nacl64.dll, nacl.exe -> nacl64.exe). The motivation for the change: 1. Make the name shorter (look better when installed on users machines) 2. Allow differentiation between 64-bit and 32-bit binaries if we decide to switch to a similar design for 32-bits too. Review URL: http://codereview.chromium.org/650195 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40043 0039d316-1c4b-4281-b951-d872f2087c98
* Further reduce the bad dependency of chrome/common on chrome/browser.phajdan.jr@chromium.org2010-02-241-0/+2
| | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/656011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39877 0039d316-1c4b-4281-b951-d872f2087c98
* Implement the broker process that launches NaCl loader processes on 64-bit ↵gregoryd@google.com2010-02-011-0/+1
| | | | | | | | | | | | Windows systems. BUG=28176 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=37578 Review URL: http://codereview.chromium.org/542030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37720 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 37578 - Implement the broker process that launches NaCl loader ↵gregoryd@google.com2010-01-301-1/+0
| | | | | | | | | | | | processes on 64bit Windows systems. BUG=28176 TEST=none Review URL: http://codereview.chromium.org/542030 TBR=gregoryd@google.com git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37580 0039d316-1c4b-4281-b951-d872f2087c98
* Implement the broker process that launches NaCl loader processes on 64-bit ↵gregoryd@google.com2010-01-301-0/+1
| | | | | | | | | | Windows systems. BUG=28176 TEST=none Review URL: http://codereview.chromium.org/542030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37578 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid accepting suspiciously long URLs from the renderer. These can take downcevans@chromium.org2010-01-081-0/+1
| | | | | | | | | | | the browser with OOM. BUG=20233 TEST=NONE Review URL: http://codereview.chromium.org/523088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35757 0039d316-1c4b-4281-b951-d872f2087c98
* Try 2: Completely redo how themes are stored on disk and processed at ↵erg@google.com2009-12-141-1/+1
| | | | | | | | | | | | | | | | | install time. Same as previous patch, except we now have a BrowserThemeProvider::GetDefaultDisplayProperty() so we don't have UMRs in ntp_resource_cache.cc. BUG=24493,21121 TEST=All the new unit tests pass. All the complex theme startup tests go faster. Previous Review URL: http://codereview.chromium.org/460050 Review URL: http://codereview.chromium.org/499004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34486 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Completely redo how themes are stored on disk and processed at installerg@google.com2009-12-111-1/+1
| | | | | | | | | | time," as it fails valgrind tests. This reverts commit 86faccd1028937a69ccc718718fd48c06c0cd471 (r34379). Review URL: http://codereview.chromium.org/490025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34385 0039d316-1c4b-4281-b951-d872f2087c98
* Completely redo how themes are stored on disk and processed at install time.erg@google.com2009-12-111-1/+1
| | | | | | | | | | | | | | | | | | | | Rewrites most of BrowserThemeProvider and adds a new class BrowserThemePack. BrowserThemePack takes all the logic of generating resources out of the BrowserThemeProvider, does all of them at theme install time (previously, we lazily generated all the button images and a good number of colors, which muddled logic quite a bit), and then writes all the data out into an mmap()able file to speed startup when a theme is installed. In addition, this changes how the GtkThemeProvider works. The GtkThemeProvider now generates all of its images lazily and doesn't reach into the implementation details of BrowserThemeProvider as it used to. BUG=24493,21121 TEST=All the new unit tests pass. All the complex theme startup tests go faster. Review URL: http://codereview.chromium.org/460050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34379 0039d316-1c4b-4281-b951-d872f2087c98
* Set prop app id for chromium/application shortcut.xiyuan@chromium.org2009-11-191-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a follow up change after andrew's patch for win7 shortcut to properly set app id for chromium/application shortcut. - Move PKEY_AppUserModel_ID and code to set it from app/win_util.cc to base/win_util.cc as SetAppIdForPropertyStore to share with file_util shortcut code; - Add an app_id args to file_util's CreateShortcutLink and UpdateShortcutLink; - Update code that calls the above two function in installer and UserDataManager so that the chromium shortcuts are created with proper app id (except the uninstall shortcut which is not tagged with any app id). - Move ComputeApplicationNameFromURL from Browser to web_app namespace and use it as app id for application shortcut. This makes pinned shortcut and browser window use the same app id and Win7 correctly groups them; - Rename ComputeApplicationNameFromURL to GenerateApplicationNameFromURL per Ben's comments; - Add a DCHECK in SetAppIdForPropertyStore to ensure app id is less than 128 chars and contains no space per msdn; - Change default app id from IDS_PRODUCT_NAME to chrome::kBrowserAppName BUG=28104 TEST=On Win7, pinned shortcut should no longer be separated from running instance of chrome for both chrome and web application. Review URL: http://codereview.chromium.org/399045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32508 0039d316-1c4b-4281-b951-d872f2087c98
* linux: use /proc/self/exe when exec'ing ourselvesevan@chromium.org2009-11-191-1/+3
| | | | | | | | | | | | | | | | | | | We don't want to ever go out to disk when looking for data after startup, since they can be changed by an update. We *should* just be using the zygote, but the zygote is sandboxed-only for now, and fixing that has a lengthy dependency graph. In the interim, /proc/self/exe is the correct executable and exec'ing it should work as long as the subprocess doesn't need any other files from the Chrome directory. BUG=22703 TEST=Start Chrome. Move away the entire Chrome directory; plugins should still work. Review URL: http://codereview.chromium.org/403018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32486 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "linux: use /proc/self/exe when exec'ing ourselves"evan@chromium.org2009-11-191-3/+1
| | | | | | | | This reverts commit r32457. This works for me in Debug and Release, and Lei in Debug, but not for him or the bots in Release. Hate computers. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32472 0039d316-1c4b-4281-b951-d872f2087c98
* linux: use /proc/self/exe when exec'ing ourselvesevan@chromium.org2009-11-191-1/+3
| | | | | | | | | | | | | | | | | | | We don't want to ever go out to disk when looking for data after startup, since they can be changed by an update. We *should* just be using the zygote, but the zygote is sandboxed-only for now, and fixing that has a lengthy dependency graph. In the interim, /proc/self/exe is the correct executable and exec'ing it should work as long as the subprocess doesn't need any other files from the Chrome directory. BUG=22703 TEST=Start Chrome. Move away the entire Chrome directory; plugins should still work. Review URL: http://codereview.chromium.org/403018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32457 0039d316-1c4b-4281-b951-d872f2087c98
* Implement web app shortcuts natively per issue 25528xiyuan@chromium.org2009-11-171-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Implement a CreateApplicationShortcutView similar to the current Gears-based one; - Add a few profile prefs to persist user's last checked shortcut locations - Implement a web_app::CreateShortcut that stores icon under "<profile>/Web Applications" in a similar layout as gears (i.e. <host>/<scheme_port>/<web_app_title>.ico) and calls file_util code to creates shortcut on Windows; - Add Win7 taskbar pin/unpin support function to file_util; - Update TabContents to replace gears with new code; Note: - Gears dialog is modaless but this one is a modal dialog. - Gear's icon store is not migrated because gears icons could still be used by shortcuts created by gears and thus we could not delete them even after migration. And we are not using the local ico files in the dialog even if they exists. - New CreateApplicationShortcutView is included when TOOLKIT_VIEW is defined. However on platforms other than Windows, the actual CreateShortCut code is not implemented. Right now it calls ShellIntegration's CreateDesktopShort if OS_LINUX is defined and NOTREACHED() for other platforms. BUG=25528 TEST=Verify the new UI provides the same functionality as gears under XP/Vista and support pinning on Win 7. Review URL: http://codereview.chromium.org/372012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32165 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the Chrome Frame preprocessor define in chrome_constants.cc and deal ↵robertshield@chromium.org2009-10-281-4/+1
| | | | | | | | | | | | with resulting fallout. Also, remove several instances of Chrome Frame using wstrings instead of FilePaths. The main goal of this patch is to move towards ensuring that Chrome Frame and Google Chrome share binary-identical exes and dlls except for setup.exe and mini_installer.exe. Review URL: http://codereview.chromium.org/338025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30290 0039d316-1c4b-4281-b951-d872f2087c98
* Create BlacklistManager, which will aggregate individual blacklists into one ↵phajdan.jr@chromium.org2009-10-151-0/+1
| | | | | | | | | | | | | | | | | compiled one and maintain it. This is the first step towards shipping privacy blacklists in extensions. The next step will be to make Profile own a BlacklistManager, and make ExtensionsService a BlacklistPathsProvider. TEST=Covered by unit_tests. BUG=21541 Review URL: http://codereview.chromium.org/164535 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29135 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate char/wchar_t conversions, probably-unsafe statics, and disk accessmark@chromium.org2009-10-141-5/+5
| | | | | | | | | | when determining the framework and helper app paths on the Mac. BUG=24833 TEST=app still works, tests still pass Review URL: http://codereview.chromium.org/267102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29034 0039d316-1c4b-4281-b951-d872f2087c98
* Move the framework and helper application into a versioned directory in supportmark@chromium.org2009-10-141-1/+0
| | | | | | | | | | | | | | | | | | | | | | of unbreaking auto-update. BUG=14610 TEST= - The following bundles should be gone: - Chromium.app/Contents/Frameworks/Chromium Framework.framework - Chromium.app/Contents/Resources/Chromium Helper.app They should be replaced by: - Chromium.app/Contents/Versions/*/Chromium Framework.framework - Chromium.app/Contents/Versions/*/Chromium Helper.app - The application should continue to function properly and all tests should still pass. - The signed application should have the inner framework and helper application signed, and the outer application signed. The outer seal should permit unknown versions to be present in the Versions directory, but should protect the active versioned directory. - Auto-updating to an official build with this change should still work. Review URL: http://codereview.chromium.org/261031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28963 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of mac_app_names.h. Replace it with real constants frommark@chromium.org2009-10-081-7/+15
| | | | | | | | | | | | | | | | | chrome_constants.h. As a side effect of this change, tests will use the framework in the build directory as their main bundle override for the purposes of resource loading, instead of looking into the framework inside the application bundle. This should be more than sufficient, and is done for simplicity, because a future change will make it more difficult to locate the correct framework inside the application bundle unless the product version number is known. BUG=24220 TEST=product still works and all tests still pass Review URL: http://codereview.chromium.org/266023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28431 0039d316-1c4b-4281-b951-d872f2087c98
* Cleaning up after the initial Chrome Frame commit.robertshield@chromium.org2009-09-281-3/+3
| | | | | | Review URL: http://codereview.chromium.org/242025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27367 0039d316-1c4b-4281-b951-d872f2087c98
* Changing the Chrome browser app name when CHROME_EXP_BUILD is defined. robertshield@chromium.org2009-09-111-1/+4
| | | | | | Review URL: http://codereview.chromium.org/201097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26032 0039d316-1c4b-4281-b951-d872f2087c98
* Check in http://codereview.chromium.org/197013/show for tfarina.mirandac@chromium.org2009-09-101-1/+1
| | | | | | Review URL: http://codereview.chromium.org/200086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25939 0039d316-1c4b-4281-b951-d872f2087c98
* Plumb request interception into the appcache library for both chrome and ↵michaeln@google.com2009-09-011-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | test_shell. AppCache library: * Added AppCacheInterceptor, which is derived from URLRequest::Interceptor. Chrome: * Each UserProfile instantiates a ChromeAppCacheService, which is derived from an appcache library class. * Each ChromeURLRequestContext associated with that profile has a reference to that instance. * ResourceDispatcherHost pokes AppCacheInterceptor when initiating URLRequests and when returning the response head. TestShell: * Added SimpleAppCacheSystem which bundles together appcache lib components for use in a single process with an UI and IO thread. * TestShellWebKit instantiates and initializes an instance of the above, aimed at at temp directory that will get cleaned up when the test run is over. * SimpleResourceLoaderBridge pokes the system when initiating URLRequests and when returning the response head. TEST=none, although many existing tests exercise this stuff BUG=none Review URL: http://codereview.chromium.org/173406 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25099 0039d316-1c4b-4281-b951-d872f2087c98
* Cache images on theme install so startup does no image processing.mirandac@chromium.org2009-08-241-0/+1
| | | | | | | | | BUG= http://crbug.com/18768 TEST= none Review URL: http://codereview.chromium.org/174085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24170 0039d316-1c4b-4281-b951-d872f2087c98
* Make ProcessSingletonLinux check the hostname to avoid multiple uses of a ↵mattm@chromium.org2009-08-211-0/+1
| | | | | | | | | | | | | profile over NFS. In order to avoid the singleton socket filename from exceeding the max socket name length, the socket is just named "SingletonSocket" and a new file "SingletonLock" is used for the hostname&pid. BUG=17549 TEST=see bug Review URL: http://codereview.chromium.org/174041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23930 0039d316-1c4b-4281-b951-d872f2087c98
* Make unit_tests UtilityProcessHostTest use the helper app on the Mac.mark@chromium.org2009-08-201-12/+20
| | | | | | | | | | BUG=none, not worth it for this TEST=unit_tests '--gtest_filter=UtilityProcessHostTest*' runs Chromium Helper, not Chromium. No application icon should appear in the dock during this test. Review URL: http://codereview.chromium.org/174061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23792 0039d316-1c4b-4281-b951-d872f2087c98
* Fix up the pid collection code for Mac OS X so it handles the different ↵thomasvl@chromium.org2009-08-141-3/+4
| | | | | | | | | | bundle names we use for the helpers. TEST=page cycler tests should show memory for the renderers again. BUG=19021 Review URL: http://codereview.chromium.org/165531 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23439 0039d316-1c4b-4281-b951-d872f2087c98
* Make ThumbnailStore broadcast a notification when it has finished reading ↵meelapshah@chromium.org2009-07-281-0/+1
| | | | | | | | | | | thumbnails from disk. Make DOMUIThumbnailSource wait for this notification if ThumbnailStore isn't ready yet. Also clean up some of the code. Review URL: http://codereview.chromium.org/155911 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21785 0039d316-1c4b-4281-b951-d872f2087c98
* Integrates a custom JumpList of Windows 7 into Chromium.hbono@chromium.org2009-07-241-0/+1
| | | | | | | | | | | | This change adds an option "--enable-custom-jumplist" that uses the ICustomDestinationList interface to add "Most Visited" pages, "Recently Closed" pages, and "Tasks" to the JumpList of Chromium. This change registers the CustomJumpList class into an observer of TabRestoreService so it can update the JumpList when a user adds/removes a tab. This change stores icon files used by a custom JumpList under "$(User Data Dir)/JumpListIcons" so Taskbar can show JumpList icons even when Chromium is not running. BUG=8037 TEST=Right-click the taskbar icon of Chromium on Windows 7. Review URL: http://codereview.chromium.org/56175 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21522 0039d316-1c4b-4281-b951-d872f2087c98
* Wire up a LoginDatabase for PasswordStoreMac, and start using it for lookup.stuartmorgan@chromium.org2009-06-301-0/+1
| | | | | | | | | | (Although it will always be empty at this point, since storage isn't implemented yet.) BUG=11745 TEST=none (no user-visible effect yet) Review URL: http://codereview.chromium.org/147044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19685 0039d316-1c4b-4281-b951-d872f2087c98
* Enforce a max length for document titles.abarth@chromium.org2009-05-301-0/+2
| | | | | | | | | | R=deanm BUG=http://crbug.com/12810 TEST=None Review URL: http://codereview.chromium.org/113969 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17282 0039d316-1c4b-4281-b951-d872f2087c98
* With the recent change to the ExternalTabContainer to have it subclass ↵ananta@chromium.org2009-05-271-1/+0
| | | | | | | | | | | | WidgetWin rather than Widget and the associated ATL classes, the class name based comparison for a window to check if it is an external tab container window is no longer valid. We now check if a window is an external tab window by looking for the existence of the kWindowObjectKey window property, which is only set on external tab container windows. Review URL: http://codereview.chromium.org/115833 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17034 0039d316-1c4b-4281-b951-d872f2087c98
* Fix another name I missed.thomasvl@chromium.org2009-05-211-1/+1
| | | | | | Review URL: http://codereview.chromium.org/113727 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16668 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed on official app name used for unittests that I missed before.thomasvl@chromium.org2009-05-211-1/+1
| | | | | | Review URL: http://codereview.chromium.org/115637 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16631 0039d316-1c4b-4281-b951-d872f2087c98
* Add a separate cookie store that's used for extensions.mpcomplete@google.com2009-05-141-0/+1
| | | | | | | Modify CookieMonster to support overriding the "cookieable schemes". Review URL: http://codereview.chromium.org/115204 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16083 0039d316-1c4b-4281-b951-d872f2087c98
* Create a ChromeProcessUtil for the Mac, and enable it in the tests.avi@google.com2009-04-231-4/+14
| | | | | | Review URL: http://codereview.chromium.org/95009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14328 0039d316-1c4b-4281-b951-d872f2087c98
* More solid detection of browser process in chrome_process_util_linux.cc:phajdan.jr@chromium.org2009-04-211-0/+3
| | | | | | | | | | | | | | | | - use GetAppOutput instead of popen - make unexpected conditions fatal (otherwise the tests using this code would mistakenly assume that there is no running browser process) Also add a constant for SingletonSocket. Make necessary adjustments to GetAppOutput - ignore stderr (because fuser prints the file name to stderr and having stderr in |output| would require more parsing). Review URL: http://codereview.chromium.org/77031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14091 0039d316-1c4b-4281-b951-d872f2087c98
* Ports all of the chrome/browser/history code to use FilePath, exceptestade@chromium.org2009-03-181-2/+2
| | | | | | | | | | | | | for DownloadDatabase, InMemoryDatabase, and RedirectUiTest. Except for in those files, we now only use std::wstring for text strings. This CL also enables two more unittests on Mac. patch by Rohit Rao. http://codereview.chromium.org/48018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12009 0039d316-1c4b-4281-b951-d872f2087c98
* Make startup_tests build and work on Mac.phajdan.jr@chromium.org2009-03-181-0/+9
| | | | | | | | | | Also ensure that Chromium.app quits properly between the tests. http://crbug.com/8391 Review URL: http://codereview.chromium.org/42306 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11998 0039d316-1c4b-4281-b951-d872f2087c98
* NO CODE CHANGEdeanm@chromium.org2009-03-101-1/+0
| | | | | | | | | Normalize end of file newlines in chrome/. All files end in a single newline. Review URL: http://codereview.chromium.org/42015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11331 0039d316-1c4b-4281-b951-d872f2087c98
* Make startup_tests build and run on Linux (except reference tests).phajdan.jr@chromium.org2009-03-051-0/+4
| | | | | | Review URL: http://codereview.chromium.org/27240 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10978 0039d316-1c4b-4281-b951-d872f2087c98
* Add FilePath setter/getter to pref service. Change callers to use it rather ↵estade@chromium.org2009-03-041-1/+1
| | | | | | | | | | | | | than the string methods. Update the pref service unit test and enable it on linux. Also switch over some wstrings to filepaths where appropriate. BUG=8154 Review URL: http://codereview.chromium.org/27354 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10844 0039d316-1c4b-4281-b951-d872f2087c98
* Proposed change to support resource loading for media files.hclam@chromium.org2009-03-021-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Highlights of changes: - Added methods to disk_cache::Entry: - Entry::PrepareTargetAsExternalFile(int index) Prepare a stream in an entry to use external file for storage. - Entry::GetExternalFile(int index) Get the external file backing the stream in the entry. - Added a property "CacheType type_" to HttpCache, along with setter and getter. There shall be two cache types, COMMON_CACHE and MEDIA_CACHE for distinguishing between different purpose of HttpCache. We have this property to trigger special behavior for caching needs of media files. - Added static methods to ChromeURLRequestContext - ChromeURLRequestContext::CreateOriginalForMedia Create a URLRequestContext for media files for the original profile. - ChromeURLRequestContext::CreateOffTheRecordForMedia Create a URLRequestContext for media files for off the record profile. - Added method to Profile interface. - GetRequestContextForMedia To get the request context for media files from the context. Design decissions: - Enforce writing to external file by calling methods to Entry rather than construct Backend by a different flag. Since we only want a valid and full response to go into an external file rather than redirection response or erroneous response, we should let HttpCache::Transaction to decide when to have an external file for response data. We eliminate a lot of useless external cache files. - Adding the CacheType enum and property to HttpCache, we could allow possible (?) future extensions to HttpCache to handle other different caching needs. And there's no need to add change constructors of HttpCache, but maybe we should add a specific constructor to accomodate a media HttpCache? - Adding Profile::GetRequestContextForMedia() Since we will need to use this new request context in ResourceDispatcherHost, I think the best place to keep it is in the profile. Also we will expose to user that there's a separate cache for media, so it's better to expose it in the Profile level to allow settings to the media cache, e.g. max file size, etc. Review URL: http://codereview.chromium.org/19747 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10745 0039d316-1c4b-4281-b951-d872f2087c98
* Ports SpellChecker to use FilePaths instead of wstring.estade@chromium.org2009-02-251-1/+3
| | | | | | | | | by Rohit Rao (rohitrao@google.com) issue: http://codereview.chromium.org/28013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10374 0039d316-1c4b-4281-b951-d872f2087c98
* Delete the ViewSourceTabContents.brettw@chromium.org2009-02-251-1/+2
| | | | | | | | | | | | | This removes all the tab contents type stuff for view source mode. The RenderViewHostManager now automatically switches RenderViews when we turn view source mode on or off to get the desired effect. I also moved some instances of hardcoded schemes into chrome_constants.h, and renamed RendererCreated/Ready/Gone to RenderViewCreated/Ready/Gone to reflect what they actually mean. Review URL: http://codereview.chromium.org/28089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10346 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-10 23:21:55 +0000