| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
On iOS, it is created in the ApplicationContextImpl.
BUG=576772
R=rohitrao@chromium.org,sdefresne@chromium.org
Review URL: https://codereview.chromium.org/1578283002
Cr-Commit-Position: refs/heads/master@{#369750}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of repeating the same string literal multiple times, use a
constant switches::kWatcherProcess.
In an upcoming CL, this constant will also be used by a function
returning the /prefetch switch to use for a given process type.
BUG=577698
Review URL: https://codereview.chromium.org/1585203003
Cr-Commit-Position: refs/heads/master@{#369531}
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=576402
Committed: https://crrev.com/1ad82bbc44d87669926c9cffe2ba77564df420a3
Cr-Commit-Position: refs/heads/master@{#368810}
Review URL: https://codereview.chromium.org/1580583002
Cr-Commit-Position: refs/heads/master@{#369291}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implementation behind the enable-native-notifications chrome://flags
Conceptually based on a previous attempt.
(https://codereview.chromium.org/224183002) but now using the same
interface android uses.
System and extensions notifications remain implemented through chrome
toasts.
There are a few things missing that will come in future CLs, most notably
Buttons
Auto dimsissal (i.e all notifications requireInteraction)
Sounds
BUG=571056
Review URL: https://codereview.chromium.org/1509923002
Cr-Commit-Position: refs/heads/master@{#369255}
|
|
|
|
|
|
|
|
| |
BUG=566085
Review URL: https://codereview.chromium.org/1577883003
Cr-Commit-Position: refs/heads/master@{#369077}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1580583002/ )
Reason for revert:
Speculative revert for Android Cronet bots failure (CronetTestInstrumentation)
Original issue's description:
> Add a whitelist for QUIC hosts.
>
> BUG=576402
>
> Committed: https://crrev.com/1ad82bbc44d87669926c9cffe2ba77564df420a3
> Cr-Commit-Position: refs/heads/master@{#368810}
TBR=agl@chromium.org,rsleevi@chromium.org,rch@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=576402
Review URL: https://codereview.chromium.org/1574423003
Cr-Commit-Position: refs/heads/master@{#369050}
|
|
|
|
|
|
|
|
|
|
|
| |
Remove the flag that would enable animation of reader mode. Since
animation now is the intended behavior, the flag is no longer needed.
BUG=
Review URL: https://codereview.chromium.org/1571993002
Cr-Commit-Position: refs/heads/master@{#368915}
|
|
|
|
|
|
|
|
| |
BUG=576402
Review URL: https://codereview.chromium.org/1580583002
Cr-Commit-Position: refs/heads/master@{#368810}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mac hasn't migrated to the new task manager yet, and the network bytes
code checks the switch to determine which task manager to forward the
bytes data to. Hence, on Macs, the switch check should be skipped.
BUG=548380
Review URL: https://codereview.chromium.org/1568953002
Cr-Commit-Position: refs/heads/master@{#368656}
|
|
|
|
|
|
|
|
|
|
|
|
| |
As a component, the SecurityStateModel logic can be reused on iOS, so
that we use consistent logic and definitions to describe a page's
overall security status for UI on all platforms.
BUG=515071
Review URL: https://codereview.chromium.org/1539043002
Cr-Commit-Position: refs/heads/master@{#368636}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds a flag and field trial group enabling app banners to use
the site engagement service for triggering. This allows banners to be
triggered based on broader criteria than simply navigations.
An additional UMA histogram is also added to compare the time from when
an origin was first recorded as visited by the app banner system until
the time when a banner should be shown.
This CL revealed a bug in the testing for the site engagement service,
where the service would be NULL under some testing contexts. This
issue is fixed, and a new app banner settings helper test for site
engagement is added. Existing tests are refactored to properly reset
the app banner trigger system to its default values, ensuring that tests
can be run in different orders without failures.
Another bug is fixed where the SiteEngagementServiceFactory did not
have a dependency on the HistoryServiceFactory; this caused crashes
on the Android debug builder.
BUG=553858,569941
Committed: https://crrev.com/e85b17d58172be38e869624a9c60e7d918cd34dc
Cr-Commit-Position: refs/heads/master@{#365689}
Review URL: https://codereview.chromium.org/1413343008
Cr-Commit-Position: refs/heads/master@{#367796}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
LocalizedError uses several switches that it conceptually "owns" (i.e., they
are fundamentally related to this class). This CL componentizes these switches
into //components/error_page in anticipation of componentizing
localized_error.*.
BUG=523362
Review URL: https://codereview.chromium.org/1539903002
Cr-Commit-Position: refs/heads/master@{#367506}
|
|
|
|
|
|
|
|
| |
BUG=566085
Review URL: https://codereview.chromium.org/1551743002
Cr-Commit-Position: refs/heads/master@{#367155}
|
|
|
|
|
|
|
|
| |
BUG=529962
Review URL: https://codereview.chromium.org/1512113002
Cr-Commit-Position: refs/heads/master@{#367025}
|
|
|
|
|
|
|
|
|
|
| |
BUG=138542
TBR=thakis@chromium.org
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/1548153002
Cr-Commit-Position: refs/heads/master@{#366893}
|
|
|
|
|
|
|
|
|
| |
BUG=467808
TBR=isherman@chromium.org
Review URL: https://codereview.chromium.org/1541033002
Cr-Commit-Position: refs/heads/master@{#366517}
|
|
|
|
|
|
|
|
|
|
|
| |
extension protected behind a flag.
TBR=grunell@chromium.org
BUG=568169
Review URL: https://codereview.chromium.org/1530863002
Cr-Commit-Position: refs/heads/master@{#366258}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 9b52527c4d7542b4706b8fba945e8141346da098.
Reason: still breaks Android (dbg) bot: https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/31923
BUG=553858
NOTRY=TRUE
TBR=benwells
Review URL: https://codereview.chromium.org/1530983004
Cr-Commit-Position: refs/heads/master@{#365765}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds a flag and field trial group enabling app banners to use
the site engagement service for triggering. This allows banners to be
triggered based on broader criteria than simply navigations.
An additional UMA histogram is also added to compare the time from when
an origin was first recorded as visited by the app banner system until
the time when a banner should be shown.
This CL revealed a bug in the testing for the site engagement service,
where the service would be NULL under some testing contexts. This
issue is fixed, and a new app banner settings helper test for site
engagement is added. Existing tests are refactored to properly reset
the app banner trigger system to its default values, ensuring that tests
can be run in different orders without failures.
BUG=553858
Review URL: https://codereview.chromium.org/1413343008
Cr-Commit-Position: refs/heads/master@{#365689}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 3e7cdbf1b379398f5e1a710d22629fdf14df02cf.
Reason:
broke Android Tests (dbg) bot, see
https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/31891
e.g. AppBannerSettingsHelperTest.SiteEngagementTrigger
BUG=553858
NOTRY=TRUE
TBR=dominickn@chromium.org, calamity@chromium.org, benwells@chromium.org, isherman@chromium.org
Review URL: https://codereview.chromium.org/1527973002
Cr-Commit-Position: refs/heads/master@{#365249}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds a flag and field trial group enabling app banners to use
the site engagement service for triggering. This allows banners to be
triggered based on broader criteria than simply navigations.
An additional UMA histogram is also added to compare the time from when
an origin was first recorded as visited by the app banner system until
the time when a banner should be shown.
BUG=553858
Committed: https://crrev.com/936894045ed2aed9ee67b9c371a9eff94912c346
Cr-Commit-Position: refs/heads/master@{#363100}
Review URL: https://codereview.chromium.org/1413343008
Cr-Commit-Position: refs/heads/master@{#365227}
|
|
|
|
|
|
|
|
|
|
|
| |
Removes all the viewer code for the old design, the --enable-pdf-material-ui
flag, and the associated tests.
BUG=439114
Review URL: https://codereview.chromium.org/1521913002
Cr-Commit-Position: refs/heads/master@{#365205}
|
|
|
|
|
|
|
|
|
|
| |
Now that there is a device chooser UI this flag is unnecessary.
BUG=529950
Review URL: https://codereview.chromium.org/1514413004
Cr-Commit-Position: refs/heads/master@{#364907}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is experiment controls the behaviour of what happens when a user opens a
suggestion from the NTP. Specifically if there are previously opened tabs for
the suggestion.
We are starting this with 2 simple cases where we match the existing tabs and
the suggestion by URL or by Hostname.
This is a base change so we can understand which direction to proceed from here.
BUG=565953
Review URL: https://codereview.chromium.org/1501753002
Cr-Commit-Position: refs/heads/master@{#364319}
|
|
|
|
|
|
|
|
| |
BUG=245319
Review URL: https://codereview.chromium.org/1501543002
Cr-Commit-Position: refs/heads/master@{#364103}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome.input.ime.* APIs on windows and linux.
See the step 1 in: https://codereview.chromium.org/1403543004/
See the step 2 in: https://codereview.chromium.org/1419593002/
Main changes:
1. Update the entry in _permission_features.json and gypi file to make IME APIs accessible under chromeos, windows and linux platforms.
2. Add "platforms" attribute in input_ime.json, to reuse the ChromeOS APIs: chrome.input.ime.setComposition, .commitText, .sendKeyEvents, .keyEventHandled, .deleteSurroundingText, .onFocus, onBlur, .onKeyEvent, .onReset, .onDeactivated;
And keep other APIs ChromeOS only: chrome.input.ime.clearComposition, .hideInputView, .setCandidateWindowProperties, setCandidates, .setCursorPosition, .setMenumItems, updateMenuItems, .onActivate, .onInputContexUpdate, .onCandidateClicked, onMenuItemActivated, onSurroundingTextChanged.
3. Add flag "enable-input-ime-api" to enable chrome.input.ime API on Linux and Win.
Update input_ime_api.cc as API implementation on Linux and Win.
And add two kinds of errors: kErrorAPINotImplemented/ kErrorAPIDisabled to indicate whether this API is disabled.
4. Add new file input_ime_api_chromeos.cc for chromeos specific
implementation of the input_ime API.
BUG=517773
TEST=No compiling errors.
Review URL: https://codereview.chromium.org/1418643007
Cr-Commit-Position: refs/heads/master@{#363975}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 02b30b18f74daf51b16b1b8ac733f9b44915137f.
Reason for revert: Speculative attempt to see if this fixes the FYI
memory bots (e.g. http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28valgrind%29%283%29/builds/48940/steps/memory%20test%3A%20unit/logs/stdio)
NOTRY=true
TBR=benwells
NOTREECHECKS=true
BUG=553858
Review URL: https://codereview.chromium.org/1505633002
Cr-Commit-Position: refs/heads/master@{#363389}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds a flag and field trial group enabling app banners to use
the site engagement service for triggering. This allows banners to be
triggered based on broader criteria than simply navigations.
An additional UMA histogram is also added to compare the time from when
an origin was first recorded as visited by the app banner system until
the time when a banner should be shown.
BUG=553858
Review URL: https://codereview.chromium.org/1413343008
Cr-Commit-Position: refs/heads/master@{#363100}
|
|
|
|
|
|
|
|
|
|
|
| |
This adds a new version of the chrome://history WebUI page, which is
available behind the flag --enable-md-history on Desktop and Android.
BUG=425625
Review URL: https://codereview.chromium.org/1451163003
Cr-Commit-Position: refs/heads/master@{#362612}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This requires making the test aware of kIsolateExtensions, so that it
can adjust its expectations accordingly. Since the schema in
extensions/common/api/test.json is also used in
extensions_browsertests (by web_view_apitest.cc), this also required
moving kIsolateExtensions to a location where those tests can
reference them, namely extensions/common/switches.cc.
BUG=532666
Review URL: https://codereview.chromium.org/1457163002
Cr-Commit-Position: refs/heads/master@{#362580}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
LayoutManagerDocumentTabSwitcher (LMDTS) is the new LayoutManager to
support tab switcher in document mode. Most of the implementations are
inside this LayoutManager.
LMDTS is very similar to LayoutManagerDocument (LMD) except:
1) It keeps overview list layout and overview layout and hooks up
DocumentTabModelSelector to them.
2) Creates title cache and (temporarily) stores it in mTabCache.
3) Simplified overview show and hide logic similar to that of
LayoutManagerChrome.
Additionally, this CL contains the following changes:
1) A chrome switch to enable and disable document mode.
(flag is available only for canary)
2) DocumentActivity will now switch between LMD and LMDTS.
3) ToolbarPhone will now check the flag in 1).
4) Straightened up ToolbarPhone's tab switching resource inflating and
removing logic
BUG=520327
Review URL: https://codereview.chromium.org/1412293007
Cr-Commit-Position: refs/heads/master@{#362564}
|
|
|
|
|
|
|
|
| |
BUG=561867
Review URL: https://codereview.chromium.org/1475113003
Cr-Commit-Position: refs/heads/master@{#362353}
|
|
|
|
|
|
|
|
| |
BUG=519012
Review URL: https://codereview.chromium.org/1436633002
Cr-Commit-Position: refs/heads/master@{#362289}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes since https://codereview.chromium.org/1416133003 are ps1 -> ps2.
- Includes build fix to for debug component GN build.
- Includes Crashpad roll to pull in clang compile fixes and a limit on
the number of locks saved to the crash dump.
- Increase timeout on tab crash telemetry test for debug builds.
Original CL:
Crashpad Windows: Use the Crashpad client instead of Breakpad on Windows
Crashpad is always compiled into chrome and its handler is always
enabled. It only uploads in Official builds.
On Windows, the crash handler is chrome.exe run with a
--crashpad-handler argument. This is due to concern about
incompatibilities of shipping an additional new different binary for AV,
firewalls, etc.
Sample renderer crash/1aed2bc785e28995
Sample browser: crash/66c822815474a5d8
See also http://crbug.com/427611 .
R=mark@chromium.org
TBR=cpu@chromium.org
BUG=447073, 546288, 456193
Review URL: https://codereview.chromium.org/1479283002
Cr-Commit-Position: refs/heads/master@{#362258}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Windows (patchset #48 id:1160001 of https://codereview.chromium.org/1416133003/ )
Reason for revert:
Some failing tests https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/43485. Unclear why they didn't fail on trybots so I'm going to revert and investigate.
Original issue's description:
> Crashpad Windows: Use the Crashpad client instead of Breakpad on Windows
>
> Crashpad is always compiled into chrome and its handler is always
> enabled. It only uploads in Official builds.
>
> On Windows, the crash handler is chrome.exe run with a
> --crashpad-handler argument. This is due to concern about
> incompatibilities of shipping an additional new different binary for AV,
> firewalls, etc.
>
> Sample renderer crash/1aed2bc785e28995
> Sample browser: crash/66c822815474a5d8
>
> See also http://crbug.com/427611 .
>
> R=mark@chromium.org,cpu@chromium.org
> BUG=447073,546288, 456193
>
> Committed: https://crrev.com/aaa2ff656f9fcabcbdd9e9964e3b2bdc8f5102ed
> Cr-Commit-Position: refs/heads/master@{#361742}
TBR=mark@chromium.org,cpu@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=447073,546288, 456193
Review URL: https://codereview.chromium.org/1476193002
Cr-Commit-Position: refs/heads/master@{#361797}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Crashpad is always compiled into chrome and its handler is always
enabled. It only uploads in Official builds.
On Windows, the crash handler is chrome.exe run with a
--crashpad-handler argument. This is due to concern about
incompatibilities of shipping an additional new different binary for AV,
firewalls, etc.
Sample renderer crash/1aed2bc785e28995
Sample browser: crash/66c822815474a5d8
See also http://crbug.com/427611 .
R=mark@chromium.org,cpu@chromium.org
BUG=447073,546288, 456193
Review URL: https://codereview.chromium.org/1416133003
Cr-Commit-Position: refs/heads/master@{#361742}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move FlagsState class definition to components/flags_ui so that it can
be shared with iOS but leave the global FeatureEntry list definition
in the embedder.
Slightly change FlagsState interface to take the name of embedder
specific switches (switches::kEnableFeatures, ...) and use dummy values
for unit testing.
Split the unit tests moving all those that have no dependency on the
global FeatureEntry to flags_state_unittest.cc. Remove helper testing
function that are no longer useful (overridding global state).
BUG=551954
Review URL: https://codereview.chromium.org/1411453004
Cr-Commit-Position: refs/heads/master@{#361295}
|
|
|
|
|
|
|
|
|
|
|
| |
Network security team asked to put feature behind the flag to review
the code.
BUG=524788
Review URL: https://codereview.chromium.org/1450213002
Cr-Commit-Position: refs/heads/master@{#360749}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Exosphere is a set of display server classes for Chromium that
can be used for building a display server on top of Ash, the
Chrome Compositor and the GpuMemoryBuffer framework.
The classes and interfaces are inspired by the Wayland protocol
and reference implementation of a display server that uses
the Wayland protocol and server library is provided in the
wayland/ sub-directory.
BUG=549781
TEST=components_unittests --gtest_filter=ServerTest.*:SurfaceTest.*:BufferTest.*:DisplayTest.*:ShellSurfaceTest.*:SharedMemoryTest.*
Review URL: https://codereview.chromium.org/1412093006
Cr-Commit-Position: refs/heads/master@{#360672}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts the revert d58c07b6ac2dee0cb4ce0bee04438073dcead4e6.
Original speculative revert didn't fix the tests on the downstream
buildbots.
TBR=mlamouri@chromium.org
NOTRY=true
BUG=556902
Review URL: https://codereview.chromium.org/1456443002
Cr-Commit-Position: refs/heads/master@{#360043}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 151479f43c58255e210c1d0f730ebf979ea360f6.
This is suspected to have caused WebApp / ThemeColor related tests to fail on
downstream bots only.
TBR=mlamouri
NOTRY=true
BUG=556902
Review URL: https://codereview.chromium.org/1451313002
Cr-Commit-Position: refs/heads/master@{#360035}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
And distill auto_launch_util.cc to essentially the very simple thing it is
doing once all the if(in_foreground) code is out of the way..!
TBR=atwilson (metrics change in chrome/browser/background/background_mode_manager.cc already reviewed by metrics OWNER rkaplow@)
TBR=pkasting (side-effect of switch removal on chrome/browser/ui/startup/startup_browser_creator_impl.cc already reviewed by grt@)
TBR=gene (side-effect of switch removal on cloud_print -- that switch was a no-op for cloud_print anyways)
BUG=553790
TEST=Install pre-CL chrome, enable bg auto-launch, install new Chrome, confirm it uses the same key for bg auto-launch and works with it.
Review URL: https://codereview.chromium.org/1439803002
Cr-Commit-Position: refs/heads/master@{#359561}
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove about:flags enable-theme-color-in-tabbed-mode
- Enable theme-color for tabbed mode for phones for all channels.
BUG=482207
Review URL: https://codereview.chromium.org/1434123002
Cr-Commit-Position: refs/heads/master@{#359430}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds a command line flag, field trial name, and other
support to disable auto-hiding the toolbar when the page
is scrolled. The toolbar is still hidden if page content
goes fullscreen.
BUG=554565
Review URL: https://codereview.chromium.org/1442483002
Cr-Commit-Position: refs/heads/master@{#359379}
|
|
|
|
|
|
|
|
|
|
| |
This flag has outlived its usefulness and is more confusing than anything else now.
BUG=514340
Review URL: https://codereview.chromium.org/1432423002
Cr-Commit-Position: refs/heads/master@{#359226}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Kill switch is implemented using base::FeatureList and can be activated
using Finch or --disable-features=PrintPreviewDistiller flag.
BUG=490809
Committed: https://crrev.com/afa40172de656dbb8085519fc7a7a9c7a5111b97
Cr-Commit-Position: refs/heads/master@{#359048}
Review URL: https://codereview.chromium.org/1424933017
Cr-Commit-Position: refs/heads/master@{#359112}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Reason for reverting is suspicion of adding a static initializer.
See blamelist for sizes failure: https://build.chromium.org/p/chromium/builders/Mac/builds/9102
This reverts commit afa40172de656dbb8085519fc7a7a9c7a5111b97.
Add kill switch for Print Preview Distiller
Kill switch is implemented using base::FeatureList and can be activated
using Finch or --disable-features=PrintPreviewDistiller flag.
BUG=490809
TBR=vitalybuka@chromium.org
Review URL: https://codereview.chromium.org/1437803002 .
Cr-Commit-Position: refs/heads/master@{#359068}
|
|
|
|
|
|
|
|
|
|
|
| |
Kill switch is implemented using base::FeatureList and can be activated
using Finch or --disable-features=PrintPreviewDistiller flag.
BUG=490809
Review URL: https://codereview.chromium.org/1424933017
Cr-Commit-Position: refs/heads/master@{#359048}
|
|
|
|
|
|
|
|
|
|
|
|
| |
They already didn't do anything, and nobody's been asking to disable
this feature (... which they can do via the UI in settings anyways).
R=tommycli@chromium.org
BUG=none
Review URL: https://codereview.chromium.org/1417213010
Cr-Commit-Position: refs/heads/master@{#358948}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 93f190df6d1e0435e535a4336e1fe9035a5c9eb7.
The original CL is https://codereview.chromium.org/1413373012/
The revert CL is https://codereview.chromium.org/1423373006/
The problem which caused the revert was the assumption that ProfileSyncService exists, which should be solved by the CL https://codereview.chromium.org/1413373012/ that landed in the meantime. The trybots did not catch it, as this issue was introduced after running git cl try on the original CL but before it landed.
BUG=553640
TBR=stevenjb@chromium.org,isherman@chromium.org,dbeam@chromium.org,petermayo@chromium.org,robliao@chromium.org
NOTREECHECKS=True
NOTRY=True
Review URL: https://codereview.chromium.org/1434763002 .
Cr-Commit-Position: refs/heads/master@{#358922}
|