| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
For context see this thread:
https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II
TBR=thakis,pkasting,jam
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, these components only registered themselves if CHROME_ETW_LOGGING was set in the environment. This is likely preventing the new log machinery in http://crrev.com/126240 from providing useful information on the main waterfall bots.
Siggi: overall
Brett: chrome/common
BUG=none
TEST=none
R=siggi@chromium.org,brettw@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9702021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126810 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=mseaborn@chromium.org
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9365073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The env var kNoOOBreakpad (NO_OO_BREAKPAD) was used as a global
variable to communicate in-process between chrome.exe and chrome.dll
so that the latter can report via UMA whether Breakpad was enabled
(with the counts kStabilityBreakpadRegistrationFail and
kStabilityBreakpadRegistrationSuccess, also known as
"user_experience_metrics.stability.breakpad_registration_ok" and
"user_experience_metrics.stability.breakpad_registration_fail".)
But this was broken:
* In the browser process, checking for Breakpad enablement happens in
a thread, so the UMA report might happen before Breakpad is
enabled, in which case the UMA report would be wrong.
* If Breakpad is not enabled, kNoOOBreakpad would not be set, and
chrome_browser_main_win.cc would assume this meant that Breakpad
was enabled successfully.
If the stat is wrong and no-one noticed, we might as well remove it
and simplify the code.
BUG=111265
TEST=none
Review URL: http://codereview.chromium.org/9391030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For BWSI (incognito) mode, we want to make sure that we don't leak
private information between sessions, so we need to have chrome write
log output to the tmpfs created for that mode.
Also, the chrome log in "logged in" mode should reside in the "log"
subdir instead of in the user data dir.
BUG=http://crosbug.com/6908
TEST=Ran on device in incognito and regular modes, and watched where
log output ended up.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64638
Review URL: http://codereview.chromium.org/4194005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64826 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For BWSI (incognito) mode, we want to make sure that we don't leak
private information between sessions, so we need to have chrome write
log output to the tmpfs created for that mode.
Also, the chrome log in "logged in" mode should reside in the "log"
subdir instead of in the user data dir.
BUG=http://crosbug.com/6908
TEST=Ran on device in incognito and regular modes, and watched where
log output ended up.
Review URL: http://codereview.chromium.org/4194005
TBR=gspencer@chromium.org
Review URL: http://codereview.chromium.org/4089014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For BWSI (incognito) mode, we want to make sure that we don't leak
private information between sessions, so we need to have chrome write
log output to the tmpfs created for that mode.
Also, the chrome log in "logged in" mode should reside in the "log"
subdir instead of in the user data dir.
BUG=http://crosbug.com/6908
TEST=Ran on device in incognito and regular modes, and watched where
log output ended up.
Review URL: http://codereview.chromium.org/4194005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=50273
TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux
TBR: erg
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
shutdown method: {Close all windows, clicking exit, terminating process}
and number of tabs open: {just about:blank, twenty tabs}
BUG=23118
TEST=This CL adds a test.
Review URL: http://codereview.chromium.org/1594008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
ChromeLoggingTest along the way.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1559016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to control the log level and log feature flags from outside the process, and all log messages can be transported into ETW trace sessions.As is this provides an event trace provider class thatmanages the log level on control callbacks and shunts the formatted log messages to ETW when warranted.The provider observes one feature flag, which when turned on causes it to capture and log a stack trace at the log site, which can be helpful when diagnosing errors from logs.This CL also initializes ETW logging for chrome.dll, but only if the environment variable "CHROME_ETW_LOGGING" is set. The ETW machinery may create a thread in every process registering a trace provider, and the environment variable makes this overhead optional.
TEST=Unittests in this change
BUG=none
Review URL: http://codereview.chromium.org/413006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Normalize end of file newlines in chrome/. All files end in a single newline.
Review URL: http://codereview.chromium.org/42015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
get crash reports.
- Added env_vars to exe project instead of keep duplicating the strings.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15 0039d316-1c4b-4281-b951-d872f2087c98
|