| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The previous reverted CL caused a MSAN leak errors because of a circular
reference to FileBrowserPrivateGetFileTasksFunction, which is a ref counted
class. Instance of it was passed to a callback of a MimeTypeCollector, which
was a member of the ref counted function, and inside was storing the callback
with the ref counted function bound.
As a result, the ref counted FileBrowserPrivateGetFileTasksFunction was never
deleted, and hence resulting in leaking of all its members.
To resolve this problem, the callbacks are always called with a PostTask, and
the callback member of the MimeTypeCollector class is cleared as son as
possible, to remove a reference to the ref counted object.
The reverted CL is here:
FileBrowserPrivateGetFileTasksFunction,
Original description:
This is the first patch, part of efforts to move MIME calculation to one place.
With introducing this class, we no longer need to pass MIME types from Files
app back to C++ layer when running tasks.
The next step will be cleaning up apps/launcher.cc in order to use the new
class.
TBR=benwells@chromium.org
TEST=unit_tests: *FileManagerMimeUtilTest*, browser_tests: *FileSystemProvider*Mime*
BUG=388586
Review URL: https://codereview.chromium.org/367853004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=asargent@chromium.org, levin@chromium.org, xiyuan@chromium.org
BUG=386881
Review URL: https://codereview.chromium.org/360393005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=305852
Review URL: https://codereview.chromium.org/366483002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=389230
TEST=none
Review URL: https://codereview.chromium.org/353063002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280879 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This patch adds the detailed change information into onDirectoryChanged event to Files.app. The detailed information is not handled on Files.app, hence this patch itself should not change any functionality.
BUG=131198
TEST=browser_tests/unit_tests passes
Review URL: https://codereview.chromium.org/343073003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/349333009/)
Reason for revert:
memory leaks on chromium os lsan builder
Original issue's description:
> Introduce MimeTypeCollector class for easy MIME type resolution.
>
> This is the first patch, part of efforts to move MIME calculation to one place.
> With introducing this class, we no longer need to pass MIME types from Files
> app back to C++ layer when running tasks.
>
> The next step will be cleaning up apps/launcher.cc in order to use the new
> class.
>
> TBR=benwells@chromium.org
> TEST=Partly by browser_tests: *FileSystemProvider*MimeTest*.
> BUG=388586
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280794
TBR=kinaba@chromium.org,hirono@chromium.org,benwells@chromium.org,mtomasz@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=388586
Review URL: https://codereview.chromium.org/360963002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280816 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the first patch, part of efforts to move MIME calculation to one place.
With introducing this class, we no longer need to pass MIME types from Files
app back to C++ layer when running tasks.
The next step will be cleaning up apps/launcher.cc in order to use the new
class.
TBR=benwells@chromium.org
TEST=Partly by browser_tests: *FileSystemProvider*MimeTest*.
BUG=388586
Review URL: https://codereview.chromium.org/349333009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280794 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Extension for mounting fake archives on launch event.
Multiple archives can be mounted and handled at the same time.
There is support for listening directories, reading files, etc.
As an important feature we have the state saving on suspending the
extension. When the extension is loaded again we can restore the
state at the previous point before suspending. Also there is
support for restarts and crashes by using the onStartup event.
BUG=388080
Review URL: https://codereview.chromium.org/360673004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280773 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=305852
Review URL: https://codereview.chromium.org/357123002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=309681
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279121
Review URL: https://codereview.chromium.org/326233002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280685 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The flag is used in JavaScript side to detect the app should show the
notification for the volume or not.
BUG=341902
TEST=manually
R=benwells@chromium.org, kinaba@chromium.org
Review URL: https://codereview.chromium.org/352633006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds the startCharacteristicNotifications and
stopCharacteristicNotifications functions to the chrome.bluetoothLowEnergy API.
These changes the API behavior from automatically getting characteristic value
notifications to explicitly having to enable them by calling the new API method.
Internally an API resource is created for each app on a per-characteristic
basis, managing the life-time of a device::BluetoothGattNotifySession
object. Notifications are physically enabled/disabled and shared among apps
using session objects.
BUG=387989
TEST=browser_tests --gtest_filter=BluetoothLowEnergyApiTest.*
Review URL: https://codereview.chromium.org/351123002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=389625
NOTRY=True
Review URL: https://codereview.chromium.org/361503002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280450 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=305852
Review URL: https://codereview.chromium.org/358013004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280424 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
See https://chrome-apps-doc.appspot.com/_patch/355853005/extensions/permission_warnings for how it looks.
BUG=364336
NOTRY=True
Review URL: https://codereview.chromium.org/355853005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280423 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Provider API.
Mount a sample file system on installing an extension.
The file system is made of fake content and if offers
functionality like directory listening and opening,
reading and closing files supplied with fake content.
BUG=388080
Review URL: https://codereview.chromium.org/351553005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Disable extensions code on Android so they do not use these messages.
BUG=349436
Review URL: https://codereview.chromium.org/345693002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch shows amount of data returned in each chunk when reading a file
plus additionally amount of overhead caused by IPC.
TEST=Tested manually with chrome://provided-file-system and a sample extension.
BUG=384201
Review URL: https://codereview.chromium.org/352503002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
webview.json -> web_view_internal.json
Broke compile on clobber builds, was not caught on trybot incremental builds.
Fixed the #include header in web_view_internal_api.cc
Requires NOTRY for (false) histograms.xml presubmit failure.
NOTRY=true
TBR=kalman@chromium.org, fsamuel@chromium.org, thestig@chromium.org, asvitkine@chromium.org
BUG=388380
Test=Internal cleanup, no visible change.
Review URL: https://codereview.chromium.org/356793004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280091 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=178319
NOTRY=True
Review URL: https://codereview.chromium.org/245783005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=387730
Test=Open a chrome app that uses <webview>, e.g:
https://chrome.google.com/webstore/detail/edggnmnajhcbhlnpjnogkjpghaikidaa
Now inspect the app (not the webview) to be able to run JavaScript
on the app.
Then call the print() function on the webview to see printing
dialog for the webview, e.g.:
document.querySelector('webview').print();
Review URL: https://codereview.chromium.org/344213005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
NOTRY=true
BUG=None
Test=None, OWNERS file internal change.
Review URL: https://codereview.chromium.org/332093006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280053 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch adds support for returning mime types with metadata, and using them
for launching file handlers.
Note, that Files app is not able to use MIME types for launching file handlers,
because the MIME types are not passed to Files app. This problem is separately
tracked here: crbug.com/388586.
TEST=unit_tests: *FileSystemProvider*GetMetadata*,
browser_tests: *FileSystemProvider*MimeType*
BUG=388586
R=benwells@chromium.org, hirono@chromium.org, kinaba@chromium.org
Review URL: https://codereview.chromium.org/352753002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This patch adds basic documentation, which is mostly auto generated.
TEST=Tested manually with a testing server.
BUG=248427
Review URL: https://codereview.chromium.org/356463002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These need to stay here until M38 goes stable since 'title' was
previously mandatory.
This also adds a comment that 'title' is removed from M38.
BUG=350217
Review URL: https://codereview.chromium.org/353743004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=233982
NOTRY=True
Review URL: https://codereview.chromium.org/353883004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=fgorski@chromium.org, rpop@chromium.org
TBR=kalman
NOTRY=true
Review URL: https://codereview.chromium.org/352573002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279865 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Rename webview API related files to web_view_internal.
> webview.json -> web_view_internal.json
>
> NOTRY=True
> BUG=388380
> Test=Internal cleanup, no visible change.
>
> Review URL: https://codereview.chromium.org/347143004
TBR=lazyboy@chromium.org
Review URL: https://codereview.chromium.org/351033006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
webview.json -> web_view_internal.json
NOTRY=True
BUG=388380
Test=Internal cleanup, no visible change.
Review URL: https://codereview.chromium.org/347143004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=322094
Review URL: https://codereview.chromium.org/354673006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the extension asks for HostsAll permission and DecalarativeWebRequest the use will get the following two messages:
"Read and change all your data on the websites you visit"
"Block parts of web pages"
The former message includes the latter so is too excessive to show two messages. So this CL makes HostsAll warning message supersedes DeclarativeWebRequest warning message.
BUG=384487
R=jww,meacer,kalman
Review URL: https://codereview.chromium.org/351943006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279563 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=375008
Review URL: https://codereview.chromium.org/340953002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279562 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=305852
Review URL: https://codereview.chromium.org/351673004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279520 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
destroyed
BUG=309681
Review URL: https://codereview.chromium.org/332273003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mention limitations of response headers w.r.t caching.
Document how errors are handled.
BUG=355232
R=battre@chromium.org
Review URL: https://codereview.chromium.org/218393018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
_api_features.json to _permission_features.json. The only reason they're in the
former is because of systemic cargo culting; the practical effect is that when
those permissions are requested on non-chromeos platforms it will appear to
work, but the APIs won't appear. After this change it will at least show an
install warning (in developer mode) that it's not supported.
R=rockot@chromium.org
Review URL: https://codereview.chromium.org/295273002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This should just make the docs available for convenient referece by devs
using the private API. It need not be listed in any index.
BUG=none
R=kalman@chromium.org
Review URL: https://codereview.chromium.org/349293004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Followup to https://codereview.chromium.org/335273005/, https://codereview.chromium.org/335833003/, and https://codereview.chromium.org/316863002/
This CL renames the remaining C++ stuff, except for CrOS-specific code.
Still missing:
- ChromeOS-specific code in c/b/chromeos/login/managed/ and ash/system/
- JavaScript
- Resource names
- The global ENABLE_MANAGED_USERS define
TBR=msw@chromium.org (c/b/ui)
TBR=noms@chromium.org (c/b/profiles)
TBR=atwilson@chromium.org (components/signin)
TBR=finnur@chromium.org (c/b/extensions, c/common/extensions, and extensions/common)
All the TBRs are just renames.
BUG=385113
Review URL: https://codereview.chromium.org/345563008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This provides the following APIs at JavaScript level to enable/disable
password saving.
chrome.privacy.services.passwordSavingEnabled.get()
chrome.privacy.services.passwordSavingEnabled.set()
chrome.privacy.services.passwordSavingEnabled.clear()
R=bauerb@chromium.org, gcasto@chromium.org, koz@chromium.org, sabineb@google.com
BUG=61621
Review URL: https://codereview.chromium.org/290123003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279363 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Re-applying SVN r206985, which was inadvertently lost in a refactor.
BUG=249193
BUG=387515
NOTRY=true
Review URL: https://codereview.chromium.org/355533003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279319 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Re-applying SVN r194776, which was inadvertently lost in a refactor.
BUG=230281
BUG=387515
NOTRY=true
Review URL: https://codereview.chromium.org/345353002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279307 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=322094
Review URL: https://codereview.chromium.org/344453003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279278 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(SimpleFeature) rather than external to them (ExtensionAPI).
This fixes ComplexFeature dependency checking.
R=rockot@chromium.org
Review URL: https://codereview.chromium.org/308423002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279224 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
NOTRY=true
BUG=360270
Review URL: https://codereview.chromium.org/298463003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279217 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I accidentally wrote another version of this without remembering that it already existed in extensions/generated_extensions_api.gni.
R=rockot@chromium.org
Review URL: https://codereview.chromium.org/344443011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=kalman@chromium.org, asargent@chromium.org
BUG=387999
Review URL: https://codereview.chromium.org/341833006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=387169
TEST=none
Review URL: https://codereview.chromium.org/345203004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"read" and "write".
The "read" and "write" strings are all different among warnings.
So far we have:
Read and write
Read and modify
Read and change
Access and modify
Access and change
To ensure consistency all of them should use "read" and "change" whenever possible. Also according to Helen's findings, users don't know the exact meaning of the word "access".
BUG=386224
R=jww,meacer,felt
Review URL: https://codereview.chromium.org/348483002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279191 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=387622
Review URL: https://codereview.chromium.org/349213003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
AutomationApiTest.GeneratedTree test crashes now:
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/32326
> Rewriting automation_node update handling based on ax_tree
>
> BUG=309681
>
> Review URL: https://codereview.chromium.org/326233002
TBR=aboxhall@chromium.org
Review URL: https://codereview.chromium.org/354503002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279173 0039d316-1c4b-4281-b951-d872f2087c98
|