| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
run script on XML
pages. For more info, see: http://code.google.com/p/chromium/issues/detail?id=39845#c7
TBR=rafaelw@chromium.org
TBR=aa@chromium.org
Review URL: http://codereview.chromium.org/2812006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50051 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
pages. For more info, see: http://code.google.com/p/chromium/issues/detail?id=39845#c7
TBR=rafaelw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is in seconds, not milliseconds.
Regenerated the docs using the test_shell script; a few other docs appeared to be out-of-date as well.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2838008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50011 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
focus.
Note that this patch includes support for Views (Windows/chromeos) and GTK (Linux). I was going to do mac as well, but decided my objective-c skillz were too rusty.
BUG=32932
TEST=none
Review URL: http://codereview.chromium.org/2778001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ManifestTest.AppsDisabledByDefault.
Don't cache the value of the CommandLine, since unit_tests can modify it while
the process is running.
BUG=41280
Review URL: http://codereview.chromium.org/2824005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49809 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Don't cache the value of the CommandLine, since unit_tests can modify it while
the process is running.
BUG=41280
Review URL: http://codereview.chromium.org/2632001
TBR=mpcomplete@chromium.org
Review URL: http://codereview.chromium.org/2861001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49745 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Don't cache the value of the CommandLine, since unit_tests can modify it while
the process is running.
BUG=41280
Review URL: http://codereview.chromium.org/2632001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
that failed.
This change is designed to help understand bug 35198, which we can not reproduce locally.
BUG=35198
TEST=manual
Review URL: http://codereview.chromium.org/2714016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=45155
TEST=Run chrome with the --enable-apps flag.Install an app - the confirmation
dialog should say "..this App..." instead of "...this Extension...". Install an
extension - it should stil say "Extension".
Review URL: http://codereview.chromium.org/2730002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49553 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(Found by clang.)
Review URL: http://codereview.chromium.org/2725010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49466 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
by people who use the gallery, and making sure that people
know about the gallery.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2655006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2690001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=41571
TEST=Try loading chrome/test/data/extensions/bad/bad_encoding extension. You should get error message about wrong encoding.
Review URL: http://codereview.chromium.org/2260006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=mpcomplete
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2555003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=aa
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2516001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48783 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some generated files changed (cookies, extension, history),
but those seem to be random reordering by the API generator.
TBR=aa
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2498002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
features to work on, but it's in a usable state.
When an extension is installed that specifies an omnibox keyword in its manifest, we add that keyword to the user's list of Search Engines. The user can then edit this keyword later.
I'm leveraging most of the original search engine keyword code. An extension keyword has a special URL that identifies it as an extension keyword. There is some special case code to treat these keywords slightly differently throughout
the omnibox code.
BUG=38884
Review URL: http://codereview.chromium.org/2078021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48503 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2127015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
windows
BUG=22651
TEST=NONE
Review URL: http://codereview.chromium.org/2173003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I reverted http://codereview.chromium.org/1986006 as part of that change, after talking with Ben and Aaron. (it breaks the UI tests on ChromeOS now that apps are enabled).
Disabling app launcher and enabling apps by default on ChromeOS .
BUG=3218
TEST=Open the new tab, the new new tab should be shown. Any installed
app should be showing in there.
Review URL: http://codereview.chromium.org/2149003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Disabling app launcher and enabling apps by default on ChromeOS .
BUG=3218
TEST=Open the new tab, the new new tab should be shown. Any installed
app should be showing in there.
Review URL: http://codereview.chromium.org/2135011
TBR=jcivelli@chromium.org
Review URL: http://codereview.chromium.org/2077020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=3218
TEST=Open the new tab, the new new tab should be shown. Any installed
app should be showing in there.
Review URL: http://codereview.chromium.org/2135011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Wrap title with correctly bidi control characters in windows for display purpose.
BUG=43485
TEST=1. open RTL chrome.
2. install Google dictionary extension.
3. extension title "Google Dictionary (by Google)" should be displayed as is in chrome://extensions page,
4. right click the extension icon, title "Google Dictionary (by Google)" should be displayed in extension context menu,
5. extension title should be displayed correctly in other places, such as task manager, etc.
Review URL: http://codereview.chromium.org/2015004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
documented icons sizes.
BUG=42992
Review URL: http://codereview.chromium.org/2073016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47862 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes minor point about topmost vs last active window in discussion of "current window"
TBR=kathyw
BUG=28055
Review URL: http://codereview.chromium.org/2114013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
version. This is useful during development, for switching
themes, and for user scripts (since user scripts have no
development mode).
Since we can't always immediately delete the version directory
for an extension after unloading it (because some files might
be in use), this required changing the directory layout of the
extensions directory to allow multiple copies of the same
version of the same extension to be present at once. This was
done by adding a counter to the version directory name.
Also get rid of all the old "Current Version" cruft, since we
no longer use that.
BUG=26538
Review URL: http://codereview.chromium.org/1521039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=aa
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2081011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2127008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47614 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
handler.
BUG=38398
TEST=none
Review URL: http://codereview.chromium.org/841006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
bit, FILTER_EXTENSION_MESSAGES, into a bool that's only passed to places that really need it.
Also renames ExtensionMessageFilterPeer to ExtensionLocalizationPeer in hopes of making its one use more apparent. I added a couple comments too.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2105006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47533 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Updated analytics tutorial with new tracking code as well as more information about debugging requests.
TEST=None
BUG=None
Review URL: http://codereview.chromium.org/1880001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47353 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=aa
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2095003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=aa
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2078007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=rafaelw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
enough for anyone's shortcut flags!"
Review URL: http://codereview.chromium.org/1991009
TBR=aa@chromium.org
Review URL: http://codereview.chromium.org/2010013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47081 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
anyone's shortcut flags!"
Review URL: http://codereview.chromium.org/1991009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47079 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=39505
TEST=Should be able to add a bunch of context menu items and then change or
remove them using update and removeAll respectively.
Review URL: http://codereview.chromium.org/1736028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47060 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is a duplicate of http://codereview.chromium.org/2027006 which was accidentally created in a read-only client.
BUG=None
TEST=ExtensionApiTest.Popup
Review URL: http://codereview.chromium.org/2003016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=if it compiles, it is perfect
BUG=none
Review URL: http://codereview.chromium.org/2001007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
experimental.extension.popup(...) windows.
Patch 1 contains twiz@'s code reviewed implementation from http://codereview.chromium.org/1512007.
This CL is to address the failure of release tests.
BUG=None
TEST=ExtensionApiTest.Popup
Review URL: http://codereview.chromium.org/1921003
TBR=ericdingle@google.com
Review URL: http://codereview.chromium.org/2036002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Patch 1 contains twiz@'s code reviewed implementation from http://codereview.chromium.org/1512007.
This CL is to address the failure of release tests.
BUG=None
TEST=ExtensionApiTest.Popup
Review URL: http://codereview.chromium.org/1921003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46592 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch adds a new RVH container: BackgroundContents. The idea is that apps can open a live web-page as a "background" page using window.open('<url>', '<name>', 'background');
If 'background' is specified and the opener is within the app's extent, a BackgroundContents will be used. Otherwise, the 'background' feature is ignored and it is treated as a regular popup call.
Note that as of this patch the following are explicitly not-yet addressed:
1) Session storage for BackgroundContents
2) SSL (or other failures) requiring UI
3) Javascript messages (alert, etc...)
4) Session restore
TEST=All tests should pass
BUG=41275
Review URL: http://codereview.chromium.org/1734014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46544 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
popup API. "
This reverts http://codereview.chromium.org/1512007
TBR=twiz
Review URL: http://codereview.chromium.org/1735026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46184 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- It was previously possible to programmatically launch two popups from the same extension. (Simply call popup.show twice in a row, or in a callback chain.)
I removed this incorrect funcationality by registering ExtensionPopupHost to listen for EXTENSION_HOST_CREATED notifications. If a popup is shown, and a new ExtensionHost is constructed of type EXTENSION_POPUP, then the presently displayed popup is dismissed.
- The callback function for popup.show(...) was previously called in response to EXTENSION_POPUP_VIEW_READY, as processed in response to a ViewHostMsg_DocumentAvailableInMainFrame message. This message wassent after PARSING of the conent of the popup view. Because of this behaviour, the API was difficult to use because one could not meaningfully interact with the popup page
during the callback: The callback would race with completion of the onload handler within the popup, so some sort of polling for onload-complete was required.
I fixed the problem by adding new notifications and messages so that EXTENSION_POPUP_VIEW_READY is now sent only after all onload handlers have been invoked.Corresponding unit-tests have also been added.
BUG=None
TEST=ExtensionApiTest.Popup
Review URL: http://codereview.chromium.org/1512007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Other users of the temp directory will be altered in a subsequent CL.
BUG=13044
TEST=SandboxedExtensionUnpackerTest.*, ScopedTempDir.UniqueTempDirUnderPath, FileUtilTest.CreateNewTempDirInDirTest, manual testing on win, linux, mac.
Review URL: http://codereview.chromium.org/1582022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=rafaelw
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1783012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45999 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
and extension_error_reporter to browser, so that the UIs surrounding them can be in the browser.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1705009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=skerner
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1812004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45943 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implement shared resources and use them in bookmark manager
I had an issue with git when moving files so i had to create a new patch to
delete/readd them here. See code review 1564034. This is just for
trybots/checkins.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1694019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=42447
TEST=none
Review URL: http://codereview.chromium.org/1730013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45862 0039d316-1c4b-4281-b951-d872f2087c98
|