| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=57753
TEST=none
Review URL: http://codereview.chromium.org/4498003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fire tabs.onUpdated event if a tab's pinned state changes.
BUG=24781
TEST=ExtensionApiTest
Review URL: http://codereview.chromium.org/3816005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65379 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
benchmarks extension."
This reverts commit fbf3155bc7b82cbf56c9e6bdbd806a81daf2f2ce.
Also update docs.
BUG=61650
TEST=Successfully ran build.py
Review URL: http://codereview.chromium.org/4421001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
ImageCache remains on Extension, on the expectation that it will eventually be
loaded at startup.
BUG=56558
TEST=no functional change
Review URL: http://codereview.chromium.org/4132005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64973 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4146012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64919 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in pure HTML into the extension-based web apps used internally
by Chrome.
BUG=49233
TEST=unit_tests --gtest_filter=ExtensionFromWebApp.*
Review URL: http://codereview.chromium.org/4139008
TBR=aa@chromium.org
Review URL: http://codereview.chromium.org/4326002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
in pure HTML into the extension-based web apps used internally
by Chrome.
BUG=49233
TEST=unit_tests --gtest_filter=ExtensionFromWebApp.*
Review URL: http://codereview.chromium.org/4139008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These files should be part of http://codereview.chromium.org/4123001/,
but were missed during the original patch.
Contributed by Jianxia Ning <jning@google.com>.
BUG=none
TEST=none
TBR=lzheng@chromium.org
Review URL: http://codereview.chromium.org/4349001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64828 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Extension::StaticData and put"
Original CL:
Part 4/4 of immutable Extension refactor: Kill Extension::StaticData and put
its guts into Extension.
BUG=56558
TEST=no functional change
Review URL: http://codereview.chromium.org/4200005
Review URL: http://codereview.chromium.org/4277002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Extension::StaticData and put"
Original CL:
Part 4/4 of immutable Extension refactor: Kill Extension::StaticData and put
its guts into Extension.
BUG=56558
TEST=no functional change
Review URL: http://codereview.chromium.org/4200005
TBR=nirnimesh
Review URL: http://codereview.chromium.org/4274001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
its guts into Extension.
BUG=56558
TEST=no functional change
Review URL: http://codereview.chromium.org/4200005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64676 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This CL was created automatically by this clang rewriter: http://codereview.appspot.com/2776043/ . I manually fixed a few rough spots of the rewriter output (doh1-3) and fixed all presubmit errors.
BUG=28083
TEST=None
Review URL: http://codereview.chromium.org/4192012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(Note: This is a TODO in string_util.h)
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/4111011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64567 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make ExtensionsService hold const Extension pointers only. This ensures that
extensions can't be modified after they're created, and lets us share them
between threads.
BUG=56558
TEST=no functional change
Review URL: http://codereview.chromium.org/4138006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These files should be part of http://codereview.chromium.org/4123001/,
but were missed during the original patch.
Contributed by Jianxia Ning <jning@google.com>.
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64493 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Adds a new "toggle" sprite to the documentation images.
* Adds CSS classes for the toggles.
* Includes "sidebar.js" for documentation pages which implements the toggles in JavaScript.
BUG=49239
TEST=None
Review URL: http://codereview.chromium.org/4005003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
by PhistucK. (I tested the code this time, to make sure it
was correct.)
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4184009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64449 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=erikkay
Review URL: http://codereview.chromium.org/4211002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4189006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
2. Throws an error in port.postMessage if the port has already been disconnected.
3. Sets lastError when tabs.sendRequest can't connect to the tab.
BUG=27565, 32899
TEST=ExtensionApiTest
Review URL: http://codereview.chromium.org/3676008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64277 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
docs build script.
* Refactors the zip generation to its own step in build.py
* Add a command line flag (--no-zips) to build.py that can disable zip generation.
* Tweaks the command line flags of build.py (adds better help content).
* Changes sample manifest generation so zip_path is still written even if zips are not.
BUG=61025
TEST=Pass --nozip to build.py to skip zip generation.
Review URL: http://codereview.chromium.org/4185006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64266 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
-Add the option to clear selected data sets.
-Add the option to sort the result table according to the chosen metric.
-Move "load from file" button to the same line of Url text box.
-Highlight the tested page to trigger the paint event.
-Include third party libraries table2CSV.js and sorttable.js in util folder.
-Remove some redundant scripts from jquery folder.
-Prune sorttable.js to remove some browser specific code.
Contributed by Jianxia Ning <jning@google.com>.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4123001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
suggested by PhistucK, plus did a bit of cleanup here and there.
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/4201003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to the manifest page.
BUG=60609
TEST=none
Review URL: http://codereview.chromium.org/4184002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64162 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
other edits I'd made. Strangely, the content_scripts.html and crx.html
fixes cause no corresponding changes in the generated files.
(It seems like HTML correction that seems to happen automatically
when docs are generated changed somehow.)
TBR=kurrik
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4188002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64159 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Last landing broke chromeos and chromium linux builder.)
I made Extension a refcounted object, and privitized the existing
con/destructor and InitFromValue. The only way to get an Extension is to call
a factory method.
In the next CL, I plan to make the factory method return a const Extension,
to guarantee that no one can modify the Extension object after creation.
Note: There was a tricky part of this CL because of the difference in
semantics between scoped_ptr and scoped_refptr. I had to be careful not to use
ptr.release(), since that would result in leaks (an un-Released AddRef).
BUG=56558
TEST=no functional change
Original Review URL: http://codereview.chromium.org/3982001
TBR=aa
Review URL: http://codereview.chromium.org/4119010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
always gets called. Support queueing utterances. Add new extension api tests
to test this logic with mocks.
BUG=none
TEST=Adds new browser tests.
Review URL: http://codereview.chromium.org/3999004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
applicable bug upstream.
TBR=evan@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
changes, since there are lots of spurious ones, but this one seems legit.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4169003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=kurrik
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/4090004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"Part 2 of immutable Extension refactor."
I made Extension a refcounted object, and privitized the existing
con/destructor and InitFromValue. The only way to get an Extension is to call
a factory method.
In the next CL, I plan to make the factory method return a const Extension,
to guarantee that no one can modify the Extension object after creation.
Note: There was a tricky part of this CL because of the difference in
semantics between scoped_ptr and scoped_refptr. I had to be careful not to use
ptr.release(), since that would result in leaks (an un-Released AddRef).
BUG=56558
TEST=no functional change
Original Review URL: http://codereview.chromium.org/3982001
TBR=aa
Review URL: http://codereview.chromium.org/4186002
TBR=mpcomplete@chromium.org
Review URL: http://codereview.chromium.org/4130004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63976 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/4198002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I made Extension a refcounted object, and privitized the existing
con/destructor and InitFromValue. The only way to get an Extension is to call
a factory method.
In the next CL, I plan to make the factory method return a const Extension,
to guarantee that no one can modify the Extension object after creation.
Note: There was a tricky part of this CL because of the difference in
semantics between scoped_ptr and scoped_refptr. I had to be careful not to use
ptr.release(), since that would result in leaks (an un-Released AddRef).
BUG=56558
TEST=no functional change
Original Review URL: http://codereview.chromium.org/3982001
TBR=aa
Review URL: http://codereview.chromium.org/4186002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Compile failure on Linux x64.
BUG=56558
TEST=no functional change
TBR=aa
Review URL: http://codereview.chromium.org/4156002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I made Extension a refcounted object, and privitized the existing
con/destructor and InitFromValue. The only way to get an Extension is to call
a factory method.
In the next CL, I plan to make the factory method return a const Extension,
to guarantee that no one can modify the Extension object after creation.
Note: There was a tricky part of this CL because of the difference in
semantics between scoped_ptr and scoped_refptr. I had to be careful not to use
ptr.release(), since that would result in leaks (an un-Released AddRef).
BUG=56558
TEST=no functional change
Review URL: http://codereview.chromium.org/3982001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63919 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=evan@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
CID=12543,12544,12758,12878,12879,12918,13252,13285,13301,13391
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4040003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63910 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also, a regression had been introduced in earlier changes. Added explicit error codes to Parse(), and removed default constructor, to avoid making the same mistake again.
BUG=49969
TEST=n/a
Review URL: http://codereview.chromium.org/3978007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63836 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=60617
TEST=tools/heapcheck/chrome_tests.sh -t unit
Review URL: http://codereview.chromium.org/4115001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63802 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
show up in the result table. This is introduced by the change of refreshing the table after every run.
Change the metrics ReadKB, WriteKB, Readkbps and etc. as array storing the value of each run. Only avg is saved in original version. Move the calculation of bytes -> Kbytes and bps ahead.
Add a metric timestamp.
Add the function of comparing a selected metric of two selected data sets, in chart.
The flot JS library (the entire jquery folder) is included for plotting.
Contributed by Jianxia Ning <jning@google.com>.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3928001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=28907
TEST=Added homepage_url to manifest, check that it replaces gallery URL link.
Review URL: http://codereview.chromium.org/3767013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Extensions that are silent-installed by an admin policy will have EXTERNAL_POLICY_DOWNLOAD set as their locations. It will not be possible to uninstall them and they will be silently updated.
BUG=59782
TEST=none
Review URL: http://codereview.chromium.org/3938005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63718 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Mark functions in file_util_posix as requiring permission to perform
disk actions.
- Mark the IO thread as disallowed from performing disk actions.
- Temporarily work around the protections in places where we currently
have bugs.
BUG=59847,59849,60207,60211,60394
TEST=no dchecks in debug builds
Review URL: http://codereview.chromium.org/3872002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
from doing IO
Reverting because this breaks the ChromiumOS (dbg) builder.
- Mark functions in file_util_posix as requiring permission to perform
disk actions.
- Mark the IO thread as disallowed from performing disk actions.
- Temporarily work around the protections in places where we currently
have bugs.
BUG=59847,59849,60207,60211
TEST=no dchecks in debug builds
Review URL: http://codereview.chromium.org/3872002
TBR=evan@chromium.org
Review URL: http://codereview.chromium.org/3983005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4071004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63614 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Mark functions in file_util_posix as requiring permission to perform
disk actions.
- Mark the IO thread as disallowed from performing disk actions.
- Temporarily work around the protections in places where we currently
have bugs.
BUG=59847,59849,60207,60211
TEST=no dchecks in debug builds
Review URL: http://codereview.chromium.org/3872002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
This reverts commit r63580, build breakage.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63586 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Mark functions in file_util_posix as requiring permission to perform
disk actions.
- Mark the IO thread as disallowed from performing disk actions.
- Temporarily work around the protections in places where we currently
have bugs.
BUG=59847,59849,60207,60211
TEST=no dchecks in debug builds
Review URL: http://codereview.chromium.org/3872002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63580 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
to use StringToInt. These usages now pass the iterators directly to the new StringToInt overloads.
BUG=None
TEST=All
Review URL: http://codereview.chromium.org/3968001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63515 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also removes LOG_RESOURCE_REQUESTS and all associated code.
Also remove some "using"s, fix non-const ref (style violation), remove some "else" after "return", and remove some extra {}s.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3941001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63462 0039d316-1c4b-4281-b951-d872f2087c98
|