| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This contains fixes for the following sorts of issues:
* Signedness mismatch
* Assignment inside conditional
* Constant value was truncated
* Possibly-uninitialized local variable
BUG=81439
TEST=none
Review URL: https://codereview.chromium.org/377683002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283305 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
methods.
BUG=381601
TEST=None
R=oshima
TBR=sky
Review URL: https://codereview.chromium.org/344733005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
First stop to fix favicon for fractional scale factor.
I'll convert the rest of ui::ScaleFactor in 38
BUG=376367,381601
R=pkotwicz@chromium.org, sky@chromium.org
Review URL: https://codereview.chromium.org/335233003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
First step for renaming ui::ScaleFactor to ui::ResourceScaleFactor
BUG=372212
R=pkotwicz@chromium.org, sky@chromium.org
Review URL: https://codereview.chromium.org/291733004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The move caused includes, DEPS, and gyp to change.
This CL also adds droger as a temporary owner to the favicon and favicon_base components.
Reasoning behind the creation of a favicon_base component:
Bookmarks and History code do not fundamentally depend on the Favicon code, so we should be able to build those components without building the Favicon code.
Deep inside the Bookmarks and History code base there's usage of certain favicon types. Those typedefs are moved to a separate component to break the dependency between the Bookmark/History components and the Favicon component.
BUG=362481
Review URL: https://codereview.chromium.org/234893002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264555 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=353954
R=thakis@chromium.org
TBR=vrk
Review URL: https://codereview.chromium.org/203193012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=299841
TEST=ui_unittests, no behavior changes.
R=ben@chromium.org
Review URL: https://codereview.chromium.org/26171003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228582 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Original CL: https://codereview.chromium.org/15388002/
BUG=227087
Review URL: https://chromiumcodereview.appspot.com/5805043437535232
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212088 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This failed the "sizes" bot because it added static initializers in favicon_url_parser.cc
> Preparation for supporting high dpi favicons in Instant Extended.
>
> The logic in FaviconSource::ParsePath() has been moved from chrome/browser/ui/* to chrome/common/favicon* allowing it to be used from the renderer. Also, chrome/browser/favicon/favicon_types.h to chrome/common/favicon/favicon_types.h for the same reason.
>
> Related internal CL: cl/46805180
>
> To test this CL:
> 1) git cl patch 15388002
> 2) ./build/gyp_chromium
> 2) compile chrome
> 3) run chrome with --enable-instant-extended-api
>
>
> BUG=227087
>
> Review URL: https://chromiumcodereview.appspot.com/15388002
TBR=pedrosimonetti@chromium.org
Review URL: https://codereview.chromium.org/18337015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
The logic in FaviconSource::ParsePath() has been moved from chrome/browser/ui/* to chrome/common/favicon* allowing it to be used from the renderer. Also, chrome/browser/favicon/favicon_types.h to chrome/common/favicon/favicon_types.h for the same reason.
Related internal CL: cl/46805180
To test this CL:
1) git cl patch 15388002
2) ./build/gyp_chromium
2) compile chrome
3) run chrome with --enable-instant-extended-api
BUG=227087
Review URL: https://chromiumcodereview.appspot.com/15388002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211085 0039d316-1c4b-4281-b951-d872f2087c98
|