| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Doesn't occur on the trybots; failing only on main waterfall:
312> Creating library C:\b\slave\chromium-rel-builder\build\src\build\Release\lib\nacl64_exe.lib and object C:\b\slave\chromium-rel-builder\build\src\build\Release\lib\nacl64_exe.exp
312>installer_util_nacl_win64.lib(master_preferences_dummy.obj) : error LNK2019: unresolved external symbol "public: __cdecl GURL::~GURL(void)" (??1GURL@@QEAA@XZ) referenced in function "public: void * __cdecl GURL::`scalar deleting destructor'(unsigned int)" (??_GGURL@@QEAAPEAXI@Z)
312>C:\b\slave\chromium-rel-builder\build\src\build\Release\nacl64.exe : fatal error LNK1120: 1 unresolved externals
This reverts commit 8aee3906174e920e22ca070df0e951af853462b8 (r63764).
TBR=leiz@
Review URL: http://codereview.chromium.org/4097001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63775 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/4001005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
protocol is already getting registered by url_util.cc super early in the
process, so this extra registration is redundant. Re-adding the protocol later
apparently modifies the set that url_util uses, and when this happens there
could be other threads reading it.
BUG=41150
TEST=none
Review URL: http://codereview.chromium.org/1545029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
Supply a dummy implementation of url_util::AddStandardScheme that will allow
us to link a 64-bit library on an otherwise 32-bit OS. We don't otherwise need
googleurl (or else it wouldn't link for other reasons) so we're guaranteed not
calling AddStandardScheme is OK.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/668222
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40822 0039d316-1c4b-4281-b951-d872f2087c98
|