| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
This change introduces one more dependency on chrome/browser,
but it seems simpler to move gtk_util first and then fix it.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/661271
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=35178,36183
TEST=none
Review URL: http://codereview.chromium.org/652172
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/657065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
options dialog.
The "Exceptions" dialogs are still not implemented; they're the next step but
this changelist is already getting pretty huge.
BUG=35178
TEST=none
Review URL: http://codereview.chromium.org/602005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=34416
TEST=right, middle, and left click on bookmark bar folder all do what they should
Review URL: http://codereview.chromium.org/576008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Prevent moving options dialog out of monitor boundaries.
BUG=1143
TEST=Tested on Linux with multiple desktops.
Review URL: http://codereview.chromium.org/555151
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/562019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
r36138 might have caused a 5-20ms startup perf regression
on linux-release-hardy. Revert to see if the startup
time shows any improvement.
BUG=22614
TEST=watch the linux-release-hardy startup test for
~5 runs
Review URL: http://codereview.chromium.org/555053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/551065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36547 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/551034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36402 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(Plus some gdk_cairo_rectangle() cleanups)
BUG=26255
TEST=none
Review URL: http://codereview.chromium.org/542084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36313 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
font that will trigger the jumping around bug.
BUG=22614
TEST=none
Review URL: http://codereview.chromium.org/542041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
GTK dialogs size to their contents, but sometimes the title is the
longest string available.
BUG=28024
Review URL: http://codereview.chromium.org/534006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
RenderPreferences on theme change.
BUG=10949
TEST=none
Review URL: http://codereview.chromium.org/525016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
utility function to allow other labels to do the same.
BUG=29797
TEST=Open the content options page, and check that the labels wrap at the width of the page.
Review URL: http://codereview.chromium.org/500026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34745 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
---------------
linux: theme scrollbars from GTK theme
Pick the color of the slider's thumbpart and rail from the GTK theme.
We cannot match the exact visual appearance of the GTK theme, as
rendering engines can make arbitrary changes to the actual visual
appearance. But by sampling a representative set of pixels, we ensure
that we will at least match the general color scheme.
BUG=10949
patch by <markus [at] chromium>
original review: http://codereview.chromium.org/400027/show
Review URL: http://codereview.chromium.org/479006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34285 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The changes are propagated across open chrome windows, but are not persisted between sessions yet.
BUG=26990
Review URL: http://codereview.chromium.org/463056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34272 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
tbr=asargent
Review URL: http://codereview.chromium.org/482002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Pick the color of the slider's thumbpart and rail from the GTK theme.
We cannot match the exact visual appearance of the GTK theme, as
rendering engines can make arbitrary changes to the actual visual
appearance. But by sampling a representative set of pixels, we ensure
that we will at least match the general color scheme.
BUG=10949
patch by <markus [at] chromium>
original review: http://codereview.chromium.org/400027/show
Review URL: http://codereview.chromium.org/466080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the user right clicks on the maximize button, it will horizontally maximize the window, and if the user middle clicks on the maximize button it will vertically maximize the window.
At least on kde, the window manager supports more complicated behavior, e.g. right clicking on a window that is horizontally maximized will return it to its former size. It seems to keep track of multiple restored rects. However, we're not well equipped to replicate this behavior, so I just didn't add it. If the user wants it, they can disable the custom frame.
BUG=28881
Review URL: http://codereview.chromium.org/455012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=28707
Review URL: http://codereview.chromium.org/456003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
window manager bug. While we're at it, change dialog's default size to match that of Chrome on Windows.
BUG=28230
TEST=see bug
Review URL: http://codereview.chromium.org/425016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I misunderstood how allocations work in the original
version and wasn't handling the case where there are
intermediate GdkWindows between the target widget and
its toplevel window correctly.
TEST=first-run, bookmark, and browser action bubbles get opened in the correct places under xmonad, metacity, and ion3
BUG=23373
Review URL: http://codereview.chromium.org/326017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
toplevel window.
BUG=19082 "Linux: Omnibox auto-complete popup is on top of IME candidate window when using SCIM"
TEST=Please refer to the bug report for how to test.
Review URL: http://codereview.chromium.org/274046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=strace chrome. Moving the mouse over the webpage shouldn't spew open() calls.
BUG=21623
Review URL: http://codereview.chromium.org/195071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This only works for GTK 2.16+.
BUG=21495
Review URL: http://codereview.chromium.org/199099
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26043 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=19622
TEST=none
Review URL: http://codereview.chromium.org/180031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
all the time.
Review URL: http://codereview.chromium.org/174586
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24576 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
In addition, only draw the dirty rectangle area when manually drawing a gtk entry.
http://crbug.com/17962
Review URL: http://codereview.chromium.org/174577
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24558 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://www.google.com/codesearch/p?hl=en&sa=N&cd=2&ct=rc#eSCqYNcHl48/gtk%2B-2.4.10/gdk/gdkevents.c&q=gdk_event_get_time
Review URL: http://codereview.chromium.org/164429
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Also uses the new consistent border color in GTK theme mode.
Review URL: http://codereview.chromium.org/165356
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23189 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TabContentsDragHandler so that it can be used by both Gtk and Views.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/165302
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23168 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=18483
TESTED=restarted and visited a page with a broken SSL cert a few times while changing font settings via gnome-appearance-properties
Review URL: http://codereview.chromium.org/164094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22679 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
I'm not especially happy with how it looks now, though I think it's
better than before.
Review URL: http://codereview.chromium.org/160661
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Labels in LocationBarViewGtk should be black even when a dark GTK theme is used
when we're not in GTK theme mode. Likewise, when we're using a GTK theme, we
should have the background and border color of the "Search X for:" box use
colors from the theme instead of having hard coded ones.
Review URL: http://codereview.chromium.org/159798
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22293 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To be clear, this only adds button images from stock images, and doesn't change the text of the buttons. I chose APPLY for dialogs that involve checkboxes. I chose OK for dialogs without checkboxes.
also
- switched the position of the OK/Cancel buttons on the import lock dialog.
- changed the first run dialog CANCEL button to QUIT, because CANCEL is really confusing in that situation (this is a problem on windows as well).
I couldn't find any other dialogs that are missing button images, but if you see some call em out.
BUG=none
TEST=look at all the pretty images.
Review URL: http://codereview.chromium.org/160493
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
gtk_util/gtk_tree_util.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/160417
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/160371
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22036 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/16783
Review URL: http://codereview.chromium.org/160025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21535 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16951
TEST=launch bookmark manager on gnome/metacity, observe that window has icon
Review URL: http://codereview.chromium.org/155672
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/149695
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- improve spacing and and sizing, both internally and externally (using windows as the guide)
- make legible for dark themes
- make show delay longer because it was too short on my machine (at least when using a Debug build).
Also explicitly set bookmark bubble labels black.
BUG=16782
TEST=none
Review URL: http://codereview.chromium.org/149664
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/149501
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
looking for the top-left origin of the tab strip in screen coordinates, but we sent in the coordinates of this point relative to the entire window to gtk_util::ConvertWidgetPointToScreen.
BUG=15867
TEST=Open enough tabs so that they must be resized. Repeatedly press the mouse over a close button so that many tabs are closed. The tabs should not resize until the mouse leaves the tab strip.
Review URL: http://codereview.chromium.org/155308
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Originally I had split it into multiple files, but I think it's
cleaner to just use one.
(I want to use this for measuring plugin jank.)
BUG=8077
Review URL: http://codereview.chromium.org/155194
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and display LTR for RTL locales.
r19162 | jhawkins@chromium.org | 2009-06-24 13:15:04 -0700 (Wed, 24 Jun 2009) | 5 lines
Add support for RTL languages in the gtk toolbar layout.
BUG=none
TEST=Open a browser window in a RTL language (--lang=he). The toolbar layout should correctly be in RTL layout.
Review URL: http://codereview.chromium.org/147102
r19179 | jhawkins@chromium.org | 2009-06-24 14:38:25 -0700 (Wed, 24 Jun 2009) | 5 lines
Add support for RTL languages in the gtk bookmark bar.
BUG=none
TEST=Open a browser window in a RTL language (--lang=he). The bookmark bar layout should correctly be in RTL layout.
Review URL: http://codereview.chromium.org/146105
See http://i139.photobucket.com/albums/q315/failfast/revertrtl.png
Review URL: http://codereview.chromium.org/147130
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Open a browser window in a RTL language (--lang=he). The bookmark bar layout should correctly be in RTL layout.
Review URL: http://codereview.chromium.org/146105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/15100
TEST=do it
Review URL: http://codereview.chromium.org/146062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19101 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Open the browser with --lang=he and make sure the tabs are ordered starting from the right. Also, the UI elements in the tabs should be reversed as well.
Review URL: http://codereview.chromium.org/147020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19051 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
_NET_CLIENT_LIST_STACKING.
BUG=14004
TEST=Drag tabs in and out of tabstrip in xmonad window manager.
Review URL: http://codereview.chromium.org/141061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18949 0039d316-1c4b-4281-b951-d872f2087c98
|