| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/283016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
It induced a leak detected by valgrind, so I'll revert, and look more
closely when I'm in on Monday.
TBR=raman
Review URL: http://codereview.chromium.org/268033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28694 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We're currently losing histogram data gathered in the renderer when
we shut down the renderer. We were only gathering it for UMA about every
20 minutes, and also getting an update when the user visits about:histograms.
This change causes the render to push a final update to the browser
when the renderer is about to terminate.
This is almost exactly CL 160153
http://codereview.chromium.org/160153/show
being landed for Raman Tenneti.
Per discussion with Darin, I ended up moving the renderer call to send the
histograms to the next function, which allows it to be called later (often
after the running of the on-unload handler, potentially gathering a bit
more data).
bug=16495
r=ramanTenneti
Review URL: http://codereview.chromium.org/258017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
DISALLOW_EVIL_CONSTRUCTORS in a bunch of files.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/173538
Patch from Thiago Farina <thiago.farina@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24774 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
correct, and it was badly named and needed fixing anyway.
This patch just removes it. There were a few debugging places that used it
which I just removed, since I think they're old and haven't been useful lately.
The non-trivial changes were in the histogram code, it now counts them slightly
differently.
Review URL: http://codereview.chromium.org/171051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
This replaces the current time based approach (chrome is given N seconds
to upload all renederer histograms) with an asynch callback approach
that waits until all renderers have responded (with their updates). It
uses a fall-back timer to ensure that a hung renderer won't delay things
forever as well.
This causes faster (and complete) updates in about:histograms as well
as generally assuring complete updates during UMA gatherings.
This code was contributed by Raman Tenneti in CL 42496
http://codereview.chromium.org/42496
bug=12850
r=raman
Review URL: http://codereview.chromium.org/113473
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17123 0039d316-1c4b-4281-b951-d872f2087c98
|