| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
Add IsLocaleSupportedByOS to l10n_util_{win,posix}.cc. Posix version always returns true. Windows blocks Oriya on Windows XP.
BUG=7325
TEST=1. L10n*.GetAppLocale
2. On Win XP, Oriya should not be shown in the UI language switch menu while it should be shown elsewhere.
Review URL: http://codereview.chromium.org/45054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12557 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/8997
Previously, the path itself and every single path component are marked with LTR marks.
The fix is only mark the path as a whole (but not every single path component)with LTR marks.
Review URL: http://codereview.chromium.org/49034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12539 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
in turn calls uscript_getCode() to get the script code and compare it against
Hebrew and Arabic scripts (as opposed to languages).
TEST=L10n*.GetTextDirection
Review URL: http://codereview.chromium.org/40125
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Also, don't alphabetize available spellchecker locale codes.
Review URL: http://codereview.chromium.org/42531
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Fix files with lines > 80 cols. Part 2.
Review URL: http://codereview.chromium.org/40226
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
corresponding .lproj folder so we can more easily find them. The nibs have not yet been moved, that'll be a further step.
Review URL: http://codereview.chromium.org/28259
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10609 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
While I'm at it, remove references to .dll in comments in the file.
Review URL: http://codereview.chromium.org/27223
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/28127
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- compile resource_bundle
- add resource_bundle_mac by cloning the linux and using some NSBundle to find
the files.
- enable resource bundles on the mac in the calling code.
- added script to app target to repack .pak files into larger chunks (chrome,
theme, and localized bits).
- added script to copy repacked files into the app bundle.
Review URL: http://codereview.chromium.org/28171
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10460 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/27103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10307 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
each that returns a string. The strings are then compared using a
collator, or operator < if no collator is found.
I'm going to use this for sorting bookmarks.
BUG=1750
TEST=none yet
Review URL: http://codereview.chromium.org/20484
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ups.
(http://crbug.com/6099)
Currently, in RTL locales, a pure *multi-line* English message is displayed as right aligned and has RTL directionality (such as the ending punctuation appears at the very left).
Single-line message works fine.
I do not know why, but simply putting LRE-PDF around a multi-line English text which has the following flags
DT_WORDBREAK | DT_RTLREADING
wont render the English message as LTR.
We have to remove the DT_RTLREADING to render multi-line English message correctly in LTR direction.
The fix is that in RTL locales, for JavaScript message, if the message is pure English, the alignment is set to be left-aligned, and the directionality is set to be left-to-right. If the message is mixed BiDi text, the alignment and the directionality is determined by the directionality of the first character with strong directionality in the text.
JavaScript message is a MessageBoxView, and the message is a view::Label. Both MessageBoxView and Label are used by Chrome's UI as well.
If the message is one of Chrome UI's, the alignment and directionality of the message should be taken from that of the UI's.
In order to distinguish where the message comes from, a new flag kFlagWebMessage is introduced in MessageBoxView, and a new argument is introduced in Label::SetHorizontalAlignment() to control whether the alignment need to be flipped or not for RTL locales.
Consequently, quite a few files which calls Label::SetHorizontalAlignment() are changed.
The main changes are in 5 areas. Other files are changed due to the signature change of Label::SetHorizontalAlignment().
1. jsmessage_box_handler.cc: pass in extra flag kFlagWebPage when creating MessageBoxView to indicate the message box is one from a web page, not from Chrome UI.
2. l10n_util.h/.cc
added function GetFirstStrongDirection()
3. label.h/.cc
a new argument is introduced in Label::SetHorizontalAlignment() to control whether the alignment need to be flipped or not for RTL locales.
4. message_box_view.cc
when init message box view, if the flag is kFlagWebPage, get the text directionality from the text itself (not Chrome UI's) and calls Label::SetHorizontalAlignment() to not resetting the flag for RTL locales.
5. chrome_canvas_win.cc
5.1 ComputeFormatFlags()
only set flag DT_RTLREADING for RTL locales if the text contains strong RTL characters and the alignment is RIGHT aligned. All labels of Chrome's UI and other Chrome UI components in RTL locales have been set as (or flipped to) RIGHT aligned.
5.2 DoDrawText()
Only adjust string for locale is the reading direction is DT_RTLREADING.
Review URL: http://codereview.chromium.org/18863
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10178 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1.7324 -- RTL: Path contains Hebrew is wrong on "Download location" text box
(http://crbug.com/7324)
2. 7326 -- RTL: Folder icon missing on "Download location" text box
(http://crbug.com/7326)
The fix are:
1. force path to have LTR directionality.
2. draw icon in mirrored position in RTL locales.
Steps for test:
1. Create a folder with a Hebrew file name on Hebrew XP
2. Change the download location to the folder created in step 1
3. Observe the path displayed on "Google Chrome Options" --> "Minor Tweaks" --> "Download location" text box
Without the fix:
The path contains Hebrew folder name is wrong. It displayed as "cCBA\:" while the path is "c:\CBA" where "CBA" is a Hebrew folder name.
And there is no folder icon in the "download location" text box.
With the fix:
The path displayed correctly as "c:\CBA" or "c:\CBA\FED" where "FED" is subfolder of "CBA".
And the folder icon showed at the very right.
Review URL: http://codereview.chromium.org/20038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10121 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
except the UTF-8 encoding and the recently selectd encodings.
For details, see Fix bug http://code.google.com/p/chromium/issues/detail?id=7647
BUG=7647
Review URL: http://codereview.chromium.org/21414
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the resource bundle on linux unittests and make the unit_tests
executable require the various .pak files.
Review URL: http://codereview.chromium.org/20471
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit r9972.
TBR=evan
Review URL: http://codereview.chromium.org/21478
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21465
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21323
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20171
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19757
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9055 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
current process's command line.
One explicit goal of this change is to *not* deal with the string/wstring issues at the API on POSIX; the functions are the same as before, which means they remain as broken as before. (I did try to fix the internals, though, so migrating the callers is now possible by adding platform-appropriate hooks.)
Review URL: http://codereview.chromium.org/18248
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(http://crbug.com/6093).
The directionality of gears button is already fixed.
This CL fixes the wrong location of ":".
It adds RLM at the end of string "Google Gears:" for Hebrew and Arabic Chrome,
so that the ":" in "Google Gears:" in Hebrew is displayed leftmost instead of
rightmost.
Test:
1) open chrome, Hebrew UI
2) option -> under the hood -> google gears
Without the fix, the name appears as "Google Gears:".
With the fix, the name appears as ":Google Gears".
Review URL: http://codereview.chromium.org/18279
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/17277
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7864 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/16529
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7575 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/16528
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7574 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
* Bringup visit_database_unittest.cc on POSIX
Review URL: http://codereview.chromium.org/17025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7570 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
I used the BiDiLineIterator, which I moved out of the AutocompletePopup and into the l10n_util file. I also added a wrapper function around ubidi_getLogicalRun.
Review URL: http://codereview.chromium.org/8727
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4294 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The download page was quickly changed to address bug 1358202, but still there's
a problem that the UI
langauge of Chrome set-up program is different from what a user choose in the
following
scenarios:
* English is chosen on non-en-US OS
* Hebrew is chosen on non-Hebrew OS
* Norwegian Bokmal is selected on non-Norwegian Bokmal OS
Once these changes go in for next-point-release, the change made on the download
server can be reverted.
1. Aliases {iw,no,tl} to {he,nb,fil}.
2. Also map en to en-US.
3. Map {zh-HK, zh-MK, zh-SG} to {zh-TW, zh-TW, zh-CN}
This does not yet deal with other potentially problematic cases.
Added a similar change for l10n_string_util.cc for installer .
Tony already LGTM'd 238 so that I'm tbr'ing here.
BUG=1358202
TEST=L10n* unittest
TBR=tc
Review URL: http://codereview.chromium.org/260
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15 0039d316-1c4b-4281-b951-d872f2087c98
|