summaryrefslogtreecommitdiffstats
path: root/chrome/common/logging_chrome.cc
Commit message (Collapse)AuthorAgeFilesLines
* Split IPC logging between content and chrome.jochen@chromium.org2012-10-301-3/+3
| | | | | | | | | | | | | I add a new content API to register IPC message loggers, and modify the IPC message macros to not directly create the g_log_function_mapping. That allows for multiple files generating IPC loggers. Also, it gets rid of the ctor/dtor for the g_log_function_mapping. BUG=101600,111316,155765 Review URL: https://codereview.chromium.org/11347012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164861 0039d316-1c4b-4281-b951-d872f2087c98
* Don't lock the log file unless we are logging to a file.wtc@chromium.org2012-09-141-2/+5
| | | | | | | | | | R=jschuh@chromium.org,davemoore@chromium.org,brettw@chromium.org BUG=146406 TEST=none Review URL: https://chromiumcodereview.appspot.com/10909164 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156750 0039d316-1c4b-4281-b951-d872f2087c98
* Enable timestamps and disable tick counts in logsgauravsh@chromium.org2012-09-011-2/+2
| | | | | | | | | | | | Currently, logs include tick counts. Tick counts do not increment when the system is suspended or switched off. This makes the logs less useful on platforms like Chrome OS where it is harder (and sometimes impossible) to correlate them with logs from other system services. BUG=chromium:132366 TEST=visually inspect logs Review URL: https://chromiumcodereview.appspot.com/10855114 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154603 0039d316-1c4b-4281-b951-d872f2087c98
* Added "Store Debug Logs" functionality. Logs from /var/log are gzippedygorshenin@chromium.org2012-04-121-14/+14
| | | | | | | | | | | | | | and stored on the fileshelf. BUG=chromium-os:25700 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=131963 Review URL: http://codereview.chromium.org/9965072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131988 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 131963 - Added "Store Debug Logs" functionality. Logs from /var/log ↵ygorshenin@chromium.org2012-04-121-14/+14
| | | | | | | | | | | | | | | | | are gzipped and stored on the fileshelf. BUG=chromium-os:25700 TEST= Review URL: http://codereview.chromium.org/9965072 TBR=ygorshenin@chromium.org Review URL: https://chromiumcodereview.appspot.com/10069009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131965 0039d316-1c4b-4281-b951-d872f2087c98
* Added "Store Debug Logs" functionality. Logs from /var/log are gzippedygorshenin@chromium.org2012-04-121-14/+14
| | | | | | | | | | | | and stored on the fileshelf. BUG=chromium-os:25700 TEST= Review URL: http://codereview.chromium.org/9965072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131963 0039d316-1c4b-4281-b951-d872f2087c98
* Unconditionally send Chrome and Chrome Frame events through ETW machinery.grt@chromium.org2012-03-151-2/+1
| | | | | | | | | | | | | | | Previously, these components only registered themselves if CHROME_ETW_LOGGING was set in the environment. This is likely preventing the new log machinery in http://crrev.com/126240 from providing useful information on the main waterfall bots. Siggi: overall Brett: chrome/common BUG=none TEST=none R=siggi@chromium.org,brettw@chromium.org Review URL: https://chromiumcodereview.appspot.com/9702021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126810 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Implement logging:DumpWithoutCrashing().shess@chromium.org2012-02-281-3/+3
| | | | | | | | | | | | | | | | | | Bring OSX up to parity with other platforms. It is currently in use in the thread-watcher code. Use BreakpadGenerateAndSendReport() to generate a crash report without actually crashing. This function does not dump the current thread's stack, so spin up a separate thread to do the dump, then wait on that thread to complete. BUG=none TEST=Monitor for thread-watcher dumps on the crash server. Review URL: http://codereview.chromium.org/9460028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123870 0039d316-1c4b-4281-b951-d872f2087c98
* linux: Support generating dumps without crashing.derat@chromium.org2012-02-091-3/+17
| | | | | | | | | | BUG=chromium-os:20487 TEST=manual Review URL: http://codereview.chromium.org/8618015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121285 0039d316-1c4b-4281-b951-d872f2087c98
* Convert chrome/common non-debug logs to debug logs.brettw@chromium.org2011-10-281-10/+10
| | | | | | Review URL: http://codereview.chromium.org/8368018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107814 0039d316-1c4b-4281-b951-d872f2087c98
* Startup hang - Dump the call stacks of all threads ifrtenneti@chromium.org2011-10-081-0/+10
| | | | | | | | | | | | | | | | | | ThreadWatcherdoesn't start watching all threads in 5 mins. In Debug mode, it doesa DCHECK and in release mode it dumps the callstack on windows, butdoesn't crash the browser. TODO: need to implement code to get stack traces on other platforms. This is a partial fix to chromium-os:20487. BUG=97997, chromium-os:20487 Test=ThreadWatcher and startup tests R=jar Review URL: http://codereview.chromium.org/8041003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104644 0039d316-1c4b-4281-b951-d872f2087c98
* Register all message types with the IPC logging systemsteveblock@chromium.org2011-09-261-5/+2
| | | | | | | | | | Move all_messages.h from chrome/tools/ipclist/ to chrome/common/ to allow it to be included in logging_chrome.cc. This requires profile_import_process_messages.h to be moved from chrome/browser/ to chrome/common/. Update DEPS files accordingly. Also fixes include ordering in content/common/content_message_generator.h. Review URL: http://codereview.chromium.org/7886009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102791 0039d316-1c4b-4281-b951-d872f2087c98
* Include missing stringprintf.h to fix the Arm build in r97067.tfarina@chromium.org2011-08-171-0/+1
| | | | | | | | | | | BUG=None TEST=None TBR=evan@chromium.org Review URL: http://codereview.chromium.org/7670017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97068 0039d316-1c4b-4281-b951-d872f2087c98
* Unify infobars' link-opening behavior to respect user-requested dispositions ↵pkasting@chromium.org2011-08-021-2/+2
| | | | | | | | | | | | | | and append the Google locale param (since all these links are opening Google pages). This also fixes an incorrect "&" (should be "&") that I assume is a holdover from the string in question formerly being in generated_resources.grd. Randomly, this also removes some unnecessary .c_str() calls in logging_chrome.cc. BUG=none TEST=Middle-clicking "Learn more" on any applicable infobar should open the link in a new background tab. Review URL: http://codereview.chromium.org/7545021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95025 0039d316-1c4b-4281-b951-d872f2087c98
* Do not call GetLogFileName() unless we know we're logging to a filejschuh@chromium.org2011-06-141-19/+29
| | | | | | | | | | Calling GetLogFileName() triggers profile resolution on Windows. This leaves and open ALPC interface after sandbox lockdown, whicb exposes attack surface to a compromised renderrer. My solution is to just not resolve the log path except for the rare case where we need it. TEST=None. BUG=86002 Review URL: http://codereview.chromium.org/7145015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89029 0039d316-1c4b-4281-b951-d872f2087c98
* This change provides initial support for sending DevTools messages between ↵yurys@chromium.org2011-05-271-1/+1
| | | | | | | | | | | | | | | | | | | Worker and Page processes. On the Page side devtools messages are handled by WorkerDevtoolsAgentProxy. It implements WebWorkerBase::DevToolsDelegate interface which isolates worker stuff under content/ from DevTools specifics. In the worker process it's WorkerDevtoolsAgent that is responsible for sending/receiving devtools messages. It implements WebWorkerStub::DevToolsDelegate and WebWorkerClientProxy::DevToolsDelegate which insulate worker stuff under content/ from the devtools implementation details. WorkerDevtoolsAgentProxy and WorkerDevtoolsAgent are counterparts of WebWorkerProxy and WebWorkerStub. Since devtools is not a part of HTML5 the new classes live under chrome/ ContentWorkerClient is introduced for notifying embedder about certain events when worker clients can be installed. BUG=13684 TEST=None Review URL: http://codereview.chromium.org/6990059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86991 0039d316-1c4b-4281-b951-d872f2087c98
* Style cleanups. No functional change.agl@chromium.org2011-05-101-2/+1
| | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84842 0039d316-1c4b-4281-b951-d872f2087c98
* Move plugin messages to content.jam@chromium.org2011-03-141-1/+1
| | | | | | | TBR=tsepez Review URL: http://codereview.chromium.org/6682033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78099 0039d316-1c4b-4281-b951-d872f2087c98
* Move worker_messages to content in preparation of moving worker.jam@chromium.org2011-03-121-1/+1
| | | | | | | TBR=avi Review URL: http://codereview.chromium.org/6681022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77927 0039d316-1c4b-4281-b951-d872f2087c98
* startup: move a bit of logging initialization into InitChromeLoggingevan@chromium.org2011-03-011-8/+36
| | | | | | | | | | | | | Previously we called InitChromeLogging() and then did a bit more logging setup just afterwards. This change moves the follow-up setup into InitChromeLogging as well. While I'm at it, I renamed the dumping function to something more descriptive and used an anonymous namespace rather than "static"s. Review URL: http://codereview.chromium.org/6596077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76444 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos issue 11603: crash in CleanupChromeLogging on shutdown in Debug buildsstevenjb@google.com2011-02-021-0/+8
| | | | | | | | | | BUG=http://code.google.com/p/chromium-os/issues/detail?id=11603 TEST=Test logging. Run a Debug build of Chrome in an environment where log files can not be written, ensure clean shutdown. Review URL: http://codereview.chromium.org/6410041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73527 0039d316-1c4b-4281-b951-d872f2087c98
* Temporary whitelist several cases of disk I/O on the UI threads in cros.nkostylev@chromium.org2011-01-241-0/+4
| | | | | | | | | BUG=60211, 70097, 70119, 70131, 62626, 61143, chromium-os:11102, chromium-os:11104, chromium-os:11105, chromium-os:11106, chromium-os:11109 TEST=bots Review URL: http://codereview.chromium.org/6272012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72331 0039d316-1c4b-4281-b951-d872f2087c98
* Made logging not look up --enable-dcheck from command lineakalin@chromium.org2011-01-111-2/+14
| | | | | | | | | | | | | | | | Made --enable-dcheck a parameter to InitLogging() and fixed up all callsites. BUG=62736 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70782 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70920 Review URL: http://codereview.chromium.org/6070006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70977 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 70920 - Made logging not look up --enable-dcheck from command lineakalin@chromium.org2011-01-101-7/+1
| | | | | | | | | | | | | | | | | Made --enable-dcheck a parameter to InitLogging() and fixed up all callsites. BUG=62736 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70782 Review URL: http://codereview.chromium.org/6070006 TBR=akalin@chromium.org Review URL: http://codereview.chromium.org/6099012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70923 0039d316-1c4b-4281-b951-d872f2087c98
* Made logging not look up --enable-dcheck from command lineakalin@chromium.org2011-01-101-1/+7
| | | | | | | | | | | | | | Made --enable-dcheck a parameter to InitLogging() and fixed up all callsites. BUG=62736 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70782 Review URL: http://codereview.chromium.org/6070006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70920 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 70782 - Made logging not look up --enable-dcheck from command lineakalin@chromium.org2011-01-071-7/+1
| | | | | | | | | | | | | | | Made --enable-dcheck a parameter to InitLogging() and fixed up all callsites. BUG=62736 TEST=Manual Review URL: http://codereview.chromium.org/6070006 TBR=akalin@chromium.org Review URL: http://codereview.chromium.org/6100007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70783 0039d316-1c4b-4281-b951-d872f2087c98
* Made logging not look up --enable-dcheck from command lineakalin@chromium.org2011-01-071-1/+7
| | | | | | | | | | | | Made --enable-dcheck a parameter to InitLogging() and fixed up all callsites. BUG=62736 TEST=Manual Review URL: http://codereview.chromium.org/6070006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70782 0039d316-1c4b-4281-b951-d872f2087c98
* ipc: Simplify the magic required to create IPC message headers.This gets rid ↵jam@chromium.org2010-12-081-1/+1
| | | | | | | | | of having to include the files in a magic place because of xcode dependency issues, and just makes it simpler to create new IPC message classes. It also gets rid of including the X_messages_internal.h file multiple times, which simplifies things and should make the build a little faster. In a future change, I will remove the "internal.h" files since they're no longer needed. Review URL: http://codereview.chromium.org/5526008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68664 0039d316-1c4b-4281-b951-d872f2087c98
* Start using file_util symlink code, now that it's available.gspencer@chromium.org2010-12-031-9/+3
| | | | | | | | | | | | In CL http://codereview.chromium.org/5349007 I added some base API for manipulating symlinks (since I needed it for some ChromeOS code and noticed that other places could use it too), and this just starts using that API. BUG=none TEST=Ran ui_tests, passed trybots. Review URL: http://codereview.chromium.org/5286010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68181 0039d316-1c4b-4281-b951-d872f2087c98
* Integrate ETW with VLOG logging.siggi@chromium.org2010-11-041-2/+3
| | | | | | | | | | | | | This change extends the log severities into the negative for VLOG verbosities. It also keeps track of file/line information and passes it to any registered log handler. The log level is naturally controlled by translating ETW log levels to the severities. BUG=none TEST=none Review URL: http://codereview.chromium.org/4164011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65062 0039d316-1c4b-4281-b951-d872f2087c98
* This moves log output for ChromeOS to safer locations.gspencer@chromium.org2010-11-021-6/+32
| | | | | | | | | | | | | | | | | | | For BWSI (incognito) mode, we want to make sure that we don't leak private information between sessions, so we need to have chrome write log output to the tmpfs created for that mode. Also, the chrome log in "logged in" mode should reside in the "log" subdir instead of in the user data dir. BUG=http://crosbug.com/6908 TEST=Ran on device in incognito and regular modes, and watched where log output ended up. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64638 Review URL: http://codereview.chromium.org/4194005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64826 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 64638 - This moves log output for ChromeOS to safer locations.gspencer@chromium.org2010-11-011-28/+4
| | | | | | | | | | | | | | | | | | | | For BWSI (incognito) mode, we want to make sure that we don't leak private information between sessions, so we need to have chrome write log output to the tmpfs created for that mode. Also, the chrome log in "logged in" mode should reside in the "log" subdir instead of in the user data dir. BUG=http://crosbug.com/6908 TEST=Ran on device in incognito and regular modes, and watched where log output ended up. Review URL: http://codereview.chromium.org/4194005 TBR=gspencer@chromium.org Review URL: http://codereview.chromium.org/4089014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64655 0039d316-1c4b-4281-b951-d872f2087c98
* This moves log output for ChromeOS to safer locations.gspencer@chromium.org2010-11-011-4/+28
| | | | | | | | | | | | | | | | | For BWSI (incognito) mode, we want to make sure that we don't leak private information between sessions, so we need to have chrome write log output to the tmpfs created for that mode. Also, the chrome log in "logged in" mode should reside in the "log" subdir instead of in the user data dir. BUG=http://crosbug.com/6908 TEST=Ran on device in incognito and regular modes, and watched where log output ended up. Review URL: http://codereview.chromium.org/4194005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64638 0039d316-1c4b-4281-b951-d872f2087c98
* chrome/common: Append base:: in the StringPrintf calls.tfarina@chromium.org2010-10-311-7/+7
| | | | | | | | | | | (Note: This is a TODO in string_util.h) BUG=None TEST=trybots Review URL: http://codereview.chromium.org/4111011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64567 0039d316-1c4b-4281-b951-d872f2087c98
* This fixes a bad readlink call that was causing some tests to fail.gspencer@chromium.org2010-10-281-3/+5
| | | | | | | | | BUG=none (Fixing build) TEST=Ran all WorkerTest ui tests on linux (with chromeos=1 and without), and they succeeded. Review URL: http://codereview.chromium.org/4128013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64299 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 64240 - Pass the correct array size to readlink, and pass the length ↵vangelis@chromium.org2010-10-281-2/+2
| | | | | | | | | | | | | | | | of the result to the string constructor Suspect for causing failures in ChromiumOS linux builders ("terminate called after throwing an instance of 'std::length_error'") BUG=none TEST=none Review URL: http://codereview.chromium.org/4181004 TBR=jochen@chromium.org Review URL: http://codereview.chromium.org/4143006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64269 0039d316-1c4b-4281-b951-d872f2087c98
* Pass the correct array size to readlink, and pass the length of the result ↵jochen@chromium.org2010-10-281-2/+2
| | | | | | | | | | | to the string constructor BUG=none TEST=none Review URL: http://codereview.chromium.org/4181004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64240 0039d316-1c4b-4281-b951-d872f2087c98
* This fixes the logging for ChromeOS so that it uses symlinksgspencer@chromium.org2010-10-281-31/+95
| | | | | | | | | | | | | | | | | | | | | | | to log to instead of going to the timestamped files directly, so that the browser process can more precisely control the output file being used. It still creates timestamped logs, and the regular chrome operations should be unchanged. Added a bool return value to InitLogging so we know when it fails, because failing needs to be handled properly in ChromeOS to remove hanging symbolic links. [This change has already been reviewed and approved here: http://codereview.chromium.org/3983004/show Somehow the dcommit failed without me noticing, so I'm trying again.] BUG=http://crosbug.com/6343 TEST=ran on device in incognito and regular mode, looked at logs. Review URL: http://codereview.chromium.org/4167004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64184 0039d316-1c4b-4281-b951-d872f2087c98
* Move debug-related stuff from base to the base/debug directory and use thebrettw@chromium.org2010-10-261-2/+2
| | | | | | | | | | | | | | | | base::debug namespace. This splits apart debug_util into base/debugger and base/stack_trace There are still two functions in debug_util that I'm not sure what to do with. Since this uses the base::debug namespace, I removed the functions in debugger.h from the static class and just made them free functions in the namespace. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3945002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63859 0039d316-1c4b-4281-b951-d872f2087c98
* logging: set the default log level to INFOevan@chromium.org2010-10-051-9/+11
| | | | | | | | | | | | Previously we'd only show LOG(WARNING) or above. This change makes us show LOG(INFO) as well. Now that we have VLOG(), we should remove LOG(INFO) for information we don't care about. Review URL: http://codereview.chromium.org/3599016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61566 0039d316-1c4b-4281-b951-d872f2087c98
* Removed support for log prefix filters.akalin@chromium.org2010-09-301-4/+0
| | | | | | | | | | | No one is using this, and this is obsoleted by --vmodule. BUG=56965 TEST=None Review URL: http://codereview.chromium.org/3596003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61035 0039d316-1c4b-4281-b951-d872f2087c98
* Stop eternal loop in DisplayDebugMessageInDialogcmasone@google.com2010-08-171-0/+4
| | | | | | | | | | | | | | | | if CommandLine was never initialized, CommandLine::ForCurrentProcess() will DCHECK. That causes DisplayDebugMessageInDialog() to run...which calls CommandLine::ForCurrentProcess(), which can DCHECK. Also, Chrome OS doesn't have xmessage, so we don't want to try to pop up a message using that mechanism. BUG=None TEST=Run a binary that doesn't initialize CommandLine (a chrome os unittest binary, for example) and make it CHECK(false). Instead of looping until the stack explodes, it should print messages for the check failures and exit. Review URL: http://codereview.chromium.org/3151016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56281 0039d316-1c4b-4281-b951-d872f2087c98
* base: rename Environment::GetEnv to Environment::GetVar.tfarina@chromium.org2010-08-071-1/+1
| | | | | | | | | | | This is the part 4 and the latest of this series. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/3029062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55326 0039d316-1c4b-4281-b951-d872f2087c98
* base: rename Environment::HasEnv to Environment::HasVar.tfarina@chromium.org2010-08-041-2/+2
| | | | | | | | | | | | This is the part 2 of this series. More two comming. Splitting this into small parts, so it is more easy to review and reduce the size of the CL. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/3035050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54996 0039d316-1c4b-4281-b951-d872f2087c98
* [ChromeOS] Keep logging inside the user's home dir, even after a browser crashcmasone@google.com2010-08-041-0/+8
| | | | | | | | | BUG=50866 TEST=Boot, log in, check that logging goes to /home/chronos/user/chrome_log. Crash the browser. After it comes back, verify that the browser process has created a new log file in /home/chronos/user and is writing to it. Review URL: http://codereview.chromium.org/3063014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54854 0039d316-1c4b-4281-b951-d872f2087c98
* base: Rename EnvVarGetter to Environment.tfarina@chromium.org2010-08-031-3/+3
| | | | | | | | | | | | | | | Now EnvVarGetter do much more than getting environment variables. Per suggestion from Pawel in http://codereview.chromium.org/3043018/. BUG=None TEST=trybots Signed-off-by: Thiago Farina <tfarina@chromium.org> Review URL: http://codereview.chromium.org/3052034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54696 0039d316-1c4b-4281-b951-d872f2087c98
* Move the number conversions from string_util to a new file.brettw@chromium.org2010-07-301-1/+2
| | | | | | | | | | | | | Use the base namespace in the new file. Update callers. I removed all wstring variants and also the string->number ones that ignore the return value. That encourages people to write code and forget about error handling. TEST=included unit tests BUG=none Review URL: http://codereview.chromium.org/3056029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54355 0039d316-1c4b-4281-b951-d872f2087c98
* base/ header cleanup. Forward declaration instead of including.erg@google.com2010-07-281-0/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3068004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53969 0039d316-1c4b-4281-b951-d872f2087c98
* Remove <iostream> where possible.erg@google.com2010-07-201-1/+0
| | | | | | | | | | | | | <iostream> creates a static initializer. Most people don't need <iostream> anyway--they really need <ostream> for operator<< overloads. <iostream> should *never* be included in a header file; <iosfwd> exists for that purpose. BUG=none TEST=none Review URL: http://codereview.chromium.org/3014015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53083 0039d316-1c4b-4281-b951-d872f2087c98
* be more aggressive about removing symlink to latest chrome logcmasone@google.com2010-06-141-4/+3
| | | | | | | | | | | | Due to a semantic mismatch between file_util::Delete and the linux library calls I was using, I was running into problems nuking a symlink that pointed at nothing. I realized that I kinda don't care if the symlink is there, or what it's pointing at. I just want to blow it away. Even if I can't, i still want to redirect logging. So I changed to code to reflect this policy. BUG=None TEST=Log into Chromium OS, alter /home/chronos/chrome_log to point to some nonexistent file. After reboot, verify that it now correctly points to the most recent chrome_log file in /home/chronos Review URL: http://codereview.chromium.org/2811003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49730 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-18 03:55:42 +0000