summaryrefslogtreecommitdiffstats
path: root/chrome/common/metrics
Commit message (Collapse)AuthorAgeFilesLines
* Shorten INSTANT_NEW_TAB_PAGE_WITH_FAKEBOX_AS_STARTING_FOCUS, ↵hfung@chromium.org2013-11-081-7/+7
| | | | | | | | | | | | INSTANT_NEW_TAB_PAGE_WITH_OMNIBOX_AS_STARTING_FOCUS, NEW_TAB_PAGE, and OBSOLETE_INSTANT_NEW_TAB_PAGE enums. This is based the suggestion at https://codereview.chromium.org/23621037/diff/972001/chrome/browser/autocomplete/search_provider.cc#newcode941 BUG= Review URL: https://codereview.chromium.org/65373002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233988 0039d316-1c4b-4281-b951-d872f2087c98
* GCAPI should append to the existing experiment_labels instead of clobbering ↵gab@chromium.org2013-11-076-307/+332
| | | | | | | | | | | | | | | | | | | them. As described on http://crbug.com/266955#c7 Also adding AtExitManager to gcapi_test.exe; this is required to support MasterPreferences's LazyInstance used by BrowserDistribution, used by google_update's ReadExperimentLabels(). Introducing GCAPITestRegistryOverrider as a class to be added as a member to GCAPI test fixtures that require registry overriding; extracted from the existing GCAPIReactivationTest fixture. Move Windows-specific variations_util.cc code to experiment_labels_win.cc BUG=266955 TEST=gcapi_test.exe Review URL: https://codereview.chromium.org/23579003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233493 0039d316-1c4b-4281-b951-d872f2087c98
* Add stable experiment IDs for Android NTP finch trials.tedchoc@chromium.org2013-11-051-8/+14
| | | | | | | | | | | | Renames previous constants to make it clearer they are for Dev/Beta. BUG=251830 NOTRY=true R=asvitkine@chromium.org Review URL: https://codereview.chromium.org/56513005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232848 0039d316-1c4b-4281-b951-d872f2087c98
* Fix minor typo in commentssdefresne@chromium.org2013-10-311-1/+1
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/52793002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232067 0039d316-1c4b-4281-b951-d872f2087c98
* MetricsService: Send a hash of the UMA log in a header. asvitkine@chromium.org2013-10-193-43/+152
| | | | | | | | | | | | | | | | | | | | | Add a new X-Chrome-UMA-Log-SHA1 header that is transmitted along with each UMA log upload. The header contains the SHA1 (as hex) of the payload prior to compression. The hash is computed at the time that the log is closed, rather than just before being transmitted - to minimize the chance of hashing an already corrupted log. Does not store the hash with logs when they are persisted temporarily to local state for later upload, since log are already hashed when stored (and discarded on load if the hash does not match). The SHA1 hash is re-computed when logs are loaded from local state. BUG=308066 Review URL: https://codereview.chromium.org/26646003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229594 0039d316-1c4b-4281-b951-d872f2087c98
* Add multi_profile_user_count field to system_profile proto.tengs@chromium.org2013-10-111-2/+7
| | | | | | | | BUG=297184 Review URL: https://codereview.chromium.org/25364002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228126 0039d316-1c4b-4281-b951-d872f2087c98
* Omit histogram bucket min/max in some cases to optimize UMA size.asvitkine@chromium.org2013-10-043-11/+95
| | | | | | | | | | | | Also updates proto file comments and marks bucket_index as deprecated. BUG=288750 TEST=New unit test. Review URL: https://codereview.chromium.org/25611005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227115 0039d316-1c4b-4281-b951-d872f2087c98
* Add tablet specific IDs for the nntp finch trial.tedchoc@chromium.org2013-10-011-0/+2
| | | | | | | | BUG=251830 Review URL: https://codereview.chromium.org/25108003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226094 0039d316-1c4b-4281-b951-d872f2087c98
* Set the experiment/variation info in crash reports using the crash key ↵rsesek@chromium.org2013-09-253-84/+8
| | | | | | | | | | | logging system. BUG=77656 R=asvitkine@chromium.org, jochen@chromium.org Review URL: https://codereview.chromium.org/23995025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225186 0039d316-1c4b-4281-b951-d872f2087c98
* Add variation IDs for the android native NTP trial.tedchoc@chromium.org2013-09-131-1/+8
| | | | | | | | | BUG=286554 R=asvitkine Review URL: https://chromiumcodereview.appspot.com/23902024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222930 0039d316-1c4b-4281-b951-d872f2087c98
* Omit bucket_index field from UMA HistogramEventProto records.asvitkine@chromium.org2013-09-111-4/+0
| | | | | | | | | | | This field was never used for anything and actually takes up a lot of space in the records. BUG=288750 Review URL: https://chromiumcodereview.appspot.com/23526035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222442 0039d316-1c4b-4281-b951-d872f2087c98
* Add Pepper flag to UMA plugin records.meacer@chromium.org2013-09-101-0/+3
| | | | | | | | BUG=285440 Review URL: https://chromiumcodereview.appspot.com/23534051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222179 0039d316-1c4b-4281-b951-d872f2087c98
* Create a variations component, so that it can be re-used.asvitkine@chromium.org2013-08-2912-1363/+3
| | | | | | | | | | | | | | | | | | | | | Moving this code out of chrome/ paves the way for server-controlled system field trials on ChromeOS. This allows building a new ChromeOS daemon binary that depends on the new variations target, without needing to depend on all of chrome/. This CL moves several files from chrome/common/metrics and chrome/browser/metrics into a separate component/variations target and updates all the include paths referencing these. It does not do additional cleanup, such as changing namespaces - this is left for a follow-up cleanup CL. BUG=266007 TEST=Existing unit tests. R=joi@chromium.org, jwd@chromium.org, sky@chromium.org Review URL: https://codereview.chromium.org/23097007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220339 0039d316-1c4b-4281-b951-d872f2087c98
* Allocate variation ID's for QUIC.rch@chromium.org2013-08-281-1/+5
| | | | | | Review URL: https://chromiumcodereview.appspot.com/23587005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219941 0039d316-1c4b-4281-b951-d872f2087c98
* Omnibox: Cleanup Comments by Page Classification Enummpearson@chromium.org2013-08-281-9/+28
| | | | | | | | | | | | | Followed up previous code review; see linked bug. Once you approve of these comments, I'll revise them in the other two places (google-internal protocol file and autocomplete_input.h). BUG=264938 Review URL: https://chromiumcodereview.appspot.com/22912009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219926 0039d316-1c4b-4281-b951-d872f2087c98
* InstantExtended: analysts have a voracious appetite for IDs.samarth@chromium.org2013-08-211-1/+3
| | | | | | | | | BUG=none R=asvitkine@chromium.org Review URL: https://codereview.chromium.org/22303005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218850 0039d316-1c4b-4281-b951-d872f2087c98
* Remove dependency on variation_ids.h in some variations code.asvitkine@chromium.org2013-08-165-14/+24
| | | | | | | | | | | | | This way, variation_ids.h can stay under chrome/ when a subset of this code will move to a new target that will also be used by the ChromeOS daemon process. BUG=266007 TEST=Existing unit tests. Review URL: https://chromiumcodereview.appspot.com/22980009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218102 0039d316-1c4b-4281-b951-d872f2087c98
* Omnibox: Create DemoteByType Experimentmpearson@chromium.org2013-08-092-2/+13
| | | | | | | | | | | | | | | | | | | | This experiment, which runs as part of the bundled omnibox field trial, uses the field trial parameters to demote results of particular types (e.g., HISTORY_TITLE results), possibly depending on context (e.g., search results page doing search term replacement). It also improves the testing framework for field trial parameters, allowing them to be cleared between consecutive TEST_F()s. Tested via unit tests and by setting up my local variations server with some parameters and making sure results can be demoted or omitted. BUG=264066 Review URL: https://chromiumcodereview.appspot.com/22031002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216633 0039d316-1c4b-4281-b951-d872f2087c98
* Define COOKIE_RETENTION_PRIORITY_STUDY variation IDs.erikwright@chromium.org2013-08-091-1/+5
| | | | | | | | | R=asvitkine@chromium.org BUG=237218 Review URL: https://chromiumcodereview.appspot.com/22481004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216576 0039d316-1c4b-4281-b951-d872f2087c98
* [InstantExtended] Fixing how PageLoadSRP is emitted. Previously it was ↵rlp@chromium.org2013-08-081-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | emitted only for Instant search results pages. Now it should be emitted for any search results page. These fixes include: - Pull out checking for search results page to its own function, IsSearchResultsPageFromDefaultSearchProvider(url) on the TemplateURLService - Add IsSearchResultsPage() to OmniboxCurrentPageDelegate to make checking within omnibox code easier - Add a test for TempalteURL::IsSearchURL which is the heart of the above functions - Move checking for search results pages from metrics_service.cc to uma_browsing_activity_observer.cc which is a more logical location. - Listen to notification for NAV_ENTRY_COMMITTED rather than LOAD_STARTED to capture more events. This includes adding a control RecordAction for NAV_ENTRY_COMMITTED so we can differentiate SRP from non-SRP. Incorporating some of the changes from https://codereview.chromium.org/20043003/ which utilize this functionality. These changes include: - Add a page classification category for SEARCH_RESULT_PAGE_NO_SEARCH_TERM_REPLACEMENT - Update the ClassifyPage function using the changes above to determine if search replacement is being done. - Update the omnibox_event.proto to account for the additional category as well. Also updates the name of the metrics since the definitions have changed. BUG=263644,264067 Review URL: https://chromiumcodereview.appspot.com/21395002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216469 0039d316-1c4b-4281-b951-d872f2087c98
* InstantExtended: record initial focus state for omnibox interactions.samarth@chromium.org2013-08-071-1/+8
| | | | | | | | | | | | Keep track of whether omnibox was visibly or invisibly focused when user first started typing and record that state in OmniboxLog. BUG=264069 R=isherman@chromium.org, mpearson@chromium.org, pkasting@chromium.org Review URL: https://codereview.chromium.org/20587003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216067 0039d316-1c4b-4281-b951-d872f2087c98
* Add an option for InstantExtended field trials to suppress the display of ↵dcblack@chromium.org2013-08-061-1/+5
| | | | | | | | | | | | the verbatim suggestion when it is at position 0. Also flips ShouldPreferRemoteNTPOnStartup to true by default, and modifies the pseudo-flags defined in the field trial names of InstantExtended field trials to be able to be queried successfully even when overall InstantExtended is disabled. (This is necessary to allow an experiment for suppressing verbatim outside of InstantExtended.) BUG=252823 Review URL: https://chromiumcodereview.appspot.com/17114003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215762 0039d316-1c4b-4281-b951-d872f2087c98
* Call group() on 100% uniformity trial.asvitkine@chromium.org2013-08-051-2/+5
| | | | | | | | | | This ensures the trial is reported in metrics. BUG=none Review URL: https://chromiumcodereview.appspot.com/21959007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215670 0039d316-1c4b-4281-b951-d872f2087c98
* Split variations_util.cc into two separate files.asvitkine@chromium.org2013-08-056-612/+704
| | | | | | | | | | | | | | Moves id and param association to variations_associated_data.cc, while keeping the rest of the functionality in variations_util.cc. No functional changes. BUG=266007 TEST=Existing unit tests. Review URL: https://chromiumcodereview.appspot.com/21401002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215644 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land "Move CachingPermutedEntropyProvider to its own file."asvitkine@chromium.org2013-08-026-192/+240
| | | | | | | | | | | | | | | | | Reland of https://codereview.chromium.org/21127007/ The original CL changed a std::string to a const char* in a test, which resulted in saving a ref to a temporary that was later deref'd, which is now fixed in this CL. BUG=266007 TEST=Existing unit tests. TBR=thakis@chromium.org,isherman@chromium.org NOTRY=true Review URL: https://chromiumcodereview.appspot.com/21893002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215291 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 215106 "Move CachingPermutedEntropyProvider to its own file."yzshen@chromium.org2013-08-016-239/+191
| | | | | | | | | | | | | | | | | > Move CachingPermutedEntropyProvider to its own file. > > No functional changes. > > BUG=266007 > TEST=Existing unit tests. > > Review URL: https://chromiumcodereview.appspot.com/21127007 TBR=asvitkine@chromium.org Review URL: https://codereview.chromium.org/21542004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215112 0039d316-1c4b-4281-b951-d872f2087c98
* Move CachingPermutedEntropyProvider to its own file.asvitkine@chromium.org2013-08-016-191/+239
| | | | | | | | | | | No functional changes. BUG=266007 TEST=Existing unit tests. Review URL: https://chromiumcodereview.appspot.com/21127007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215106 0039d316-1c4b-4281-b951-d872f2087c98
* Make CachingPermutedEntropyProvider a subclass of PermutedEntropyProvider.asvitkine@chromium.org2013-07-312-27/+21
| | | | | | | | | | | | | This is a pre-cursor to moving CachingPermutedEntropyProvider to a separate file. Done in a separate CL to make it easier to review. BUG=266007 TEST=Existing unit tests. Review URL: https://chromiumcodereview.appspot.com/21248003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@214708 0039d316-1c4b-4281-b951-d872f2087c98
* Add a 100 percent uniformity field trial.gavinp@chromium.org2013-07-301-0/+6
| | | | | | | | | | | | Everyone in this field trial is always in group_01. It's useful in field trial based dashboard views if you actually just want to look at all data. R=rkaplow@chromium.org BUG=None Review URL: https://chromiumcodereview.appspot.com/19185005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@214444 0039d316-1c4b-4281-b951-d872f2087c98
* Make field trial randomization type a constructor param.asvitkine@chromium.org2013-07-303-76/+71
| | | | | | | | | | | | | | | | | | | | | Changes the Field Trial API to require users to pass ONE_TIME_RANDOMIZED or SESSION_RANDOMIZED at the time the field trial is created. This removes a source of human errors, where developers would sometimes previously forget to call UseOneTimeRandomization() in their CLs. It's a small startup performance win, since one time randomized trials will no longer call RandDouble() that will be then replaced by a value from the entropy provider. (This was showing up in profiles when I was measuring metrics startup perf on mobile.) BUG=262971 TEST=Existing unit tests. TBR=isherman@chromium.org, thakis@chromium.org Review URL: https://codereview.chromium.org/20777005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@214352 0039d316-1c4b-4281-b951-d872f2087c98
* InstantExtended: reserve even more ids.samarth@chromium.org2013-07-241-2/+2
| | | | | | | | BUG=none Review URL: https://chromiumcodereview.appspot.com/19751005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213537 0039d316-1c4b-4281-b951-d872f2087c98
* InstantExtended: reserve more IDs for field trials.samarth@chromium.org2013-07-231-1/+3
| | | | | | | | BUG=none Review URL: https://chromiumcodereview.appspot.com/19497006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213246 0039d316-1c4b-4281-b951-d872f2087c98
* Omnibox Logging: Record Whether User Was on a Search Result Pagempearson@chromium.org2013-07-221-0/+4
| | | | | | | | | | | | | | | | More precisely, reduce whether the user was on a search result page doing search term replacement. This has been approved by chrome-privacy. Tested by adding a LOG(INFO) line in metrics_log to see what the page classification emitted was. BUG=251484 Review URL: https://chromiumcodereview.appspot.com/19810002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212895 0039d316-1c4b-4281-b951-d872f2087c98
* Omnibox UMA Logging: Add Instant New Tab Page as a Classificationmpearson@chromium.org2013-07-191-1/+2
| | | | | | | | | | | | Currently the Instant Extended new tab page is classified as OTHER because it doesn't have the URL chrome://newtab. This adds a new way classification for the instant new tab page. BUG= Review URL: https://chromiumcodereview.appspot.com/19019008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212491 0039d316-1c4b-4281-b951-d872f2087c98
* Include CPU information in UMA system profile.simonjam@chromium.org2013-07-181-1/+11
| | | | | | | | | | | This is particularly useful to help determine which CPUs fail to tick monotonically in HighResNow() on Windows. BUG=254211 Review URL: https://chromiumcodereview.appspot.com/17770005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212323 0039d316-1c4b-4281-b951-d872f2087c98
* [UMA] Clean up MetricsLogBase::set_hardware_class()isherman@chromium.org2013-07-183-15/+2
| | | | | | | | | | BUG=109818 TEST=none R=jar@chromium.org Review URL: https://chromiumcodereview.appspot.com/19707002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212319 0039d316-1c4b-4281-b951-d872f2087c98
* [UMA] Drop base-64 encoding from MetricsLogBase::CreateHashesisherman@chromium.org2013-07-183-85/+31
| | | | | | | | | | BUG=109818 TEST=none R=jar@chromium.org Review URL: https://chromiumcodereview.appspot.com/19684005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212309 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of the message_loop header in chrome/app, ↵avi@chromium.org2013-07-171-1/+1
| | | | | | | | | | | | chrome/common, chrome/nacl/, chrome/renderer/, chrome/service/. BUG=260807 TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/19579004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212174 0039d316-1c4b-4281-b951-d872f2087c98
* [UMA] Remove deprecated XML code paths from MetricsLogBase.isherman@chromium.org2013-07-174-530/+35
| | | | | | | | | BUG=109818 TEST=none Review URL: https://chromiumcodereview.appspot.com/19278006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212051 0039d316-1c4b-4281-b951-d872f2087c98
* Add install_date from prefs into UMA logs with 1 hour granularity.rkaplow@chromium.org2013-07-111-1/+6
| | | | | | | | | | Reduce granularity of uma_enabled_date to 1 hour. BUG=254551 Review URL: https://chromiumcodereview.appspot.com/18503011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211190 0039d316-1c4b-4281-b951-d872f2087c98
* VariationsService: Add support for variation params.asvitkine@chromium.org2013-07-093-44/+286
| | | | | | | | | | | | Previously, some variations have abused group names to pass params anyway. This change adds first class support for this. BUG=257088 TEST=New unit tests. Review URL: https://chromiumcodereview.appspot.com/18178010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210586 0039d316-1c4b-4281-b951-d872f2087c98
* chrome: Migrate from googleurl/ includes to url/ ones. Part 3.tfarina@chromium.org2013-07-041-1/+1
| | | | | | | | | | BUG=229660 TBR=thestig@chromium.org NOTRY=true Review URL: https://chromiumcodereview.appspot.com/18523004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210197 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of time headers in chrome/common/, chrome/installer, ↵avi@chromium.org2013-06-284-4/+4
| | | | | | | | | | | | chrome/renderer/, chrome/service/. BUG=254986 TEST=none TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/18147002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209157 0039d316-1c4b-4281-b951-d872f2087c98
* Change kMaxLowEntropySize to have 8000 values instead of 8192.asvitkine@chromium.org2013-06-211-1/+1
| | | | | | | | | | | | | | | This maps much better to percentages people actually use for experiments (e.g. 1%) without causing an uneven distribution and thus a source of non-uniformity. Re-generates the low entropy source values for users who have it outside the new range. BUG=252283 Review URL: https://chromiumcodereview.appspot.com/17499002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207865 0039d316-1c4b-4281-b951-d872f2087c98
* Adding AppsLauncherPromo variation IDs.mad@chromium.org2013-06-131-1/+5
| | | | | | | | BUG=180475 Review URL: https://chromiumcodereview.appspot.com/16834003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206208 0039d316-1c4b-4281-b951-d872f2087c98
* Reserve some variation ids for UMA dynamic trial.asvitkine@chromium.org2013-06-131-1/+4
| | | | | | | | BUG=none Review URL: https://chromiumcodereview.appspot.com/16821005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206063 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of strings headers in chrome/common/, part 2.avi@chromium.org2013-06-115-8/+8
| | | | | | | | | | BUG=247723 TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/16579006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205372 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of utf_string_conversions.h in chrome/app/, ↵avi@chromium.org2013-06-073-3/+3
| | | | | | | | | | | chrome/common/, chrome/installer. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/16026013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204902 0039d316-1c4b-4281-b951-d872f2087c98
* chrome: metrics: add callgraph and branch stack to perf data protobufsque@chromium.org2013-06-061-1/+19
| | | | | | | | | | | | | | | | Taken from: https://gerrit.chromium.org/gerrit/48671 https://gerrit.chromium.org/gerrit/48673 BUG=238327 TEST=build successfully Change-Id: I6a64d49658e6ab26619688ab50c2beaed66336bc Signed-off-by: Simon Que <sque@chromium.org> Review URL: https://chromiumcodereview.appspot.com/14957007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204489 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 195288 "removed unused variation ids"harrym@chromium.org2013-05-151-0/+25
| | | | | | | | | | | | | | > removed unused variation ids > > BUG= > > Review URL: https://chromiumcodereview.appspot.com/14232021 TBR=harrym@chromium.org Review URL: https://codereview.chromium.org/14566023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200389 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-18 11:35:55 +0000