| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ASCIIToUTF16. I removed string_util includes from a few places where it
obviously wasn't needed.
In a separate pass, I'm going to remove ASCIITo* from string_util, then I'm
going to do an even later pass to find the unnecessary string_util.h includes
and remove them.
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/3058027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use the base namespace in the new file. Update callers.
I removed all wstring variants and also the string->number ones that ignore the return value. That encourages people to write code and forget about error handling.
TEST=included unit tests
BUG=none
Review URL: http://codereview.chromium.org/3056029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
logs now have the following format:
[list_size, log1, log2, ..., log_n, checksum].
where each log is bzipped before being written. Upon reading the logs from disk, we verify the data and register whether we faced corruptions or not.
r=jar
Review URL: http://codereview.chromium.org/2936005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
never get read from again.
r=jar
Review URL: http://codereview.chromium.org/2925006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
As working on change committed in rev50132, instead of yet adding another project to the dependency list of libxml, I decided to abstract the dependency in the metrics helper.
BUG=0
TEST=None
Review URL: http://codereview.chromium.org/2753010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Preparation CL for adding crash metrics UMA counters to ChromeFrame. Basically this would mean
that metrics reporting would be done directly by ChromeFrame. Currently ChromeFrame uses Chrome to
upload this data.
Refactored the chrome metrics service and metrics logging functionality into base classes defined in
chrome\common\metrics_helpers.cc/.h. While this refactoring is by no means complete it is a first step
to avoid needless code duplication between chrome and chrome frame.
Bug=46057
TBR=amit
Review URL: http://codereview.chromium.org/2731006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49417 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original r49354 description: Preparation CL for adding crash metrics UMA counters to ChromeFrame. Basically this would mean that metrics reporting would be done directly
by ChromeFrame. Currently ChromeFrame uses Chrome to upload this data.
Refactored the chrome metrics service and metrics logging functionality into base classes defined in chrome\common\metrics_helpers.cc/.h. While
this refactoring is by no means complete it is a first step to avoid needless code duplication between chrome and chrome frame.
Bug=46057
Review URL: http://codereview.chromium.org/2744003
TBR=ananta@chromium.org
Review URL: http://codereview.chromium.org/2779013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49382 0039d316-1c4b-4281-b951-d872f2087c98
|
|
Basically this would mean that metrics reporting would be done directly
by ChromeFrame. Currently ChromeFrame uses Chrome to upload this data.
Refactored the chrome metrics service and metrics logging functionality into base classes defined in chrome\common\metrics_helpers.cc/.h. While
this refactoring is by no means complete it is a first step to avoid needless code duplication between chrome and chrome frame.
Bug=46057
Review URL: http://codereview.chromium.org/2744003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49354 0039d316-1c4b-4281-b951-d872f2087c98
|