summaryrefslogtreecommitdiffstats
path: root/chrome/common/net
Commit message (Collapse)AuthorAgeFilesLines
* Look up the canonical email address before reporting client login success.johnnyg@chromium.org2010-09-223-10/+97
| | | | | | | | | BUG=55133 TEST=login without @gmail.com at the end Review URL: http://codereview.chromium.org/3451012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60230 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bunch of clang warnings/errors.thakis@chromium.org2010-09-211-1/+1
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/3473006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60109 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 59972 (chromium os leaks) - Reland r59511: Eagerly set the IO loop ↵willchan@chromium.org2010-09-211-17/+1
| | | | | | | | | | | | | | | | | | used for OCSP. ChromeOS will create a special Profile for login. Previously, OCSP initialization was done for the "default" ChromeURLRequestContext for each Profile. Since we can have multiple profiles, this causes the initialization (and uninitialization) to happen multiple times, which causes problems for OCSP since we use statics. The solution is to identify the "main" Profile. We create said Profile in BrowserMain. I add an "is_main_" variable to URLRequestContextGetter and URLRequestContext, so that only the "main" URLRequestContext will initialize OCSP. Other than minor plumbing of "is_main_", this changelist is identical to r59511. BUG=55940 TEST=Startup ChromeOS's Chrome. Should not crash on startup. Review URL: http://codereview.chromium.org/3470001 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/3468005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60025 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r59511: Eagerly set the IO loop used for OCSP.willchan@chromium.org2010-09-201-1/+17
| | | | | | | | | | | | | ChromeOS will create a special Profile for login. Previously, OCSP initialization was done for the "default" ChromeURLRequestContext for each Profile. Since we can have multiple profiles, this causes the initialization (and uninitialization) to happen multiple times, which causes problems for OCSP since we use statics. The solution is to identify the "main" Profile. We create said Profile in BrowserMain. I add an "is_main_" variable to URLRequestContextGetter and URLRequestContext, so that only the "main" URLRequestContext will initialize OCSP. Other than minor plumbing of "is_main_", this changelist is identical to r59511. BUG=55940 TEST=Startup ChromeOS's Chrome. Should not crash on startup. Review URL: http://codereview.chromium.org/3470001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59972 0039d316-1c4b-4281-b951-d872f2087c98
* Fix unintentional pointer arithmetic.evan@chromium.org2010-09-151-1/+2
| | | | | | | | TEST=compiles Review URL: http://codereview.chromium.org/3380009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59582 0039d316-1c4b-4281-b951-d872f2087c98
* Log error string when ClientLogin failscmasone@google.com2010-09-151-0/+1
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/3429008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59563 0039d316-1c4b-4281-b951-d872f2087c98
* Adding additional ClientLogin error messages parsing.nkostylev@chromium.org2010-09-094-0/+53
| | | | | | | | | | | | | | | By default use the same behavior as INVALID_GAIA_CREDENTIALS. Might be used as additional error info or to show different UI error message. ClientLogin API http://code.google.com/apis/accounts/docs/AuthForInstalledApps.html BUG= http://crosbug.com/6379 TEST=Added. Review URL: http://codereview.chromium.org/3335006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58931 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: A giant cleanup to net/erg@google.com2010-08-311-0/+1
| | | | | | | | | | | | This moves all sorts of code from h files to cc files and reduces header dependencies. BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3212008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58020 0039d316-1c4b-4281-b951-d872f2087c98
* Use ChromeThread::IO instead of virtual set_request_contextukai@chromium.org2010-08-232-8/+3
| | | | | | | | | | | | ChromeThread::IO will be used to cancel URLFetcher request and clean up URLRequestContextGetter. BUG=52562,52826 TEST=valgrind passes Review URL: http://codereview.chromium.org/3176028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57032 0039d316-1c4b-4281-b951-d872f2087c98
* Use a generic error instead of a dcheck.chron@chromium.org2010-08-201-1/+5
| | | | | | Review URL: http://codereview.chromium.org/3186020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56904 0039d316-1c4b-4281-b951-d872f2087c98
* Fix typo in TestURLFetcherukai@chromium.org2010-08-201-1/+1
| | | | | | | | | BUG=52826,52562 TEST=valgrind pass Review URL: http://codereview.chromium.org/3153030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56861 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r56483 - Monitor network change in GoogleURLTrackerukai@chromium.org2010-08-203-2/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | It changes to fetch https://www.google.com/searchdomaincheck?format=domain&type=chrome instead of checking http://www.google.com/ redirection. Also show infobar if google domain has been changed to new domain and ask user to switch new domain. Fix Win IO Perf regressions: - GoogleURLTracker::RequestServerCheck() is not called in headless mode (CHROME_HEADLESS=1) nor in Chrome Frame (--chrome-frame). Fix leaks in TestingProfile::CreateRequestContext(): 52562 - Add TestURLFetcher::set_request_context() do nothing, because TestURLFetcher might miss to release core_->request_context_getter_. Fix GoogleURLTracker observer removal DCHECK: 52608 - call RemoveAll(), instead of calling Remove()s BUG=48688,15141,52477,52562,52608 TEST=unit_tests passes Review URL: http://codereview.chromium.org/3171019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56811 0039d316-1c4b-4281-b951-d872f2087c98
* Switch to GoogleServiceAuthError struct instead of GaiaAuthError.chron@chromium.org2010-08-195-64/+305
| | | | | | | | | | | | Remove CAPTCHA code from existing user controller and plumb into google authenticator2. TEST=Install ChromeOS build. Hit Captcha. Enter captcha. BUG=50408 Review URL: http://codereview.chromium.org/3134009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56724 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Make URLFetcherProtectTestPassedThrough fail fast.phajdan.jr@chromium.org2010-08-181-3/+4
| | | | | | | | | | | We should not hang entire unit_tests in case of failure. TEST=unit_tests BUG=none Review URL: http://codereview.chromium.org/3104015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56561 0039d316-1c4b-4281-b951-d872f2087c98
* Win IO Perf Regressionsthomasvl@chromium.org2010-08-181-6/+1
| | | | | | | | | | | | | | | | http://build.chromium.org/buildbot/perf/xp-release-dual-core/moz/report.html?history=150&rev=-1&graph=total_byte_b Revert 56483 - Monitor network change in GoogleURLTracker BUG=48688,15141 TEST=GoogleURLTrackerTest.MonitorNetworkChange passes Review URL: http://codereview.chromium.org/3034018 TBR=ukai@chromium.org Review URL: http://codereview.chromium.org/3176017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56544 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 56522 - Fix leaks in GoogleURLTrackerTest::CreateRequestContext()thomasvl@chromium.org2010-08-181-3/+1
| | | | | | | | | | | | | | | | URLFetcher will release URLRequestContextGetter in CancelURLRequest, which runs in IOMessageLoopProxy. So, if a test doesn't run with IO thread, it will not run CancelURLRequest from URLFetcher::Core::Stop(). BUG=52562 TEST=./tools/valgrind/chrome_tests.sh --test unit --tool memcheck --gtest_filter='GoogleURLTrackerTest.*' Review URL: http://codereview.chromium.org/3198001 TBR=ukai@chromium.org Review URL: http://codereview.chromium.org/3160025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56543 0039d316-1c4b-4281-b951-d872f2087c98
* Fix leaks in GoogleURLTrackerTest::CreateRequestContext()ukai@chromium.org2010-08-181-1/+3
| | | | | | | | | | | | | URLFetcher will release URLRequestContextGetter in CancelURLRequest, which runs in IOMessageLoopProxy. So, if a test doesn't run with IO thread, it will not run CancelURLRequest from URLFetcher::Core::Stop(). BUG=52562 TEST=./tools/valgrind/chrome_tests.sh --test unit --tool memcheck --gtest_filter='GoogleURLTrackerTest.*' Review URL: http://codereview.chromium.org/3198001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56522 0039d316-1c4b-4281-b951-d872f2087c98
* Monitor network change in GoogleURLTrackerukai@chromium.org2010-08-181-1/+6
| | | | | | | | | BUG=48688,15141 TEST=GoogleURLTrackerTest.MonitorNetworkChange passes Review URL: http://codereview.chromium.org/3034018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56483 0039d316-1c4b-4281-b951-d872f2087c98
* Test server cleanup patch of death:phajdan.jr@chromium.org2010-08-171-42/+40
| | | | | | | | | | | | | | - reduce the number of different classes - clean up the internal code - modify the interface to expose less internal details (this will allow more flexibility with port numbers) TEST=many BUG=49680 Review URL: http://codereview.chromium.org/3080029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56405 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 56376 - This CL will introduce a new way to do exponential back-off ↵joi@chromium.org2010-08-171-3/+1
| | | | | | | | | | | | | | | | | | | | | | on failure within Chromium. It is a network level implementation and should constitute a good enough bottleneck to manage every outgoing http request. Committing for malavv@google.com. Original review: http://codereview.chromium.org/2487001/show R=phajdan-jr BUG=none TEST=unit tests Review URL: http://codereview.chromium.org/3005049 TBR=joi@chromium.org Review URL: http://codereview.chromium.org/3165029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56393 0039d316-1c4b-4281-b951-d872f2087c98
* This CL will introduce a new way to do exponential back-off on failure within joi@chromium.org2010-08-171-1/+3
| | | | | | | | | | | | | | | | Chromium. It is a network level implementation and should constitute a good enough bottleneck to manage every outgoing http request. Committing for malavv@google.com. Original review: http://codereview.chromium.org/2487001/show BUG=none TEST=unit tests Review URL: http://codereview.chromium.org/3005049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56376 0039d316-1c4b-4281-b951-d872f2087c98
* Remove remaining deprecated wstring methods from base/values.{cc,h}.viettrungluu@chromium.org2010-08-171-13/+13
| | | | | | | | | BUG=23581 TEST=builds and passes tests Review URL: http://codereview.chromium.org/3109025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56362 0039d316-1c4b-4281-b951-d872f2087c98
* Gaia authentication for access remoting directory and talkhclam@chromium.org2010-08-172-0/+3
| | | | | | | | | | | | | | | | We are now able to access remoting directory token and talk token through the chromoting setup dialog. These information are sent to the service process for enabling the chromoting host and perform the host registration. All the plumbing for starting the service process, enabling the chromoting host through through IPC commands are in place but host registration is stubbed out and will be completed in next patch. Review URL: http://codereview.chromium.org/3176014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56278 0039d316-1c4b-4281-b951-d872f2087c98
* Add undeclared virtual destructors part 4ziadh@chromium.org2010-07-301-0/+6
| | | | | | | | | | | | | | | Preventative maintenance for abstract classes that do not declare virtual destructors. Base classes that do not declare their destructors as virtual could potentially lead to memory leaks. These files were discovered using the -Wnon-virtual-dtor flag in g++. r=jar BUG=47469 Review URL: http://codereview.chromium.org/3032046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54408 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Move more test server code from net/url_request/url_request_unittest.hphajdan.jr@chromium.org2010-07-291-13/+21
| | | | | | | | | | | | | to net/test/test_server.h No code changes, just a move. TEST=none BUG=49680 Review URL: http://codereview.chromium.org/3034038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54201 0039d316-1c4b-4281-b951-d872f2087c98
* The token service should now support issuing auth tokens.chron@chromium.org2010-07-285-12/+60
| | | | | | | | | | | | The service will fetch tokens in the background and broadcast notifications after it's done. Move some common constants out into a new file. Modify TestNotificationTracker to support subclassing as it doesn't properly make a deep copy of notifications on the stack. TEST=unit tests included BUG=47093 Review URL: http://codereview.chromium.org/3024002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54028 0039d316-1c4b-4281-b951-d872f2087c98
* Make login cancel logic load localaccount file before attempting offline logincmasone@google.com2010-07-282-3/+4
| | | | | | | | | BUG=chromium-os:5169 TEST=unit tests Review URL: http://codereview.chromium.org/2847080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53913 0039d316-1c4b-4281-b951-d872f2087c98
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-2613-0/+13
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Use FRIEND_TEST_ALL_PREFIXES some more.phajdan.jr@chromium.org2010-07-261-2/+3
| | | | | | | | | TEST=compile BUG=44549 Review URL: http://codereview.chromium.org/3032025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53706 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: test server cleanup:phajdan.jr@chromium.org2010-07-231-19/+12
| | | | | | | | | | | | | - simplify the public interface - remove unneeded methods - make it easier to understand TEST=none BUG=49680 Review URL: http://codereview.chromium.org/2881028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53509 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Move net/socket/ssl_test_util to net/test/test_serverphajdan.jr@chromium.org2010-07-211-1/+1
| | | | | | | | | | | This is a first step to make test server easier to use and more reliable. TEST=none BUG=49680 Review URL: http://codereview.chromium.org/3040011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53137 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt four at landing the "histogram.h removed from message_loop.h" patch.erg@chromium.org2010-07-151-0/+1
| | | | | | | | | | | | | | Previously committed as r52349 and r52336. Related commits: r52367, r52364 and r52343. Rerunning trybots due to previous trybot breakage. TEST=none BUG=none Review URL: http://codereview.chromium.org/2965015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52496 0039d316-1c4b-4281-b951-d872f2087c98
* Revert everything related to the relanding.erg@chromium.org2010-07-141-1/+0
| | | | | | Review URL: http://codereview.chromium.org/2982009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52367 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r52336.erg@chromium.org2010-07-141-0/+1
| | | | | | | | | | | | | | (I accidentally committed a previous version of the patch (the fixed version was in codereview since I had switched to my mac to address this exact compile failure.) BUG=none TEST=none TBR=evan Review URL: http://codereview.chromium.org/2937010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52349 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 52336 - More header cleanup:erg@chromium.org2010-07-141-1/+0
| | | | | | | | | | | | | | | | - Some cleanup to url_request.h - Remove task.h from headers that don't need it. - Remove histogram.h from message_loop.h BUG=none TEST=none Review URL: http://codereview.chromium.org/2986002 TBR=erg@chromium.org Review URL: http://codereview.chromium.org/2969006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52343 0039d316-1c4b-4281-b951-d872f2087c98
* More header cleanup:erg@chromium.org2010-07-141-0/+1
| | | | | | | | | | | | | - Some cleanup to url_request.h - Remove task.h from headers that don't need it. - Remove histogram.h from message_loop.h BUG=none TEST=none Review URL: http://codereview.chromium.org/2986002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52336 0039d316-1c4b-4281-b951-d872f2087c98
* Add IssueAuthToken and unit tests to GaiaAuthenticator2.chron@chromium.org2010-07-065-81/+276
| | | | | | | | | | | GaiaAuthConsumer pure virtuals now optional since you can choose to not listen to ClientLogin subscriptions. Renamed ClientLoginError to a general GaiaAuthError. BUG=47093 TEST=Unit tests included Review URL: http://codereview.chromium.org/2834042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51678 0039d316-1c4b-4281-b951-d872f2087c98
* Split Gaia auth out into common/net. This is in preparation for creating a ↵chron@chromium.org2010-07-015-0/+757
| | | | | | | | | | | | | | | | | new Auth service which will issue auth tokens. I'd like to get it in and continue hacking on it so I can stop colliding so badly with merges. I've ported over the existing unit tests. Eventually gaia_authenticator.cc is going away. For the time being, i'll be number two. This is now done, with a pile of unit tests. I am trying to run the interactive tests but I was getting numerous unrelated failures and need to resync ChromiumOS to a working build. TEST=unit tests, manually log in, out, enter wrong password. BUG=47091 Review URL: http://codereview.chromium.org/2801015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51437 0039d316-1c4b-4281-b951-d872f2087c98
* Move chrome/common/net/notifier to jingle/notifier so that it can be used by ↵ajwong@chromium.org2010-06-3056-5906/+0
| | | | | | | | | | | remoting/remoting.gyp. BUG=none TEST=compiles Review URL: http://codereview.chromium.org/2885005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51216 0039d316-1c4b-4281-b951-d872f2087c98
* Rename Dns prefetching files to Predictor filesjar@chromium.org2010-06-271-3/+3
| | | | | | | | | | | | We are now doing more than DNS pre-resolution, and want to do TCP/IP pre-warming. This change uses the updated class names etc., and tries to use Predictor as the common element in most names. r=mbelshe Review URL: http://codereview.chromium.org/2866026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50951 0039d316-1c4b-4281-b951-d872f2087c98
* Massively simplify the NetworkChangeNotifier infrastructure:pkasting@chromium.org2010-06-2519-1335/+12
| | | | | | | | | | | | | | * Use a process-wide object (singleton pattern) * Create/destroy this object on the main thread, make it outlive all consumers * Make observer-related functions threadsafe As a result, the notifier can now be used by any thread (eliminating things like NetworkChangeObserverProxy and NetworkChangeNotifierProxy, and expanding its usefulness); its creation and inner workings are much simplified (eliminating implementation-specific classes); and it is simpler to access (eliminating things like NetworkChangeNotifierThread and a LOT of passing pointers around). BUG=none TEST=Unittests; network changes still trigger notifications Review URL: http://codereview.chromium.org/2802015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50895 0039d316-1c4b-4281-b951-d872f2087c98
* Do speculative preconnection based on network traffic (not just DNS)jar@chromium.org2010-06-231-0/+6
| | | | | | | | | | | | This rev also handles the triple of scheme/host/port for recording both referrers and speculative connections, so that we can soon support SSL warming as well as "mere" TCP/IP preconnection. r=mbelshe Review URL: http://codereview.chromium.org/2563004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50563 0039d316-1c4b-4281-b951-d872f2087c98
* Implemented initial version of server-issued notification client.akalin@chromium.org2010-06-232-23/+29
| | | | | | | | | | | | | | | | Added NOTIFICATION_SERVER notification method (use --sync-notification-method=server to turn on). BUG=34647 TEST=manually Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50479 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50550 Review URL: http://codereview.chromium.org/2827014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50560 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 50550 - Implemented initial version of server-issued notification client.akalin@chromium.org2010-06-232-29/+23
| | | | | | | | | | | | | | | | | Added NOTIFICATION_SERVER notification method (use --sync-notification-method=server to turn on). BUG=34647 TEST=manually Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50479 Review URL: http://codereview.chromium.org/2827014 TBR=akalin@chromium.org Review URL: http://codereview.chromium.org/2860015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50557 0039d316-1c4b-4281-b951-d872f2087c98
* Implemented initial version of server-issued notification client.akalin@chromium.org2010-06-232-23/+29
| | | | | | | | | | | | | | Added NOTIFICATION_SERVER notification method (use --sync-notification-method=server to turn on). BUG=34647 TEST=manually Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50479 Review URL: http://codereview.chromium.org/2827014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50550 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 50479 - Implemented initial version of server-issued notification client.akalin@chromium.org2010-06-222-29/+23
| | | | | | | | | | | | | | | Added NOTIFICATION_SERVER notification method (use --sync-notification-method=server to turn on). BUG=34647 TEST=manually Review URL: http://codereview.chromium.org/2827014 TBR=akalin@chromium.org Review URL: http://codereview.chromium.org/2805023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50482 0039d316-1c4b-4281-b951-d872f2087c98
* Implemented initial version of server-issued notification client.akalin@chromium.org2010-06-222-23/+29
| | | | | | | | | | | | Added NOTIFICATION_SERVER notification method (use --sync-notification-method=server to turn on). BUG=34647 TEST=manually Review URL: http://codereview.chromium.org/2827014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50479 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Put functions in the same order in the .cc file as the .h file. ↵pkasting@chromium.org2010-06-171-22/+21
| | | | | | | | | | Remove an unneeded pair of braces. BUG=none TEST=none Review URL: http://codereview.chromium.org/2809021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50151 0039d316-1c4b-4281-b951-d872f2087c98
* Implement a TODO: Move "NonThreadSafe" inheritance from ↵pkasting@chromium.org2010-06-172-17/+12
| | | | | | | | | | | | NetworkChangeNotifier interface to implementations. Also add CalledOnValidThread() DCHECKs in as many places as possible. Some minor style changes. BUG=none TEST=none Review URL: http://codereview.chromium.org/2813019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50139 0039d316-1c4b-4281-b951-d872f2087c98
* Combined both constructors of TalkMediatorImpl into one.akalin@chromium.org2010-06-163-53/+49
| | | | | | | | | BUG=none TEST=manual, trybots Review URL: http://codereview.chromium.org/2835003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49891 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-25 01:05:46 +0000