summaryrefslogtreecommitdiffstats
path: root/chrome/common/notification_registrar.cc
Commit message (Collapse)AuthorAgeFilesLines
* Prevent NotificationRegistrar from pulling in platform threading stuff.erg@chromium.org2010-07-201-10/+13
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3013018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53055 0039d316-1c4b-4281-b951-d872f2087c98
* Next part of removing the dependency of chrome/common on chrome/browserphajdan.jr@chromium.org2010-03-061-19/+11
| | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/669184 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40834 0039d316-1c4b-4281-b951-d872f2087c98
* Add per-observer instrumenting code to NotificationRegistrar.huanr@chromium.org2010-02-011-22/+21
| | | | | | | | | TEST=All current tests pass BUG=31078 Review URL: http://codereview.chromium.org/554130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37744 0039d316-1c4b-4281-b951-d872f2087c98
* Adding instrument to NotificationRegistrar to checkhuanr@chromium.org2009-12-041-0/+25
| | | | | | | | | | | | | | | Add() and Remove() are called from same thread. Note I already checked in a fix for the bug. The CL is trying to check whether the issue exists in other code path. TEST=none BUG=27834 Review URL: http://codereview.chromium.org/449044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33802 0039d316-1c4b-4281-b951-d872f2087c98
* Add more logging on a NOTREACHED() in hopes of getting more data about why ↵pkasting@chromium.org2009-05-281-1/+2
| | | | | | | | | we're hitting it. BUG=12684 Review URL: http://codereview.chromium.org/113958 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17094 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid calling NotificationService::current() unless we have to, to prevent ↵pkasting@chromium.org2009-05-231-7/+12
| | | | | | | | | problems during shutdown in atypical cases.We can now be more stringent with the Remove() check that was already in place, since now users _must_ go through NotificationRegistrar to register an observer. BUG=12560 Review URL: http://codereview.chromium.org/115733 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16821 0039d316-1c4b-4281-b951-d872f2087c98
* Make the NotificationRegistrar safe for use in Singletons, which may outlive ↵pkasting@chromium.org2009-05-211-5/+17
| | | | | | | | | | | the NotificationService instances, by checking whether the service exists before calling RemoveObserver() on it. Also add comments in NotificationService telling people to use NotificationRegistrar. BUG=2381 Review URL: http://codereview.chromium.org/115601 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16554 0039d316-1c4b-4281-b951-d872f2087c98
* Remove most header file dependencies on the notification type list. It isbrettw@chromium.org2009-02-011-1/+18
| | | | | | | | | | | really painful to add more types, since lots of headers include the notification service to derive from the notification observer. This splits that out, so much less of the project should end up including notification_types.h ---Paths modified but not in any changelist: Review URL: http://codereview.chromium.org/19744 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9020 0039d316-1c4b-4281-b951-d872f2087c98
* Pass NotificationSource by const ref rather than value, as it's a class (and ↵pkasting@chromium.org2008-10-081-2/+2
| | | | | | | | this matches NotificationObserver). Review URL: http://codereview.chromium.org/6468 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3060 0039d316-1c4b-4281-b951-d872f2087c98
* Remove an explicit call from the NavigationController to the alternate URLbrettw@google.com2008-09-161-0/+54
fetcher since there is already a notification that does this. I created a class that will automatically unregister for notifications when it goes out of scope and used it here. I think it will be useful for most consumers of notifications. Review URL: http://codereview.chromium.org/2895 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2276 0039d316-1c4b-4281-b951-d872f2087c98