| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
2. Change "GetSearchEngineType" function to use the short name to get the search engine type if we can't choose by prepopulate_id.
3. Disable the close button. (Next CL will remove it, if possible, but this requires adding a method to window_delegate.h).
4. Close the search engine view immediately if the user launches the keyword editor view. Pass the SearchEngineViewObserver object (the FirstRunView) to the keyword editor, who will call back to the waiting observer when closed.
BUG= none
TEST= none
Review URL: http://codereview.chromium.org/1539044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45092 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
now. Soon the cloud print proxy code will move from the browser process to a background process called the service process.
BUG=None
TEST=None for now
Review URL: http://codereview.chromium.org/1566047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
instead of using WebDataService. Once PasswordStoreWin is migrated as well,
PasswordStoreLinux will likely be folded back into PasswordStoreDefault.
BUG=35038
TEST=PasswordStoreLinuxTest.*
Review URL: http://codereview.chromium.org/1525026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44679 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG= 37564
TEST= start Chrome with --first-run enabled -- you should see a new search engine selection dialog.
Review URL: http://codereview.chromium.org/1586005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
LoginDatabase"
This reverts commit 2fa9a35a2e607688e7c2f8908c0d1e4c31ff5c96.
TBR=stuartmorgan
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1545033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
instead of using WebDataService. Once PasswordStoreWin is migrated as well,
PasswordStoreLinux will likely be folded back into PasswordStoreDefault.
BUG=35038
TEST=PasswordStoreLinuxTest.*
Review URL: http://codereview.chromium.org/1525026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
of r42674).
BUG=none
TEST=Run (branded, official) Google Chrome build with --enable-internal-flash; EULA "dialog" tab should no longer be shown, and our Flash should be enabled (check about:plugins). Without --enable-internal-flash, it should still not appear in about:plugins.
Review URL: http://codereview.chromium.org/1527023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44147 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change also disables the latter hot-key so that users can't disable IBus. This is preferable since "current input method is xkb:us::eng (for example) and it is enabled" and "current one is xkb:us::eng but it's disabled" are almost indistinguishable.
This change depends on http://codereview.chromium.org/1528023 and http://codereview.chromium.org/1610013.
BUG=none
TEST=boot chrome os, activate English and Chinese, click omnibox, press lang menu, press English to enable "xkb:us::eng", press omnibox, press ctrl+space, verify that the menu shows "Chi" (not "Eng").
Review URL: http://codereview.chromium.org/1553018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44072 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=37394
TEST=unit_tests + manual
Review URL: http://codereview.chromium.org/1567010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(2nd try; see r43475 and r43481).
Modified chrome/browser/chromeos/cros/cros_in_process_browser_test.cc not to break browser_tests. Other files are not modified since the previous CL (r43475).
BUG=crosbug.com/488
TEST=none
Review URL: http://codereview.chromium.org/1599017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
502 and 503 responses, etc.
TEST=Unit-tested + by setting up the response from AutoFill server.
BUG=39921
Review URL: http://codereview.chromium.org/1535011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43531 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to Chrome side.
BUG=crosbug.com/488
TEST=none
Review URL: http://codereview.chromium.org/1546010
TBR=yusukes@chromium.org
Review URL: http://codereview.chromium.org/1520012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=crosbug.com/488
TEST=none
Review URL: http://codereview.chromium.org/1546010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The ProfileSyncService will manage the enabled/disabled types. Remove
CustomizeSyncWindowView's DataTypeManager dependency; it should really
just be operating on the preferences via the ProfileSyncService.
Clarify the difference between types being enabled (meaning the user
wants to sync them) versus being advertisable (meaning we support the
datatype, and advertise that the user has the option of syncing it).
BUG=34209,38340
TEST=After syncing, open the options dialog and recustomize your
options. Verify that the enabled types from the wizard match the
initial state of the options window. After changing the options and
hitting "accept", observe that a breakpoint in DTM::Configure gets
triggered, with exactly the new configuration set. Verify that the
preferences are preserved on restart, as well as across Stop
Syncing / Start Syncing.
Review URL: http://codereview.chromium.org/1556009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43440 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=34209,32414
TEST=none
Review URL: http://codereview.chromium.org/1582006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43312 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
data type (bookmarks, preferences, etc).
The Customize Sync dialog appears if you click a button on the gaia login or the Options->Personal Stuff tab. This button only appears if you've set the --enable-sync-preferences or --enable-sync-autofill command-line flag.
On the Gaia login, the Customize Sync button grays out when you click 'sign in'. If the "customize sync" dialog is open, it closes when you click "cancel" on the Gaia login, and it accepts when you log in to Gaia.
Removed "Merge and Sync" from the login sequence. Also deleted the 'merge_allowed' parameter from DataTypeController and its subclasses.
Fixed strings so they all refer to "Google Chrome/Chromium sync" instead of "Bookmark sync".
BUG=34209,27259
TEST=none
Review URL: http://codereview.chromium.org/1134002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43256 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
ibus-memconf) to Chrome side. This change should make it easier to sync the IME preferences with cloud.
BUG=crosbug.com/2299
BUG=crosbug.com/488
TEST=manual
Review URL: http://codereview.chromium.org/1599005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
AutoFill dialog. Add two new prefs to track the default profile and credit
card.
BUG=38975
TEST=none
Review URL: http://codereview.chromium.org/1480001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1320002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42674 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=736
TEST=Go to chrome://plugins/. Should be able to enable/disable plugins. Enabled/disabled plugins should persist between sessions.
Review URL: http://codereview.chromium.org/1085003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
HostContentSettingsMap.
This was originally written by bulach and posted at http://codereview.chromium.org/1033004 ; modified and landed by me.
BUG=37206
TEST=Tested by unittests
TBR=bulach,joth
Review URL: http://codereview.chromium.org/1084005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
restore.
BUG=23613
TEST=turn off session restore, pin a tab, restart chrome and make sure
you get back the pinned tab.
Review URL: http://codereview.chromium.org/1026005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also fix some issues on GTK concerning the proper behavior when adding/removing browser actions (container sizing + chevron visibility).
Windows uses a different pref (kBrowserActionContainerWidth), which is measured in pixels; it should be migrated to the new pref.
Also, register extension prefs during startup.
BUG=32101
TEST=manual
Review URL: http://codereview.chromium.org/841007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Uptime was being reported only at startup, and then, for the previous session.
This meant that folks with a long uptime would be very slow to report.
This change moves the reporting to an incremental reporting, done as
often as we report pageloads etc. (i.e., in each UMA upload).
This also fixes several bugs relating to uptime calculation, by using
TimeTicks (which show process time) rather than Time (which shows wall
clock time, and is subject to corruption if the user changes the will
clock time on the computer). It also resolves a bug that may have caused
negative uptimes to be reported.
BUG=37630
r=hunar
Review URL: http://codereview.chromium.org/675001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/656009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Adds a boolean preference to specify whether to use the Mac user's Address Book "me" card as a source of information for AutoFill addresses. This CL adds the Mac UI and the preference setup only. It does not cover the functionality for fetching the actual Address Book data. The changes to AutoFillDialog.xib add the checkbox UI and bind the checkbox to the |auxiliaryEnabled| property in the controller class. The |addressSection_| outlet is set to the spacer following the new checkbox. Unit tests are included for the addition of the preference at the mac dialog controller level.
BUG=36496
TEST=PersonalDataManagerTest, AutoFillDialogControllerTest
Review URL: http://codereview.chromium.org/668171
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40803 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
already to avoid re-enabling sync everytime the machine boots.
BUG=37164
TEST=unit test
Review URL: http://codereview.chromium.org/669099
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40760 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Visit a page in a language other than the Chrome's language.
A translate infobar should be shown.
In the options/Under the Hood tab, unselect "Offer to translate
pages that aren't in a language I read". Navigate again to a
page in a non Chrome-UI language. No translate infobar should be
shown.
Review URL: http://codereview.chromium.org/661095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40128 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change to AutoFillDialog.xib was window anchoring flags to better position dialog in different window sizes on first run.
> 1.) The initial position of the dialog is half off-screen on my 15'' MBP. It should probably be
> more on the left.
>
Done. Auto centering now.
> 2.) Furthermore, the dialog should autosave its position. See e.g.
> keyword_editor_cocoa_controller.mm on how to do this (the |if (g_browser_process...)| block in
> |initWithProfile| – it takes only a couple lines).
>
Done.
> 3.) When clicking "Add an address", I find it weird that the new address starts in the collapsed
> state. That makes it hard to see how to delete it again, and chances are that when I'm adding a
> new address I want to edit it immediately.
>
Done.
BUG=36441
TEST=see manual repro steps above.
Review URL: http://codereview.chromium.org/660130
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
to show the infobar asking the user to enable/disable AutoFill++.
BUG=18201
TEST=none
Review URL: http://codereview.chromium.org/650169
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
persistence (via local state prefs)
BUG=11246
TEST=unit_tests.exe --gtest_filer=Geoloc*
Review URL: http://codereview.chromium.org/603040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. Fixes bug that lead to randomly expanding and not (expanded_view_
wasn't in the member initializer list).
. Fixed bug where expanding/collapsing would result in dialog changing
to wrong size.
. Persist expanded state to prefs.
BUG=35092, 35165
TEST=see bugs
Review URL: http://codereview.chromium.org/595014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The option to enable the vertical tabstrip will appear when Chrome is run with:
--enable-vertical-tabs
and a pref is set. There is presently no UI to set this pref.
http://crbug.com/34509
TEST=none
Review URL: http://codereview.chromium.org/561004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32719
TEST=none
Review URL: http://codereview.chromium.org/560024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=32719
TEST=none
Review URL: http://codereview.chromium.org/564012
TBR=jochen@chromium.org
Review URL: http://codereview.chromium.org/564023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32719
TEST=none
Review URL: http://codereview.chromium.org/564012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also, do a better job of making sure we don't write useless default values to disk, and we force the in-memory copy of the default prefs to never say "DEFAULT" even if a caller provides that to SetDefaultContentSetting().
BUG=32719
TEST=unittests
Review URL: http://codereview.chromium.org/562003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37775 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This also rewrites the affected UI bits to make it easier to do this, get rid of unnecessary code, and be more consistent with the blocked content bubble code.
BUG=32719
TEST=Content settings windows now have radio buttons that work, and remember their settings. The Flash link works too.
Review URL: http://codereview.chromium.org/558060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There was no LGTM, and there was still open discussion in the code review. See
http://codereview.chromium.org/554119. This was not ready to land.
TBR=pkasting
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/553154
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37556 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32782
TEST=none
Review URL: http://codereview.chromium.org/554119
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37535 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/555172
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37526 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This reverts commit r37508, as it was crashing on the reliability bots.
Review URL: http://codereview.chromium.org/556076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37519 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This map stores whether a given host may load images or use plugins and javascript. And makes this information available to the render view
BUG=32782
TEST=none
Review URL: http://codereview.chromium.org/551149
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37508 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32719
TEST=none
Review URL: http://codereview.chromium.org/554045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37153 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32782
TEST=unit_tests
Review URL: http://codereview.chromium.org/555033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This changelist implements the following:
- A resize gripper and chevron in the browser action container
- Overflow when icons don't fit
- Snap to multiple of icon size (no excess pixels)
- Animation when resizing container / adding&removing icons (disable, enable).
- Persists the last width of the browser action container.
Known issues:
- No menu (yes, the chevron button doesn't do anything yet).
BUG=32101
TEST=Install and uninstall browser actions & make sure install bubble appears in
the right location. Make sure browser action container does not expand if
chevron is showing when you add browser action. Make sure container loses
chevron when no overflow occurs. Make sure browser action icons never disappear
due to shrinking when you release the mouse (when resizing). Make sure snapping
works.
Review URL: http://codereview.chromium.org/553039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
direction for
the clear browsing data dialog.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/542126
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
r=huanr
Review URL: http://codereview.chromium.org/548058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36549 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GTK.
NOTE: This change does not contain src/chrome/app/nibs/ClearBrowsingData.xib. It'll be edited by someone who knows about Mac.
BUG=none
TEST=The clear browser data dialog box should have a new option: Delete local storage"
Landing for Marcus
Original CL: http://codereview.chromium.org/524026
Review URL: http://codereview.chromium.org/542048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36098 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
infobar has been shown to the user. autofill.enabled is true if the user has accepted the autofill confirmation infobar.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/541001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35917 0039d316-1c4b-4281-b951-d872f2087c98
|