| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
Adds PrintingContext implementation stub for Android.
BUG=147070
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/22999026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218339 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=260807
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/19275015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=avi@chromium.org
Review URL: https://codereview.chromium.org/16923013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL changes the majority of include paths from the old
Source/WebKit/chromium/public to the new public/web directory.
TBR=darin
BUG=239545
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/17148003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
printing is disabled.
BUG=224623
Review URL: https://codereview.chromium.org/13220005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=83098
Review URL: https://chromiumcodereview.appspot.com/12177009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180570 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=83098
Review URL: https://chromiumcodereview.appspot.com/12084012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=113594
Review URL: https://chromiumcodereview.appspot.com/11818062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176617 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=144051
Review URL: https://chromiumcodereview.appspot.com/10870003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Uses a render view ID to find a correct window handle to use as a parent
for the system dialog.
Uses a series of PostTask calls to cause the various steps of
getting print settings to occur on the correct threads.
BUG=130095
TEST=Verify 130095
Review URL: https://chromiumcodereview.appspot.com/10544084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/129187
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10449058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139601 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
obtain profile and parent window from invocation context.
http://crbug.com/129053
TEST=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138485
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138561
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138823
Review URL: https://chromiumcodereview.appspot.com/10388214
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138863 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
list, instead obtain profile and parent window from invocation context.
http://crbug.com/129053
TEST=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138485
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138561
Review URL: https://chromiumcodereview.appspot.com/10388214
TBR=ben@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138827 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
obtain profile and parent window from invocation context.
http://crbug.com/129053
TEST=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138485
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138561
Review URL: https://chromiumcodereview.appspot.com/10388214
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
list, instead obtain profile and parent window from invocation context.
http://crbug.com/129053
TEST=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138485
Review URL: https://chromiumcodereview.appspot.com/10388214
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10427005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138565 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
obtain profile and parent window from invocation context.
http://crbug.com/129053
TEST=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138485
Review URL: https://chromiumcodereview.appspot.com/10388214
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138561 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138496 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
obtain profile and parent window from invocation context.
http://crbug.com/129053
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10388214
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
class and webkit-glue.cc
BUG=85132
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10168013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137761 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=85132
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10083060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137498 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(1) Added |fit_to_paper_size| member variable in PrintMsg_Print_Params.
(2) Removed |fit_to_page_| from PrintWebViewHelper.
(3) Modified PrintWebViewHelper member functions accordingly.
BUG=85132
TEST=none
Review URL: http://codereview.chromium.org/10142002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds a check in the window.print call to make window.print fail if called from a blocked popup.
Creates a new notification sent by BlockedContentTabHelper to let other parts of the code know about the state of blocked content.
Based off of https://chromiumcodereview.appspot.com/9762004.
Also adds handling to print_preview_tab_controller.cc to mark preview as done if the creation of the print preview ui fails.
BUG=117955
TEST=Open test page attached to bug 117955. Allow the blocked popup. Ctrl-P should work normally.
R=thestig@chromium.org
Review URL: http://codereview.chromium.org/9815014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128349 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=104080
TEST= Please refer to bug report.
Review URL: http://codereview.chromium.org/9699040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
saving to PDF. Also fix the print preview state machine in PrintViewManager.
BUG=105640,110100
TEST=See minimal test case in bug 110100.
Review URL: http://codereview.chromium.org/9112052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=104210, 100819
TEST=Added PrintWebViewHelperPreviewTests.
Review URL: http://codereview.chromium.org/8585017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(printable_size => content_size).
|printable_size| is a misnomer. |content_size| is correct.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8784012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=105933
TEST=see bug.
Review URL: http://codereview.chromium.org/8761014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=92107
TEST=see bug
Review URL: http://codereview.chromium.org/8515017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a reland of http://codereview.chromium.org/8351048/ with minor changes
to fix the compilation errors on the shared builders.
BUG=102446
TEST=See bug description.
Review URL: http://codereview.chromium.org/8528053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110055 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL makes "Custom" margins sticky across different preview sessions but also within the same preview session.
Here is a summary of all changes.
- Within same preview session: So far selecting "Custom" was
picking up from whatever the previous selected option was.
Now, "Custom" remembers the specified margins. To test this
select "Custom", do some dragging, then change to another
option and back to "Custom".
- Across preview sessions: Select "Custom", do some dragging,
then print. Open print preview again, the last used custom
margins are remembered.
- There was a bunch of messages sent from JS to get various
info/settings (initiator tab title, measurement system and
number format, last used margin settings, default printer).
I created a single message "getInitialSettings" to get all
at once (they are needed before the 1st preview is is
requested).
BUG=102446
TEST=See bug description.
Review URL: http://codereview.chromium.org/8351048
TBR=dpapad@chromium.org
Review URL: http://codereview.chromium.org/8564040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL makes "Custom" margins sticky across different preview sessions but also within the same preview session.
Here is a summary of all changes.
- Within same preview session: So far selecting "Custom" was
picking up from whatever the previous selected option was.
Now, "Custom" remembers the specified margins. To test this
select "Custom", do some dragging, then change to another
option and back to "Custom".
- Across preview sessions: Select "Custom", do some dragging,
then print. Open print preview again, the last used custom
margins are remembered.
- There was a bunch of messages sent from JS to get various
info/settings (initiator tab title, measurement system and
number format, last used margin settings, default printer).
I created a single message "getInitialSettings" to get all
at once (they are needed before the 1st preview is is
requested).
BUG=102446
TEST=See bug description.
Review URL: http://codereview.chromium.org/8351048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
remove an unneeded prefs check.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8386028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108378 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It seems that this is where it is supposed to live and it was erroneously added to PrintWebViewHelper.
BUG=67091, 92045, 91880, 92000, 92218, 95905
TEST=NONE
Review URL: http://codereview.chromium.org/8201027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105688 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7970021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7826002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99310 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=94082
TEST=none
Review URL: http://codereview.chromium.org/7740005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On page selection, regenerate the complete document with the selection, but preserve the existing draft pages and simply display a subset of them.
Added a new param |clear all preview data| to |PrintHostMsg_DidGetPreviewPageCount|.
BUG=84383
TEST=print preview works after code changes.
Review URL: http://codereview.chromium.org/7647010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The UI for margin options are hidden by default.
BUG=69337
TEST=
There is currently minimal UI for testing this. The custom margins option does nothing. You can however click the no margins option to see the page print without margins.
Review URL: http://codereview.chromium.org/7552033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
sync messages. The sync messages now go to the IO thread to avoid the potential deadlock on Windows.
BUG=91057, and probably a few more.
TEST=included.
Review URL: http://codereview.chromium.org/7621087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
for resetting the values of the member vars of the struct (used in place of calling memset(0) )
BUG=93508
TEST=
1. open print preview
2. click advanced
3. cancel the native print dialog
Ensure that browser doesn't crash.
Review URL: http://codereview.chromium.org/7693017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=67514
TEST=
In the preview tab, note added options for printing headers and footers. Toggle with the checkbox and ensure that the correct headers and footers are displayed.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97219
Review URL: http://codereview.chromium.org/7348010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Skia
BUG=67514
TEST=
In the preview tab, note added options for printing headers and footers. Toggle with the checkbox and ensure that the correct headers and footers are displayed.
Review URL: http://codereview.chromium.org/7348010
TBR=aayushkumar@chromium.org
Review URL: http://codereview.chromium.org/7670045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=67514
TEST=
In the preview tab, note added options for printing headers and footers. Toggle with the checkbox and ensure that the correct headers and footers are displayed.
Review URL: http://codereview.chromium.org/7348010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that pending preview requests are being canceled when a new request is issued, the event listeners of the printing controls should not check for |hasPendingPreviewRequest| before issuing new requests, instead they should immediately request a new preview so that the previous one is canceled.
Also all functions that are associated with a specific print request should get the requestID as a parameter, in order to ignore obsolete responses.
I found out that when the print preview tab is reloaded, responses from requests before the reload are reaching the ui code. If reloading the preview tab repeatedly all these request have id=0 and are not being ignored as they should. Therefore I changed the id of the initial request to have a random variable.
BUG=91556, 91769
TEST=See bug description
Review URL: http://codereview.chromium.org/7550022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
require a rerendering of draft pages.
On page selection, regenerate the complete document with the selection, but preserve the existing draft pages and simply display a subset of them.
1. Added a new param |clear all preview data| to |PrintHostMsg_DidGetPreviewPageCount|.
2. Removed |requested_preview_page_index| from |PrintMsg_ContinuePreview|
Review URL: http://codereview.chromium.org/7544018
Original Commit: http://src.chromium.org/viewvc/chrome?view=rev&revision=96406
Revert Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96414
BUG=84383
TEST=print preview works after code changes.
Review URL: http://codereview.chromium.org/7628019
TBR=kmadhusu@chromium.org
Review URL: http://codereview.chromium.org/7639023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of draft pages.
On page selection, regenerate the complete document with the selection, but preserve the existing draft pages and simply display a subset of them.
1. Added a new param |clear all preview data| to |PrintHostMsg_DidGetPreviewPageCount|.
2. Removed |requested_preview_page_index| from |PrintMsg_ContinuePreview|
Review URL: http://codereview.chromium.org/7544018
Original Commit: http://src.chromium.org/viewvc/chrome?view=rev&revision=96406
Revert Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96414
BUG=84383
TEST=print preview works after code changes.
Review URL: http://codereview.chromium.org/7628019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96567 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of draft pages.
On page selection, regenerate the complete document with the selection, but preserve the existing draft pages and simply display a subset of them.
1. Added a new param |clear all preview data| to |PrintHostMsg_DidGetPreviewPageCount|.
2. Removed |requested_preview_page_index| from |PrintMsg_ContinuePreview|
BUG=84383
TEST=print preview works after code changes.
Review URL: http://codereview.chromium.org/7544018
TBR=kmadhusu@chromium.org
Review URL: http://codereview.chromium.org/7618014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On page selection, regenerate the complete document with the selection, but preserve the existing draft pages and simply display a subset of them.
1. Added a new param |clear all preview data| to |PrintHostMsg_DidGetPreviewPageCount|.
2. Removed |requested_preview_page_index| from |PrintMsg_ContinuePreview|
BUG=84383
TEST=print preview works after code changes.
Review URL: http://codereview.chromium.org/7544018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and |page_slot| from PrintMsg_PrintPage_Params.
We will not add preview pages to the complete metafile in out of order fashion.
BUG=none
TEST=print preview works after code changes.
Review URL: http://codereview.chromium.org/7549001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95092 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previous review comments:
http://codereview.chromium.org/7395016/
http://codereview.chromium.org/7210042/
BUG=88762
TEST=NONE
Review URL: http://codereview.chromium.org/7495003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94066 0039d316-1c4b-4281-b951-d872f2087c98
|