| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
bookmark-only columns. Add getters and setters for BookmarkSpecifics to
syncapi as well as syncable entries. Make the datatype be a required
property when creating a syncapi node. Add a datatype for the 'google
chrome' top level folder. Add database migrations from version 67 to
the new schema. Add infrastructure to support migrations generically.
Add unit tests for the migrations.
Pull a new version of the protobuf library to pick up a fix for a
bug that this change exposed (I upstreamed the fix).
Fix some example code in the sql helpers so that it would actually
compile.
BUG=29899,30041
TEST=New unit tests for migrations: unit tests are based on actual
database dumps. Additionally, I manually tested 2-client sync using
combos of old-protocol servers, new-protocol servers, and initial
database versions v67, v68, and v0 (new client). I manually verified
that add/edit/delete works in these combination cases. Afterwards I
verified (by inspecting the sync databases) that the ModelTypes are
consistent across the various migration/protocol paths.
Review URL: http://codereview.chromium.org/554066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37253 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=yaar
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/305002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29549 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Got plenty of crashes in 4.0.211.4
BUG=11908
TEST=none
TBR=bretw
Review URL: http://codereview.chromium.org/217007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
How do you guys feel about trying this pach for a few days?
The idea is to have devs that run their own build to help us test
wether or not we are having serious errors.
I'll monitor the crash server to see if we get crashes here
BUG=11908
TEST=none
Review URL: http://codereview.chromium.org/195020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- This CL is the skeleton of the approach, does not change current behavior
- Right now only detects errors for the SQLStatement::step calls
TEST=none
BUG=11908
Review URL: http://codereview.chromium.org/174090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24321 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We have a local patch to sqlite which adds a sqlite3Preload function.
In the interim before this patch is upstreamed, we add this stub
function to allow us to compile with a system sqlite.
(Reported by fta)
http://codereview.chromium.org/173033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Modify LoginDatabase slightly to give PasswordStoreMac enough information to do the right thing.
Add creator code for keychain items we create, and unit tests to make sure.
BUG=11745
TEST=Visit a site for which you have a password in the Keychain. Type your username, unfocus the field, and then log in with the filled password. Log out, return to the login page, and the username and password should now autofill without user interaction.
Review URL: http://codereview.chromium.org/151176
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19822 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Patch by rohitrao@google.com
http://codereview.chromium.org/40001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Normalize end of file newlines in chrome/. All files end in a single newline.
Review URL: http://codereview.chromium.org/42015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
for example Linux.
The problem was that old code assumed wstring is UTF-16, which resulted
in string corruption on Linux. I actually tested it on browser/history
unit tests, see http://codereview.chromium.org/18758.
Review URL: http://codereview.chromium.org/18805
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
* wstring -> FilePath
* create versions of WriteFile/ReadFile with FilePath signatures
Review URL: http://codereview.chromium.org/19610
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
little dangerous because it can return NULL. Most STL string stuff can't handle this. I changed the uses to column_string() which handles NULL properly and generates STL strings for us.
BUG=3770
Review URL: http://codereview.chromium.org/9189
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4811 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Applied glint.
No code change, just moving around.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15 0039d316-1c4b-4281-b951-d872f2087c98
|