| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
For context see this thread:
https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II
TBR=thakis,pkasting,jam
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL changes ThumbnailGenerator to accept wider than tall pages as good clipping, and penalize its boring score instead.
On devices with a small display (and especially under Aura shell), most pages are wider than tall, so good clipping is rarely obtained and almost every tab switching causes to generate thumbnail without this change.
BUG=96351
TEST=Manually checked that wider than tall bitmap is accepted as good clipping in ThumbnailGenerator.
Review URL: http://codereview.chromium.org/9720039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=94925
TEST=none
Review URL: http://codereview.chromium.org/7839019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Thumbnails taken while page loading may only contain partial contents,
hence these are not desirable.
BUG=65936
TEST=with --enable-in-browser-thumbnailing --vmodule=thumbnail_generator=1, confirm that thumbnails taken while page loading were replaced with new ones properly.
Review URL: http://codereview.chromium.org/6962008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87284 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The change broke the tsan (ThreadSanitizer) build:
http://build.chromium.org/p/chromium.memory/builders/Linux%20Tests%20%28tsan%29/builds/3164
Thumbnails taken while page loading may only contain partial contents,
hence these are not desirable.
BUG=65936
TEST=with --enable-in-browser-thumbnailing --vmodule=thumbnail_generator=1, confirm that thumbnails taken while page loading were replaced with new ones properly.
Review URL: http://codereview.chromium.org/6962008
TBR=satorux@chromium.org
Review URL: http://codereview.chromium.org/7094002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Thumbnails taken while page loading may only contain partial contents,
hence these are not desirable.
BUG=65936
TEST=with --enable-in-browser-thumbnailing --vmodule=thumbnail_generator=1, confirm that thumbnails taken while page loading were replaced with new ones properly.
Review URL: http://codereview.chromium.org/6962008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87264 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The absolute boring score is not suitable for judging a thumbnail is actually
boring or not. For instance, www.google.com is very succinct so the boring
score can be as high as 0.9, where 1 is the maximum. This score should only
be used for comparing two thumbnails taken from the same page to see which one
is more boring/interesting.
BUG=65936
TEST=with --enable-in-browser-thumbnailing --vmodule=thumbnail_generator=1, confirm that the thumbnail is not updated very often for www.google.com.
Review URL: http://codereview.chromium.org/7071008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
More specifically, skip thumbnail generation in the following occasions:
- The browser is in the off-the-record mode.
- The URL is not valid for top sites (ex. new tab pages, etc.)
- The existing thumbnail is new and interesting enough.
This patch should reduce the number of thumbnail generations significantly.
BUG=65936
TEST=add unit tests. confirm that the thumbnails are updated as expected.
Review URL: http://codereview.chromium.org/6389001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72763 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=50273
TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux
TBR: erg
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the really hard ones which will need actual review instead of rubber-stamping.)
Review URL: http://codereview.chromium.org/386026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the thumbnail database, and will also replace the ThumbnailStore which was the
previous replacement we didn't ship. This component will be very much like the
ThumbnailStore wtih the addition of the actual most visited data (not just
thumbnails) and that it is threadsafe.
This class is designed to be called on any thread. When it is complete,
thumbnails will be added to it from the UI thread of the browser. Requests for
thumbnails and the most visited data can be serviced directly on the I/O thread
without going through the UI thread, and since the data is cached, the request
won't also have to go through the history thread.
The current state is that it cqan store and update the the most visited list and thumbnails. There are unit tests covering this behavior.
I also added support for redirect ranking to ThumbnailScore. This is to
duplicated the ranking function in history currently, where it prefers
thumbnails closer to the end of a redirect chain. Since we won't be using the
history service and are only storing thumbnails for the most visited items, we
have to track the redirect index ourselves.
BUG=none
TEST=covered by unit tests (hopefully!)
Review URL: http://codereview.chromium.org/251002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27824 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Normalize end of file newlines in chrome/. All files end in a single newline.
Review URL: http://codereview.chromium.org/42015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7995
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4022 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15 0039d316-1c4b-4281-b951-d872f2087c98
|