summaryrefslogtreecommitdiffstats
path: root/chrome/common/thumbnail_score.h
Commit message (Collapse)AuthorAgeFilesLines
* Remove the rest of #pragma once in one big CL.ajwong@chromium.org2012-07-111-1/+0
| | | | | | | | | For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
* Allow wider than tall clipping as good clipping and add kTooWiderThanTall.mazda@chromium.org2012-03-201-4/+9
| | | | | | | | | | | | This CL changes ThumbnailGenerator to accept wider than tall pages as good clipping, and penalize its boring score instead. On devices with a small display (and especially under Aura shell), most pages are wider than tall, so good clipping is rarely obtained and almost every tab switching causes to generate thumbnail without this change. BUG=96351 TEST=Manually checked that wider than tall bitmap is accepted as good clipping in ThumbnailGenerator. Review URL: http://codereview.chromium.org/9720039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127779 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a static initializer in thumbnail_score.othakis@chromium.org2011-09-071-1/+1
| | | | | | | | | | BUG=94925 TEST=none Review URL: http://codereview.chromium.org/7839019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99908 0039d316-1c4b-4281-b951-d872f2087c98
* Add load_completed property to ThumbnailScore.satorux@chromium.org2011-05-311-1/+6
| | | | | | | | | | | | Thumbnails taken while page loading may only contain partial contents, hence these are not desirable. BUG=65936 TEST=with --enable-in-browser-thumbnailing --vmodule=thumbnail_generator=1, confirm that thumbnails taken while page loading were replaced with new ones properly. Review URL: http://codereview.chromium.org/6962008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87284 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 87264 - Add load_completed property to ThumbnailScore.satorux@chromium.org2011-05-311-6/+1
| | | | | | | | | | | | | | | | | | | The change broke the tsan (ThreadSanitizer) build: http://build.chromium.org/p/chromium.memory/builders/Linux%20Tests%20%28tsan%29/builds/3164 Thumbnails taken while page loading may only contain partial contents, hence these are not desirable. BUG=65936 TEST=with --enable-in-browser-thumbnailing --vmodule=thumbnail_generator=1, confirm that thumbnails taken while page loading were replaced with new ones properly. Review URL: http://codereview.chromium.org/6962008 TBR=satorux@chromium.org Review URL: http://codereview.chromium.org/7094002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87274 0039d316-1c4b-4281-b951-d872f2087c98
* Add load_completed property to ThumbnailScore.satorux@chromium.org2011-05-311-1/+6
| | | | | | | | | | | | Thumbnails taken while page loading may only contain partial contents, hence these are not desirable. BUG=65936 TEST=with --enable-in-browser-thumbnailing --vmodule=thumbnail_generator=1, confirm that thumbnails taken while page loading were replaced with new ones properly. Review URL: http://codereview.chromium.org/6962008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87264 0039d316-1c4b-4281-b951-d872f2087c98
* Stop using the boring score for judging we should update a thumbnail or not.satorux@chromium.org2011-05-271-0/+7
| | | | | | | | | | | | | | | The absolute boring score is not suitable for judging a thumbnail is actually boring or not. For instance, www.google.com is very succinct so the boring score can be as high as 0.9, where 1 is the maximum. This score should only be used for comparing two thumbnails taken from the same page to see which one is more boring/interesting. BUG=65936 TEST=with --enable-in-browser-thumbnailing --vmodule=thumbnail_generator=1, confirm that the thumbnail is not updated very often for www.google.com. Review URL: http://codereview.chromium.org/7071008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86965 0039d316-1c4b-4281-b951-d872f2087c98
* Add heuristics to skip thumbnail generation when it's unnecessary.satorux@chromium.org2011-01-271-0/+13
| | | | | | | | | | | | | | | | More specifically, skip thumbnail generation in the following occasions: - The browser is in the off-the-record mode. - The URL is not valid for top sites (ex. new tab pages, etc.) - The existing thumbnail is new and interesting enough. This patch should reduce the number of thumbnail generations significantly. BUG=65936 TEST=add unit tests. confirm that the thumbnails are updated as expected. Review URL: http://codereview.chromium.org/6389001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72763 0039d316-1c4b-4281-b951-d872f2087c98
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-261-0/+1
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes almost all of the rest of lint errors in the chrome/ directory (minus ↵erg@google.com2009-11-131-3/+3
| | | | | | | | the really hard ones which will need actual review instead of rubber-stamping.) Review URL: http://codereview.chromium.org/386026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31932 0039d316-1c4b-4281-b951-d872f2087c98
* Add some initial code for the top sites service. This will be a replacement forbrettw@chromium.org2009-10-021-3/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | the thumbnail database, and will also replace the ThumbnailStore which was the previous replacement we didn't ship. This component will be very much like the ThumbnailStore wtih the addition of the actual most visited data (not just thumbnails) and that it is threadsafe. This class is designed to be called on any thread. When it is complete, thumbnails will be added to it from the UI thread of the browser. Requests for thumbnails and the most visited data can be serviced directly on the I/O thread without going through the UI thread, and since the data is cached, the request won't also have to go through the history thread. The current state is that it cqan store and update the the most visited list and thumbnails. There are unit tests covering this behavior. I also added support for redirect ranking to ThumbnailScore. This is to duplicated the ranking function in history currently, where it prefers thumbnails closer to the end of a redirect chain. Since we won't be using the history service and are only storing thumbnails for the most visited items, we have to track the redirect index ourselves. BUG=none TEST=covered by unit tests (hopefully!) Review URL: http://codereview.chromium.org/251002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27824 0039d316-1c4b-4281-b951-d872f2087c98
* NO CODE CHANGEdeanm@chromium.org2009-03-101-1/+0
| | | | | | | | | Normalize end of file newlines in chrome/. All files end in a single newline. Review URL: http://codereview.chromium.org/42015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11331 0039d316-1c4b-4281-b951-d872f2087c98
* Move Time, TimeDelta and TimeTicks into namespace base.dsh@google.com2008-10-271-3/+3
| | | | | | Review URL: http://codereview.chromium.org/7995 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4022 0039d316-1c4b-4281-b951-d872f2087c98
* Use a more compact license header in source files.license.bot2008-08-241-28/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1287 0039d316-1c4b-4281-b951-d872f2087c98
* Add chrome to the repository.initial.commit2008-07-261-0/+92
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15 0039d316-1c4b-4281-b951-d872f2087c98