summaryrefslogtreecommitdiffstats
path: root/chrome/common/translate_errors.h
Commit message (Collapse)AuthorAgeFilesLines
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-261-0/+1
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* When Chrome translates a page, the translate server might detect that the ↵jcivelli@chromium.org2010-07-191-0/+2
| | | | | | | | | | | | | | page is in a different language than the one Chrome detected. If that language is not in the list of languages that Chrome supports for translation, then we do not know what to show and we were crashing. This CL makes it so that we show an error infobar instead. Note that in the future we should improve the "after translate" infobar to support showing the original language as unknown. (http://crbug.com/9390) BUG=48918 TEST=Not sure how to test without changing the code. Review URL: http://codereview.chromium.org/3011008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52876 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support for language detection on the server side.jcivelli@chromium.org2010-06-301-2/+4
| | | | | | | | | | | | | | | | | Relanding: http://codereview.chromium.org/2860037 The CLD can sometimes fail to detect the language of a page, in which case the translate server might be able to. This CL ensures the browser deals with the server side language detection properly. Also added a new factory method to create error translate infobar delegates that does not assert when the language code is incorrect. Also changed the enums in TranslateInfoBarDelegate2 to use the constant name style, as it is the preferred naming for enums according to the style guide. BUG=40857 TEST=Visit http://www.saanconf.org/saanday.htm, use the context menu to translate the page. You should get an error mentioning the page is already in English. Review URL: http://codereview.chromium.org/2854032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51288 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 51263 (breaks the Linux views build)jcivelli@chromium.org2010-06-301-4/+2
| | | | | | | | | | | | | | | | | | | | | | | | Adds support for language detection on the server side. The CLD can sometimes fail to detect the language of a page, in which case the translate server might be able to. This CL ensures the browser deals with the server side language detection properly. Also added a new factory method to create error translate infobar delegates that does not assert when the language code is incorrect. Also changed the enums in TranslateInfoBarDelegate2 to use the constant name style, as it is the preferred naming for enums according to the style guide. Original review: http://codereview.chromium.org/2859013/show BUG=40857 TEST=Visit http://www.saanconf.org/saanday.htm, use the context menu to translate the page. You should get an error mentioning the page is already in English. Review URL: http://codereview.chromium.org/2860037 TBR=jcivelli@chromium.org Review URL: http://codereview.chromium.org/2873035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51265 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support for language detection on the server side.jcivelli@chromium.org2010-06-301-2/+4
| | | | | | | | | | | | | | | | | | | | The CLD can sometimes fail to detect the language of a page, in which case the translate server might be able to. This CL ensures the browser deals with the server side language detection properly. Also added a new factory method to create error translate infobar delegates that does not assert when the language code is incorrect. Also changed the enums in TranslateInfoBarDelegate2 to use the constant name style, as it is the preferred naming for enums according to the style guide. Original review: http://codereview.chromium.org/2859013/show BUG=40857 TEST=Visit http://www.saanconf.org/saanday.htm, use the context menu to translate the page. You should get an error mentioning the page is already in English. Review URL: http://codereview.chromium.org/2860037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51263 0039d316-1c4b-4281-b951-d872f2087c98
* Changing the translate back-end to use the Google Translate element.jcivelli@google.com2010-04-061-2/+4
| | | | | | | | | | | | | | | | When the user indicates that a page should be translated, the browser first fetches the Google Translate Element JS code. It then sends it to the renderer, which injects the script in the page, waits for the Translate element to be initialized and then calls the translate method on it. The TranslationService class previously used to translate text chunks is now unused and has been removed. Some of its static methods that are still used have been moved to the TranslateManager class. This CL also implements the "revert" translation behavior. BUG=35474,37778,35553,39375 TEST=Test the translation feature extensively. Review URL: http://codereview.chromium.org/1599016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43768 0039d316-1c4b-4281-b951-d872f2087c98
* reland cl that implement error state for translate infobarkuan@chromium.org2010-03-291-0/+24
| | | | | | | | | | | | - original review URL: http://codereview.chromium.org/1321003 - this reland fixes uniitest build break in translate_manager_unittest.cc BUG=38548 TEST=none yet (details in original review url) Review URL: http://codereview.chromium.org/1542003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42976 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "implement error state for translate infobar"phajdan.jr@chromium.org2010-03-291-24/+0
| | | | | | | | | | | Due to broken build (compile). TBR=kuan BUG=38548 Review URL: http://codereview.chromium.org/1567001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42955 0039d316-1c4b-4281-b951-d872f2087c98
* implement error state for translate infobarkuan@chromium.org2010-03-291-0/+24
- this cl implements the UI on Windows and the partial backend of IPC messaging to include error type - implement error state - add translate error types - use a structure as details for IPC messaging between render view and browser so as to include error type (was using std::pair) - translate delegate handles error state and provides mapping to error messages - infobar handles visual error states - modify background painting to handle normal and error backgrounds, and animation of cross-fading between the 2 backgrounds - infobar now stores state (and translation_pending flag) that it's currently displaying to user, instead of just relying on TransateInfoBarDelegate's - if infobar receives PAGE_TRANSLAED notification before delegate does (possible because order is not fixed), delegate's state won't be updated to be used by infobar. - after all the observers have received the notification, both infobar and delegate will end up with matching states, so there's no worries of out-of-sync. - update unittests accordingly - update mac and linux code accordingly to make build pass - jay will implement the remaining backend to pass actual translate error types to the IPC message (tracked by bug 37778) BUG=38548 TEST=none yet, until bug 37778 is also fixed. Review URL: http://codereview.chromium.org/1321003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42953 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-30 15:27:16 +0000