| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
the bug is not there either.
Review URL: http://codereview.chromium.org/56033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
save dialog on Windows 7.
BUG: 8409
Review URL: http://codereview.chromium.org/42666
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12621 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Note that this only works if you are using a gnome or kde session. Support for other sessions will be added in the future.
Review URL: http://codereview.chromium.org/52034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12395 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is very similar to r10845, but also includes a regression fix for issue 8410, where locking and unlocking the screen would cause mispositioning of child content.
BUG=20,8410
Review URL: http://codereview.chromium.org/42027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Fix files with lines > 80 cols. Part 2.
Review URL: http://codereview.chromium.org/40226
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11284 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are a few caveats here:
* On Aero glass, if the auto-hide taskbar is at the top of the screen, we get one row of nonclient pixels along the bottom of the screen (not too noticeable for light-colored pages, looks a bit odd with a dark page). I can't find a way around this.
* Switching between fullscreen and normal mode can leave things a bit confused until you click another app and then reactivate Chromium. This seems to happen with other applications too (e.g. Firefox fullscreen mode) so I'm not too worried.
* Chromium does not deal well with toggling the taskbar's auto-hide setting (or, I think, its position?) unless you restore and remaximize the window. I tried to fix this via modified handling of WM_SETTINGCHANGE but only made things worse and so gave up.
BUG=20
Review URL: http://codereview.chromium.org/28338
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the headers too.
Review URL: http://codereview.chromium.org/21472
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10167 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The save dialog code attempts to generate a file extension based on
the suggested name provided to it, which in the case of saving a web
page is the title. If that title contains a '.' character, it treats
anything that follows as the file extension and appends it to the name
the user selects.
For example, saving a page with the title "Google Inc. - A search engine"
and the user choosing the save name as "Google" will result in the saved
file being named "Google. - A search engine.htm" when it should be
"Google.htm".
In the case of saving a web page, we can ignore trying to figure out
the file extension since we already know it will be ".htm".
BUG=6105 (http://crbug.com/6105)
Review URL: http://codereview.chromium.org/18699
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
.cc file.
Instead of modifying all of the depending .scons and .vcproj files, I'm just removing the DCHECK() I had added and moving the calls back into the header file where they were to begin with.
Review URL: http://codereview.chromium.org/17350
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/17348
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(Fixed up version of issue 17032. Now passes all unit tests.)
Review URL: http://codereview.chromium.org/16533
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of type instead of *.html.
BUG=4479
TEST=Bring up the bookmark manager, click tools->import. Make sure the
import dialog 'files of type' has something like 'Chrome Document'
(although this depends upon your registry), and that selecting it
shows all html and htm files. Additionally make sure you have 'all
files' in the 'files of type' combobox too.
Review URL: http://codereview.chromium.org/14025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a file in Windows Explorer. IShellFolder::ParseDisplayName will fail
when the directory is a raw drive letter like "C:" instead of "C:\\".
This situation can occur if a user downloads a file to the "C:"
directory and then attempts to run the UI command "Show in folder".
BUG = http://crbug.com/4396
Review URL: http://codereview.chromium.org/14030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
of the SaveFileAsWithFilter function (after splitting
it out to a separate function).
Review URL: http://codereview.chromium.org/13637
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6618 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
incorrectly for monitors with an origin < 0 along either axis.
BUG=5059
TEST=see bug
Review URL: http://codereview.chromium.org/13100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6300 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We were not supplying a filter list for the Save As dialog.
Now that we do, the user can select between, for example, say *.jpg and *.* as filters and we behave as follows:
With a *.jpg filter active, user enters foo and we save the file as: foo.jpg
With a *.jpg filter active, user enters foo. and we save the file as: foo..jpg (which is consistent with IE)
With a *.jpg filter active, user enters foo.jpg, we save the file as: foo.jpg
With a *.jpg filter active, user enters foo.jpeg, we save the file as: foo.jpeg (not foo.jpg or foo.jpeg.jpg)
With a *.* filter active, we respect whatever user enters as extension, except if the filename contains one or more trailing dots then we strip out all those trailing dots.
Also test filenames created when saving web pages, as opposed to images (should work as before).
Review URL: http://codereview.chromium.org/12836
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the user specifies a filename without an extension, such as "foo" instead of "foo.gif", we would append "gif" to the filename instead of ".gif" (so the user ends up with a file named "foogif").
I'm not confident this is the only thing wrong with this function. For example if the user specifies "foo." and the filter says "*.gif" shouldn't we add ".gif" to the filename instead of deleting the dot?
Also, we seem to be ignoring the default_extension parameter passed in when we figure out what extension to tack on and instead get the file extension from GetFileExtensionFromPath... :s
Review URL: http://codereview.chromium.org/12838
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the ability to dock to the following locations:
Maximize the window on drop.
Resize the window to fill up the left, bottom, or right half of the
monitor.
Tile the newly created window with an existing chrome window such that
the two are on top of each other and fill the height of the monitor,
or tiled such that they fill the width of the monitor.
The graphics suxor. Glen says he'll come up with something better once
its landed.
BUG=none
TEST=4628
Review URL: http://codereview.chromium.org/11325
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=4287
TEST=see bug
Review URL: http://codereview.chromium.org/10621
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5304 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/3376
Review URL: http://codereview.chromium.org/7274
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3307 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implement "iframe shim" behavior for windowed plugins.
In FF and IE on windows, iframes are implemented as native HWNDs.
This has the side effect that iframes display on top of windowed
plugins. This side effect has long been known as a workaround for
allowing HTML elements to appear above plugin content.
BUG=1788
Review URL: http://codereview.chromium.org/7032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
bookmarks is failing for some people. As a result of this I moved some
code from common/win_util to base/win_util so that file_util_win could
call it. The only changes to this code are formatting.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2931
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2312 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
was an issue
with Adobe reader retaining an open handle to the chrome application folder causing issues
with subsequent installs.
This was because we did not specify the current directory in the ShellExecute call. This resulted
in the chrome application folder becoming the current directory and hence the issue.
Bug=2321
Review URL: http://codereview.chromium.org/3092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=1327320
Review URL: http://codereview.chromium.org/1864
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
MAX_PATH not MAX_PATH+1 to GetSaveFileName, and log failures better.
Review URL: http://codereview.chromium.org/1609
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1807
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1828 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
B=1362425
Review URL: http://codereview.chromium.org/476
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1810 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15 0039d316-1c4b-4281-b951-d872f2087c98
|