summaryrefslogtreecommitdiffstats
path: root/chrome/common/zip_unittest.cc
Commit message (Collapse)AuthorAgeFilesLines
* If we can't read a unicode character, write the standard "unknown" (0xFFFD) ↵cevans@chromium.org2010-01-011-25/+17
| | | | | | | | | | | character. This will prevent security issues where the current behaviour can be used to strip characters out of a string after it has passed some validation. BUG=30798 TEST=utf_string_conversions_unittest.cc,utf_offset_string_conversions_unittest.cc,zip_unittest.cc Review URL: http://codereview.chromium.org/522029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35430 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a path traversal issue in extension unpacking. Because of the sandbox, ↵aa@chromium.org2009-11-191-0/+14
| | | | | | | | this was not exploitable, but still a good thing to fix. Review URL: http://codereview.chromium.org/399063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32502 0039d316-1c4b-4281-b951-d872f2087c98
* Filter out hidden files, both when loading extensions and whenaa@chromium.org2009-10-281-9/+33
| | | | | | | | | | | | | packaging them. We also special case the common OS X zip dropping "__MACOSX" when loading extensions. BUG=23004 Review URL: http://codereview.chromium.org/340018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30312 0039d316-1c4b-4281-b951-d872f2087c98
* Fix temp file leak in ZipTest.thestig@chromium.org2009-09-021-12/+8
| | | | | | | | BUG=none TEST=Run ZipTest, make sure it doesn't leave temporary files around. Review URL: http://codereview.chromium.org/177058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25144 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid directory traversal attacks when unpacking zips. The sandbox would tendcevans@chromium.org2009-07-231-7/+19
| | | | | | | | | | | | | to catch & deny this, but the Linux and Mac port does not yet do extension packing inside the sandbox. Therefore, reject any filenames in the zip which have .. in them. BUG=NONE TEST=ZipTest.UnzipEvil Review URL: http://codereview.chromium.org/160028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21460 0039d316-1c4b-4281-b951-d872f2087c98
* Include a parent directory link in the file list for file:///somepathyuzo@chromium.org2009-06-091-1/+3
| | | | | | | | | | | | | | | Also, order files/directories lexicographically. TEST=on linux, type file:///usr/ in the address bar and make sure the contents are sorted and include an entry for '..', which is [parent directory]. On windows, type file:///C:/Users/ . BUG=12621, 12812 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17933 0039d316-1c4b-4281-b951-d872f2087c98
* Broaden valgrind supression for known issue in zlib. This seems ok because ↵aa@chromium.org2009-06-011-4/+2
| | | | | | | | | | this code changes infrequently. Re-enable zip unit tests on mac. Review URL: http://codereview.chromium.org/118087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17369 0039d316-1c4b-4281-b951-d872f2087c98
* Disable ZipTest on mac (valgrind memory issue)rafaelw@chromium.org2009-06-011-2/+4
| | | | | | Review URL: http://codereview.chromium.org/118077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17333 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable zip unit tests.aa@chromium.org2009-06-011-4/+0
| | | | | | | | Git's empty directory issue strikes again. Review URL: http://codereview.chromium.org/115985 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17310 0039d316-1c4b-4281-b951-d872f2087c98
* Disable zip tests while trying to figure out problem.aa@chromium.org2009-06-011-1/+2
| | | | | | Review URL: http://codereview.chromium.org/114066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17308 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bustage again.aa@chromium.org2009-06-011-1/+1
| | | | | | Review URL: http://codereview.chromium.org/115982 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17307 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bustage.aa@chromium.org2009-06-011-3/+6
| | | | | | Review URL: http://codereview.chromium.org/118067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17306 0039d316-1c4b-4281-b951-d872f2087c98
* Implements a Zip() utility function. Refactor existingaa@chromium.org2009-06-011-0/+105
Unzip-relatedness into shared locations. Review URL: http://codereview.chromium.org/118028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17305 0039d316-1c4b-4281-b951-d872f2087c98