summaryrefslogtreecommitdiffstats
path: root/chrome/common
Commit message (Collapse)AuthorAgeFilesLines
* Disable the Protector feature.scr@chromium.org2012-01-052-6/+6
| | | | | | | | | | | R=sky@chromium.org BUG=109229 TEST= Review URL: http://codereview.chromium.org/9109005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116539 0039d316-1c4b-4281-b951-d872f2087c98
* Mark ImportantFileWriterTest.BatchingWrites as flaky.asvitkine@chromium.org2012-01-051-2/+3
| | | | | | | | TBR=phajdan.jr@chromium.org BUG=109292 Review URL: http://codereview.chromium.org/9112017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116523 0039d316-1c4b-4281-b951-d872f2087c98
* Add tests for the page visibility, position, and clip in the new view API. ↵brettw@chromium.org2012-01-051-8/+18
| | | | | | | | This adds some additional capabilities to the UI test framework to support navigating background tabs. Review URL: http://codereview.chromium.org/9034001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116507 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 116488 - Makes detached tab dragging create a real browser. It's ↵sky@chromium.org2012-01-053-11/+3
| | | | | | | | | | | | | | | | | | enabled on aura (not in compact mode) and behind a flag on windows. BUG=98345 TEST=make sure tab dragging still works on aura and windows both with and without the flag 'Enable Tab Browser Dragging' enabled. R=ben@chromium.org Review URL: http://codereview.chromium.org/8983025 TBR=sky@chromium.org Review URL: http://codereview.chromium.org/9108012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116499 0039d316-1c4b-4281-b951-d872f2087c98
* Makes detached tab dragging create a real browser. It's enabled onsky@chromium.org2012-01-053-3/+11
| | | | | | | | | | | | | aura (not in compact mode) and behind a flag on windows. BUG=98345 TEST=make sure tab dragging still works on aura and windows both with and without the flag 'Enable Tab Browser Dragging' enabled. R=ben@chromium.org Review URL: http://codereview.chromium.org/8983025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116488 0039d316-1c4b-4281-b951-d872f2087c98
* Marking ExtensionUnpackerTest.EmptyDefaultLocale as flake on Windows. See ↵dslomov@chromium.org2012-01-051-2/+9
| | | | | | | | | | http://crbug.com/109238 TBR=cira@chromium.org,RDevlin.Cronin@gmail.com Review URL: http://codereview.chromium.org/9108006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116463 0039d316-1c4b-4281-b951-d872f2087c98
* Add stubs to options menu for additional accessibility featureszork@chromium.org2012-01-052-2/+11
| | | | | | | | | | | R=dmazzoni@chromium.org BUG=None TEST=None Review URL: http://codereview.chromium.org/8932002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116447 0039d316-1c4b-4281-b951-d872f2087c98
* Remove deprecated page action features from manifest v2.aa@chromium.org2012-01-0450-223/+153
| | | | | | | | BUG=106977 Review URL: http://codereview.chromium.org/8989055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116398 0039d316-1c4b-4281-b951-d872f2087c98
* Fix typo in extension permissions docs.jstritar@chromium.org2012-01-044-5/+5
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/9085011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116321 0039d316-1c4b-4281-b951-d872f2087c98
* Directly download and open plug-in installer files.bauerb@chromium.org2012-01-041-1/+9
| | | | | | | | | | | | TBR=arv@chromium.org BUG=62079 TEST=none Review URL: http://codereview.chromium.org/9070001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116308 0039d316-1c4b-4281-b951-d872f2087c98
* Move background_page extension manifest key to background.page.aa@chromium.org2012-01-047-39/+84
| | | | | | | | | | | | | Move background_page to background.page so that additional properties can be added to the background group in the future. Only support background_page in older manifest versions. BUG=107791 Review URL: http://codereview.chromium.org/9072015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116289 0039d316-1c4b-4281-b951-d872f2087c98
* Hide downloads of extensions blacklist from web request API.battre@chromium.org2012-01-042-2/+21
| | | | | | | | | | | | | This CL prevents that extensions using the web request API can prevent Chrome from updating its extensions blacklist. R=mpcomplete@chromium.org BUG=108648 TEST=no Review URL: http://codereview.chromium.org/8952021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116258 0039d316-1c4b-4281-b951-d872f2087c98
* Convert the remaining Browser::GetSelectedTabContents() calls to ↵jam@chromium.org2012-01-031-1/+1
| | | | | | | | | | GetSelectedWebContents, and update all dependent code. BUG=98716 TBR=joi Review URL: http://codereview.chromium.org/9074012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116226 0039d316-1c4b-4281-b951-d872f2087c98
* Replace WebUI::tab_contents() with web_contents() and switch all users to ↵jam@chromium.org2011-12-301-2/+3
| | | | | | | | | | use web_contents.h instead of tab_contents.h. In a few cases some of these files used functions that needed a TabContents, so I switched them as well. BUG=98716 TBR=joi Review URL: http://codereview.chromium.org/9003014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116051 0039d316-1c4b-4281-b951-d872f2087c98
* Remove views screenlocker.flackr@chromium.org2011-12-292-4/+0
| | | | | | | | | | | This removes the views screenlocker code as well as the flag to enable it. The first patch is based off of http://codereview.chromium.org/8681016/ which has landed and is merged in the third patchset. BUG=105263 TEST=Make sure locking screen still works. Review URL: http://codereview.chromium.org/9032006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115975 0039d316-1c4b-4281-b951-d872f2087c98
* TBR=jampfeldman@chromium.org2011-12-292-0/+4
| | | | | | | | John: I've added a method and a message in the devtools subsystem. Review URL: http://codereview.chromium.org/9008043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115967 0039d316-1c4b-4281-b951-d872f2087c98
* Add more per-tab preferences.mnaganov@chromium.org2011-12-292-20/+61
| | | | | | | | | | | | | | | | | | | | | | | | | | | | intl.global.charset_default webkit.webprefs.global.standard_font_family webkit.webprefs.global.fixed_font_family webkit.webprefs.global.serif_font_family webkit.webprefs.global.sansserif_font_family webkit.webprefs.global.cursive_font_family webkit.webprefs.global.fantasy_font_family webkit.webprefs.global.default_font_size webkit.webprefs.global.default_fixed_font_size webkit.webprefs.global.minimum_font_size webkit.webprefs.global.minimum_logical_font_size webkit.webprefs.global.javascript_can_open_windows_automatically webkit.webprefs.global.loads_images_automatically webkit.webprefs.global.plugins_enabled BUG=105537 TEST=PrefsTabHelperTest*,PrefsTabHelperBrowserTest* For files that has only prefs names changes and require OWNERS approval: TBR=erikwright@chromium.org,gene@chromium.org,csilv@chromium.org,atwilson@chromium.org,mirandac@chromium.org Review URL: http://codereview.chromium.org/8879016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115955 0039d316-1c4b-4281-b951-d872f2087c98
* A command line flag to simulate an unrecoverable error.lipalani@chromium.org2011-12-282-0/+6
| | | | | | | | | | | The error is thrown right after initialization. BUG=101304 TEST=sync_unit_tests.exe, sync_integration_tests.exe, unit_tests.exe, manual test Review URL: http://codereview.chromium.org/9008045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115921 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable extension_l10n_util unittests on non-Windows.yoz@chromium.org2011-12-281-21/+64
| | | | | | | | | BUG=108429 TBR=pastarmovj@chromium.org Review URL: http://codereview.chromium.org/9049009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115902 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable screen_locker_browsertests and implement for WebUI.flackr@chromium.org2011-12-281-0/+3
| | | | | | | | | | BUG=104143 TEST=ScreenLockerTest.* Review URL: http://codereview.chromium.org/8681016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115895 0039d316-1c4b-4281-b951-d872f2087c98
* Improved Web Request API documentationbattre@chromium.org2011-12-283-43/+43
| | | | | | | | | BUG=none TEST=no Review URL: http://codereview.chromium.org/9018011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115881 0039d316-1c4b-4281-b951-d872f2087c98
* Disable flakily crashing ExtensionResourceTest.CreateWithAllResourcesOnDisk ↵yoz@chromium.org2011-12-281-0/+4
| | | | | | | | | | | on Windows. BUG=108721 TBR=asargent@chromium.org Review URL: http://codereview.chromium.org/9049003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115865 0039d316-1c4b-4281-b951-d872f2087c98
* Added command line flag for enabling DevTools experiments.vsevik@chromium.org2011-12-272-0/+4
| | | | | | | | | BUG=108691 Review URL: http://codereview.chromium.org/9047004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115838 0039d316-1c4b-4281-b951-d872f2087c98
* Remove PrefService::ScheduleSavePersistentPrefs and change ↵bauerb@chromium.org2011-12-274-29/+2
| | | | | | | | | | | | | SavePersistentPrefs calls to CommitPendingWrites. TBR=ncarter@chromium.org BUG=99306 TEST=none Review URL: http://codereview.chromium.org/8198007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115829 0039d316-1c4b-4281-b951-d872f2087c98
* Extensions: Move Debugger Extension API (chrome.debugger) out of experimental.pfeldman@chromium.org2011-12-2718-97/+79
| | | | | | | | BUG=105931 Review URL: http://codereview.chromium.org/8980017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115820 0039d316-1c4b-4281-b951-d872f2087c98
* Move most of the remaining users of WebContentsObserver::tab_contents() to ↵jam@chromium.org2011-12-261-2/+2
| | | | | | | | | | use web_contents(). BUG=98716 TBR=joi Review URL: http://codereview.chromium.org/9030010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115800 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling the whole ExtensionL10nUtil test suite because it crashes the ↵pastarmovj@chromium.org2011-12-261-20/+20
| | | | | | | | | | | | Vista bot. BUG=108429 TEST=unit_tests should not crash on Vista. TBR=cira@chromium.org Review URL: http://codereview.chromium.org/9030011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115790 0039d316-1c4b-4281-b951-d872f2087c98
* Disabled GetEmptyLocalesEmptyLocaleFolder because it crashes too often on ↵pastarmovj@chromium.org2011-12-261-1/+1
| | | | | | | | | | | | the Vista bot. BUG=108429 TEST=unit_tests GetEmptyLocalesEmptyLocaleFolder TBR=cira@chromium.org Review URL: http://codereview.chromium.org/8980018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115787 0039d316-1c4b-4281-b951-d872f2087c98
* Extensions: bring generated messages in sync with json schemas.pfeldman@chromium.org2011-12-266-10/+418
| | | | | | | | TBR=mtytel,calamity,aa Review URL: http://codereview.chromium.org/9042002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115783 0039d316-1c4b-4281-b951-d872f2087c98
* Convert a bunch of WebContentsObservers to use web_contents() instead of ↵jam@chromium.org2011-12-251-3/+3
| | | | | | | | | | tab_contents(), as well as all the dependent code. BUG=98716 TBR=joi Review URL: http://codereview.chromium.org/8982008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115777 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing names in extension api jsons so that code generation will work.calamity@chromium.org2011-12-259-11/+22
| | | | | | | | | | BUG= TEST= Review URL: http://codereview.chromium.org/8958023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115776 0039d316-1c4b-4281-b951-d872f2087c98
* WebRequest API documentation reviewbattre@chromium.org2011-12-233-377/+300
| | | | | | | | | BUG=108541 TEST=no Review URL: http://codereview.chromium.org/8729027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115717 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: do not allow chrome.debugger to attach to the WebUI pages.pfeldman@chromium.org2011-12-235-4/+4
| | | | | | | | BUG=108519 Review URL: http://codereview.chromium.org/9024014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115691 0039d316-1c4b-4281-b951-d872f2087c98
* Change most of the methods of WebContentsObserver to take a ↵jam@chromium.org2011-12-231-1/+1
| | | | | | | | | content::WebContents instead of a TabContents, and update all the dependent code. BUG=98716 Review URL: http://codereview.chromium.org/9022023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115664 0039d316-1c4b-4281-b951-d872f2087c98
* Redo r113722 - Add Pass(), which implements move semantics, to scoped_ptr, ↵ajwong@chromium.org2011-12-221-0/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | scoped_array.... -- This time for sure. -- Add Pass(), which implements move semantics, to scoped_ptr, scoped_array, and scoped_ptr_malloc. This modification to the scopers implements the "moveable but not copyable" semantics that were introduced in C++11's unique_ptr<>. With this, is now possible to use scopers as an argument type or a return type. This signifies, in the type system, transfer of ownership into a function or out of a function respectively. Calling, or returning such a function MUST use the temporary resulting from a function or explicit cast. This distinction makes it possible to avoid the implicit ownership transfer issues of auto_ptr, but still allow us to have compiler enforced ownership transfer. Also adds a Passed() helper that allows using a scoper with Bind(). Original Review URL: http://codereview.chromium.org/8774032 BUG=96118 TEST=new unittests Review URL: http://codereview.chromium.org/9018037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115607 0039d316-1c4b-4281-b951-d872f2087c98
* Remove references to obsolete TOUCH_UI build - extension samplerbyers@chromium.org2011-12-222-8/+1
| | | | | | | | | | | | | | | | | | | This sample includes a copy of the WebUI cr.js. We've removed all references to the old TOUCH_UI build from most of the code (including the main copy of cr.js). This updates the copy here and rebuilds the extension docs as requested by presubmit. Note that rebuilding the extension docs also gave me some unrelated changes to window.html (presumably because someone else failed to rebuild after updating) - I have not included those unrelated changes here. BUG=105046 TEST= Review URL: http://codereview.chromium.org/9018024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115554 0039d316-1c4b-4281-b951-d872f2087c98
* Marked the ExtensionL10nUtil.GetValidLocalesEmptyLocaleFolder as flakypastarmovj@chromium.org2011-12-221-1/+1
| | | | | | | | | | | | Has been failing constantly on the Vista Tests (3) buildbot. BUG=108429 TEST=unit_tests ExtensionL10nUtil.GetValidLocalesEmptyLocaleFolder TBR=cira@chromium.org Review URL: http://codereview.chromium.org/9025011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115530 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity fixlet: fix PASS_BY_VALUE.scr@chromium.org2011-12-222-2/+2
| | | | | | | | | | | | CID=102599 R=munjal@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/9004043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115497 0039d316-1c4b-4281-b951-d872f2087c98
* Allow clearing tokens with cmd-line flags from release builds.atwilson@chromium.org2011-12-222-7/+6
| | | | | | | | | BUG=107499 TEST=try using clear-token flags on release builds. Review URL: http://codereview.chromium.org/8989029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115461 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 115441 - Redo r113722 - Add Pass(), which implements move semantics, ↵jeremya@chromium.org2011-12-211-13/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | to scoped_ptr, scoped_array.... (This undoes the revert in r114247. Win canaries still can't link, but this change has been deemed safe). Add Pass(), which implements move semantics, to scoped_ptr, scoped_array, and scoped_ptr_malloc. This modification to the scopers implements the "moveable but not copyable" semantics that were introduced in C++11's unique_ptr<>. With this, is now possible to use scopers as an argument type or a return type. This signifies, in the type system, transfer of ownership into a function or out of a function respectively. Calling, or returning such a function MUST use the temporary resulting from a function or explicit cast. This distinction makes it possible to avoid the implicit ownership transfer issues of auto_ptr, but still allow us to have compiler enforced ownership transfer. Also adds a Passed() helper that allows using a scoper with Bind(). BUG=96118 TEST=new unittests Review URL: http://codereview.chromium.org/9021032 TBR=ajwong@chromium.org Review URL: http://codereview.chromium.org/8949057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115444 0039d316-1c4b-4281-b951-d872f2087c98
* Redo r113722 - Add Pass(), which implements move semantics, to scoped_ptr, ↵ajwong@chromium.org2011-12-211-0/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | scoped_array.... (This undoes the revert in r114247. Win canaries still can't link, but this change has been deemed safe). Add Pass(), which implements move semantics, to scoped_ptr, scoped_array, and scoped_ptr_malloc. This modification to the scopers implements the "moveable but not copyable" semantics that were introduced in C++11's unique_ptr<>. With this, is now possible to use scopers as an argument type or a return type. This signifies, in the type system, transfer of ownership into a function or out of a function respectively. Calling, or returning such a function MUST use the temporary resulting from a function or explicit cast. This distinction makes it possible to avoid the implicit ownership transfer issues of auto_ptr, but still allow us to have compiler enforced ownership transfer. Also adds a Passed() helper that allows using a scoper with Bind(). BUG=96118 TEST=new unittests Review URL: http://codereview.chromium.org/9021032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115441 0039d316-1c4b-4281-b951-d872f2087c98
* Add 'web_accessible_resource" keyword for version 2 extension manifests. ↵cdn@chromium.org2011-12-219-1/+101
| | | | | | | | | | This makes extension resources web accessible only when explicitly intended. Behavior is unaffected unless an extension specifies a manifest_version of 2 or more. BUG=46002 TEST=ExtensionResourceRequestPolicyTest.WebAccessibleResources Review URL: http://codereview.chromium.org/8849010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115401 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: update chrome.experimental.debugger sample zip files.pfeldman@chromium.org2011-12-212-0/+0
| | | | | | | | TBR=yurys Review URL: http://codereview.chromium.org/9018010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115333 0039d316-1c4b-4281-b951-d872f2087c98
* Take chrome.devtools out of experimental.caseq@google.com2011-12-213-11/+0
| | | | | | | | | BUG=105920 TEST=DevToolsExtensionAPITest.TestDevToolsExtensionAPI, ExtensionManifestTest.DevToolsExtensions Review URL: http://codereview.chromium.org/8995004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115320 0039d316-1c4b-4281-b951-d872f2087c98
* Disable ExtensionFileUtil.ValidateThemeUTF8 on Windowspeter@chromium.org2011-12-211-0/+4
| | | | | | | | | | | BUG=108279 TEST= TBR=mpcomplete@chromium.org Review URL: http://codereview.chromium.org/9021012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115314 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: inline the non-permission API names in extension_permission_set.cc.kalman@chromium.org2011-12-211-24/+12
| | | | | | | | | | BUG= TEST= Review URL: http://codereview.chromium.org/9021005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115298 0039d316-1c4b-4281-b951-d872f2087c98
* Add experimental.accessibility.getAlertsForTabhashimoto@chromium.org2011-12-211-0/+35
| | | | | | | | | | BUG=chromium-os:17602 TEST=browser_tests --gtest_filter="ExtensionApiTest.GetAlertsForTab" Review URL: http://codereview.chromium.org/8956009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115296 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Hunspell on OS X - step 4jeremy@chromium.org2011-12-211-14/+15
| | | | | | | | | | | | | | | | | | | | | | | | | Changes: * Isolate Mac-only functionality into SpellCheckerMessageFilterMac. * Isolate Spelling related IPC messages only needed on Mac. * Add some #ifdefs around sending IPC messages, so it's clear which ones are Mac-only. * Remove 'Platform' specifier from Mac-only IPC messages. Unit tests: The tests this CL touches were added as part of http://src.chromium.org/viewvc/chrome?view=rev&revision=75577 which integrated the OS X Grammar checker into Chrome. * spellcheck_provider_unittest.cc - split into Mac and Hunspell variants and add OVERRIDE where appropriate. * spellcheck_message_filter_browsertest.cc - This test was Mac-only to begin with, rename it to reflect that. Future steps (so it's clear where I'm going with this CL): * Unravel remaining functions in SpellCheckMessageFilter - ideally this class shouldn't be used on Mac. * Split spellcheck.cc into Hunspell/Mac variants to remove #ifdefs. BUG=69944 TEST=Spellchecking should continue to work on Mac and Windows. Review URL: http://codereview.chromium.org/8905004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115282 0039d316-1c4b-4281-b951-d872f2087c98
* Extensions: only inject the necessary extension API JSON into ↵kalman@chromium.org2011-12-215-70/+187
| | | | | | | | | | | schema_generated_bindings.js when populating the chrome.* namespace, where "necessary" is defined as the APIs that the extension has permission to use. BUG=80310 TEST=Extension* browser_tests Review URL: http://codereview.chromium.org/8888024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115252 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize member variables.jhawkins@chromium.org2011-12-202-2/+4
| | | | | | | | | | | | | CID=100356,100360,100368,100373,100374,100562,101529,101530,101536,101541, 101542,101595,101630,101685,101687,101689,101776,101812,101813,101854, 101861,101862,101871,101883,101886,101887,102034 BUG=none TEST=none R=binji Review URL: http://codereview.chromium.org/8965054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115225 0039d316-1c4b-4281-b951-d872f2087c98