summaryrefslogtreecommitdiffstats
path: root/chrome/common
Commit message (Collapse)AuthorAgeFilesLines
* Make the font scale and the font family to use for UI 'OS-dependent' (Win XP ↵jungshik@google.com2009-04-281-6/+16
| | | | | | | | | | | | | | | | | | | | vs Win Vista/ Win 7). In r13773, the localizable font size/family override was added to work around the tiny font issue for some Indian languages. Initially, I thought the 'tiny UI font' issue was completely taken care of on Vista/Win 7 (it's resolved for Malayalam) and added a check for that. It turned out that Indian fonts on Vista and Windows 7 were updated, but the issue has not been resolved. As a result, he scale and the fonts for Windows XP do not work on Vista/Win 7 and we need to use different values for Vista/Win 7. Note that what this CL does (having separate resource entries in a single reosource bundle for Win XP and Vista/Win 7 and picking one at run-time) is a temporary work-around for the branch and for the trunk, we need to have a better way of handling platform-dependent resources. It's not just for different flavors of Windows but also for taking care of differences between Win, Mac and Linux. BUG=7319 TEST=On Vista/Win7/Win XP, run Chrome with '--lang=XX' where XX is hi, mr, kn, gu, te, ta, bn, ml (and or on Vista/Win 7) and make sure that UI font size looks ok and there's no truncated strings/dialog box. Review URL: http://codereview.chromium.org/92135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14736 0039d316-1c4b-4281-b951-d872f2087c98
* Should handle the events when no printer is detected on localmaruel@chromium.org2009-04-281-0/+6
| | | | | | | | | | | | | | | | | machineGetDefaultPrintSettings was returning an empty struct because no printer is installed. Checking when its empty will allow us to know that a printer is missing on that system. There is clearly no other way to do this, unless we do not do all those dchecks on dpi and other struct members.BUG=6835TEST=Tested only on windows, since linux/mac printing not even implemented. Removed all printer drivers, opened chromium, and ran a print job, popup dialog appeared stating no printer installed. Installed my printer drivers again, print dialog appeared. Patch contributed by Mohamed Mansour <m0.interactive@gmail.com> Review: http://codereview.chromium.org/100023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14731 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a NOTIMPLEMENTED for Macpinkerton@chromium.org2009-04-281-5/+0
| | | | | | Review URL: http://codereview.chromium.org/99086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14727 0039d316-1c4b-4281-b951-d872f2087c98
* Synchronously update the loading state when a load starts so that the UI willbrettw@chromium.org2009-04-281-5/+8
| | | | | | | | | | | | | be more responsive and the loading state won't be out-of-sync with anything else. This also removes the synchronous update to the throbber when we load a URL because this happens before the loda actually starts, giving a flash of the default favicon. The load start call made by RenderViewHost will cover this case after the load actually starts. BUG=11051 Review URL: http://codereview.chromium.org/100033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14718 0039d316-1c4b-4281-b951-d872f2087c98
* ImportantFileWriterphajdan.jr@chromium.org2009-04-288-157/+401
| | | | | | | | | | | | | | Introducing a class for writing important files, preventing their corruption during writing. Switched PrefService to use it. Other classes will be switched in future changesets. TEST=This may affect things using preferences. Make sure that changes in preferences don't get lost, and that you don't get excessive disk activity when changing preferences. http://crbug.com/10618 Review URL: http://codereview.chromium.org/83001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14717 0039d316-1c4b-4281-b951-d872f2087c98
* Implement tabs.createWindow extension api call. Required: (a) new ↵rafaelw@chromium.org2009-04-282-0/+2
| | | | | | | | | | | RVHDelegate & TabContentsDelegate method(s) CreateExtensionFunctionDispatcher() so that the dispatcher could be created with (an optional) browser attached to it, while avoiding having render_host depend on browser.h BUG=11092: R=aa,mpComplete,darin,pkasting Review URL: http://codereview.chromium.org/79070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14710 0039d316-1c4b-4281-b951-d872f2087c98
* POSIX: don't spawn zombies.agl@chromium.org2009-04-285-7/+81
| | | | | | | | | http://codereview.chromium.org/93147 BUG=9401 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14705 0039d316-1c4b-4281-b951-d872f2087c98
* Removes the use of Windows-specific types for accessibility roles and states ↵klink@chromium.org2009-04-282-0/+52
| | | | | | | | in Views and Browser\Views. Helps with the porting effort, and makes for a cleaner implementation. Review URL: http://codereview.chromium.org/93085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14689 0039d316-1c4b-4281-b951-d872f2087c98
* Convert Windows Sleep to PlatformThread::Sleepevan@chromium.org2009-04-282-5/+5
| | | | | | | | | | | | First stage to make tests/others cross-platform. BUG=None TEST=Ran tests successfully (windows) Review URL: http://codereview.chromium.org/63113 Patch from Mohamed Mansour <m0.interactive@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14688 0039d316-1c4b-4281-b951-d872f2087c98
* Fix several painting glitches for toolstrips.aa@chromium.org2009-04-271-0/+2
| | | | | | | | | | | | | | * Reset HWND size when HWNDHtmlView changes size. The two should always be in sync. * Race: We might already have frames when RenderWidget receives a new background, need to set these to transparent too. * Race: Toolstrip background not always available by the time ExtensionToolstrip is constucted * Make images line up correctly for toolstrip buttons. Review URL: http://codereview.chromium.org/99042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14682 0039d316-1c4b-4281-b951-d872f2087c98
* Add quarantine metadata to downloads on the Mac. Patch by Stuart Morganmark@chromium.org2009-04-272-0/+112
| | | | | | | | | | | <stuart.morgan@gmail.com>. BUG=10853 Code review URL: http://codereview.chromium.org/99005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14657 0039d316-1c4b-4281-b951-d872f2087c98
* Changes to get multi-process plug-in scaffolding building on Mac.pinkerton@chromium.org2009-04-271-17/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14656 0039d316-1c4b-4281-b951-d872f2087c98
* Adds --no-audio, which replaces the audio IPC layer with a mock audio device.scherkus@chromium.org2009-04-272-2/+9
| | | | | | | | Useful for testing <audio> and <video> over remote desktop or on machines without sound cards. Should also let mac/linux playback videos without our audio layer being implemented on those platforms. Review URL: http://codereview.chromium.org/93132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14637 0039d316-1c4b-4281-b951-d872f2087c98
* More linux ifdef tweaks. This reverts my earlier change (13503).sky@chromium.org2009-04-277-22/+8
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/100046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14628 0039d316-1c4b-4281-b951-d872f2087c98
* Searching by keyword now generates a visit against the site with asky@chromium.org2009-04-271-1/+17
| | | | | | | | | | | | | | | | transition type of TAB_TO_SEARCH. This visit increments the typed count and ensures if you use TAB_TO_SEARCH you still get autocompleted to the site. I'll add some tests for this, but want to make sure we're ok with it before I do that. BUG=3633 TEST=will be covered by unit tests. Review URL: http://codereview.chromium.org/93087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14609 0039d316-1c4b-4281-b951-d872f2087c98
* Fix sudden termination after the latest WebKit merge.jam@chromium.org2009-04-251-4/+4
| | | | | | | | BUG=10927 Review URL: http://codereview.chromium.org/93104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14517 0039d316-1c4b-4281-b951-d872f2087c98
* Add a note pointing at a bug so others don't waste time.evan@chromium.org2009-04-241-0/+3
| | | | | | Review URL: http://codereview.chromium.org/101002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14501 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "POSIX: Don't spawn zombies." (r14488)agl@chromium.org2009-04-245-81/+7
| | | | | | | | Something else is trying to reap children in the ui_tests and causing a mess. Reverting since it's a Friday night. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14499 0039d316-1c4b-4281-b951-d872f2087c98
* Rename process_watcher.cc -> process_watcher_win.cc on Windows.agl@chromium.org2009-04-241-1/+1
| | | | | | | (Seems that we still don't use GYP on Windows for a lot of things.) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14495 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: build fix.agl@chromium.org2009-04-241-1/+1
| | | | | | | | Different header paths it seems, although the tryservers were ok with it. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14493 0039d316-1c4b-4281-b951-d872f2087c98
* For TransportDIB::HandleAndSequenceNumber, make operator<nick@chromium.org2009-04-241-5/+4
| | | | | | | | | | | | | be antisymmetric. The old implementation was flawed because both of the following comparisons were true: "{0, 1} < {1, 0}" and "{1, 0} < {0, 1}" On Windows, std::map<> doesn't like that, and complains -- rightly so. Review URL: http://codereview.chromium.org/93151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14490 0039d316-1c4b-4281-b951-d872f2087c98
* POSIX: Don't spawn zombies.agl@chromium.org2009-04-244-6/+80
| | | | | | | | TEST=Navigate to several different sites and check that no Chrome zombies are roaming around. BUG=9401 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14488 0039d316-1c4b-4281-b951-d872f2087c98
* Add a gcc warning if we don't check the results of ReadParam. Sometc@google.com2009-04-241-5/+6
| | | | | | | | | | | | of the buildbots noticed that we weren't checking the results when generating log output. AGL gets the credit for tracking this down. Review URL: http://codereview.chromium.org/93126 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14475 0039d316-1c4b-4281-b951-d872f2087c98
* Implement HTML selects as native Cocoa controls for Chrome.paul@chromium.org2009-04-242-0/+110
| | | | | | | | BUG=8389 (http://crbug.com/8389) Review URL: http://codereview.chromium.org/57032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14471 0039d316-1c4b-4281-b951-d872f2087c98
* Removes FindBar cruft from TabContentsViewMac.rohitrao@chromium.org2009-04-241-20/+0
| | | | | | | | | TEST=Ran Chromium, clicked around, found something in page. Nothing seems to have broken. Review URL: http://codereview.chromium.org/93124 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14442 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome side of using WebPluginListBuilder.darin@chromium.org2009-04-241-0/+1
| | | | | | | | | | | | | | I also broke glue/webplugininfo.h out of glue/webplugin.h as part of this change. Eventually, glue/webplugin.h will go away and be moved into the WebKit API, but the structures left in glue/webplugininfo.h need to remain since they are used extensively throughout Chrome. BUG=10922 R=dglazkov Review URL: http://codereview.chromium.org/93116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14438 0039d316-1c4b-4281-b951-d872f2087c98
* Linux valgrind: fix new[] / delete mismatchagl@chromium.org2009-04-241-1/+1
| | | | | | | | | TBR=abarth http://codereview.chromium.org/93113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14413 0039d316-1c4b-4281-b951-d872f2087c98
* Remove deprecated file_util::GetFilenameWithoutExtensionFromPath(), also ↵thestig@chromium.org2009-04-243-42/+51
| | | | | | | | convert ElideFilename() to take a FilePath. Review URL: http://codereview.chromium.org/92060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14409 0039d316-1c4b-4281-b951-d872f2087c98
* Try 14398 again, with Mac fix.abarth@chromium.org2009-04-242-4/+53
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14408 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: use opaque NativeViewIdsagl@chromium.org2009-04-242-5/+38
| | | | | | | | | | | | | | | | | | | | | | | | | | Currently we are still passing GtkWidget* into the renderer and trusting the value on the way out. With this patch we switch to using opaque values. These opaque values are handled by a GtkNativeViewIdManger, a singleton object which maintains the list of currently valid ids and their current X window ids. We don't pass the X window ids directly to the renderer because they are a) guessable and b) possibly variable for a GtkWidget. From a patch size point of view, the X window isn't current created at the point where we need it so significant work would be needed to reorder operations to fix that as well. This patch also removes the GTK accesses from the BACKGROUND_X11 thread which were a temporary hack. http://codereview.chromium.org/92110 BUG=9014,9869,10787 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14405 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused bits and pieces of #ifdefed code that isn't used.tim@chromium.org2009-04-241-10/+0
| | | | | | Review URL: http://codereview.chromium.org/93042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14402 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 14398.abarth@chromium.org2009-04-242-53/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14399 0039d316-1c4b-4281-b951-d872f2087c98
* Check the size of bitmaps coming over IPC.abarth@chromium.org2009-04-242-4/+53
| | | | | | | | | | R=cpu BUG=10869 TEST=IPCMessageTest.Bitmap Review URL: http://codereview.chromium.org/92064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14398 0039d316-1c4b-4281-b951-d872f2087c98
* Port and enable most of TabRestoreUITest on linux.estade@chromium.org2009-04-245-6/+16
| | | | | | | | | - fill in necessary bits of automation proxy, also mock out some windows-only functions on posix so that the IPC messages don't get completely ignored (so we get NOTIMPLEMENTEDs rather than just hanging when porting future UI tests) - add IsWindowActive to platform_util Review URL: http://codereview.chromium.org/93096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14396 0039d316-1c4b-4281-b951-d872f2087c98
* Add transparency support to RenderWidgetHostView.aa@chromium.org2009-04-232-0/+6
| | | | | | | | | | | | This is used to make the background behind toolstrips 'shine through' them. It isn't possible to make them really transparent due to cleartype (cleartype must know the pixels behind the text to work), so instead we paint the background we want behind the transparent webview. Review URL: http://codereview.chromium.org/88076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14378 0039d316-1c4b-4281-b951-d872f2087c98
* Allow Flash (and other plugins) to be installed without restarting the ↵jam@chromium.org2009-04-231-0/+3
| | | | | | | | | | | browser. This works by monitoring the MozillaPlugins registry key and reloading the plugin list afterwards. Note: I'll commit the WebKit change separately, but putting it in this change right now so everything can be reviewed together. BUG=10574 Review URL: http://codereview.chromium.org/88020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14377 0039d316-1c4b-4281-b951-d872f2087c98
* linux (and some posix): multiprocess plugins compiling.evan@chromium.org2009-04-239-9/+17
| | | | | | | | | | | | | | | | | | | The goal of this change is to *not* make any behavioral change, but to instead just get all the plugin-related files linking on Linux with a bunch of NOTIMPLEMENTED()s in the appropriate places. It's enormous enough already without any refactorings or new features. Changes include: - Lots of gcc warning fixes. - Use portable replacements for Windows-specific functions (_strdup, etc.). - Use TransportDIB instead of just shared memory in the plugin messaging. Note that this is not fleshed out on Linux and on Windows it just hacks in the existing handles so there should be no functional change. - Fix --plugin-launcher to use cross-platform APIs. Review URL: http://codereview.chromium.org/79020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14338 0039d316-1c4b-4281-b951-d872f2087c98
* Create a ChromeProcessUtil for the Mac, and enable it in the tests.avi@google.com2009-04-232-4/+15
| | | | | | Review URL: http://codereview.chromium.org/95009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14328 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of http://codereview.chromium.org/87058 which appears to hang the XP ↵robertshield@google.com2009-04-231-2/+0
| | | | | | | | | | | | | Tests. Log of hanging tests: http://build.chromium.org/buildbot/waterfall/builders/XP%20Tests%20(dbg)(2)/builds/1246/steps/unit_tests/logs/stdio TBR=http://codereview.chromium.org/92055 Review URL: http://codereview.chromium.org/92055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14281 0039d316-1c4b-4281-b951-d872f2087c98
* Fix focus rects for checkboxes and radio buttons:ben@chromium.org2009-04-221-0/+8
| | | | | | | | | | | | | | | | | | | | | | | - add concept of default insets to view which get added to any other insets provided by the user. used by label to provide room for a focus border. - provide the ability for the label to paint its focus border even if it isn't focused. needed because the outer container (the checkbox) gets focus but the inner label does not, however the label knows best the location of its text around which the focus border must be drawn. please note: - also make it easier to click checkboxes by not resetting mouse_pressed_handler_ in RootView when a view decides it doesn't want to handle a drag. this is so we can still receive mousereleased notifications when the mouse is released... it's "difficult" to click checkboxes and radio buttons when you accidentally drag a little on their label. (this is the root view change). - fix slight alignment issue on the general page of options. Also fix a slight error in my last radio checkbox - clicking on a checked radio button should still focus it. http://crbug.com/10834 TEST=visit options, Minor Tweaks. click the "always ask before downloading" checkbox and observe that the focus rect tightly surrounds the text label instead of stretching to the right side of the dialog. Visit options, click an already-checked radio button. observe that it takes focus. Visit options, click on any checkbox or radio button, drag slightly then release (still within the bounds of the item). note the item is now toggled or selected. click down then drag out and release, note that it is not toggled or selected. Review URL: http://codereview.chromium.org/92004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14265 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ExtensionView to properly set the size of the RenderWidgetHostView. ↵erikkay@google.com2009-04-221-0/+2
| | | | | | | | Without this, GetClientRect would return a size of 0,0 for the view, which would prevent the tooltip machinery from working properly. Review URL: http://codereview.chromium.org/87058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14264 0039d316-1c4b-4281-b951-d872f2087c98
* Add pref_service_unittest.cc on Mac.shess@chromium.org2009-04-221-4/+0
| | | | | | | | | Needed to remove the anonymous namespace because Mac's gcc complains about friend trying to poke through anonymous namespaces. Review URL: http://codereview.chromium.org/93043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14259 0039d316-1c4b-4281-b951-d872f2087c98
* Always enable copy-link-address in context menu.brettw@chromium.org2009-04-221-0/+2
| | | | | | | | | | | | | | Added a new field into ContextMenuParam only for this purpose. The new field won't be validated in frontend processes. In this way, even if renderer processes are going to mad, the frontend would be OK if the frontend uses this new field only for copying into the clipboard. Fix checked in for Shinichiro Hamaji Original code review: http://codereview.chromium.org/91002 BUG=2725 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14256 0039d316-1c4b-4281-b951-d872f2087c98
* Fix DIR_SOURCE_ROOT to work in bundles like Chromium.app. Add more ui tests. ↵pinkerton@chromium.org2009-04-221-2/+14
| | | | | | | | Add a resource for tabs with no title on mac. Fix window title reporting. Remove the Browser dependency from the tab strip (only needs a TabStripModel). Review URL: http://codereview.chromium.org/93025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14212 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: move X operations from the IO to UI2 thread.agl@chromium.org2009-04-222-34/+91
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | (r14075 take two) Currently we perform several X operations on the IO thread including geometry and clipboard work. This is causing races inside Xlib and crashing the browser. These are the result of synchronous calls from the renderer, so we cannot route these requests to the UI thread without risking deadlock. Thus we introduce the UI2 thread. This thread has a second connection to the X server and can perform X operations safely the without UI thread. Work remains to be done: Since we still have the hack where we pass GtkWidget pointers into the renderer and back, we still have to access these structures from the IO and UI2 threads. This still needs to be fixed, but this is not the patch for it. Also, not all the X calls from the IO thread have been moved over in this patch; just a few small ones. http://codereview.chromium.org/67145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14206 0039d316-1c4b-4281-b951-d872f2087c98
* Properly construct shell filters (forgetting the asterisk means it works but ↵avi@chromium.org2009-04-222-3/+3
| | | | | | | | | | doesn't show existing files). BUG=10734 Review URL: http://codereview.chromium.org/93019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14202 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r14146 which refactors DialogButton into cross platformtc@google.com2009-04-212-13/+10
| | | | | | | | | | code. This is the same as the last change except I renamed class MessageBox to class MessageBoxFlags to avoid conflicting with the same name in windows.h. Review URL: http://codereview.chromium.org/87065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14159 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Refactor DialogDelegate so the DialogButton enum is in cross platform"tc@google.com2009-04-212-7/+10
| | | | | | | | | | | | This reverts commit r14146. MessageBox is redefined to MessageBoxW by windows. I need to rename the class. Review URL: http://codereview.chromium.org/87064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14147 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor DialogDelegate so the DialogButton enum is in cross platformtc@google.com2009-04-212-10/+7
| | | | | | | | | | | | | | | | | code. This is mostly a find & replace in our code to use the new location of the enum. I also deleted some GetDialogButtons methods in child classes because they were identical to the parent version in DialogDelegate. This will allow more code to be enabled on linux/mac in the automation provider. Review URL: http://codereview.chromium.org/88008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14146 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a leak when we fail to load a gdkpixbuf. I meant to do this intc@google.com2009-04-211-7/+7
| | | | | | | | | the last change, but forgot. Review URL: http://codereview.chromium.org/69042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14143 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-23 05:39:33 +0000