| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
gtk_window_get_position returns different values (includes frame or not) depending on the window manager.
BUG=none
TEST=Using a non-composited window manager, drag the tab within the tab strip. The tab should be rendered within the bounds of the tabstrip and not in the frame.
Review URL: http://codereview.chromium.org/115680
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=2381
Review URL: http://codereview.chromium.org/115676
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16704 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=2381
Review URL: http://codereview.chromium.org/113738
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
communication between WebPlugin and WebPluginDelegate, to use a cross-platform
message based on WebInputEvent.
BUG=8202
TEST=A lot of manual testing on Linux and Windows, with Flash plugins and a
custom plugin that dumps events on Linux.
Review URL: http://codereview.chromium.org/115330
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also removed all external dependencies from ExtensionsService.
It now only sends out notifications, which other services
consume. This should allow us to unit test the
ExtensionsService frontend, but I haven't added that yet.
Review URL: http://codereview.chromium.org/113493
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16676 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We use a modal dialog with a single checkbox on OS X.
We use the OSX defaults system since we want something quick and reliable. The
dialog is displayed at a very early stage in Chrome startup (Before any
subsystems start relying on the stats variable). This means there are a few
quirks in displaying the UI.
A change was also needed to our event handling code since when the dialog is
shown we spin an event loop at a very early stage in the process lifetime.
Changed default value for stats to false and updated unit tests to reflect that.
Also some misc. minor cleanup.
BUG=11971,12046
Review URL: http://codereview.chromium.org/115608
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113727
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
there too, but needs Separator to actually completely compile.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/113720
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/114035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115637
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
EXCLUDE_SKIA_DEPENDENCIES block
This will cause compile failures if EXCLUDE_SKIA_DEPENDENCIES is defined.
TBR=mpcomplete
Review URL: http://codereview.chromium.org/113705
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
<app_name>/Contents/Resources and read them from there.
Review URL: http://codereview.chromium.org/115587
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16585 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115491
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16562 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This reverts commit ebb5f616663f9d5ee78584187da16bba4ce96811.
Review URL: http://codereview.chromium.org/113680
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16557 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the NotificationService instances, by checking whether the service exists before calling RemoveObserver() on it.
Also add comments in NotificationService telling people to use NotificationRegistrar.
BUG=2381
Review URL: http://codereview.chromium.org/115601
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16554 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also removed all external dependencies from ExtensionsService.
It now only sends out notifications, which other services
consume. This should allow us to unit test the
ExtensionsService frontend, but I haven't added that yet.
Review URL: http://codereview.chromium.org/113493
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16547 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This reverts commit 5b2fc12fbca26b20ed4176ac740c58fe49360c4a.
Review URL: http://codereview.chromium.org/113664
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16538 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also removed all external dependencies from ExtensionsService.
It now only sends out notifications, which other services
consume. This should allow us to unit test the
ExtensionsService frontend, but I haven't added that yet.
Review URL: http://codereview.chromium.org/113493
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16529 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
sending them. This makes it so that types sendable via IPC no longer need
copy constructors.
BUG=12296
Review URL: http://codereview.chromium.org/112042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16497 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
escaping.BUG=http://crbug.com/11431TEST=base_unittests.exe --gtest_filter=StringEscapeTest.Json*
Review URL: http://codereview.chromium.org/113606
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST: Start chrome, make sure it loads pages, then user process explorer to make sure the WindowStation handle name is not the same as the browser process.
BUG:10996
Review URL: http://codereview.chromium.org/113190
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I added a command line for the renderer that accepts a FieldTrial
name and value, and forces that value to be activated in the
renderer. As a result, any FieldTrial setting that is specified
by the browser process can be set (forced) in the renderer
process. Such settings can then be used to establish names
of histograms, which means all processes can work in sync
on a single field trial (and generate data). This should
allow A/B tests to be run that modulate the page load times.
Dave: Please review/confirm that you are happy with the changes to
render_view.cc. Note that all I did was change the names and limits
for the histograms (they now go up to 3 minutes). The MakeName()
allows me to get an A/B test of the impact of DNS pre-resolution.
Mike: Please review the code for passing along switch settings.
r=davemoore,mbelshe
Review URL: http://codereview.chromium.org/115525
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16460 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
of assistive technologies (accessibility). Also cleans up the handling of WM_GETOBJECT in RenderWidgetHostViewWin and WidgetWin, as well as in BrowserAccessibilityManager.
Review URL: http://codereview.chromium.org/115374
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16449 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Nor do we have support for alternate file formats; nor do we have a default icon.
BUG=http://crbug.com/8631
Review URL: http://codereview.chromium.org/113571
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/115265
Original text:
"""
This addresses 3 of the 4 issues described in Issue 9223:
1) Creates a new streamlined bubble with less text.
2) Incorporates a close [x].
3) Driven by configuration option in master_preferences file; this alternate
bubble will be used only if "oem_bubble": true is set.
Requested longer linger time feature will involve mucking with the focus
manager; this change will be uploaded separately.
BUG=9223
TEST=Add "oem_bubble": true to master_preferences file. Run chrome with
--first-run option. Alternate, smaller OEM bubble should appear over the Chrome
browser in the place of the standard first-run bubble.
"""
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=11017,12056
Review URL: http://codereview.chromium.org/113587
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
As a bonus, debugging of extensions now works. Go OOP inspector team!
Inspection code was calling RVHD::GetProfile(), which was not implemented by ExtensionHost. Looking into this, it seems better to just remove the method from the interface since Profile is already accessible by way of RVH.
The only caller to RVHD::GetProfile() besides the inspector was HWNDHtmlView which is itself dead code, so I removed it too.
Review URL: http://codereview.chromium.org/115501
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
It has more strict semantics than file_util::Move.
http://crbug.com/11585
Review URL: http://codereview.chromium.org/113207
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115412
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16374 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the prototype new new tab page.
Split the DownloadsDOMHandler into its own file.
The prototype is rough and has bugs. Don't file any bugs on it!
TEST=Run with the command line above and you should see an alternative
new tab page.
Review URL: http://codereview.chromium.org/115426
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Allow enabling/disabling stats via user defaults.
Fix breakpad to read from global stats setting.
To disable stats, type the following in the terminal:
defaults write com.google.Chrome usagestats -bool NO
BUG=12046
Review URL: http://codereview.chromium.org/113549
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
so we don't get layout overflow issues. Ideally, we would have
vector graphics for buttons and stuff so this wouldn't be an issue,
but for now, this will have to do.
BUG=11128
Review URL: http://codereview.chromium.org/113546
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16327 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We follow the GNOME HIG where possible, which mostly means the
pixel spacing of the borders and buttons in dialogs.
BUG=12056
Review URL: http://codereview.chromium.org/113539
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16320 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=11826
Review URL: http://codereview.chromium.org/115474
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16313 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
tab or tab contents during a tab drag.
Review URL: http://codereview.chromium.org/113532
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16310 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
When we delete a ResourceLoaderBridge before OnCompletedRequest is received, bad things happen. There's a lot of leaks at the following points:
1. OnMessageReceived ignores the message.
2. RemovePendingRequest removes it's internal deferred_message_queue.
But ViewHostMsg_Resource_DataReceived is not POD. We should also close the shared memory handle inside it.
Review URL: http://codereview.chromium.org/115396
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16297 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/11585
TBR=stoyan
Review URL: http://codereview.chromium.org/113534
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16296 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115430
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16294 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
It has more strict semantics than file_util::Move.
http://crbug.com/11585
Review URL: http://codereview.chromium.org/113207
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16291 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(The webkit part is http://codereview.chromium.org/67209/show and
http://bugs.webkit.org/show_bug.cgi?id=25239 )
1. Adds '--enable-remote-fonts' command line switch
2. Adds a field ('enable_remote_fonts) to WebPreference
3. Pass the value of enable_remote_fonts to the corresponding field in WebCore::Settings (m_downloadableBinaryFontsEnabled)
BUG=9633
TEST: 1. Run Chrome with and without '--enable-remote-font' command line flag and go to http://www.alistapart.com/d/cssatten/heid.html. Without the flag, the page should be rendered with 'dull-looking ordinary' fonts. With the flag, the page should be rendered with 'decorative' remote fonts.
2. Even without the above flag, Chrome should should get 100/100, with no boxes in the upper right corner (still has the Linktest Failed error).
Review URL: http://codereview.chromium.org/67210
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
http://codereview.chromium.org/115265 BUG=9223 TBR=mirandac
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16243 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/115265
BUG=9223
TBR=mirandac
Review URL: http://codereview.chromium.org/113504
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Move/Copy paths used by app to app_paths.
http://crbug.com/11387
Review URL: http://codereview.chromium.org/115420
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
of extension packages.
This is a first pass. In the second pass, I will add support for transcoding
the manifest and any images in the browser process.
BUG=11680
Review URL: http://codereview.chromium.org/114027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16198 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/8631
Review URL: http://codereview.chromium.org/113428
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
render view sizing.
http://crbug.com/11080
Review URL: http://codereview.chromium.org/113322
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16193 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113465
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16188 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
only short term. I'll stub out parts of chrome_menu next so that these
can be removed.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115406
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16178 0039d316-1c4b-4281-b951-d872f2087c98
|