summaryrefslogtreecommitdiffstats
path: root/chrome/common
Commit message (Collapse)AuthorAgeFilesLines
* linux: drop temp_scaffolding_stubsevan@chromium.org2009-09-251-1/+2
| | | | | | | | | It was mostly unneeded, but I had to excise the last bits of RLZ and move some NOTIMPLEMENTED bits to where they belong. Review URL: http://codereview.chromium.org/219042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27161 0039d316-1c4b-4281-b951-d872f2087c98
* Implement BrowserList::AllBrowsersClosed for Linux.tony@chromium.org2009-09-241-4/+2
| | | | | | | | | | | This fixes leaks caused by not calling gtk_widget_destroy on dialog windows when we exit. While I'm here, fix a GList leak on Linux toolkit views. Review URL: http://codereview.chromium.org/223015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27130 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 27117.davemoore@chromium.org2009-09-242-12/+0
| | | | | | Review URL: http://codereview.chromium.org/235010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27124 0039d316-1c4b-4281-b951-d872f2087c98
* Another draft of the overview, now with figures. Made related changes to the ↵kathyw@google.com2009-09-2410-364/+243
| | | | | | | | background pages and content scripts pages. Review URL: http://codereview.chromium.org/225023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27121 0039d316-1c4b-4281-b951-d872f2087c98
* Use chrome/base synchronization primitives and threads instead oftim@chromium.org2009-09-242-0/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | pthreads in SyncerThread. The old pthread impl can be used by specifying --syncer-thread-pthreads for comparison until we settle fully on the final impl (I have a MessageLoop-based impl in progress). The default SyncerThread is as close to the pthreads-impl semantics as I could get, with one exception: it does not offer a time-out when calling Stop(), because it greatly simplifies the implementation. I first implemented it *with* the timeout, and for sake of experimentation while this is in shuffle I am checking it in as SyncerThreadTimedStop, available by using --syncer-thread-timed-stop. I'm not sure which we want ultimately, but it's useful to have around when building the MessageLoop based impl. I had to refactor the interface slightly to allow multiple implementations, I think it will be quite useful while working on the MessageLoop impl. Added several tests to SyncerThreadUnittest, which all impls now pass ( just pass the command line flag to try each out). TEST=SyncerThreadTest, SyncerThreadWithSyncerTest, integration tests Review URL: http://codereview.chromium.org/214033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27117 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/227008 for Charlie:sky@chromium.org2009-09-232-1/+5
| | | | | | | | | | Add touchpad sensitivity setting. BUG=22848 TEST=none Review URL: http://codereview.chromium.org/223012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26996 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Make about:memory not crash.shess@chromium.org2009-09-231-0/+1
| | | | | | | | | | | | | | http://codereview.chromium.org/177024 enabled about:memory for Linux, but it went from not-implemented to crashing for Mac, due to an out-of-bounds vector access. This returns it to simply not-implemented. http://crbug.com/21830 TEST=Browse to about:memory, don't crash, show a template with obviously null data in it. Review URL: http://codereview.chromium.org/219008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26964 0039d316-1c4b-4281-b951-d872f2087c98
* Make chromeos build use shared object to load batterydavemoore@chromium.org2009-09-232-0/+14
| | | | | | | | functionality. Call into it and show new battery images Review URL: http://codereview.chromium.org/215025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26898 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a theme promo in the lower right cornerarv@chromium.org2009-09-232-0/+6
| | | | | | | | | BUG=None TEST=The theme promo should show up in the lower right corner and when clicked should navigate to the Chrome theme gallery. The promo should go away after 5 runs of chrome Review URL: http://codereview.chromium.org/217020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26894 0039d316-1c4b-4281-b951-d872f2087c98
* Move FTP LIST parsing code to the renderer process.phajdan.jr@chromium.org2009-09-222-0/+78
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/210027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26860 0039d316-1c4b-4281-b951-d872f2087c98
* Automated ui test porting + cleanup:estade@chromium.org2009-09-221-12/+10
| | | | | | | | | | | | | | | | - Change POINTs to gfx::Point - Get rid of 2 unused automation messages (the messages themselves are staying for now so we don't mess with the reference build) -- add new automation messages to replace GetWindowHWND, which is not portable - re-enable automated_ui_test_interactive_test (it seems to have been dropped when we converted to gyp) - compile additional tests on linux (they don't pass, so they are disabled) - stub out linux tab dragging automation implementation (browser side) - delete various cruft BUG=19758 Review URL: http://codereview.chromium.org/211033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26846 0039d316-1c4b-4281-b951-d872f2087c98
* Fix appcache_service and request_context referencing.michaeln@google.com2009-09-221-8/+10
| | | | | | | | | | | | There is one appcache service per profile and several request context per profile. The profile holds a reference to the appcache service. Those request contexts which are subject to retrieval from appcaches hold a reference to the appcache service too. The appcache service is provided with a pointer back to the 'main' request context, this context is used when updating appcaches. Initialization is a little tricky because profiles can't be used on the IO thread and request contexts can't be used on the UI thread. BUG=22597,22125 TEST=many existing tests exercise profile/context creation Review URL: http://codereview.chromium.org/215024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26844 0039d316-1c4b-4281-b951-d872f2087c98
* Modify the template to add analytics to all extension docs.kathyw@google.com2009-09-2235-69/+713
| | | | | | | | | | | | | Besides the usual code.google.com analytics, there's also an account for just Chrome-related docs. Also deleted some end-of-line spaces to avoid presubmit errors. TBR=rafaelw Review URL: http://codereview.chromium.org/209067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26843 0039d316-1c4b-4281-b951-d872f2087c98
* Speculative patch to fix flakiness in RendererCrashTest.Crash.phajdan.jr@chromium.org2009-09-221-0/+1
| | | | | | | | | | | If that doesn't fix it, then maybe the crash_service.exe isn't running? TEST=none BUG=22569 Review URL: http://codereview.chromium.org/215048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26814 0039d316-1c4b-4281-b951-d872f2087c98
* Create an enum for local storage vs. session storage rather than usingjorlow@chromium.org2009-09-223-79/+125
| | | | | | | | | | | | a boolean. TEST=It still works. BUG=21070 Review URL: http://codereview.chromium.org/212033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26793 0039d316-1c4b-4281-b951-d872f2087c98
* Add NotificationType::BROWSER_WINDOW_READY, chrome.windows.onCreated now ↵rafaelw@chromium.org2009-09-224-59/+20
| | | | | | | | | | sends full window BUG=NONE Review URL: http://codereview.chromium.org/195030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26771 0039d316-1c4b-4281-b951-d872f2087c98
* Extension Doc Changes (no building or testable changes).rafaelw@chromium.org2009-09-222-11/+603
| | | | | | | | | | Removing stray comma that was breaking the extension docs build. TBR=aa Review URL: http://codereview.chromium.org/217009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26769 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the CHECK() when SQLite is corrupt.cpu@chromium.org2009-09-221-8/+1
| | | | | | | | | | | | | | Got plenty of crashes in 4.0.211.4 BUG=11908 TEST=none TBR=bretw Review URL: http://codereview.chromium.org/217007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26767 0039d316-1c4b-4281-b951-d872f2087c98
* Update renderer plugin cache when we load/unload extensions with plugins.mpcomplete@chromium.org2009-09-211-2/+4
| | | | | | | | | BUG=12306 TEST=Load and unload extensions that contain plugins and visit pages that use them. Also covered by tests. Review URL: http://codereview.chromium.org/201111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26748 0039d316-1c4b-4281-b951-d872f2087c98
* Retry of r26698.estade@chromium.org2009-09-212-8/+0
| | | | | | | | R=stuartmorgan Review URL: http://codereview.chromium.org/208047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26704 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting r26698. Somehow this broke scons?estade@chromium.org2009-09-212-0/+8
| | | | | | | | TBR=stuartmorgan Review URL: http://codereview.chromium.org/217004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26699 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Remove linux splash page and printing command line switch.estade@chromium.org2009-09-212-8/+0
| | | | | | | | | BUG=22295 BUG=19911 Review URL: http://codereview.chromium.org/211036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26698 0039d316-1c4b-4281-b951-d872f2087c98
* Adds NOTREACHED if we ever hit the max cache size of the render pictsky@chromium.org2009-09-211-1/+10
| | | | | | | | | | | | format cache. BUG=none TEST=none TBR=estade Review URL: http://codereview.chromium.org/217002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26689 0039d316-1c4b-4281-b951-d872f2087c98
* <html>aa@chromium.org2009-09-212-5/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | <style type="text/css"> <!-- body { font-family: arial,sans-serif; background-color: #fff; margin-top: 2; } .c { width: 4; height: 4; } a:link { color: #00c; } a:visited { color: #551a8b; } a:active { color: #f00; } .form-noindent { background-color: #fff; border: 1px solid #c3d9ff; } --> </style> <style type="text/css"><!-- .gaia.le.lbl { font-family: Arial, Helvetica, sans-serif; font-size: smaller; } .gaia.le.fpwd { font-family: Arial, Helvetica, sans-serif; font-size: 70%; } .gaia.le.chusr { font-family: Arial, Helvetica, sans-serif; font-size: 70%; } .gaia.le.val { font-family: Arial, Helvetica, sans-serif; font-size: smaller; } .gaia.le.button { font-family: Arial, Helvetica, sans-serif; font-size: smaller; } .gaia.le.rem { font-family: Arial, Helvetica, sans-serif; font-size: smaller; } .gaia.captchahtml.desc { font-family: arial, sans-serif; font-size: smaller; } .gaia.captchahtml.cmt { font-family: arial, sans-serif; font-size: smaller; font-style: italic; } --></style> <head> <title>Google Accounts</title> <style type="text/css"><!-- body { font-family: arial, sans-serif; margin: 0; padding: 13px 15px 15px; } .body { margin: 0; } div.errorbox-good {} div.errorbox-bad {} div.errormsg { color: red; font-size: smaller; font-family: arial,sans-serif;} font.errormsg { color: red; font-size: smaller; font-family: arial,sans-serif;} div.topbar { font-size:smaller; margin-right: -5px; text-align:right; white-space:nowrap; } div.header { margin-bottom: 9px; margin-left: -2px; position:relative; zoom: 1 } div.header img.logo { border: 0; float:left; } div.header div.headercontent { float:right; margin-top:17px; } div.header:after{ content:"."; display:block; height:0; clear:both; visibility:hidden; } div.pagetitle { font-weight:bold; } .footer { color: #666; font-size: smaller; margin-top: 40px; text-align: center; } table#signupform { left: -5px; top: -7px; position:relative; } table#signupform td{ padding: 7px 5px; } table#signupform td table td{ padding: 1px; } hr { border: 0; background-color:#DDDDDD; height: 1px; width: 100%; text-align: left; margin: 5px; } --></style> </head> <body dir="ltr" onLoad= "gaia_setFocus();" > <div id="main"> <?sc # for new logo transition ?> <div class=header> <a href='https://www.google.com/accounts/'> <img class=logo src='https://www.google.com/intl/en/images/logos/accounts_logo.gif' alt="Google" /> </img> </a> </div> <div id=maincontent> <table border="0" width="100%" cellpadding=0 cellspacing=0> <tr> <td width="75%" valign="top"> <h3> Chromium Code Reviews uses Google Accounts for Sign In. </h3> <p><font size=-1> Google is not affiliated with the contents of <b>Chromium Code Reviews</b> or its owners. If you sign in, Google will share your email address with <b>Chromium Code Reviews</b>, but not your password or any other personal information. </font></p> <p><font size=-1> <b>Chromium Code Reviews</b> may use your email address to personalize your experience on their website. </font></p> </td> <td style="padding-left: 10px;" valign="top" align="center"> <div id="rhs"> <div id="rhs_login_signup_box"> <script><!-- function gaia_onLoginSubmit() { if (window.gaiacb_onLoginSubmit) { return gaiacb_onLoginSubmit(); } else { return true; } } function gaia_setFocus() { var f = null; if (document.getElementById) { f = document.getElementById("gaia_loginform"); } else if (window.gaia_loginform) { f = window.gaia_loginform; } if (f) { if (f.Email && (f.Email.value == null || f.Email.value == "")) { f.Email.focus(); } else if (f.Passwd) { f.Passwd.focus(); } } } --></script> <style type="text/css"><!-- div.errormsg { color: red; font-size: smaller; font-family:arial,sans-serif; } font.errormsg { color: red; font-size: smaller; font-family:arial,sans-serif; } --></style> <style type="text/css"><!-- .gaia.le.lbl { font-family: Arial, Helvetica, sans-serif; font-size: smaller; } .gaia.le.fpwd { font-family: Arial, Helvetica, sans-serif; font-size: 70%; } .gaia.le.chusr { font-family: Arial, Helvetica, sans-serif; font-size: 70%; } .gaia.le.val { font-family: Arial, Helvetica, sans-serif; font-size: smaller; } .gaia.le.button { font-family: Arial, Helvetica, sans-serif; font-size: smaller; } .gaia.le.rem { font-family: Arial, Helvetica, sans-serif; font-size: smaller; } .gaia.captchahtml.desc { font-family: arial, sans-serif; font-size: smaller; } .gaia.captchahtml.cmt { font-family: arial, sans-serif; font-size: smaller; font-style: italic; } --></style> <form id="gaia_loginform" action="https://www.google.com/accounts/ServiceLoginAuth?service=ah&amp;sig=d71ef8b8d6150b23958ad03b3bf546b7" method="post" onsubmit= "return(gaia_onLoginSubmit());" > <div id="gaia_loginbox"> <table class="form-noindent" cellspacing="3" cellpadding="5" width="100%" border="0"> <tr> <td valign="top" style="text-align:center" nowrap="nowrap" bgcolor="#e8eefa"> <input type="hidden" name="ltmpl" value="gm"> <div class="loginBox"> <table id="gaia_table" align="center" border="0" cellpadding="1" cellspacing="0"> <tr> <td colspan="2" align="center"> <font size="-1"> Sign in with your </font> <table> <tr> <td valign="top"> <img src="google_transparent.gif" alt="Google"> </img> </td> <td valign="middle"> <font size="+0"><b>Account</b></font> </td> </tr> </table> </td> </tr> <script type="text/javascript"><!-- function onPreCreateAccount() { return true; } function onPreLogin() { if (window["onlogin"] != null) { return onlogin(); } else { return true; } } --></script> <tr> <td colspan="2" align="center"> </td> </tr> <tr> <td nowrap="nowrap"> <div align="right"> <span class="gaia le lbl"> Email: </span> </div> </td> <td> <input type="hidden" name="continue" id="continue" value="http://codereview.chromium.org/_ah/login?continue=http://codereview.chromium.org/210007/description" /> <input type="hidden" name="service" id="service" value="ah" /> <input type="hidden" name="ltmpl" id="ltmpl" value="gm" /> <input type="hidden" name="ltmpl" id="ltmpl" value="gm" /> <input type="hidden" name="ahname" id="ahname" value="Chromium Code Reviews" /> <input type="hidden" name="GALX" value="LfA4LnZj1gM" /> <input type="text" name="Email" id="Email" size="18" value="" class='gaia le val' /> </td> </tr> <tr> <td></td> <td align="left"> </td> </tr> <tr> <td align="right" nowrap="nowrap"> <span class="gaia le lbl"> Password: </span> </td> <td> <input type="password" name="Passwd" id="Passwd" size="18" class="gaia le val" /> </td> </tr> <tr> <td> </td> <td align="left"> </td> </tr> <tr> <td align="right" valign="top"> <input type="checkbox" name="PersistentCookie" id="PersistentCookie" value="yes" checked='checked' /> <input type="hidden" name='rmShown' value="1" /> </td> <td> <label for="PersistentCookie" class="gaia le rem"> Stay signed in </label> </td> </tr> <tr> <td> </td> <td align="left"> <input type="submit" class="gaia le button" name="signIn" value="Sign in" /> </td> </tr> <tr id="ga-fprow"> <td colspan="2" height="33.0" class="gaia le fpwd" align="center" valign="bottom"> <a href="http://www.google.com/support/accounts/bin/answer.py?answer=48598&amp;hl=en&amp;ctx=ch_ServiceLogin&amp;p=ah&amp;fpUrl=https%3A%2F%2Fwww.google.com%2Faccounts%2FForgotPasswd%3FfpOnly%3D1%26continue%3Dhttp%253A%252F%252Fcodereview.chromium.org%252F_ah%252Flogin%253Fcontinue%253Dhttp%253A%252F%252Fcodereview.chromium.org%252F210007%252Fdescription%26service%3Dah%26ltmpl%3Dgm" target=_top> Can&#39;t access your account? </a> </td> </tr> </table> </div> </td> </tr> </table> </div> <input type="hidden" name="asts" id="asts" value=""> </form> <form id="gaia_universallogin" action="https://www.google.com/accounts/ServiceLoginAuth?service=ah&amp;sig=d71ef8b8d6150b23958ad03b3bf546b7" method="post" onsubmit="return(gaia_onLoginSubmit());"> <input type="hidden" name="continue" id="continue" value="http://codereview.chromium.org/_ah/login?continue=http://codereview.chromium.org/210007/description" /> <input type="hidden" name="service" id="service" value="ah" /> <input type="hidden" name="ltmpl" id="ltmpl" value="gm" /> <input type="hidden" name="ltmpl" id="ltmpl" value="gm" /> <input type="hidden" name="ahname" id="ahname" value="Chromium Code Reviews" /> <input type="hidden" name="ltmpl" id="ltmpl" value="gm" /> </form> <br/> <table class="form-noindent" border="0" cellpadding="6" cellspacing="3" width="100%"> <tr> <td bgcolor="#e8eefa" align="center" style="font-size:83%"> <b>Don't have a Google Account? </b><br/> <a href='https://www.google.com/accounts/NewAccount?continue=http%3A%2F%2Fcodereview.chromium.org%2F_ah%2Flogin%3Fcontinue%3Dhttp%3A%2F%2Fcodereview.chromium.org%2F210007%2Fdescription&amp;service=ah&amp;ltmpl=gm&amp;sig=909f6cca8e55250406f8bfbd303ab4a9' > <b>Create an account now</b> </a> </td> </tr> </table> </div> <br/> </div> </td> </tr> </table> </div> <div class="footer"> &copy;2009 Google - <a href='http://www.google.com/'>Google Home</a> - <a href='https://www.google.com/accounts/TOS?hl=en'>Terms of Service</a> - <a href='http://www.google.com/intl/en/privacy.html'>Privacy Policy</a> - <a href='http://www.google.com/support/accounts?hl=en'>Help</a> </div> </div> </body> </html> Review URL: http://codereview.chromium.org/210007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26685 0039d316-1c4b-4281-b951-d872f2087c98
* Adding basic window control to the automation provider for the Mac.avi@chromium.org2009-09-211-40/+0
| | | | | | | | | BUG=http://crbug.com/16616 TEST=as described in bug. Review URL: http://codereview.chromium.org/216024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26681 0039d316-1c4b-4281-b951-d872f2087c98
* Change the view mode when switching between moles and toolstrips, anderikkay@chromium.org2009-09-191-0/+1
| | | | | | | | | | | | | | propogate this into the class of the document element so that it's possible to use CSS rules to control the display of your toolstrip/mole. BUG=21939,15494 TEST=run the Mappy extension and verify it can open and close Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26635 Review URL: http://codereview.chromium.org/208020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26654 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Polish the search engine managerrsesek@chromium.org2009-09-192-0/+6
| | | | | | | | | | | | | | | * Make the edit search engine window a sheet. * Only allow one instance of the search engine manager to be opened at once. * The search engine manager now remembers its position. * Create NSWindow(LocalStateAdditions) category to assist with storing window position in Chromium's local state. BUG=21761,21762,21883,21996 TEST=Editing/adding a search engine happens in a sheet. Press [Manage] multiple times and only 1 window should open. Press [Manage] and the window should be at its last position. Review URL: http://codereview.chromium.org/207027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26646 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 26635 - Change the view mode when switching between moles and ↵mbelshe@google.com2009-09-181-1/+0
| | | | | | | | | | | | | | | | | | toolstrips, and propogate this into the class of the document element so that it's possible to use CSS rules to control the display of your toolstrip/mole. BUG=21939,15494 TEST=run the Mappy extension and verify it can open and close Review URL: http://codereview.chromium.org/208020 TBR=erikkay@chromium.org Review URL: http://codereview.chromium.org/210024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26636 0039d316-1c4b-4281-b951-d872f2087c98
* Change the view mode when switching between moles and toolstrips, anderikkay@chromium.org2009-09-181-0/+1
| | | | | | | | | | | | propogate this into the class of the document element so that it's possible to use CSS rules to control the display of your toolstrip/mole. BUG=21939,15494 TEST=run the Mappy extension and verify it can open and close Review URL: http://codereview.chromium.org/208020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26635 0039d316-1c4b-4281-b951-d872f2087c98
* Changes x11_util::GetRenderVisualFormat to keep a cache of rendersky@chromium.org2009-09-182-7/+54
| | | | | | | | | | | | picts. This way we can support different visuals while still caching the value. BUG=none TEST=none Review URL: http://codereview.chromium.org/210021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26615 0039d316-1c4b-4281-b951-d872f2087c98
* CL is the same as http://codereview.chromium.org/173487, but had to be moved ↵cira@chromium.org2009-09-183-38/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | to new CL number because I switched machines. Implemented the rest of loading/parsing logic for extension i18n: 1. Loading message catalogs for default and application locale. 2. Parsing JSON and replacing placeholders with actual content within a message. 3. Creating unified dictionary (union of default and application dictionaries, where application dict. has priority for common messages). New class ExtensionMessageBundle holds new dictionary, and parses data. It's injected into Extension. ExtensionMessageHandler::ReplaceVariablesInString can replace both $placeholders$ and __MSG_messages__ in given string (HTML, manifest, actual message string...). Implemented actual manifest name/description replacement too, as an example. Extension is now pretty agnostic about localization, and this makes it easier to use message bundles with things that are not extensions... BUG=12131 Review URL: http://codereview.chromium.org/202063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26609 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of a few NOTIMPLEMENTEDs in the scaffolding.pinkerton@chromium.org2009-09-181-11/+4
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/209035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26608 0039d316-1c4b-4281-b951-d872f2087c98
* This CL makes the browser focus tests faster by replacingjcampan@chromium.org2009-09-182-1/+9
| | | | | | | | | | | | some time-outs with notifications. BUG=22065 TEST=Run the interactive tests, especially BrowserFocusTest*FocusTraversal* These tests should run in few seconds. Review URL: http://codereview.chromium.org/210013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26597 0039d316-1c4b-4281-b951-d872f2087c98
* Try again to land "Implement script API:executeScript"aa@chromium.org2009-09-183-0/+75
| | | | | | | | | http://codereview.chromium.org/173556 TBR=mpcomplete@chromium.org Patch from Jerry Tang <tangjie@google.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26556 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug where we fail to install an extension that has an emptyaa@chromium.org2009-09-184-13/+1
| | | | | | | | | | | | | | | | permissions array in its manifest. This was caused an old attempt to display a warning in this situation, back when we were ambitious. BUG=22157 TEST=Install extension associated with bug. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26534 Review URL: http://codereview.chromium.org/213009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26555 0039d316-1c4b-4281-b951-d872f2087c98
* Preparing rollback in case things don't work out.bradnelson@google.com2009-09-188-76/+0
| | | | | | | | | | | This rolls back 26540, gregoryd's attempt at a nacl landing. BUG=None TEST=None Review URL: http://codereview.chromium.org/213019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26543 0039d316-1c4b-4281-b951-d872f2087c98
* This is a copy of http://codereview.chromium.org/153002/showgregoryd@google.com2009-09-188-0/+76
| | | | | | | | | | First step towards NaCl-Chrome integration:1. NaCl plugin becomes a built-in plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. This CL relies on another CL that contains the changes on the Native Client side: http://codereview.chromium.org/1501904. Command line flag "--internal-nacl" is required to enable the built-in NaCl plugin.5. NaCl still cannot run in Chrome sandbox, so the "--no-sandbox" flag is also required TBR=bradnelson Review URL: http://codereview.chromium.org/207025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26540 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 26534: "Fix bug where we fail to install an extensionaa@chromium.org2009-09-181-0/+5
| | | | | | | | that has an empty" TBR=rafaelw@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26538 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug where we fail to install an extension that has an emptyaa@chromium.org2009-09-181-5/+0
| | | | | | | | | | | | | | permissions array in its manifest. This was caused an old attempt to display a warning in this situation, back when we were ambitious. BUG=22157 TEST=Install extension associated with bug. Review URL: http://codereview.chromium.org/213009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26534 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Strict transport security: add checkbox to clear state."agl@chromium.org2009-09-182-2/+0
| | | | | | | This reverts commit r25955. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26528 0039d316-1c4b-4281-b951-d872f2087c98
* Two extensions doc cleanups.asargent@chromium.org2009-09-174-20/+64
| | | | | | | | | | | | | -Note presence of tab property on message ports in background pages and toolstrips -Fix pageActions listener callback reference BUG=none TEST=none Review URL: http://codereview.chromium.org/208003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26517 0039d316-1c4b-4281-b951-d872f2087c98
* Clarify what content scripts can and can't do. Overview overhaulkathyw@google.com2009-09-174-12/+168
| | | | | | | | | | (with further clarification) will be in a later CL. TBR=aa Review URL: http://codereview.chromium.org/216015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26514 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/211002 for Charlie:sky@chromium.org2009-09-172-0/+4
| | | | | | | | | | | | Add touchpad speed factor setting to Chrome OS touchpad settings page. Created slider widget with native gtk widget. TEST=none BUG=none Review URL: http://codereview.chromium.org/209016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26511 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused prefs.tony@chromium.org2009-09-172-34/+0
| | | | | | | | | | No code references these, so I'm removing them. I kept some printing prefs that maruel says he's going to be using soon. Review URL: http://codereview.chromium.org/209019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26506 0039d316-1c4b-4281-b951-d872f2087c98
* Add Profile Import Process Type.jeremy@chromium.org2009-09-172-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | This is currently only used on OS X. We need a separate process to do profile import for 3 reasons: 1)In Firefox we load external libraries which we have no control over. 2)Conceptually it's safer to run parsing code OOP. 3)quoth chrome/browser/importer/nss_decryptor_mac.mm : """ On OS X the nss3 libraries are compiled with depedencies on one another, referenced using dyld's @executable_path directive. To make a long story short in order to get the libraries to load, dyld's fallback path needs to be set to the directory containing the libraries. To do so, the process this function runs in must have the DYLD_FALLBACK_LIBRARY_PATH set on startup to said directory. """ BUG=14458 TEST=None Possible Review URL: http://codereview.chromium.org/193131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26501 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Windows: Warn about outdated plugins."agl@chromium.org2009-09-162-6/+0
| | | | | | | This reverts commit r26409. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26420 0039d316-1c4b-4281-b951-d872f2087c98
* Tweak the sidenav. Also remove unnecessary end-of-line white spacekathyw@google.com2009-09-1628-1236/+1283
| | | | | | | | | | from the template, so that we'll have fewer presubmit warnings. TBR=aa Review URL: http://codereview.chromium.org/214001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26417 0039d316-1c4b-4281-b951-d872f2087c98
* Windows: Warn about outdated plugins.agl@chromium.org2009-09-162-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add the infrastructure for detecting out of date plugins and warning the user about them. Glen was ok with the infobar, although he notes that there will be a better 'notifications' UI for this sort of thing in the future. This UI will trigger at most once a day and only when we load the plugin information. This patch appears to duplicate some information from plugins2.xml, which is the plugins database that the default plugin uses to install missing plugins. I'm not reusing that information in this patch: * Note that the names of the plugins are different between the two. plugins2.xml uses a 'friendly' name, while this code needs to know the name that the plugin itself uses. * Also note that URLs are different. plugins2.xml wants a link to an exe for the installer, while we want a landing page. * The code for loading and parsing plugins2.xml is in the default plugin, and thus would require a lot of major refactoring to use here. Regarding the second point, above. One could imagine that we open a tab to "about:update-plugin#MAGICSTRING,application/x-shockwave". Javascript on that page notes the fragment in the URL and creates a plugin of the correct type on the page, passing MAGICSTRING to the plugin. The renderers are updated to know that all plugins on about pages should be directed to the default plugin. The default plugin notes the MAGICSTRING argument and uses a new NPAPI call to validate the string. MAGICSTRING will be a random string, created once per instance which is needed so that the default plugin can know that it's running on behalf of the browser, not some random webpage. When it validates, it doesn't wait for the user to click inside the plugin to trigger the download. It also doesn't trigger a page reload afterwards, instead draws text to the effect of "Successful install". This alternative design would remove the duplication, at the cost of a lot of work. Since it's a UI question, I asked Ben and Glen. However, they didn't get back to me so, for now at least, this simplier solution will suffice. BUG=21100 http://codereview.chromium.org/197053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26409 0039d316-1c4b-4281-b951-d872f2087c98
* Escape ampersands in web view text selection for right click context menu so ↵estade@chromium.org2009-09-161-2/+5
| | | | | | | | | | | | that they don't show up as mnemonics. Also escape underscores in gtk menus so they don't show up as mnemonics (we use ampersands to match windows). BUG=14587 Review URL: http://codereview.chromium.org/203078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26401 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Add a dialog for printing.estade@chromium.org2009-09-162-0/+8
| | | | | | | | | | | | Add an infobar directing users to tell us if they have problems with printing. Hide printing behind --enable-printing flag on linux/gtk. BUG=9847 TEST=none Review URL: http://codereview.chromium.org/200138 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26400 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 21:00:24 +0000