summaryrefslogtreecommitdiffstats
path: root/chrome/common
Commit message (Collapse)AuthorAgeFilesLines
* Basics of a new TabStrip.It's very, very rough, but I wanted to check it in ↵ben@chromium.org2009-07-072-0/+5
| | | | | | | | so I don't have to keep typing svn pset as I pass patches back and forth between machines.Behind a command line flag --enable-tabtastic2.I'm trying to split the TabContents specific stuff off of the TabStrip so it's more generic (and more easily mocked for unit testing of various layout conditions). Hence TabStrip vs. BrowserTabStrip. TabStrip may move into views/ once this process is complete.Animator is a utility that can be associated with a View that (at this point) animates that View's bounds from wherever it is now to somewhere else. The TabStrip uses this to do animations for individual Tabs that are independent of each other - a limitation of the old TabStrip is that only one animation is ever active at a time so its animations are a little jumpy compared to other products.Also, detached tab dragging shows the live contents, with all animations/video/etc.Like I said, this is really rough, but I didn't want it to grow any bigger. I will write up a design doc later.http://crbug.com/9032TEST=TBD... will finally be doing some for TabStrip layout! Review URL: http://codereview.chromium.org/42490 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20053 0039d316-1c4b-4281-b951-d872f2087c98
* linux: OOP windowed pluginsevan@chromium.org2009-07-072-1/+28
| | | | | | | | | | | | | | There are still a few issues, but that's a start. - only windowed plugins - we can't currently create the gtksocket in background tabs, because their gtkwidgets are not yet in the hierarchy, so they can't be realized (that's what gives the XID). - the plugin process talks to the browser process through the renderer process to create/destroy the gtksockets, because the plugin doesn't know which renderer it's talking to. We need a bit more plumbing to be able to have direct IPC. - some code is duplicated between chrome and test_shell. We should probably refactor it, but I'm not sure where the common part should live. Patch from Antoine Labour <piman@google.com>, with some touchups by me. Review URL: http://codereview.chromium.org/146078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20041 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "linux: OOP windowed plugins"evan@chromium.org2009-07-062-28/+1
| | | | | | This reverts r19983. Test failures on Mac and Windows. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19988 0039d316-1c4b-4281-b951-d872f2087c98
* linux: OOP windowed pluginsevan@chromium.org2009-07-062-1/+28
| | | | | | | | | | | | There are still a few issues, but that's a start. - only windowed plugins - we can't currently create the gtksocket in background tabs, because their gtkwidgets are not yet in the hierarchy, so they can't be realized (that's what gives the XID). - the plugin process talks to the browser process through the renderer process to create/destroy the gtksockets, because the plugin doesn't know which renderer it's talking to. We need a bit more plumbing to be able to have direct IPC. - some code is duplicated between chrome and test_shell. We should probably factor it, but I'm not sure where the common part should live. Review URL: http://codereview.chromium.org/146078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19983 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the current remaining Views-GTK compile and linker errors.brettw@chromium.org2009-07-061-0/+25
| | | | | | | | Chrome still doesn't run. Review URL: http://codereview.chromium.org/155026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19977 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes two documentation bugs in property_bag.sky@chromium.org2009-07-061-4/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/155012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19945 0039d316-1c4b-4281-b951-d872f2087c98
* Move Emf class to the printing library. Also creates a platform agnostic ↵sverrir@google.com2009-07-064-614/+4
| | | | | | | | | | | NativeMetafile definition to ease platform porting. BUG=none TEST=none (No functional change) Review URL: http://codereview.chromium.org/149181 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19943 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: preserve focus on activating dev tools window.pfeldman@chromium.org2009-07-061-0/+3
| | | | | | | | BUG=15912 Review URL: http://codereview.chromium.org/155068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19938 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Acid3 Test 48: LINKTEST, Chromium side....dglazkov@chromium.org2009-07-032-0/+11
| | | | | | | | | | | | | | | | | R=brettw BUG=http://crbug.com/231 BUG=http://crubg.com/5160 TEST=ExpireHistoryTest.ArchiveSomeOldHistory TEST=ExpireHistoryTest.ExpiringVisitsReader TEST=VisitedLinkTest.Listener TEST=VisitedLinkTest.Resizing TEST=VisitedLinkRelayTest.* TEST=VisitedLinkEventsTest.* Review URL: http://codereview.chromium.org/113591 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19910 0039d316-1c4b-4281-b951-d872f2087c98
* Move RenderViewHostManager back to tab_contents. Moving it to renderer_hostbrettw@chromium.org2009-07-031-6/+0
| | | | | | | | | | | | | | | was a bad idea because of its significant dependencies on NavigationController and NavigationEntry. I'm trying to make renderer_host not depend on tab_contents at all. Remove the dependency on TabContents pointers for notifications from the ResourceDispatcherHost. Instead of having the broadcast code in the ResourceDispatcherHost, I made it call a RenderViewHostDelegate callback. Then TabContents implements the notification, so that it's really from the TabContents. Review URL: http://codereview.chromium.org/150069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19909 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused notification in print code to simplify before refactoring.sverrir@google.com2009-07-031-6/+0
| | | | | | | | | | | | Removed the PRINTED_DOCUMENT_UPDATED notification and move the debug output from PrintJobManager to PrintedDocument. Also made the --debug-print startup parameter only active in non-official builds. BUG=none TEST=Should have no functional affect. Review URL: http://codereview.chromium.org/149148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19907 0039d316-1c4b-4281-b951-d872f2087c98
* Foundations for Print Preview and Setupmhm@chromium.org2009-07-032-0/+2
| | | | | | | | | | | | | Create the foundations of implementing a tab for printing should be in the form of: print:http://www.google.com I have followed similar approach as what has been done with view-source: and chrome-extension: BUG=173, 947 TEST=none Review URL: http://codereview.chromium.org/150207 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19906 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing unitialized variable (Coverity nit).finnur@chromium.org2009-07-031-2/+3
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/155025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19888 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Initial implementation of using GTK themes, partially based on evan's ↵erg@google.com2009-07-032-0/+9
| | | | | | | | | | | | | | | | | | | | | | | CL 118358. A lot of stuff works: - Colors are picked out of the GTK theme. - Buttons use the current GTK button theme. - We use the user's icon theme. A lot of stuff doesn't: - We could do a better job of picking colors for the skylines. - The omnibox hasn't been touched. - UI that's not part of the toolbar hasn't been touched. - We currently fail on themes like HighContrastInverse. TEST=Under Options>Personal Stuff, click GTK Theme. Colors and widgets should be rendered with the current GTK theme stuff. TEST=With chrome open and in GTK Theme mode, change your GTK theme or icon theme. chrome should pick up on the change immediately and reimport the colors and images. http://crbug.com/13967 Review URL: http://codereview.chromium.org/150176 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19868 0039d316-1c4b-4281-b951-d872f2087c98
* Add getFileSize support to chromiumvictorw@chromium.org2009-07-031-0/+5
| | | | | | | | | | | | | | | | | The current implementation only allows getting file size if the child process has been granted permission to upload file. May need to update the policy checking code if getFileSize is needed in other cases. Here is the webkit implementation to support this: https://bugs.webkit.org/show_bug.cgi?id=26521 TEST=none BUG=9102 Review URL: http://codereview.chromium.org/131082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19866 0039d316-1c4b-4281-b951-d872f2087c98
* Add a couple of more extension unit tests for pagefinnur@chromium.org2009-07-022-2/+91
| | | | | | | | | | | | | actions. One for the helper function that parses a page action from the manifest and another that tests the page action api. BUG=None TEST=None Review URL: http://codereview.chromium.org/151181 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19840 0039d316-1c4b-4281-b951-d872f2087c98
* Implement Add and Update for PasswordStoreMac.stuartmorgan@chromium.org2009-07-022-0/+6
| | | | | | | | | | | Modify LoginDatabase slightly to give PasswordStoreMac enough information to do the right thing. Add creator code for keychain items we create, and unit tests to make sure. BUG=11745 TEST=Visit a site for which you have a password in the Keychain. Type your username, unfocus the field, and then log in with the filled password. Log out, return to the login page, and the username and password should now autofill without user interaction. Review URL: http://codereview.chromium.org/151176 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19822 0039d316-1c4b-4281-b951-d872f2087c98
* Fix: Spurious SQL error message is logged in priming SQLite database cache.yuzo@chromium.org2009-07-021-14/+1
| | | | | | | | | | | | | | | | | | | | This patch depends on the MetaTableHelper refactoring in: http://codereview.chromium.org/150094 Currently, a spurious SQL error message is logged every time a unit test that access SQLite database runs. Example: [----------] 6 tests from HistoryBackendTest [ RUN ] HistoryBackendTest.Loaded [5660:5304:0630/150705:414864129:ERROR:sqlite_utils.cc(204)] SQLStatement.prepare_v2 failed: no such table: meta BUG=none TEST=n/a Review URL: http://codereview.chromium.org/150095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19803 0039d316-1c4b-4281-b951-d872f2087c98
* PageActions can now specify multiple icons and switch between themfinnur@chromium.org2009-07-013-16/+63
| | | | | | | | | | | using optional parameters to enableForTab. BUG=http://crbug.com/11906 TEST=None Review URL: http://codereview.chromium.org/149046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19772 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Add docked pane into the browser view.pfeldman@chromium.org2009-07-012-0/+9
| | | | | | Review URL: http://codereview.chromium.org/150160 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19723 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Introduce docked version of DevTools.pfeldman@chromium.org2009-07-011-3/+8
| | | | | | Review URL: http://codereview.chromium.org/149071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19713 0039d316-1c4b-4281-b951-d872f2087c98
* A quick fix for Issue 15531 and 10953hbono@chromium.org2009-07-012-1/+5
| | | | | | | | | | | | | | This issue is caused by my another mistake that I forgot setting the modifier-key state in creating a Char event in RenderWidgetHostViewGtkWidget::ForwardCharEvent(). Since the GtkIMContext signal-handlers don't use GdkEventKey objects and cannot get the modififer-key state, this change save the state in RenderWidgetHostViewGtkWidget::KeyPressReleaseEvent() before dispatching a key event to the GtkIMContext object. Also, this change adds gtk_im_context_focus_in() and gtk_im_context_focus_out() calls to fix compatibility problems with ibus. BUG=10953 "IME support" BUG=15531 "regression: shift-space doesn't scroll the page backwards" TEST=Open a test page in <http://crbug.com/15531>, press shift+space keys, and observe ev.shiftKey is true. Review URL: http://codereview.chromium.org/151010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19707 0039d316-1c4b-4281-b951-d872f2087c98
* Send port disconnect events when a frame is unloaded.mpcomplete@chromium.org2009-07-011-0/+5
| | | | | | | | | | | | This is the other half of CL http://codereview.chromium.org/125280, which I split into http://codereview.chromium.org/147033 and this CL. BUG=12686 TEST=no Review URL: http://codereview.chromium.org/150125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19686 0039d316-1c4b-4281-b951-d872f2087c98
* Wire up a LoginDatabase for PasswordStoreMac, and start using it for lookup.stuartmorgan@chromium.org2009-06-302-0/+2
| | | | | | | | | | (Although it will always be empty at this point, since storage isn't implemented yet.) BUG=11745 TEST=none (no user-visible effect yet) Review URL: http://codereview.chromium.org/147044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19685 0039d316-1c4b-4281-b951-d872f2087c98
* Reland arv's NNTP enablery after it was reverted in 19603glen@chromium.org2009-06-302-6/+9
| | | | | | | | TBR=arv Review URL: http://codereview.chromium.org/151108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19651 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 19593.glen@chromium.org2009-06-302-9/+6
| | | | | | Review URL: http://codereview.chromium.org/150112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19603 0039d316-1c4b-4281-b951-d872f2087c98
* Create A/B test of SDCHjar@chromium.org2009-06-301-10/+10
| | | | | | | | | | | | | | | | | | | | | To do this, I needed to add the feature that ALL FieldTrials that are established in the browser process are forwarded and established in the corresponding renderer processes. This then allows both DNS impact, as well as SDCH inmpact (and any other field tests) to be studied at the same time in a single binary. This checkin also establishes a pattern that when we're doing A/B tests via a histogram such as RequestToFinish, that we produce names for all groups, rather than leaving one group as the "default" or "empty postfix" group. This is critical for naming various sub-groups when a multitude of tests are taking place at the same time. BUG=15479 r=mbelshe Review URL: http://codereview.chromium.org/150087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19595 0039d316-1c4b-4281-b951-d872f2087c98
* Enable the NNTP by default.arv@google.com2009-06-302-6/+9
| | | | | | | | | | | | | | | | | This renames the command line flags a bit. --new-tab-page=path/to/file.html --old-new-tab-page BUG=13362 TEST=Launch chrome and you should see the new new tab page. Review URL: http://codereview.chromium.org/151054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19593 0039d316-1c4b-4281-b951-d872f2087c98
* Remove cache_uittest.cc.ericroman@google.com2009-06-301-179/+0
| | | | | | | | | | This test is flaky, and doesn't add anything on top of what the net/http/http_network_transaciton_unittest.cc or net/http/http_cache_unittest.cc unit-tests already check for. BUG=6491 Review URL: http://codereview.chromium.org/151046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19572 0039d316-1c4b-4281-b951-d872f2087c98
* Take two for http://codereview.chromium.org/131094tim@chromium.org2009-06-291-0/+2
| | | | | | | | This time without browser_tests timeout that caused the revert. The problem was BrowsingHistoryHandler trying to use a dom_ui_ before being attached. Review URL: http://codereview.chromium.org/149117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19556 0039d316-1c4b-4281-b951-d872f2087c98
* Allow extension extensions to be case-insensitive.avi@chromium.org2009-06-292-0/+11
| | | | | | | | | BUG=none TEST=try to load an extension with a capital letter or two in the extension's extension. It should load. Review URL: http://codereview.chromium.org/147017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19520 0039d316-1c4b-4281-b951-d872f2087c98
* Remove --enable-web-workers command-line switch.dimich@google.com2009-06-292-4/+0
| | | | | | | | BUG=4361 TEST=many ui/layout tests. Review URL: http://codereview.chromium.org/149114 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19512 0039d316-1c4b-4281-b951-d872f2087c98
* Use C99 standard format macros for 64-bit values.agl@chromium.org2009-06-291-3/+4
| | | | | | | | | | | | | | | | | | | Currently we have several uses of %I64d in format strings to indicate a 64-bit value. This does not work on Mac or Linux, where 'I' indicates the use of locale specific digits. Instead, we introduce base/format_macros.h which mimic the C99 standard macros for 64-bit values in a cross-platform manner. Dean pointed out that V8 is handling this themselves rather than use inttypes.h. Maybe we'll end up going down the same path but, for the moment, we'll try and do it the 'correct' way and see how it works out. http://codereview.chromium.org/147154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19500 0039d316-1c4b-4281-b951-d872f2087c98
* Added stub native web worker support, including build support in preparationsehr@google.com2009-06-292-0/+4
| | | | | | | for integrating the native client build. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19479 0039d316-1c4b-4281-b951-d872f2087c98
* A first implementation of the SSL client auth UI.This uses the Windows API ↵jcampan@chromium.org2009-06-272-10/+0
| | | | | | | | that prompts the user for a cert.R=wtcBUG=http://crbug.com/318TEST=Visit a site that requires client auth. A dialog to select a certificate should be shown. Try selecting no cert. Try again this time select a cert. Review URL: http://codereview.chromium.org/147233 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19456 0039d316-1c4b-4281-b951-d872f2087c98
* mac/linux: rework plugin channel file descriptor creationevan@chromium.org2009-06-272-12/+2
| | | | | | | | | | | | This CL fixes a bug where the same renderer could open several channels to the same plugin process, which end up having the same name. This CL makes it that there is only one channel for each (plugin, renderer) pair, just like on Windows. The socketpair is created in the plugin process (which can ensure that only one channel per renderer gets created), and sends the renderer side through the browser process. Note: this should essentially be a noop on Windows. Review URL: http://codereview.chromium.org/149062 Patch from Antoine Labour <piman@google.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19448 0039d316-1c4b-4281-b951-d872f2087c98
* revert cl 19438rvargas@google.com2009-06-272-11/+12
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/149116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19444 0039d316-1c4b-4281-b951-d872f2087c98
* Add a command line switch to allow setting the max sizervargas@google.com2009-06-262-0/+8
| | | | | | | | | | | | | | of the disk cache. This switch is intended for troubleshooting, not to add another supported configuration. BUG=15117 TEST=none Review URL: http://codereview.chromium.org/146136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19439 0039d316-1c4b-4281-b951-d872f2087c98
* Make the new new tab page the default new tab page.arv@google.com2009-06-262-12/+11
| | | | | | | | | | | | | I changed the command line switch "--new-new-tab-page" to "-new-tab-page=<path>" so we can continue to iterate. BUG=13362 TEST=The new new tab page should be on by default. Review URL: http://codereview.chromium.org/147226 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19438 0039d316-1c4b-4281-b951-d872f2087c98
* Missed a test that needed to be updated with r19418.mark@chromium.org2009-06-261-7/+15
| | | | | | | | BUG=15462 TEST=unit_tests --gtest_filter=JSONValueSerializerTest.Roundtrip Review URL: http://codereview.chromium.org/149103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19422 0039d316-1c4b-4281-b951-d872f2087c98
* Use platform-appropriate newlines in JSON output.mark@chromium.org2009-06-262-3/+5
| | | | | | | | BUG=15462 TEST=base_unittests, unit_tests, check newlines in bookmarks file Review URL: http://codereview.chromium.org/147220 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19418 0039d316-1c4b-4281-b951-d872f2087c98
* Do some minor cleanup I noticed in SiteInstance. Before, we would parse andbrettw@chromium.org2009-06-262-1/+7
| | | | | | | | | | | | canonicalize the three about URLs every time this function was called (I think for every page transition). This is unnecessary, so I just added a string comparison. TEST=none BUG=none Review URL: http://codereview.chromium.org/149084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19416 0039d316-1c4b-4281-b951-d872f2087c98
* Use regular notifications for theme changes.tc@google.com2009-06-261-0/+3
| | | | | | | | | | | | | This should have no impact on the current behavior. On linux, we'll want to get these notifications in a few places other than just the root browser windows so having it as a regular notification makes it easier for us to just listen for the event. Review URL: http://codereview.chromium.org/149032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19414 0039d316-1c4b-4281-b951-d872f2087c98
* linux plugins: eliminate GtkWidget* from plugin processevan@chromium.org2009-06-261-0/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | [retry with mac hopefully fixed this time] GtkWidget* (and its wrapper, gfx::NativeView) only work within a single process. Plugins already work with a lower-level type that works across processes -- an X Window id. The parent of a plugin is an HWND on windows, but it's an X Window id on X. So we introduce a new typedef wrapping that and push it through all the places in the code that needs it. Since we no longer have a GtkSocket in the WebPluginDelegateImpl, we need to do a bit more work in the WebViewDelegate (aka the browser process in the multiproc world). We also need the plugin host (the browser) to track the GtkSockets that are hosting the plugin, as well as destroy them when necessary. To do this we require the plugin owner to grab the plug-removed signal rather than putting its handler in GtkPluginContainer; this is the way it worked before I'd refactored into GtkPluginContainer so it shouldn't be so bad. This change still only works in test_shell, but the refactoring should translate to the multiprocess case pretty easily. Review URL: http://codereview.chromium.org/146009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19387 0039d316-1c4b-4281-b951-d872f2087c98
* Revert cl 19359 due to browser_tests timeout.tim@chromium.org2009-06-261-2/+0
| | | | | | | TBR=nsylvain Review URL: http://codereview.chromium.org/147206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19363 0039d316-1c4b-4281-b951-d872f2087c98
* Add a 'RegisterMessages' function to DOMMessageHandler to make it easy to ↵tim@chromium.org2009-06-261-0/+2
| | | | | | | | | | | | | | construct these objects by deferring the DOMUI dependency to the init / "Attach" step. Add GetMessageHandlers to HtmlDialogUIDelegate to allow sending/receiving messages to the page hosted in the dialog as opposed to only on open/close. BUG=none TEST=none Review URL: http://codereview.chromium.org/131094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19359 0039d316-1c4b-4281-b951-d872f2087c98
* Revert all of my patches from today.evan@chromium.org2009-06-261-19/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19328 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r19318. Seems we're blocking some UI thread though I thought we ↵thestig@chromium.org2009-06-261-1/+1
| | | | | | | | | | didn't here. BUG=15342 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19326 0039d316-1c4b-4281-b951-d872f2087c98
* linux plugins: eliminate GtkWidget* from plugin processevan@chromium.org2009-06-261-0/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | GtkWidget* (and its wrapper, gfx::NativeView) only work within a single process. Plugins already work with a lower-level type that works across processes -- an X Window id. The parent of a plugin is an HWND on windows, but it's an X Window id on X. So we introduce a new typedef wrapping that and push it through all the places in the code that needs it. Since we no longer have a GtkSocket in the WebPluginDelegateImpl, we need to do a bit more work in the WebViewDelegate (aka the browser process in the multiproc world). We also need the plugin host (the browser) to track the GtkSockets that are hosting the plugin, as well as destroy them when necessary. To do this we require the plugin owner to grab the plug-removed signal rather than putting its handler in GtkPluginContainer; this is the way it worked before I'd refactored into GtkPluginContainer so it shouldn't be so bad. This change still only works in test_shell, but the refactoring should translate to the multiprocess case pretty easily. Review URL: http://codereview.chromium.org/146009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19320 0039d316-1c4b-4281-b951-d872f2087c98
* Reap dead xdg-open processes so they don't turn into zombies.thestig@chromium.org2009-06-261-1/+1
| | | | | | | | BUG=15342 TEST=Click show in folder for a download, close the file manager that opens up, run ps and make sure the xdg-open process didn't turn into a zombie. Review URL: http://codereview.chromium.org/147167 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19318 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-12 21:15:25 +0000