| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit baefae90f294a981c973bffbdd3eccabfe796b6a.
The change broke Chrome for Android because non-vanilla protobuf-lite
Java files were generated.
Original review:
https://codereview.chromium.org/11228038/
TBR=phajdan.jr
BUG=160256
Review URL: https://codereview.chromium.org/11359146
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
of a filesystem as a parameter. This ensures that the file system has been initialized by calling requestFileSystem first before any other operations are possible. This also removes the need to take in DOMString serviceName as a parameter as it can be extracted from the FileSystem Instance.
BUG=160206
Review URL: https://chromiumcodereview.appspot.com/11360187
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167162 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The blue border is ugly. It should be removed.
TBR=kalman@chromium.org
BUG=159907
Review URL: https://codereview.chromium.org/11377093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Zombie objects are cleared to '!' to force faster failure. The bug
involves a containing object being zombied, and then trying to message
something it owns. This change will provide info on the object being
messaged, and perhaps info on who deallocated it.
BUG=154483
Review URL: https://chromiumcodereview.appspot.com/11359117
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Broke the build at: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%283%29/builds/16022
A previous CL introduced a smooth curve for computing an acceleration
to be applied at the start of a touchscreen fling. This CL adds the
curve coefficients to the gesture configuration page.
BUG=141653
Review URL: https://chromiumcodereview.appspot.com/11369140
TBR=rjkroege@chromium.org
Review URL: https://codereview.chromium.org/11312176
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A previous CL introduced a smooth curve for computing an acceleration
to be applied at the start of a touchscreen fling. This CL adds the
curve coefficients to the gesture configuration page.
BUG=141653
Review URL: https://chromiumcodereview.appspot.com/11369140
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
dev, and stable channel user metrics. Include client-side change to query for the trial.
BUG=160132
Review URL: https://chromiumcodereview.appspot.com/11377042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of input files.
Also added unit test for ZipFiles().
This is to permit caller to specify an arbitrary subset of file contents under a directory to
be included in the created zip file. Although it is possible to achieve this with the existing
function ZipWithFilterCallback(), the required filter callback function would be quite messy
and inefficient.
BUG=138359
TEST=unit_tests, manual tests
Review URL: https://chromiumcodereview.appspot.com/11392005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=mirandac@chromium.org, kalman@chromium.org,
Review URL: https://codereview.chromium.org/11191040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ShouldDisplayIn{AppLauncher,NewTabPage}.
Adds manifest property show_in_new_tab_page (default value=show_in_launcher)
to give component apps a way to indicate that they should only appear in the
app launcher, and not the browser new tab page.
BUG=158880
TEST=unit_tests --gtest_filter=ExtensionTest.DisplayInXManifestProperties, and (on Windows)
settings app icon does appear on app launcher: ./chrome --user-data-dir=empty --enable-settings-app --show-app-list
settings app icon does not appear on NTP: ./chrome --user-data-dir=empty --enable-settings-app
Review URL: https://chromiumcodereview.appspot.com/11362081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=159476
Review URL: https://chromiumcodereview.appspot.com/11368146
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166844 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
features in WebKit to support this).
BUG=157661
TBR=thakis@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11366127
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166809 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Some follow up cls will remove the actual jpg files and do more clean up of the old wallpaper picker code
BUG=141431
Review URL: https://codereview.chromium.org/11368018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166802 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This change removes --enable-nacl-ipc-proxy and adds --enable-nacl-srpc-proxy.
The IPC PPAPI proxy is now the default.
BUG=116317
TEST=manual
Review URL: https://codereview.chromium.org/11358023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
triggered by setting the kShowLogoutButtonInTray to true. This is meant
to happen automatically when logging into a public account but the code
is kept generic so that the logout button can be enabled for other
accounts as well in the future if needed.
BUG=152929
Review URL: https://chromiumcodereview.appspot.com/11345010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Policies.
Currently, csp_validator::HasOnlySecureTokens checks that a source expression in
extensions' Content Security Policy does not end with "*". That's an
insufficient check that both blocks the legal 'https://google.com:*' and allows
the illegal 'https://*/'. This CL expands the check to more strictly check a
given source expression.
BUG=156651
Review URL: https://chromiumcodereview.appspot.com/11194051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=160008
Review URL: https://codereview.chromium.org/11358158
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the SafeSearch preference is set and the user searches on Google the
safe=active&ssui=on parameters are added at the end of the query if they are
not already set to the correct value. We do this after the request was handled by
extensions.
Also added a policy tied to the SafeSearch preference and both unit tests for the
SafeSearch code and browser tests for the policy part.
TBR=thakis@chromium.org
BUG=159241
TEST=Included unit and browser tests.
Review URL: https://chromiumcodereview.appspot.com/11186002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=154624
TEST=None.
Review URL: https://codereview.chromium.org/11363101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=No user visible changes.
Review URL: https://chromiumcodereview.appspot.com/11364135
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166623 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=157636
Review URL: https://chromiumcodereview.appspot.com/11264053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166614 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since this version may be published, its version number needs to be
changed to make it easy for users to identify which version they have.
BUG=NONE
Review URL: https://chromiumcodereview.appspot.com/11372005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166583 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://chromiumcodereview.appspot.com/11361141
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
with unpatched system protobuf.
This is a preparation for landing https://codereview.chromium.org/11231046/
and a solution chosen because our custom protobuf changes will not
be accepted upstream.
Setting defaults to optimize for lite runtime and retain unknown fields
makes it possible to use the same .proto files with system protobuf.
BUG=157155
TEST=none
Review URL: https://codereview.chromium.org/11228038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166534 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
to some common files
BUG=none
R=jam@chromium.org,thakis@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11358137
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166530 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://chromiumcodereview.appspot.com/11275140
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Together with the commands API this makes it possible for an app/extension to
define their own reload shortcut.
The other main use for this API will be to force a reload of an app when an
update is available (at the moment updates get installed immediately, but in the
future this will change to only install updates when the app is not running).
BUG=148745
Review URL: https://chromiumcodereview.appspot.com/11288003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166510 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Somehow I lost this part of the change in r155790.
BUG=144434
Review URL: https://chromiumcodereview.appspot.com/11293151
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166496 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=cduvall@chromium.org
Review URL: https://codereview.chromium.org/11358146
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
--file-manager-packaged switch makes the Files app "packaged" (AKA Apps v2). Many features do not work in this mode yet.
BUG=139604
Review URL: https://codereview.chromium.org/11367106
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
server side
The left nav bar would jostle because it was being processed client side with
JS. Now, it is stored as JSON, and there is minimal client side JS processing.
BUG=144291
Review URL: https://chromiumcodereview.appspot.com/11185020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166396 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For Apps and Extensions with a lazy background page, this will delay installing
an update until the background page gets unloaded (or next chrome restart).
Also adds a chrome.runtime.onUpdateAvailable event which is fired when an update is
available but isn't being installed immediately because the app is not idle.
It doesn't change anything yet for Extensions with a persistent background page
(or extensions without a background page at all). Those still get updated as soon
as an update is found.
BUG=37971
BUG=143260
TBR=nick@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11293002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Issue 151985 caused a one pixel wide column of white on the right side
of the Calculator app on OS X. To make this less visible, elements were
added to the Calculator in http://crrev.com/11091078 that would mask
that column on OS X only. Since then the area next to the Calculator
keyboard has been made gray on all platforms to mitigate any bug that
would allow the Calculator window to be resized. This effectively hides
the one-column-of-white-pixels on OS X so the pixel-hiding hack can be
removed.
BUG=155383
Review URL: https://chromiumcodereview.appspot.com/11368033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
called, replacing the notification from ScriptExecutor::Observer. This fixes a
bug in ScriptBubbleController where calls to tabs.executeScript wasn't showing
a warning.
Review URL: https://chromiumcodereview.appspot.com/11359029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The position of values in the calculator display were changed when the
structure of the calculator elements was changed a while back. This
restores them pixel-for-pixel to the positions of the version of the
calculator first checked in to this source repository, which are the
position originally designed for the calculator.
The equation text positioning had to be changed from floats to tables to
allow the accumulator and operator/operand values to be vertically
aligned on their baseline in spite of the fact that they have different
font sizes. Adding margins or padding to floated elements doesn't work
for this because the fonts used are different on different platforms and
so have different pixel sizes on different platforms.
BUG=158088
Review URL: https://chromiumcodereview.appspot.com/11316012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166310 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=134068
Review URL: https://chromiumcodereview.appspot.com/11193049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was written by Eric Bidelman in a doc;
I've put it into html.
I've expanded the MVC chapter so the tutorials are exposed;
I've also included links in the MVC architecture doc to the tutorials.
Review URL: https://codereview.chromium.org/11193011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=TOT doesn't sad tab on every page.
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/11358119
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
--enable-chrome-style-dialogs.
The dialogs referenced by this flag are not frameless, and the constrained part
will soon be going away also -- see issue 157161. Update the flag to reflect
its proper purpose.
Raised (in part) by ben@ in https://codereview.chromium.org/11275065.
BUG=158772
R=ben@chromium.org
Review URL: https://codereview.chromium.org/11367083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=158536
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11369005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
So that app list could watch for the same state and animate accordingly.
BUG=129236
TEST=Nothing should change. Wait until app list animation lands to verify.
R=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11359047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=158024
Review URL: https://chromiumcodereview.appspot.com/11366057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=158801
TEST=Unit tests in field_trial_unittest.cc
Review URL: https://chromiumcodereview.appspot.com/11366041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166168 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
launcher in the Windows taskbar.
When the flag is on, a shortcut will be created and pinned if it doesn't exist. When it is off, the shortcut will be deleted if it exists.
BUG=158715
Review URL: https://chromiumcodereview.appspot.com/11367002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
PepperMessageFilter.
BUG=116317
TEST=browser_tests, --gtest_filter=PPPAPINaClNewlib.*
Review URL: https://chromiumcodereview.appspot.com/11362076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
On Android, we used to exclude some intents related code and tests.
Now exclusion is based on enable_web_intents in gyp and ENABLE_WEB_INTENTS in code.
BUG=155069
Review URL: https://chromiumcodereview.appspot.com/11362017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
from the IO thread.
BUG=137118
TEST=No user visible changes. This code will be called in a future CL.
Review URL: https://chromiumcodereview.appspot.com/11275103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166103 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
You can now use a $ref to refer to any top level type, event, method, or
property in an API. The docs server searches through the API to find a match
for the node, and renders the link accordingly.
BUG=144505
Review URL: https://codereview.chromium.org/11315018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166099 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Canceling of async operations allows to not wait for their completion
in FileStream's destructor. Other related changes include:
- Got rid of FileStream::Close() and FileStream::CloseSync() methods because
reuse of FileStream object doesn't make much sense, it should be destroyed
instead.
- Changed FileStream to always acquire ownership of the PlatformFile it was
given. Fixed usages of FileStream where no ownership was assumed, introduced
new helper functions in base/platform_file.h on the way.
- FileStream's destructor now always closes the file. If file was opened with
PLATFORM_FILE_ASYNC then actual closing is done asynchronously, destructor
doesn't wait for that and returns immediately. When file was opened without
PLATFORM_FILE_ASYNC closing is done synchronously and the thread doing that
should be allowed to do IO operations.
- Implementation of FileStream is refactored. FileStream is now just a wrapper
around internal object that does all actual work and that can be easily
orphaned in the destructor to not block on the actual file descriptor closing.
All platform-independent code is extracted into a special file and amount of
platform-dependent code is minimized.
BUG=115067, 112474
TEST=net_unittests
Review URL: https://chromiumcodereview.appspot.com/10701050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166091 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=157661
Review URL: https://chromiumcodereview.appspot.com/11270018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166019 0039d316-1c4b-4281-b951-d872f2087c98
|