summaryrefslogtreecommitdiffstats
path: root/chrome/common
Commit message (Collapse)AuthorAgeFilesLines
* plugins: use OnChannelError to detect when the channel goes awayevan@chromium.org2009-07-102-31/+13
| | | | | | | | | | | | | | | Previously we used a special Watcher object to watch the process, but that is not portable to POSIX and this is simpler anyway. With this change, I now see ~PluginProcessHost() running when a plugin crashes. If you recall all the way back to http://codereview.chromium.org/16814 we did a similar thing to the renderer host. Review URL: http://codereview.chromium.org/155331 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20414 0039d316-1c4b-4281-b951-d872f2087c98
* Remove svn:executable property from some more files that don't need it.thestig@chromium.org2009-07-106-0/+0
| | | | | | | TBR=evmar Review URL: http://codereview.chromium.org/149471 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20406 0039d316-1c4b-4281-b951-d872f2087c98
* Convert JavascriptAlertActivatesTab to browser_tests framework.phajdan.jr@chromium.org2009-07-101-0/+10
| | | | | | | | | | | | This should make it non-flaky, so I un-disabled the test. I also added necessary plumbing so we can wait for AppModalDialog to appear and close it. TEST=Covered by browser_tests. http://crbug.com/16062 Review URL: http://codereview.chromium.org/149460 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20400 0039d316-1c4b-4281-b951-d872f2087c98
* Add default browser checking and setting on Linux.mdm@chromium.org2009-07-101-14/+0
| | | | | | | | | BUG=11972 TEST=none Review URL: http://codereview.chromium.org/155100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20380 0039d316-1c4b-4281-b951-d872f2087c98
* Implementation of Extension Updater.asargent@chromium.org2009-07-102-0/+4
| | | | | | | | | | | | This also contains changes to the ExtensionsService to hook up the ExtensionUpdater. BUG=http://crbug.com/12117 TEST=Extensions still work Review URL: http://codereview.chromium.org/149213 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20379 0039d316-1c4b-4281-b951-d872f2087c98
* Add getLanguage function to tab extension.sidchat@google.com2009-07-102-0/+12
| | | | | | | | BUG=none TEST=enable extensions using the toolstip.html code (added with this CL) and load pages in different languages. The corresponding language should appear in the bottom left after the page is loadedm or when the button is clicked, or when you navigate back to that tab after visiting some other tab. Review URL: http://codereview.chromium.org/150062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20378 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "plugins: use OnChannelError to detect when the channel goes away"evan@chromium.org2009-07-102-13/+31
| | | | | | | This reverts commit r20349. Unit test failure. I suspect the test, but let's keep the tree green. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20354 0039d316-1c4b-4281-b951-d872f2087c98
* plugins: use OnChannelError to detect when the channel goes awayevan@chromium.org2009-07-102-31/+13
| | | | | | | | | | | | | | | Previously we used a special Watcher object to watch the process, but that is not portable to POSIX and this is simpler anyway. With this change, I now see ~PluginProcessHost() running when a plugin crashes. If you recall all the way back to http://codereview.chromium.org/16814 we did a similar thing to the renderer host. Review URL: http://codereview.chromium.org/155331 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20349 0039d316-1c4b-4281-b951-d872f2087c98
* Move some more interfaces on RenderViewHostDelegate to separate classes. Thebrettw@chromium.org2009-07-091-3/+8
| | | | | | | | ones in the patch are those that are implemented by other classes, avoiding TabContents pass-throughs. Review URL: http://codereview.chromium.org/149373 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20324 0039d316-1c4b-4281-b951-d872f2087c98
* Change the window background color to the inactive color when thetc@google.com2009-07-091-0/+4
| | | | | | | | | | | | | | | | | | | | window manager says the window isn't active. ActiveWindowWatcher listens for X events and notifies the browser windows when the active window changes. We can't just use focus events because popup menus cause browser windows to lose focus, but it's still the "active" window. Some window managers don't track active window, in which case we don't get the x event and we just say that all windows are active (our current behavior). BUG=14649 Review URL: http://codereview.chromium.org/155303 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20313 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the Linux tab strip zone calculation when using the skyline. We are ↵jhawkins@chromium.org2009-07-091-1/+2
| | | | | | | | | | looking for the top-left origin of the tab strip in screen coordinates, but we sent in the coordinates of this point relative to the entire window to gtk_util::ConvertWidgetPointToScreen. BUG=15867 TEST=Open enough tabs so that they must be resized. Repeatedly press the mouse over a close button so that many tabs are closed. The tabs should not resize until the mouse leaves the tab strip. Review URL: http://codereview.chromium.org/155308 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20306 0039d316-1c4b-4281-b951-d872f2087c98
* Make the API to open a message channel symmetric, so it works the same ↵mpcomplete@chromium.org2009-07-091-2/+9
| | | | | | | | | | | | | | | whether opening from a tab or extension. Also, move the callback handling back to extension_process_bindings, since I didn't need it in event_bindings to implement this, and it didn't make sense there anyway. BUG=12461 TEST=no Review URL: http://codereview.chromium.org/149237 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20296 0039d316-1c4b-4281-b951-d872f2087c98
* A prototype of resource loading through automationamit@chromium.org2009-07-095-65/+84
| | | | | | | | | | | | | | | | In a test scenario where we need to load resources over automation, we intercept the URL reqeusts and serve them using automation IPCs. This resource loading can be enabled per tab created by automation. BUG=none TEST=none Review URL: http://codereview.chromium.org/145024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20267 0039d316-1c4b-4281-b951-d872f2087c98
* Windowed plugins like Flash would cause the hung plugin dialog to show up ↵ananta@chromium.org2009-07-092-6/+47
| | | | | | | | | | | | | | | when the print dialog was displayed. The proposed fix is to signal the modal dialog event which would ensure that the renderer and plugins both pump messages when the print dialog is displayed. This fixes http://code.google.com/p/chromium/issues/detail?id=13804 Bug=13804 Review URL: http://codereview.chromium.org/155133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20243 0039d316-1c4b-4281-b951-d872f2087c98
* Renable sending page urls in renderer crashes on Mac.jabdelmalek@google.com2009-07-092-10/+13
| | | | | | Review URL: http://codereview.chromium.org/149370 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20226 0039d316-1c4b-4281-b951-d872f2087c98
* Get the Mac build compiling while we figure out how SetActiveUrl should be ↵jam@chromium.org2009-07-081-1/+3
| | | | | | | | implemented on Mac. Review URL: http://codereview.chromium.org/149362 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20198 0039d316-1c4b-4281-b951-d872f2087c98
* Add the page url to plugin crashes to aid debugging.jam@chromium.org2009-07-086-0/+322
| | | | | | Review URL: http://codereview.chromium.org/155238 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20191 0039d316-1c4b-4281-b951-d872f2087c98
* Adds tab pinning to TabStripModel. This is just the model side ofsky@chromium.org2009-07-082-0/+5
| | | | | | | | | | | | | | | | | | | things (and tests), no UI yet. The model enforces that all pinned tabs occur at the beginning of the model. For example, if there are no pinned tabs and you pin the 10th tab, it is moved to the front of the tab strip. Similarly inserting a tab before the last pinned tab implicitly pins it. Moving a pinned tab beyond the set of pinned tabs implicitly unpins it. I'll file a bug on this when the site allows me to. BUG=none TEST=none Review URL: http://codereview.chromium.org/155228 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20181 0039d316-1c4b-4281-b951-d872f2087c98
* Revert change 20173 because it breaks the ui_tests, plugin_testsnsylvain@chromium.org2009-07-086-322/+0
| | | | | | | | and most likely some page cyclers. Review URL: http://codereview.chromium.org/155236 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20180 0039d316-1c4b-4281-b951-d872f2087c98
* Add the page url to plugin crashes to aid debugging.jam@chromium.org2009-07-086-0/+322
| | | | | | Review URL: http://codereview.chromium.org/149305 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20173 0039d316-1c4b-4281-b951-d872f2087c98
* Split out some of the RVHDelegate functions into separate sub-classes. To limitbrettw@chromium.org2009-07-081-4/+4
| | | | | | | | | | the scope, this patch just contains those delegate functions implemented only by TabContents, plus the favicon functions implemented by the FavIconHelper. The only changes are re-ordering and moving the functions, and changes in the way that the functions are called through the new optional delegate. Review URL: http://codereview.chromium.org/149239 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20152 0039d316-1c4b-4281-b951-d872f2087c98
* Some code had been removed from FirstRun::IsChromeFirstRun() so that it may ↵jcampan@chromium.org2009-07-081-1/+1
| | | | | | | | return true then false when later invoked.This caused a bug where we would show the info-bar warning that Chromium is not the default browser after the first run.This patch resurrects that code and changes the first run UI, as it was relying on that behavior.BUG=http://crbug.com/15833TEST=Make IE or Firefox your default browser. Open Chromium so it shows the 1st run UI. Unselect the "make chromium my default browser" button, then press start. When Chromium shows up, there should be no info-bar warning you Chromium is not your default browser. Also test that the first run UI still works as expected. Review URL: http://codereview.chromium.org/155168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20151 0039d316-1c4b-4281-b951-d872f2087c98
* Wire GetWindowRect, GetRootWindowRect, and GetScreenInfo out to the UI thread.shess@chromium.org2009-07-081-5/+9
| | | | | | | | | | | | Convert GetScreenInfo to be sync and routed. http://crbug.com/13113 R=darin@chromium.org, jam@chromium.org, amanda@chromium.org TEST=See bug. Review URL: http://codereview.chromium.org/151130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20143 0039d316-1c4b-4281-b951-d872f2087c98
* linux: port Jankometerevan@chromium.org2009-07-083-0/+80
| | | | | | | | | | | | | Originally I had split it into multiple files, but I think it's cleaner to just use one. (I want to use this for measuring plugin jank.) BUG=8077 Review URL: http://codereview.chromium.org/155194 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20130 0039d316-1c4b-4281-b951-d872f2087c98
* Make the cancelling of drag and drop match Safari for Windows. This isarv@google.com2009-07-081-2/+3
| | | | | | | | | | | | | | | | | | a follow up CL to http://codereview.chromium.org/149038 as well as to https://bugs.webkit.org/show_bug.cgi?id=26699 With this change we use DragOperationNone (instead of DragOperationCopy) and NoButton (instead of LeftButton) when the user presses Escape. BUG=12018 TEST=On the new new tab page drag one of the thumbnails out of the window and press escape. The thumbnail should move back to its starting position. Review URL: http://codereview.chromium.org/149296 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20125 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a way to set the boundaries of the browser window througharv@google.com2009-07-081-0/+6
| | | | | | | | | | | | | | | automation and use that to set the size of the window in the "New Tab Cold" to ensure we are testing the normal case and not the small case. BUG=None TEST=The NewTabUIStartupTest, PerfCold should still work. Review URL: http://codereview.chromium.org/149233 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20124 0039d316-1c4b-4281-b951-d872f2087c98
* linux: fix renderer/plugin crash when loading multiple pages with pluginspiman@google.com2009-07-082-6/+14
| | | | | | | | | | Currently we crash if one renderer has a plugin and another one has a plugin that gets destroyed, and started again (e.g. reload). We get away with reload on a single page currently because the process gets torn down. This properly cleans up the socket and channel mapping on both sides, so it can be restarted. Review URL: http://codereview.chromium.org/155174 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20112 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: SUID sandbox supportagl@chromium.org2009-07-082-0/+7
| | | | | | | | | | | | | | | | | | | | | * Make processes dumpable when they crash. * Find crashing processes by searching for a socket inode, rather than relying on SCM_CREDENTIALS. The kernel doesn't translate PIDs between PID namespaces with SCM_CREDENTIALS, so we can't use the PID there. * Use a command line flag to the renderer to enable crash dumping. Previously it tried to access the user's home directory for this information. * Search for a sandbox helper binary and, if found, use it. * Include the source for a sandbox helper binary. It's currently not built by default. http://codereview.chromium.org/149230 R=evan,markus BUG=8081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20110 0039d316-1c4b-4281-b951-d872f2087c98
* Basics of a new TabStrip.It's very, very rough, but I wanted to check it in ↵ben@chromium.org2009-07-072-0/+5
| | | | | | | | so I don't have to keep typing svn pset as I pass patches back and forth between machines.Behind a command line flag --enable-tabtastic2.I'm trying to split the TabContents specific stuff off of the TabStrip so it's more generic (and more easily mocked for unit testing of various layout conditions). Hence TabStrip vs. BrowserTabStrip. TabStrip may move into views/ once this process is complete.Animator is a utility that can be associated with a View that (at this point) animates that View's bounds from wherever it is now to somewhere else. The TabStrip uses this to do animations for individual Tabs that are independent of each other - a limitation of the old TabStrip is that only one animation is ever active at a time so its animations are a little jumpy compared to other products.Also, detached tab dragging shows the live contents, with all animations/video/etc.Like I said, this is really rough, but I didn't want it to grow any bigger. I will write up a design doc later.http://crbug.com/9032TEST=TBD... will finally be doing some for TabStrip layout! Review URL: http://codereview.chromium.org/42490 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20053 0039d316-1c4b-4281-b951-d872f2087c98
* linux: OOP windowed pluginsevan@chromium.org2009-07-072-1/+28
| | | | | | | | | | | | | | There are still a few issues, but that's a start. - only windowed plugins - we can't currently create the gtksocket in background tabs, because their gtkwidgets are not yet in the hierarchy, so they can't be realized (that's what gives the XID). - the plugin process talks to the browser process through the renderer process to create/destroy the gtksockets, because the plugin doesn't know which renderer it's talking to. We need a bit more plumbing to be able to have direct IPC. - some code is duplicated between chrome and test_shell. We should probably refactor it, but I'm not sure where the common part should live. Patch from Antoine Labour <piman@google.com>, with some touchups by me. Review URL: http://codereview.chromium.org/146078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20041 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "linux: OOP windowed plugins"evan@chromium.org2009-07-062-28/+1
| | | | | | This reverts r19983. Test failures on Mac and Windows. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19988 0039d316-1c4b-4281-b951-d872f2087c98
* linux: OOP windowed pluginsevan@chromium.org2009-07-062-1/+28
| | | | | | | | | | | | There are still a few issues, but that's a start. - only windowed plugins - we can't currently create the gtksocket in background tabs, because their gtkwidgets are not yet in the hierarchy, so they can't be realized (that's what gives the XID). - the plugin process talks to the browser process through the renderer process to create/destroy the gtksockets, because the plugin doesn't know which renderer it's talking to. We need a bit more plumbing to be able to have direct IPC. - some code is duplicated between chrome and test_shell. We should probably factor it, but I'm not sure where the common part should live. Review URL: http://codereview.chromium.org/146078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19983 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the current remaining Views-GTK compile and linker errors.brettw@chromium.org2009-07-061-0/+25
| | | | | | | | Chrome still doesn't run. Review URL: http://codereview.chromium.org/155026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19977 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes two documentation bugs in property_bag.sky@chromium.org2009-07-061-4/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/155012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19945 0039d316-1c4b-4281-b951-d872f2087c98
* Move Emf class to the printing library. Also creates a platform agnostic ↵sverrir@google.com2009-07-064-614/+4
| | | | | | | | | | | NativeMetafile definition to ease platform porting. BUG=none TEST=none (No functional change) Review URL: http://codereview.chromium.org/149181 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19943 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: preserve focus on activating dev tools window.pfeldman@chromium.org2009-07-061-0/+3
| | | | | | | | BUG=15912 Review URL: http://codereview.chromium.org/155068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19938 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Acid3 Test 48: LINKTEST, Chromium side....dglazkov@chromium.org2009-07-032-0/+11
| | | | | | | | | | | | | | | | | R=brettw BUG=http://crbug.com/231 BUG=http://crubg.com/5160 TEST=ExpireHistoryTest.ArchiveSomeOldHistory TEST=ExpireHistoryTest.ExpiringVisitsReader TEST=VisitedLinkTest.Listener TEST=VisitedLinkTest.Resizing TEST=VisitedLinkRelayTest.* TEST=VisitedLinkEventsTest.* Review URL: http://codereview.chromium.org/113591 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19910 0039d316-1c4b-4281-b951-d872f2087c98
* Move RenderViewHostManager back to tab_contents. Moving it to renderer_hostbrettw@chromium.org2009-07-031-6/+0
| | | | | | | | | | | | | | | was a bad idea because of its significant dependencies on NavigationController and NavigationEntry. I'm trying to make renderer_host not depend on tab_contents at all. Remove the dependency on TabContents pointers for notifications from the ResourceDispatcherHost. Instead of having the broadcast code in the ResourceDispatcherHost, I made it call a RenderViewHostDelegate callback. Then TabContents implements the notification, so that it's really from the TabContents. Review URL: http://codereview.chromium.org/150069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19909 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused notification in print code to simplify before refactoring.sverrir@google.com2009-07-031-6/+0
| | | | | | | | | | | | Removed the PRINTED_DOCUMENT_UPDATED notification and move the debug output from PrintJobManager to PrintedDocument. Also made the --debug-print startup parameter only active in non-official builds. BUG=none TEST=Should have no functional affect. Review URL: http://codereview.chromium.org/149148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19907 0039d316-1c4b-4281-b951-d872f2087c98
* Foundations for Print Preview and Setupmhm@chromium.org2009-07-032-0/+2
| | | | | | | | | | | | | Create the foundations of implementing a tab for printing should be in the form of: print:http://www.google.com I have followed similar approach as what has been done with view-source: and chrome-extension: BUG=173, 947 TEST=none Review URL: http://codereview.chromium.org/150207 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19906 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing unitialized variable (Coverity nit).finnur@chromium.org2009-07-031-2/+3
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/155025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19888 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Initial implementation of using GTK themes, partially based on evan's ↵erg@google.com2009-07-032-0/+9
| | | | | | | | | | | | | | | | | | | | | | | CL 118358. A lot of stuff works: - Colors are picked out of the GTK theme. - Buttons use the current GTK button theme. - We use the user's icon theme. A lot of stuff doesn't: - We could do a better job of picking colors for the skylines. - The omnibox hasn't been touched. - UI that's not part of the toolbar hasn't been touched. - We currently fail on themes like HighContrastInverse. TEST=Under Options>Personal Stuff, click GTK Theme. Colors and widgets should be rendered with the current GTK theme stuff. TEST=With chrome open and in GTK Theme mode, change your GTK theme or icon theme. chrome should pick up on the change immediately and reimport the colors and images. http://crbug.com/13967 Review URL: http://codereview.chromium.org/150176 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19868 0039d316-1c4b-4281-b951-d872f2087c98
* Add getFileSize support to chromiumvictorw@chromium.org2009-07-031-0/+5
| | | | | | | | | | | | | | | | | The current implementation only allows getting file size if the child process has been granted permission to upload file. May need to update the policy checking code if getFileSize is needed in other cases. Here is the webkit implementation to support this: https://bugs.webkit.org/show_bug.cgi?id=26521 TEST=none BUG=9102 Review URL: http://codereview.chromium.org/131082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19866 0039d316-1c4b-4281-b951-d872f2087c98
* Add a couple of more extension unit tests for pagefinnur@chromium.org2009-07-022-2/+91
| | | | | | | | | | | | | actions. One for the helper function that parses a page action from the manifest and another that tests the page action api. BUG=None TEST=None Review URL: http://codereview.chromium.org/151181 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19840 0039d316-1c4b-4281-b951-d872f2087c98
* Implement Add and Update for PasswordStoreMac.stuartmorgan@chromium.org2009-07-022-0/+6
| | | | | | | | | | | Modify LoginDatabase slightly to give PasswordStoreMac enough information to do the right thing. Add creator code for keychain items we create, and unit tests to make sure. BUG=11745 TEST=Visit a site for which you have a password in the Keychain. Type your username, unfocus the field, and then log in with the filled password. Log out, return to the login page, and the username and password should now autofill without user interaction. Review URL: http://codereview.chromium.org/151176 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19822 0039d316-1c4b-4281-b951-d872f2087c98
* Fix: Spurious SQL error message is logged in priming SQLite database cache.yuzo@chromium.org2009-07-021-14/+1
| | | | | | | | | | | | | | | | | | | | This patch depends on the MetaTableHelper refactoring in: http://codereview.chromium.org/150094 Currently, a spurious SQL error message is logged every time a unit test that access SQLite database runs. Example: [----------] 6 tests from HistoryBackendTest [ RUN ] HistoryBackendTest.Loaded [5660:5304:0630/150705:414864129:ERROR:sqlite_utils.cc(204)] SQLStatement.prepare_v2 failed: no such table: meta BUG=none TEST=n/a Review URL: http://codereview.chromium.org/150095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19803 0039d316-1c4b-4281-b951-d872f2087c98
* PageActions can now specify multiple icons and switch between themfinnur@chromium.org2009-07-013-16/+63
| | | | | | | | | | | using optional parameters to enableForTab. BUG=http://crbug.com/11906 TEST=None Review URL: http://codereview.chromium.org/149046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19772 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Add docked pane into the browser view.pfeldman@chromium.org2009-07-012-0/+9
| | | | | | Review URL: http://codereview.chromium.org/150160 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19723 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Introduce docked version of DevTools.pfeldman@chromium.org2009-07-011-3/+8
| | | | | | Review URL: http://codereview.chromium.org/149071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19713 0039d316-1c4b-4281-b951-d872f2087c98
* A quick fix for Issue 15531 and 10953hbono@chromium.org2009-07-012-1/+5
| | | | | | | | | | | | | | This issue is caused by my another mistake that I forgot setting the modifier-key state in creating a Char event in RenderWidgetHostViewGtkWidget::ForwardCharEvent(). Since the GtkIMContext signal-handlers don't use GdkEventKey objects and cannot get the modififer-key state, this change save the state in RenderWidgetHostViewGtkWidget::KeyPressReleaseEvent() before dispatching a key event to the GtkIMContext object. Also, this change adds gtk_im_context_focus_in() and gtk_im_context_focus_out() calls to fix compatibility problems with ibus. BUG=10953 "IME support" BUG=15531 "regression: shift-space doesn't scroll the page backwards" TEST=Open a test page in <http://crbug.com/15531>, press shift+space keys, and observe ev.shiftKey is true. Review URL: http://codereview.chromium.org/151010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19707 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-13 14:10:51 +0000