| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Part 1."
Original CL: http://codereview.chromium.org/400018/show
Looks like we're no longer hoping to get this approach into mstone4 release, so I'm unwinding this.
BUG=27431
TBR=aa
Review URL: http://codereview.chromium.org/467042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
call FindPreference directly.
BUG=None
TEST=compiles and passes existing tests
Original patch by Thiago Farina <thiago.farina@gmail.com> at
http://codereview.chromium.org/460117/show
Review URL: http://codereview.chromium.org/463044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also added/removed a few commas.
TBR=aa
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/465102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
bookmark example again.)
TBR=aa
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/453021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33976 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is the first in a series of changes for adding notifications to autofill. This change adds the notification plumbing to WebDataService::AddFormFieldValues that sends a simple notification.
The next change will add a Details<> payload to the notification with a list of changes that were performed, and then I will expand the notifications to the other autofill mutation methods.
Review URL: http://codereview.chromium.org/455027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to view the source files. We should improve on this soon.
Also copyedited and reformatted the Samples page.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/464047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
SocketStream should be handled in ChildThread instead of RenderThread to be used in Worker process.
Move SocketStream in chrome/common to satisfy check_deps.
BUG=27618
TEST=none
Review URL: http://codereview.chromium.org/443015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33954 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In this episode we:
-Create a new ChildProcess privilege (SILENT_INSTALL_EXTENSION) which is granted to the extension gallery pages.
-Ensure that extension gallery pages are isolated into their own process which is never shared with other urls.
Important: The SILENT_INSTALL_EXTENSION privilege is never granted any additional abilities in this patch, so this patch only has the effect of grouping gallery URLs into a separate process.
In subsequent patch(es) we plan to (a) observe this new privilege and allow gallery urls to install extensions bypassing the normal prompts, (b) polish this UI flow [in particular, do not show the black "loading" dilaog, (c) check the id of the extension to be installed (from the crx) matches the expected id (from gallery url).
BUG=27431
Review URL: http://codereview.chromium.org/400018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=erikkay@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Google Mail checker sample extension.
BUG=29540
Review URL: http://codereview.chromium.org/465092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=567
TEST=Visit a page, zoom in or out, then navigate to a different host. The new page should not be zoomed. Go back, or restart, or open a new tab and navigate to the old page, and it should be zoomed.
Review URL: http://codereview.chromium.org/437077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33886 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change PlatformCanvas so that it only fills with "sea foam green" when bitmap data is not externally supplied. Modifying the interface to make this an option bloated the CL too much. I may do this as a follow-up.
Adds a new --show-paint-rects command line flag that will render a border around paint rects to help debug and study WebKit painting issues.
R=brettw
BUG=25905
TEST=none
Review URL: http://codereview.chromium.org/414016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Increased IPC message header type from 16 bits to 32 bits so it can accomodate more message classes.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/399013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33832 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add() and Remove() are called from same thread.
Note I already checked in a fix for the bug. The CL
is trying to check whether the issue exists in other
code path.
TEST=none
BUG=27834
Review URL: http://codereview.chromium.org/449044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33802 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
--disable-remote-fonts flag and obsoletes --enable-remote-fonts.
BUG=17818
TEST=(1) Start chromium WITHOUT --disable-remote-fonts. Visit http://www.alistapart.com/d/cssatten/poen.html . Verify that the page is rendered using _remote_ fonts (reference image: http://www.alistapart.com/d/cssatten/poen.png ) / (2) Start chromium WITH --disable-remote-fonts. Visit http://www.alistapart.com/d/cssatten/poen.html . Verify that the page is rendered using _local_ fonts
Review URL: http://codereview.chromium.org/165236
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
-Split extension renderer crashes out of the existing UMA renderer crash metric
into its own metric.
-Add a new metric for the sum of all ChildProcessHost crashes.
-Add histograms for each crash type.
BUG=28022
TEST=We should start getting more crash reports in UMA and histograms.
Review URL: http://codereview.chromium.org/468005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33794 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Change the default RenderViewHostDelegate::GetRendererPrefs to a singleton because initialization may not always be cheap (we assume copying is, however).
BUG=29043
TEST=if you focus a link in an extension popup, you can actually see the focus ring (the focus ring had been set to 0x000000 color)
Review URL: http://codereview.chromium.org/458013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33775 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to mutating extension functions, as discussed on chromium-dev and
in Extensions quotaserver design doc.
Add a hook in the dispatcher to have the quota service assess the request.
Wire up bookmarks.{create, move, remove, update} to the service.
BUG=19899
TEST=ExtensionsQuotaServiceTest, QuotaLimitHeuristicTest (both new)
Review URL: http://codereview.chromium.org/441006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Make it explicit that it only supports ASCII (since it iterates
character by character).
2) Limit the recursion to 16 levels. We could allow more, but in the
case of a ?, it has exponential complexity, so I figured 16 was a good
stopping point. It seems rare that someone would have more than 16
'?' and '*'s.
BUG=28645
Review URL: http://codereview.chromium.org/460047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This menu item only exists in the Mac build, but the code is cross-platform so it could be hooked up on other platforms as well, if desired.
It works by generating a URL of the form
mailto:?subject=Fwd:%20PAGETITLE&body=%0A%0APAGEURL
and telling platform_utils to open it.
This is my first patch involving command handling; I've tried to follow the way similar menu commands
like Print are implemented, but feel free to tell me if there are better ways.
I didn't find any place for unit tests for TabContents; if this needs tests, let me know where they should go.
BUG=29232
TEST=none
Review URL: http://codereview.chromium.org/466019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix pageTitle/pageName error (and do some cleanup to try to prevent confusion in the future).
Note that the pageData-title has changed to pageData-name in all the static pages.
TBR=kathyw,aa
Review URL: http://codereview.chromium.org/465039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This includes three minor doc changes. (1) Conditional text for description of callback based on whether it is optional -- to be less confusing. (2) Setting the page title to "" from the static pageData-title no longer shows a leading " - ". (C) Allows for a page to specify whether it shows the sideNav (and index.html declines to do so).
TBR=kathyw,aa
Review URL: http://codereview.chromium.org/460039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
utility process on OS X.
Other changes:
* An error initializing the sandbox on OS X is now treated as fatal.
* Improved error reporting for sandbox-related failures.
BUG=26492,23837
TEST=Installing extensions and themes should still work on OS X.
Review URL: http://codereview.chromium.org/434077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
part of a fix which would allow to inspect plugin resources.
BUG=2084
Review URL: http://codereview.chromium.org/435044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
A couple of icon changes to news. Bump the version for mappy.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/458011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33623 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
make_page_red
Review URL: http://codereview.chromium.org/465015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33621 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=aa
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/455034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33591 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adding the newly created Email this page extension.
(this time updating the docs page, not just the
static page).
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/466008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33587 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Changing to font-family: sans-serif; (at least on my system) does not seem to actually change the font that is selected, however, font-size: 0.8em; does change the size of the font.
BUG=29095
Review URL: http://codereview.chromium.org/450040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Adding the newly created Email this page extension.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/466005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33579 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add the page selection to the body of the email,
if something is selected.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/460002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33576 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
than Chromium specific, and clean up a few headers.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/449048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33565 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of storing pointers into a vector, store offsets. That
way, if the vector resizes, we should still be OK.
Also, add a DCHECK that we only enter this method once, which
is my current assumption.
Review URL: http://codereview.chromium.org/457028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Local State when writing to disk.
BUG=28836
Review URL: http://codereview.chromium.org/449074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33518 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also adds the npapi headers to the npapi.gyp file since I got tired of
Visual Studio not finding the files.
This removes the "open file in sandbox" feature which it doesn't look like we
will use.
One more significant change is that I changed to including pepper.h in all
cases, even when pepper is disabled. We used to have a forward declare in
npapi.h for the structs in question, but we'll be adding a lot more structs for
the different contexts and I don't think this will scale. I think its OK fo
rthe pepper API declarations to be available when Pepper isn't enabled.
BUT=none
TEST=none
Review URL: http://codereview.chromium.org/453015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33501 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=aa
Review URL: http://codereview.chromium.org/449072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33491 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the gallery.
TBR=rafaelw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33482 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
* Scale back poll rate.
* Focus existing gmail tab instead of creating a new one.
* Prefer https over http
Review URL: http://codereview.chromium.org/449049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Fix up the references to the mac plugin interpose lib for the proper naming from the GYP roll.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/453014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23658
TEST=make sure executable property is not in svn
Review URL: http://codereview.chromium.org/449066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33463 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Load the extension, try emailing pages loaded
using file://, http://, https://, chrome:// and in each
case at least the url of the page should appear in an email
in your default mail handler and in the case of http:// and
https://, also the page title. Then use the Options page
for the extension and try the same with gmail.
Review URL: http://codereview.chromium.org/431028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33447 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
so it's not needed anymore.
BUG=28992
Review URL: http://codereview.chromium.org/449028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
<http://codereview.chromium.org/437028/show>
Review URL: http://codereview.chromium.org/434096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=aa
TEST=none
BUG=27425
Review URL: http://codereview.chromium.org/457016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the user right clicks on the maximize button, it will horizontally maximize the window, and if the user middle clicks on the maximize button it will vertically maximize the window.
At least on kde, the window manager supports more complicated behavior, e.g. right clicking on a window that is horizontally maximized will return it to its former size. It seems to keep track of multiple restored rects. However, we're not well equipped to replicate this behavior, so I just didn't add it. If the user wants it, they can disable the custom frame.
BUG=28881
Review URL: http://codereview.chromium.org/455012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
duplicate the shared memory before passing it to another object that takes ownership. Prevents same handle from being closed twice.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/449026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=aa
TEST=none
BUG=28786
Review URL: http://codereview.chromium.org/457013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
options view
BUG=27657
TEST=unittest passes, manually testing typing "google" in the search field pulls up origins containing "google" in their name
Review URL: http://codereview.chromium.org/437075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=28707
Review URL: http://codereview.chromium.org/456003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/384062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33335 0039d316-1c4b-4281-b951-d872f2087c98
|