| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
TBR=erikkay@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It does not create these threads, the embedder is responsible for
providing them to the appcache library by implementing the class
declared in appcache_thread.h.
Also in this CL are two implementations, one for Chrome and another for test_shell.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/409005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
process: grep for TODO(port), find cruft, clean it up
Review URL: http://codereview.chromium.org/427004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32844 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
extensions-related places.
Also add a virtual destructor in some unrelated infobar.
BUG=27691
Review URL: http://codereview.chromium.org/427002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32840 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
of the field's label once we parse this value from the DOM.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/418032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Fixed header alignment and spacing
* Fixed top nav, removed useless/dead links, added sample link instead
* Fixup requirements in samples and getting started page (beta no workie yet, mac and linux do -- at least enough to not be worth mentioning)
* Make vertical separator bar green
* Make default_icon required for page and browser actions
* Fix incorrect description of how onclick works wrt isolated worlds
* Make the page titles be <page title> - Google Chrome Extensions - Google Code
* Add a warning about NPAPI
BUG=28152,27875,28155,28182,27864,27432
Review URL: http://codereview.chromium.org/437001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32798 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
file:// URLs. It turns out teams were already depending on
this and we didn't want to break them.
Instead, group file:// access with NPAPI in the extension
install prompt.
Note: this is a pure revert of r402029 and r402069 (sorry
Finnur!) except the changes in extension_install_ui.cc,
which are new.
BUG=28456
Review URL: http://codereview.chromium.org/430003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=6844, 27935
Review URL: http://codereview.chromium.org/402097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
http://codereview.chromium.org/418028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32700 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/414048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=27860,27861
Review URL: http://codereview.chromium.org/411008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32674 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Rather than printing errno, this macro prints useful error messages.
Review URL: http://codereview.chromium.org/420006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Patched from 401007(see http://codereview.chromium.org/401007/) to commit. Reviewed by aa and darin.
R=aa,darin
Review URL: http://codereview.chromium.org/421005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
rely on to trigger NPAPI keyboard focus notifications.
BUG=26585
TEST=On pages with multiple Flash text entry fields, only one should have
a blinking caret at any time. Flash elements that use the ActionScript2
"Key.IsDown()" function should only detect keydowns when they are in a
visible tab and focused.
Review URL: http://codereview.chromium.org/399090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/418011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Convert mappy to a page action popup.
Also fix a bug where disabling an extension with a page action didn't cause the icon to hide.
BUG=27519
TEST=none
Review URL: http://codereview.chromium.org/414019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32616 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=26594
TEST=None, just documentation
Review URL: http://codereview.chromium.org/412003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32614 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Functions that take a printf-style format get a new annotation, which
produces a bunch of compiler warnings when you use printf impoperly.
This change adds the annotations and fixes the warnings.
We now must use PRId64 for 64-bit numbers and the PRIsz for size_t.
Review URL: http://codereview.chromium.org/339059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
That was only needed because of clickjacking.
BUG=28227
Review URL: http://codereview.chromium.org/411004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32588 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=25677
Review URL: http://codereview.chromium.org/395007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32561 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
argument.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/407005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32528 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a follow up change after andrew's patch for win7 shortcut to
properly set app id for chromium/application shortcut.
- Move PKEY_AppUserModel_ID and code to set it from app/win_util.cc to
base/win_util.cc as SetAppIdForPropertyStore to share with file_util
shortcut code;
- Add an app_id args to file_util's CreateShortcutLink and
UpdateShortcutLink;
- Update code that calls the above two function in installer and
UserDataManager so that the chromium shortcuts are created with proper
app id (except the uninstall shortcut which is not tagged with any app
id).
- Move ComputeApplicationNameFromURL from Browser to web_app namespace
and use it as app id for application shortcut. This makes pinned
shortcut and browser window use the same app id and Win7 correctly
groups them;
- Rename ComputeApplicationNameFromURL to GenerateApplicationNameFromURL
per Ben's comments;
- Add a DCHECK in SetAppIdForPropertyStore to ensure app id is less than
128 chars and contains no space per msdn;
- Change default app id from IDS_PRODUCT_NAME to chrome::kBrowserAppName
BUG=28104
TEST=On Win7, pinned shortcut should no longer be separated from running instance of chrome for both chrome and web application.
Review URL: http://codereview.chromium.org/399045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32508 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
is more interesting.
Decided not to do full details on the other samples since they are
very similar to the ones we already have.
TBR=kathyw@google.com
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32505 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
this was not exploitable, but still a good thing to fix.
Review URL: http://codereview.chromium.org/399063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32502 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We don't want to ever go out to disk when looking for data after
startup, since they can be changed by an update.
We *should* just be using the zygote, but the zygote is sandboxed-only
for now, and fixing that has a lengthy dependency graph. In the
interim, /proc/self/exe is the correct executable and exec'ing it should
work as long as the subprocess doesn't need any other files from the
Chrome directory.
BUG=22703
TEST=Start Chrome. Move away the entire Chrome directory; plugins
should still work.
Review URL: http://codereview.chromium.org/403018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This reverts commit r32457.
This works for me in Debug and Release, and Lei in Debug, but not
for him or the bots in Release. Hate computers.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We don't want to ever go out to disk when looking for data after
startup, since they can be changed by an update.
We *should* just be using the zygote, but the zygote is sandboxed-only
for now, and fixing that has a lengthy dependency graph. In the
interim, /proc/self/exe is the correct executable and exec'ing it should
work as long as the subprocess doesn't need any other files from the
Chrome directory.
BUG=22703
TEST=Start Chrome. Move away the entire Chrome directory; plugins
should still work.
Review URL: http://codereview.chromium.org/403018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
XP bots were failing on directory Delete. Removing ASSERT_TRUE for deletes solves the problem.
Review URL: http://codereview.chromium.org/408009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32451 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
This reverts commit r32410. Stupid tests.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32422 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
to send an NPN_SetException back to the correct renderer if necessary. BUG=26764 TEST=none
Review URL: http://codereview.chromium.org/375005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32419 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We currently throw an error when loading the extension,
which is overly aggressive.
BUG=28158
TEST=Specify matches=file://* in the manifest for a
content script and make sure the extension still loads.
Review URL: http://codereview.chromium.org/402069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Don't show promo for extensions on Mac, as they're not available yet. Decrement promo counter even when NTP is not home page, and do not remove puzzle piece when promo line is closed. When message bar is closed, make it zip off bottom of screen instead of just disappearing.
BUG= 27814, 25258, 27815
TEST= see various bugs.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32176
Review URL: http://codereview.chromium.org/385135
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32413 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We don't want to ever go out to disk when looking for data after
startup, since they can be changed by an update.
We *should* just be using the zygote, but the zygote is sandboxed-only
for now, and fixing that has a lengthy dependency graph. In the
interim, /proc/self/exe is the correct executable and exec'ing it should
work as long as the subprocess doesn't need any other files from the
Chrome directory.
BUG=22703
TEST=Start Chrome. Move away the entire Chrome directory; plugins
should still work.
Review URL: http://codereview.chromium.org/403018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
return an undefined value.chrome.experimental.extension.getPopupView() may return undefined if no pop-up is currently displayed.chrome.experimental.popup.getParentWindow() may return undefined if called from a non-popup view.BUG=28045TEST=extension_popup_apitest.cc
Review URL: http://codereview.chromium.org/400023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This removes the two-state purge/reset code (no longer necessary), and the hooks to the power monitor (not ready to turn those on without more work and testing).
BUG=23400
TEST=Run Chrome with --purge-memory-button, use it for awhile, open the Task Manager, and click "Purge Memory". You should still be able to use the program normally, and hopefully we dumped some memory out too (varies by usage).
Review URL: http://codereview.chromium.org/399028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=tony@chromium.org
Review URL: http://codereview.chromium.org/399076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
them to sandboxed_extension_unpacker.
Added unittest files for unpacker and sandboxed unpacker.
TEST=Try loading any of the unpacker samples added in this CL. They should either pass, or show error and fail.
BUG=27362
Review URL: http://codereview.chromium.org/390019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=26471
TEST=Load news example extension, see resizing goodness.
Review URL: http://codereview.chromium.org/400028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32305 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This requires a command line flag for the page cycler tests,
since those load file:// urls.
BUG=27877
TEST=Bunch of tests affected.
Review URL: http://codereview.chromium.org/402029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32271 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
renderer only, I'll take care of plugin/worker/utility processes in a followup change. (relanding 32203)
BUG=6844
Review URL: http://codereview.chromium.org/397031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32264 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
of an empty, invalid URL to indicate whether the first party for
cookies URL needs changing when following a redirect.
R=eroman
BUG=25133
TEST=none
Review URL: http://codereview.chromium.org/405011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32260 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
mac port.
TEST=existing tests
BUG=26754
Review URL: http://codereview.chromium.org/402025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32243 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
block the UI thread. For now, renderer only, I'll take care of plugin/worker/utility processes in a followup change.
BUG=6844
Review URL: http://codereview.chromium.org/397002
Review URL: http://codereview.chromium.org/402033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Don't show promo for extensions on Mac, as they're not available yet. Decrement promo counter even when NTP is not home page, and do not remove puzzle piece when promo line is closed. When message bar is closed, make it zip off bottom of screen instead of just disappearing.
BUG= 27814, 25258, 27815
TEST= see various bugs.
Review URL: http://codereview.chromium.org/385135
TBR=mirandac@chromium.org
Review URL: http://codereview.chromium.org/399051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32237 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a) Remove the "Config" button; instead, the configuration is always just applied to a run.
b) Make the clear button work properly
Put in UI when there are no results to display.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/397025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
renderer only, I'll take care of plugin/worker/utility processes in a followup change.
BUG=6844
Review URL: http://codereview.chromium.org/397002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/399039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32198 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/400005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
git grep 'RecordAction(L' | xargs sed -i -e s/RecordAction(L/RecordAction(/
This cuts more than 10k off my binary. Which is nothing compared
to the size of the binary, but that's a whole lot of zero bytes!
This is less code this way anyway.
Review URL: http://codereview.chromium.org/399026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32194 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Don't show promo for extensions on Mac, as they're not available yet. Decrement promo counter even when NTP is not home page, and do not remove puzzle piece when promo line is closed. When message bar is closed, make it zip off bottom of screen instead of just disappearing.
BUG= 27814, 25258, 27815
TEST= see various bugs.
Review URL: http://codereview.chromium.org/385135
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32176 0039d316-1c4b-4281-b951-d872f2087c98
|