summaryrefslogtreecommitdiffstats
path: root/chrome/common
Commit message (Collapse)AuthorAgeFilesLines
* Remove +x bit from files that shouldn't have it.evan@chromium.org2009-10-2050-0/+0
| | | | | | Review URL: http://codereview.chromium.org/307007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29548 0039d316-1c4b-4281-b951-d872f2087c98
* Remove an annoying NOTIMPLEMNETED.estade@chromium.org2009-10-201-2/+1
| | | | | | | | | | | | This notimpl shows up every time a renderer crashes. People frequently post it in bug reports as if it's meaningful. Get rid of it. BUG=TEST=none Review URL: http://codereview.chromium.org/294028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29532 0039d316-1c4b-4281-b951-d872f2087c98
* Minimize dependency of user scripts.mad@chromium.org2009-10-205-71/+52
| | | | | | | | | | | And made some minor lint fixes and code refactoring on the way, based on CR comments of previous attempt. BUG=none TEST=Make sure that the extension resources can still be properly localized and that they also load correctly when they are not localized. Review URL: http://codereview.chromium.org/267051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29512 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: change PIDs to base::ProcessId (or pid_t, as appropriate).viettrungluu@chromium.org2009-10-201-1/+1
| | | | | | | | | | | We probably want to discourage the use of ints for PIDs. This is a start; there are many other places where we should fix this. BUG=25272 TEST=none Review URL: http://codereview.chromium.org/300010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29511 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 29457, because this is making ExtensionBrowserTest.PageAction crash ↵nsylvain@chromium.org2009-10-202-15/+4
| | | | | | | | | | | | | | | | | | | | on Vista Original description: Implement badges for page actions. Also add badge text color API. Also change color APIs from wanting ARGB to RGBA. BUG=24635 BUG=24644 BUG=25215 Review URL: http://codereview.chromium.org/291003 TBR=mpcomplete@chromium.org Review URL: http://codereview.chromium.org/306004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29509 0039d316-1c4b-4281-b951-d872f2087c98
* First cut at new page and browser action docs basedaa@chromium.org2009-10-2040-1011/+410
| | | | | | | | on new API. Deleted old stuff. TBR=kathyw@google.com,rafaelw@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29500 0039d316-1c4b-4281-b951-d872f2087c98
* add enableWebSockets in WebKit APIukai@chromium.org2009-10-201-3/+1
| | | | | | | | | | | | and remove experimentalWebSocketsEnabled from WebPreferences/Settings. Patch for http://bugs.webkit.org/show_bug.cgi?id=29896 will remove Settings::experimentalWebSocketsEnabled(), so we need to remove it from WebPreferences too. This is because such configuration in Settings confuses other WebKit developers and such control is only required for chromium. Instead add WebKit::enableWebSockets() in this change to control WebSockets feature. Review URL: http://codereview.chromium.org/292012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29497 0039d316-1c4b-4281-b951-d872f2087c98
* Implement chrome.browserAction.setIcon({path:...});aa@chromium.org2009-10-202-1/+47
| | | | | | | | BUG=22575 Review URL: http://codereview.chromium.org/269103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29495 0039d316-1c4b-4281-b951-d872f2087c98
* New directory to hold files that aren't directly referenced by the docs,kathyw@google.com2009-10-203-0/+1902
| | | | | | | | | | | but that are used to produce images for the docs. TEST=none BUG=none Review URL: http://codereview.chromium.org/293015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29480 0039d316-1c4b-4281-b951-d872f2087c98
* Delete unused themes from disk on shutdown.tony@chromium.org2009-10-191-1/+1
| | | | | | | | | | | | This reduces the size of the Preferences file and frees up some disk space. The smaller Preferences file should help improve startup time for users who have installed lots of themes. BUG=24377 Review URL: http://codereview.chromium.org/303006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29468 0039d316-1c4b-4281-b951-d872f2087c98
* Degrade the https color and lock icon for the page that has a worker that ↵dimich@google.com2009-10-191-2/+4
| | | | | | | | | | | loads subresource with bad cert. The idea is to make UI reflect loading of resources with bad certificates that were previously approved by the user. bug=20176 TEST=SSLUITest.TestUnsafeContentsInWorker unit_test. Review URL: http://codereview.chromium.org/268006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29461 0039d316-1c4b-4281-b951-d872f2087c98
* Implement badges for page actions. Also add badge text color API.mpcomplete@chromium.org2009-10-192-4/+15
| | | | | | | | | | | | Also change color APIs from wanting ARGB to RGBA. BUG=24635 BUG=24644 BUG=25215 Review URL: http://codereview.chromium.org/291003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29457 0039d316-1c4b-4281-b951-d872f2087c98
* Provide better diagnostics when launching with a silly executable path.mark@chromium.org2009-10-191-0/+2
| | | | | | | | BUG=24842 TEST=none Review URL: http://codereview.chromium.org/304004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29442 0039d316-1c4b-4281-b951-d872f2087c98
* Removed webkit_glue::FillFormToUploadFile from dom_operations.yaar@chromium.org2009-10-192-36/+0
| | | | | | | | No live code path uses it. Review URL: http://codereview.chromium.org/273068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29438 0039d316-1c4b-4281-b951-d872f2087c98
* Convert the spellchecker and associated messages and functions to use string16brettw@chromium.org2009-10-191-5/+5
| | | | | | | | | | | | for words instead of wstring. I also changed some places where it converted the word to a string to do that conversion at the last possible second before giving it to Hunspell (since this conversion isn't needed for Mac). TEST=Covered by unit tests BUG=none Review URL: http://codereview.chromium.org/274077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29435 0039d316-1c4b-4281-b951-d872f2087c98
* Make importer obey import_search_engine preference even if FRUI is enabled.kuchhal@chromium.org2009-10-191-1/+3
| | | | | | | | | | | | With this change importer will give preference to the value specified in master preference for import_search_engine instead of ignoring it like before. BUG=23649 TEST=Specified in above bug. Review URL: http://codereview.chromium.org/274081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29426 0039d316-1c4b-4281-b951-d872f2087c98
* First fix to minimize copying of image data.erg@google.com2009-10-191-4/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | This is the first of multiple patches that clean up handling of memory regarding images. Previously, the code did several memcpy()s or equivalents. This change: - Creates an abstract interface RefCountedMemory which provides access to the front() of a memory range and the size() of it. It is a RefCountedThreadSafe. - Adds a RefCountedStaticMemory class which isa RefCountedMemory. - Pushes RefCountedBytes up into base/ from chrome/ and make it conform to RefCountedMemory. - Have ResourceBundle return RefCountedStaticMemory to the mmaped() or DLL loaded resources instead of memcpy()ing them. - General cleanups to minimize copies in constructing RefCountedBytes. - Use the above consistent interface in the BrowserThemeProvider, along with special casing the loading of the new tab page background. This patch is mostly cleanups and there should only be a slight performance gain if any. Most of the real speedups should come in subsequent patches. BUG=http://crbug.com/24493 TEST=Slightly faster on Perf bot; does not introduce crashes. Review URL: http://codereview.chromium.org/288005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29412 0039d316-1c4b-4281-b951-d872f2087c98
* Delete glue/webview{_delegate}.hdarin@chromium.org2009-10-191-1/+0
| | | | | | | | | | R=dglazkov BUG=10033 TEST=none Review URL: http://codereview.chromium.org/293001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29390 0039d316-1c4b-4281-b951-d872f2087c98
* Make backspace not go back while IME is active.thakis@chromium.org2009-10-192-4/+16
| | | | | | | | | | | Linux does this in GtkIMContextWrapper::ProcessFilteredKeyPressEvent() by setting hardware_keycode to 0. It's a pain to change an NSEvent, so I just added a bool "skip" to NativeWebKeybordEvent and set it to "true" for rawkeydowns while ime is active. BUG=25000 TEST=Open webpage. Focus text field. Type something, hit backspace. Text should be deleted. Focus background, hit backspace. Browser should go back one page. Focus text field, start IME (either by going to syspref->international->input menu and enabling e.g. "Kotoeri" and then selecting this in the top right corner and typing a single "a", or by just activating dead key ime on an us layout by hitting opt-u, opt-i, or opt-e), hit backspace. Browser should not go back but end IME mode. Review URL: http://codereview.chromium.org/295003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29388 0039d316-1c4b-4281-b951-d872f2087c98
* Fix up ExtensionResource::CombinePathsSafely so that it can handle paths ↵dmaclach@chromium.org2009-10-191-1/+7
| | | | | | | | | | | with .. in them safely. BUG=25131 TEST=Build unit_tests on Mac with default build location that contains a .. in the path. Review URL: http://codereview.chromium.org/295001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29383 0039d316-1c4b-4281-b951-d872f2087c98
* Fix chrome_url_overides to work with packed extensions.erikkay@chromium.org2009-10-172-8/+15
| | | | | | | | | | | | | | The InitFromValue code was modifying the JSON with some local data which was then being re-used by the unpacker and sent up to the browser which caused it to use this temporary local data as if it was the original manifest source. BUG=24398 TEST=pack and install override_igoogle extension Review URL: http://codereview.chromium.org/276074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29376 0039d316-1c4b-4281-b951-d872f2087c98
* Set os_error to net::ERR_ABORTED instead of 0 or net::ERR_FAILED whenwtc@chromium.org2009-10-171-1/+1
| | | | | | | | | | | we set the status of a URLRequestStatus to URLRequestStatus::CANCELED. R=eroman BUG=24674 TEST=none Review URL: http://codereview.chromium.org/269064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29367 0039d316-1c4b-4281-b951-d872f2087c98
* Allow slightly larger browser and page action icons.aa@chromium.org2009-10-172-0/+7
| | | | | | | | | | | | | | | | | | | | | | | This allows 19px icons to be able to be used for both browser and page icons. I think it looks nicer with the page actions slightly smaller, and that is what we also usually do in Chrome, but some Chrome location bar icons use 18px for soft edges, so I guess this will just have to be something we advise developers on. We can actually fit up to 21 (whoa nelly) pixels on Windows, but apparently the space is slightly smaller on mac. Also minor layout fix. We were sizing the browser action buttons 1px too short. BUG=24881 TEST=Load chrome/test/data/extensions/samples/icon_size_test. Icons should be 17px for the page action and 19px for the browser action and centered nicely in the space. Review URL: http://codereview.chromium.org/286001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29365 0039d316-1c4b-4281-b951-d872f2087c98
* Minor cleanup in histogram_synchronizer.thestig@chromium.org2009-10-162-13/+2
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/283016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29341 0039d316-1c4b-4281-b951-d872f2087c98
* Http Cache: Enable byte-range support by default.rvargas@google.com2009-10-162-3/+3
| | | | | | | | | | | | | | | The command line parameter to modify the behavior changes from --enable-byte-range-support to --disable-byte-range-support BUG=24989 TEST= current tests Review URL: http://codereview.chromium.org/267132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29337 0039d316-1c4b-4281-b951-d872f2087c98
* Implement new page action API.mpcomplete@chromium.org2009-10-163-1/+1623
| | | | | | | | | | | Still no actual drawing code for badges, though. BUG=24635 TEST=Load the sample test_page_action extension and click the page action to cycle through various states. Review URL: http://codereview.chromium.org/269079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29335 0039d316-1c4b-4281-b951-d872f2087c98
* NTP: Fix startup visual state arv@chromium.org2009-10-161-2/+1
| | | | | | | | | | | | | | | This inject the template data earlier in the document so that we can set the initial visual state based on the user preference. This prevents flickering when the user is not showing the most visited thumbnails. BUG=24513 TEST=Use a theme with a background image to make this easier to spot. Hide the most visited. Restart Chrome. The thumbnails should not flicker Review URL: http://codereview.chromium.org/269095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29314 0039d316-1c4b-4281-b951-d872f2087c98
* Add concept of an options page to Extensions.asargent@chromium.org2009-10-165-1/+33
| | | | | | | | | | | BUG=23801 TEST=Create an extension with an "options_page" entry in its manifest with a value the name of a html file in the extension dir. Load that extension and go to chrome://extensions, there should be an "Options" button that takes you to the page specified in the manifest. Review URL: http://codereview.chromium.org/271114 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29297 0039d316-1c4b-4281-b951-d872f2087c98
* Limit extensions to 1 UI surface (either Page/Browser action, but not both).finnur@chromium.org2009-10-164-1/+22
| | | | | | | | | BUG=24473 TEST=Tested using unit test. Review URL: http://codereview.chromium.org/271117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29284 0039d316-1c4b-4281-b951-d872f2087c98
* Popup width and height are now dynamic.erikkay@chromium.org2009-10-163-20/+5
| | | | | | | | | BUG=24471 TEST=none Review URL: http://codereview.chromium.org/273046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29274 0039d316-1c4b-4281-b951-d872f2087c98
* Move autofill related WebView{Delegate} methods into the WebKit API.darin@chromium.org2009-10-161-5/+5
| | | | | | | | | | | | This CL also changes a bunch of autofill related wstring values to string16. R=jcampan BUG=24595 TEST=none Review URL: http://codereview.chromium.org/279001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29244 0039d316-1c4b-4281-b951-d872f2087c98
* Flesh out the intro and summary for the debugging tutorialkathyw@google.com2009-10-163-105/+258
| | | | | | | | | | | | so I can remove TBDs. Miscellaneous other fixes/improvements. BUG=none TEST=none TBR=aa Review URL: http://codereview.chromium.org/276055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29241 0039d316-1c4b-4281-b951-d872f2087c98
* Minor fix to some instructions.kathyw@google.com2009-10-162-2/+14
| | | | | | | | | | TEST=none BUG=none TBR=aa Review URL: http://codereview.chromium.org/274073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29232 0039d316-1c4b-4281-b951-d872f2087c98
* Added link to bookmarks example.kathyw@google.com2009-10-152-0/+10
| | | | | | | | | TBR=erikkay BUG=none TEST=none Review URL: http://codereview.chromium.org/273080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29215 0039d316-1c4b-4281-b951-d872f2087c98
* Tidy up the bookmarks doc. Hide parts that still need updating.kathyw@google.com2009-10-153-173/+141
| | | | | | | | | | BUG=none TEST=none TBR=erikkay Review URL: http://codereview.chromium.org/269086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29206 0039d316-1c4b-4281-b951-d872f2087c98
* Facelifts to sync UItim@chromium.org2009-10-152-0/+2
| | | | | | | | BUG=23136,24858,21596 TEST=SyncSetupWizardTest Review URL: http://codereview.chromium.org/270081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29197 0039d316-1c4b-4281-b951-d872f2087c98
* Get the nexe name from NaCl and send the NaCl process handle and pid to the ↵gregoryd@google.com2009-10-151-3/+5
| | | | | | | | | | renderer TEST=none BUG=http://code.google.com/p/nativeclient/issues/detail?id=108 Review URL: http://codereview.chromium.org/273056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29195 0039d316-1c4b-4281-b951-d872f2087c98
* Provides a certificate for SSL client authentication on NSS sockets.wtc@chromium.org2009-10-152-0/+14
| | | | | | | | | | | | | | | | | | | GUI is still missing, so certificates and private keys have to be stored manually, p.e.: $ pk12util -d sql:$HOME/.pki/nssdb -i PKCS12_file.p12 Adds --auto-ssl-client-auth command-line option to enable this feature. Patch contributed by Jaime Soriano <jsorianopastor@gmail.com>. Original review URL: http://codereview.chromium.org/220009 R=wtc BUG=16830 TEST=Try to connect to a web page that requires SSL authentication and confirm that it connects if and only if a valid certificate is stored in the ~/.pki/nssdb database. Review URL: http://codereview.chromium.org/276037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29188 0039d316-1c4b-4281-b951-d872f2087c98
* Add UI for changing timezones.chocobo@google.com2009-10-152-0/+4
| | | | | | | | BUG=24876 TEST=none Review URL: http://codereview.chromium.org/267113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29183 0039d316-1c4b-4281-b951-d872f2087c98
* Extensions: Make badge drawing code cross platform so linux (and eventually ↵estade@chromium.org2009-10-152-0/+111
| | | | | | | | | | | | | mac) can use it. I will switch Windows over to the common function in a follow-up patch. BUG=23882 TEST=gmail browser action sample extension Review URL: http://codereview.chromium.org/279008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29152 0039d316-1c4b-4281-b951-d872f2087c98
* Create BlacklistManager, which will aggregate individual blacklists into one ↵phajdan.jr@chromium.org2009-10-153-0/+9
| | | | | | | | | | | | | | | | | compiled one and maintain it. This is the first step towards shipping privacy blacklists in extensions. The next step will be to make Profile own a BlacklistManager, and make ExtensionsService a BlacklistPathsProvider. TEST=Covered by unit_tests. BUG=21541 Review URL: http://codereview.chromium.org/164535 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29135 0039d316-1c4b-4281-b951-d872f2087c98
* Implement some Mac platform utils.avi@chromium.org2009-10-151-4/+6
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/274058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29120 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Stack autocomplete popup window directly on top of the browser's ↵suzhe@chromium.org2009-10-152-0/+31
| | | | | | | | | | | toplevel window. BUG=19082 "Linux: Omnibox auto-complete popup is on top of IME candidate window when using SCIM" TEST=Please refer to the bug report for how to test. Review URL: http://codereview.chromium.org/274046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29102 0039d316-1c4b-4281-b951-d872f2087c98
* Revert checkin 29096jar@chromium.org2009-10-151-1/+0
| | | | | | | | | Removing a line that I put in just to get perf data from the build bots. TBR=mbelshe Review URL: http://codereview.chromium.org/267114 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29100 0039d316-1c4b-4281-b951-d872f2087c98
* Remove instructions to right-click toolstrips toaa@chromium.org2009-10-152-10/+14
| | | | | | | | | bring up an inspector, as that doesn't work anymore. TBR=kathyw@google.com git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29099 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r29095 (removes wrench integration foraa@chromium.org2009-10-152-12/+1
| | | | | | | | | | | | browser actions). Test failure was a fluke. I forgot that changing resources always makes the first bot run fail. TBR=mpcomplete@chromium.org BUG=24379,24671 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29098 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting r29095 (removes wrench integration foraa@chromium.org2009-10-152-1/+12
| | | | | | | | | browser actions). TBR=mpcomplete@chromium.org BUG=24379,24671 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29097 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarilly disable SetURL to evaluate perf impactjar@chromium.org2009-10-151-0/+1
| | | | | | | | | | | | | | | This is a temporary checkin, meant to gather data from the bots that run performance tests. I'll revert it asap. Profiling suggests we call SetURL VERY often, so that we can get crash info. The function turns out to cause a memory allocation, and also a string conversion, and hence *might* have a significant perf impact. TBR=mbelshe Review URL: http://codereview.chromium.org/273051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29096 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the implicit wrench menu items for browser actions.aa@chromium.org2009-10-152-12/+1
| | | | | | | | | | | Also, allow browser actions with no initial icons, and add some better tests. BUG=24379,24671 Review URL: http://codereview.chromium.org/276010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29095 0039d316-1c4b-4281-b951-d872f2087c98
* Re-try r29078: Remove some deprecated file_util wstring functions.estade@chromium.org2009-10-151-1/+1
| | | | | | | | | | | | | With the previous patch, the try bots failed with mysterious messages, so I ignored them, patched it into my windows box and tested it there manually, and found no problems. As it turns out, the try failures were real :(. But nsylvain and I found the problem: the behavior of file_util::GetDirectoryFromPath() differs from DirName() when the path is empty (officially, GetDirectoryFromPath is not supposed to support non-absolute paths, but that is not enforced). Here is a green win try result: http://build.chromium.org/buildbot/try-server/builders/win/builds/3705 mac: http://build.chromium.org/buildbot/try-server/builders/mac/builds/3491 linux: http://build.chromium.org/buildbot/try-server/builders/linux/builds/3466 I also applied this patch locally in Windows to test that it doesn't break the chrome frame compile or tests, since that's not covered by the trybots yet. Review URL: http://codereview.chromium.org/271099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29094 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-01 00:55:52 +0000