summaryrefslogtreecommitdiffstats
path: root/chrome/common
Commit message (Collapse)AuthorAgeFilesLines
* Add notification processes to the task manager.johnnyg@chromium.org2010-04-081-5/+6
| | | | | | | | | BUG=29332 TEST=notifications in task manager Review URL: http://codereview.chromium.org/1610006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44014 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a typo.thestig@chromium.org2010-04-081-2/+2
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1604015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43993 0039d316-1c4b-4281-b951-d872f2087c98
* Support PNG and quality control in chrome.tabs.captureVisibleTab().skerner@chromium.org2010-04-082-3/+146
| | | | | | | | | BUG=21072 TEST=ExtensionAPIClientTest.CaptureVisibleTab Review URL: http://codereview.chromium.org/1527015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43985 0039d316-1c4b-4281-b951-d872f2087c98
* Flush audio data after seekhclam@chromium.org2010-04-081-1/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | There is about 400 to 600 ms of audio that needs to be flushed after seek, this have a pretty UX effect. This is partially fixed in this patch by reducing the amount of data down to about at most 500 ms stored in the hardware buffer. This patch clears data in the software buffer in the browser process when seek happens. We could reduce the amount of hardware buffer to further reduce the amount of lag but that can be fixed by subsequent patch. BUG=24150 TEST=audio still works, audio still play after seek the playback of old data after seek is substantially reduced. Few changes in this patch: 1. Flush software buffer after seek in browser process 2. Get rid of prerolling, this actually has not effect at all, so getting rid of useless code Needs to be done after this patch: 1. Further reduce the remaining data after seek and pause 2. Still hit the DCHECK in ClockImpl::Play(), this doesn't seem to be a new problem introduced in this patch Review URL: http://codereview.chromium.org/1508021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43983 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash on Mac because the STL iterator behavior on delete is not ↵johnnyg@chromium.org2010-04-082-3/+28
| | | | | | | | | | | consistent between platforms. Add a trivial test to make sure this works on all platforms. BUG=40170 TEST=on Mac, create a notification (e.g. go/notify_demo.html), refresh the page while the toast is open. Review URL: http://codereview.chromium.org/1562016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43965 0039d316-1c4b-4281-b951-d872f2087c98
* Implement patterns for content setting exceptions.jochen@chromium.org2010-04-083-7/+20
| | | | | | | | | BUG=37394 TEST=unit_tests + manual Review URL: http://codereview.chromium.org/1567010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43936 0039d316-1c4b-4281-b951-d872f2087c98
* notification panel fix on chromeos.oshima@chromium.org2010-04-081-0/+3
| | | | | | | | | | | | | | * Changed to use NotificationService instead of delegate to notify the panel state change. * Cleanup the client event signal handler so that event won't get fired on closed instance. * Added chromeos mode. Under ChromeOS, it will wait a message from WindowManager that tells the state of panel. * The StateTransition2 test relies on the fact that Panel state change takes longer than stale timeout, so we can't use zero stale timeout. Changed to explicitly update the stale state. BUG=http://crosbug.com/2346 TEST=NotificationPanelTest.TestStateTransition2 should pass on chromeos device. Review URL: http://codereview.chromium.org/1523012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43909 0039d316-1c4b-4281-b951-d872f2087c98
* Don't bail early on extensions update.asargent@chromium.org2010-04-073-8/+49
| | | | | | | | | | | | | | | | | | | | | When parsing the extension update manifest results, we bail out of there was an error from any of the <app> tags in the xml. With the changes from http://src.chromium.org/viewvc/chrome?view=rev&revision=42899 we now can get a "error-unknownApplication" for ids that Omaha doesn't know about, so we need to not have that stop other updates. BUG=40519 TEST=Install an extension you packaged yourself that doesn't have an update_url specified, and install an older verison of one in the gallery. When you do an "update now" you should get the update for the gallery one. Review URL: http://codereview.chromium.org/1633002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43891 0039d316-1c4b-4281-b951-d872f2087c98
* Update and rewrite the permissions section of the manifest page.kathyw@chromium.org2010-04-072-22/+100
| | | | | | | | | | | | Now it lists all permissions explicitly and includes the new "notifications" permission. BUG=39862 TEST=none Review URL: http://codereview.chromium.org/1525010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43887 0039d316-1c4b-4281-b951-d872f2087c98
* Adding the new WebPopupType to the RenderWidget creation.jcivelli@google.com2010-04-072-1/+20
| | | | | | | | | BUG=None TEST=Tests that all popups (select popup, autofill, browser actions, bookmark bubble...) work as expected and get the focus correctly. Review URL: http://codereview.chromium.org/1523013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43845 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 43684 - Localize CSS files in content scripts (but don't localize JS ↵cira@google.com2010-04-071-4/+4
| | | | | | | | | | | | | | | | files). Add UserScriptSlave unittest. BUG=39899 TEST=List css file in content_scripts section of the manifest. Refer to an image using url(chromeextension://__MSG_@@extension_id_/image.png); within that css. @@extension_id message should be replaced with actual id of the extension. Review URL: http://codereview.chromium.org/1585013 TBR=cira@chromium.org Review URL: http://codereview.chromium.org/1525014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43784 0039d316-1c4b-4281-b951-d872f2087c98
* Changing the translate back-end to use the Google Translate element.jcivelli@google.com2010-04-063-84/+10
| | | | | | | | | | | | | | | | When the user indicates that a page should be translated, the browser first fetches the Google Translate Element JS code. It then sends it to the renderer, which injects the script in the page, waits for the Translate element to be initialized and then calls the translate method on it. The TranslationService class previously used to translate text chunks is now unused and has been removed. Some of its static methods that are still used have been moved to the TranslateManager class. This CL also implements the "revert" translation behavior. BUG=35474,37778,35553,39375 TEST=Test the translation feature extensively. Review URL: http://codereview.chromium.org/1599016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43768 0039d316-1c4b-4281-b951-d872f2087c98
* Add some shutdown perf tests. We measure shutdown for the combination ofthestig@chromium.org2010-04-062-2/+6
| | | | | | | | | | | shutdown method: {Close all windows, clicking exit, terminating process} and number of tabs open: {just about:blank, twenty tabs} BUG=23118 TEST=This CL adds a test. Review URL: http://codereview.chromium.org/1594008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43758 0039d316-1c4b-4281-b951-d872f2087c98
* Fix problems with unloading/reloading/updating extensions that contain NPAPImpcomplete@chromium.org2010-04-061-0/+6
| | | | | | | | | | | plugins, by ensuring that an extension's plugins are shut down and unloaded when the extension unloads. BUG=34670 BUG=32806 Review URL: http://codereview.chromium.org/1596009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43756 0039d316-1c4b-4281-b951-d872f2087c98
* Allow synchronous messages to be sent from threads other than the main ↵jabdelmalek@google.com2010-04-067-275/+82
| | | | | | | | | thread. This simplifies code that needs to do this (i.e. webkit db and file threads). BUG=23423 Review URL: http://codereview.chromium.org/1601005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43752 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure DecodeIcon is only called from the File thread.finnur@chromium.org2010-04-064-13/+21
| | | | | | | | | BUG=38521 TEST=None, Chrome should work as before. Review URL: http://codereview.chromium.org/1525009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43751 0039d316-1c4b-4281-b951-d872f2087c98
* Rename kChromeUIFavIconPath to kChromeUIFavIconHost for consistency.arv@chromium.org2010-04-062-2/+2
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/1568015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43748 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bad URL in sample code.kathyw@chromium.org2010-04-062-2/+2
| | | | | | | | | | TBR=ericbidelman BUG=40063 TEST=none Review URL: http://codereview.chromium.org/1539025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43745 0039d316-1c4b-4281-b951-d872f2087c98
* Convert variables in chrome/common/env_vars.cc from wchar_t to char. Enable ↵thestig@chromium.org2010-04-065-58/+72
| | | | | | | | | | ChromeLoggingTest along the way. BUG=none TEST=none Review URL: http://codereview.chromium.org/1559016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43738 0039d316-1c4b-4281-b951-d872f2087c98
* Add a simple example history extension.skerner@chromium.org2010-04-064-0/+138
| | | | | | | | | BUG=32362 TEST=Manual. Review URL: http://codereview.chromium.org/1568012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43727 0039d316-1c4b-4281-b951-d872f2087c98
* detect preferences errorserikkay@chromium.org2010-04-069-30/+112
| | | | | | | | | BUG=38352 TEST=none Review URL: http://codereview.chromium.org/1120006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43715 0039d316-1c4b-4281-b951-d872f2087c98
* Fix docking behaviour for devtools windows that don't have an associated ↵mnissler@chromium.org2010-04-061-2/+2
| | | | | | | | | | | browser window BUG=40090 TEST=none Review URL: http://codereview.chromium.org/1567014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43709 0039d316-1c4b-4281-b951-d872f2087c98
* Add menu and menu item events to the accessibility extension api, anddmazzoni@chromium.org2010-04-062-1/+54
| | | | | | | | | | | | | | generate menu item notifications for gtk menus. The code to generate menu open and close events is a little more complicated and will come in a future patch. BUG=none TEST=navigated menus with keyboard, watched notifications fire Review URL: http://codereview.chromium.org/1585011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43707 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding:oshima@chromium.org2010-04-061-0/+6
| | | | | | | | | | | | | | | | | BookmarkBarView tests fixes * Add BOOKMARK_CONTEXT_MENU_SHOWN notification. On Linux, event handling is asynchronous, but the showing context menu is blocking, so we can't use RunAllPending(). * Convert gtk keycode to Win when checking accelerator. BUG=39736 TEST=none (interactive_ui_tests should pass once enabled it'll be enabled by http://codereview.chromium.org/1576008 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43699 Review URL: http://codereview.chromium.org/1545011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43700 0039d316-1c4b-4281-b951-d872f2087c98
* Improve the underlying escaping function JsonDoubleQuoteT to escape < and > ↵inferno@chromium.org2010-04-061-2/+2
| | | | | | | | | | characters BY DEFAULT to prevent script execution. BUG=40147 TEST=StringEscapeTest.* Review URL: http://codereview.chromium.org/1512013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43695 0039d316-1c4b-4281-b951-d872f2087c98
* Move more extensions hard coded error messages to .grd file. finnur@chromium.org2010-04-061-28/+43
| | | | | | | | | | | Patch from Thiago Farina. Previously reviewed here: http://codereview.chromium.org/931001 BUG=23086 TEST=Chrome should work as before (no visible change). git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43691 0039d316-1c4b-4281-b951-d872f2087c98
* Make an error message verbose to investigate a un-reproducible bug.tkent@chromium.org2010-04-061-2/+7
| | | | | | | | BUG=35198 TEST=none Review URL: http://codereview.chromium.org/1528018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43686 0039d316-1c4b-4281-b951-d872f2087c98
* Localize CSS files in content scripts (but don't localize JS files).cira@chromium.org2010-04-061-4/+4
| | | | | | | | | | | Add UserScriptSlave unittest. BUG=39899 TEST=List css file in content_scripts section of the manifest. Refer to an image using url(chrome-extension://__MSG_@@extension_id_/image.png); within that css. @@extension_id message should be replaced with actual id of the extension. Review URL: http://codereview.chromium.org/1585013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43684 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "BookmarkBarView tests fixes"oshima@chromium.org2010-04-051-6/+0
| | | | | | | | | | I don't understand why this is still causing the problem, but reverting this for now. This reverts commit 6bb4f22703226e093644c28afe34d975cc7d549d. Review URL: http://codereview.chromium.org/1612005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43674 0039d316-1c4b-4281-b951-d872f2087c98
* BookmarkBarView tests fixesoshima@chromium.org2010-04-051-0/+6
| | | | | | | | | | | | | | * Add BOOKMARK_CONTEXT_MENU_SHOWN notification. On Linux, event handling is asynchronous, but the showing context menu is blocking, so we can't use RunAllPending(). * Convert gtk keycode to Win when checking accelerator. BUG=39736 TEST=none (interactive_ui_tests should pass once enabled it'll be enabled by http://codereview.chromium.org/1576008 Review URL: http://codereview.chromium.org/1545011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43628 0039d316-1c4b-4281-b951-d872f2087c98
* Pepper audio basic functionality unit test, take 3.neb@chromium.org2010-04-052-3/+14
| | | | | | | | Also changed TestSink to be derived from IPC::Channel and made MockRenderThread service AddFilter/RemoveFilter, so that it can be used by MessageFilters. Review URL: http://codereview.chromium.org/1591009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43623 0039d316-1c4b-4281-b951-d872f2087c98
* Disables AeroPeek by default.hbono@chromium.org2010-04-052-0/+4
| | | | | | | | | | Because my AeroPeek code caused lots of usability problems, this change disables the AeroPeek code by default and add an "--enable-aero-peek-tabs" option, which enables this code, until we find solutions that avoid flooding users with tab thumbnails. BUG=37957 TEST=Open two tabs, and verify we can see only one thumbnail on Windows 7. Review URL: http://codereview.chromium.org/1571008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43607 0039d316-1c4b-4281-b951-d872f2087c98
* Adding "preload_engines" and "use_global_engine" preferences to Chrome side ↵yusukes@chromium.org2010-04-052-0/+10
| | | | | | | | | | | | | (2nd try; see r43475 and r43481). Modified chrome/browser/chromeos/cros/cros_in_process_browser_test.cc not to break browser_tests. Other files are not modified since the previous CL (r43475). BUG=crosbug.com/488 TEST=none Review URL: http://codereview.chromium.org/1599017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43603 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a few places where we were incorrectly classifyingaa@chromium.org2010-04-033-5/+18
| | | | | | | | | notifications and storage permissions as "access to your browsing history". Review URL: http://codereview.chromium.org/1526007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43573 0039d316-1c4b-4281-b951-d872f2087c98
* Move EnvironmentVariableGetter from base/linux_util.h to base/env_var.h and ↵thestig@chromium.org2010-04-031-11/+7
| | | | | | | | | | rename it EnvVarGetter. Label base::SysInfo::{Get,Has}EnvVar as deprecated. BUG=none TEST=none Review URL: http://codereview.chromium.org/1606007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43559 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill: Use the FormManager cache to send forms to the AutoFillManager.jhawkins@chromium.org2010-04-032-44/+3
| | | | | | | | | | | Remove the FormFieldValues class and replace its usage with FormData. BUG=38325,33032 TEST=none Review URL: http://codereview.chromium.org/1606005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43555 0039d316-1c4b-4281-b951-d872f2087c98
* Behaving nice with AutoFill servers: Adjusting upload rate, processing 500, ↵georgey@chromium.org2010-04-022-0/+9
| | | | | | | | | | 502 and 503 responses, etc. TEST=Unit-tested + by setting up the response from AutoFill server. BUG=39921 Review URL: http://codereview.chromium.org/1535011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43531 0039d316-1c4b-4281-b951-d872f2087c98
* Extension Docs (No building or testable files).rafaelw@chromium.org2010-04-023-121/+32
| | | | | | | | | | | This changes adds documentation for the recently-landed right-click to inspect popup behavior for page and browser actions. BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/1226002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43526 0039d316-1c4b-4281-b951-d872f2087c98
* Add calling frame's source_url to extension and dom ui requests.rafaelw@chromium.org2010-04-021-2/+4
| | | | | | | | Additionally, in the extension and tabs api, compute & report UMA histogram data for relative URL use in API calls so we can decide if it's possible to change the behavior of relative url resolution to use the calling frame's url rather than the extension's base url. Review URL: http://codereview.chromium.org/1605005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43523 0039d316-1c4b-4281-b951-d872f2087c98
* Mention the "unlimited_storage" permission in the extensions docs.dumi@chromium.org2010-04-021-1/+6
| | | | | | | | | | BUG=27688 TEST=none Review URL: http://codereview.chromium.org/1556016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43512 0039d316-1c4b-4281-b951-d872f2087c98
* Sample code for tracking extension and content events.erikkay@chromium.org2010-04-026-0/+594
| | | | | | | | https://chrome.google.com/extensions/detail/kkfibincabhfblmkmhcabnlghmncdcaf Review URL: http://codereview.chromium.org/1541001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43488 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 43475 - Adding "preload_engines" and "use_global_engine" preferences ↵rohitrao@chromium.org2010-04-022-10/+0
| | | | | | | | | | | | | | to Chrome side. BUG=crosbug.com/488 TEST=none Review URL: http://codereview.chromium.org/1546010 TBR=yusukes@chromium.org Review URL: http://codereview.chromium.org/1520012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43481 0039d316-1c4b-4281-b951-d872f2087c98
* Adding "preload_engines" and "use_global_engine" preferences to Chrome side.yusukes@chromium.org2010-04-022-0/+10
| | | | | | | | | BUG=crosbug.com/488 TEST=none Review URL: http://codereview.chromium.org/1546010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43475 0039d316-1c4b-4281-b951-d872f2087c98
* 1. Create a new sandbox type which allows access to Unix sockets in the Macmsneck@google.com2010-04-023-5/+62
| | | | | | | | | | | | | | | | | | | | | renderer sandbox to support running Native Client. 2. Put the Native Client sel_ldr (which contains the user's untrusted code) into a new Mac sandbox type. 3. Open /dev/random in SandboxWarmup(). 4. Remove the "--nosandbox" flag when running Mac tests. See http://codereview.chromium.org/1234003/show and http://codereview.chromium.org/1525005/show which were both reverted because of problems on Mac 10.6. This change is identical except for the ";NACL" lines in renderer.sb files and the corresponding lines in nacl-loader.sb. Unix socket support for the sandbox changed considerably from 10.5 to 10.6. BUG=http://code.google.com/p/nativeclient/issues/detail?id=327 TEST=nacl_ui_tests still pass while running in the sandbox. Review URL: http://codereview.chromium.org/1559012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43473 0039d316-1c4b-4281-b951-d872f2087c98
* Add a folders_only and subtree api to bookmark managerfeldstein@chromium.org2010-04-021-0/+25
| | | | | | | | | | | | | | | | Adds a new API to the experimental.bookmarkManager namespace getSubtree(id, foldersOnly, callback) Which returns any subtree, and if foldersOnly is true, only returns the folders. At this point, only the bookmark tree is using the new call. BUG=39877 TEST=ExtensionBookmarksTest.* Review URL: http://codereview.chromium.org/1611001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43461 0039d316-1c4b-4281-b951-d872f2087c98
* Add --websocket-live-experiment-host flag to debug websocket live experiment.ukai@chromium.org2010-04-022-0/+6
| | | | | | | | | | | If --websocket-live-experiment-host is specified, it is used for host of websocket live experiment in debug build. BUG=none TEST=none Review URL: http://codereview.chromium.org/1524005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43460 0039d316-1c4b-4281-b951-d872f2087c98
* Move enable/disable storage to prefs.nick@chromium.org2010-04-022-0/+2
| | | | | | | | | | | | | | | | | | | | | | | The ProfileSyncService will manage the enabled/disabled types. Remove CustomizeSyncWindowView's DataTypeManager dependency; it should really just be operating on the preferences via the ProfileSyncService. Clarify the difference between types being enabled (meaning the user wants to sync them) versus being advertisable (meaning we support the datatype, and advertise that the user has the option of syncing it). BUG=34209,38340 TEST=After syncing, open the options dialog and recustomize your options. Verify that the enabled types from the wizard match the initial state of the options window. After changing the options and hitting "accept", observe that a breakpoint in DTM::Configure gets triggered, with exactly the new configuration set. Verify that the preferences are preserved on restart, as well as across Stop Syncing / Start Syncing. Review URL: http://codereview.chromium.org/1556009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43440 0039d316-1c4b-4281-b951-d872f2087c98
* Changes to the Browser to support Database access from Workers.ericu@google.com2010-04-024-0/+179
| | | | | | | | | | | | This changelist should have no visible effect until the V8 bindings for the Database get added to the Worker context in WebKit. BUG=none TEST=webkit layout tests Review URL: http://codereview.chromium.org/1387001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43427 0039d316-1c4b-4281-b951-d872f2087c98
* Move history API out of experimental. Allow extensions to override history ↵skerner@chromium.org2010-04-0154-156/+282
| | | | | | | | | | | page. BUG=32362 TEST=ExtensionApiTest.History, ExtensionApiTest.Overrides, manual testing. Review URL: http://codereview.chromium.org/1530002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43387 0039d316-1c4b-4281-b951-d872f2087c98
* Notify all active login prompts when one login prompt is submitted. This allows tonyg@chromium.org2010-04-011-1/+10
| | | | | | | | | | | | | | | | | | | identical login prompts to dismiss themselves. This was originally submitted as r42770 but had to be rolled back because I copied from a FLAKY test. Now that r43266 fixed the flakiness, this should be good to go. The code is exactly the same as r42770 with one exception. I added a WaitForNavigation guard to the tab the other tab in the new test cases. This could have also caused flakiness in the initial revision. BUG=8914 TEST=ui_tests --gtest_filter=LoginPromptTest.* Review URL: http://codereview.chromium.org/1528012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43374 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-31 14:22:20 +0000