summaryrefslogtreecommitdiffstats
path: root/chrome/common
Commit message (Collapse)AuthorAgeFilesLines
* Adds desktop notification support for renderer process, and enables the ↵johnnyg@chromium.org2009-10-053-0/+160
| | | | | | | | | | | | build flag for chromium build of webkit. Doesn't expose the feature to any websites yet. BUG=none TEST=none (This is part 1 of 3 for this feature; tests will follow). Review URL: http://codereview.chromium.org/194079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27973 0039d316-1c4b-4281-b951-d872f2087c98
* Add an API to manipulate the browser action badge.aa@chromium.org2009-10-032-4/+52
| | | | | | | | BUG=23268 Review URL: http://codereview.chromium.org/256032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27951 0039d316-1c4b-4281-b951-d872f2087c98
* Another stab at the Chromium side of storage events. Re-submission of ↵jorlow@chromium.org2009-10-031-0/+8
| | | | | | | | | | | | | | | | | http://src.chromium.org/viewvc/chrome?view=rev&revision=27756 with slight changes in dom_storage_dispatch er_host.cc TBR=darin TEST=Manually inspected that storage events fired. Will turn on more layout tests in a subsequent patch. BUG=19972 Original review URL: http://codereview.chromium.org/223013 Review URL: http://codereview.chromium.org/258010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27943 0039d316-1c4b-4281-b951-d872f2087c98
* Add quota support.jorlow@chromium.org2009-10-031-4/+5
| | | | | | | | | | | Add a 5mb quota to DOM Storage. Most of the details are in an upstream patch (https://bugs.webkit.org/show_bug.cgi?id=29991 ). BUG=16876 TEST=I added a layout test upstream and it works. Review URL: http://codereview.chromium.org/255050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27942 0039d316-1c4b-4281-b951-d872f2087c98
* More WebView / WebViewDelegate cleanup.darin@chromium.org2009-10-031-1/+1
| | | | | | | | | | | | Moves a bunch of methods from glue to the WebKit API. R=dglazkov BUG=10033 TEST=none Review URL: http://codereview.chromium.org/246079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27941 0039d316-1c4b-4281-b951-d872f2087c98
* Move the clipboard stuff out of base and into app/clipboard. I renamedbrettw@chromium.org2009-10-032-3/+3
| | | | | | | | | | | clipboard_util to clipboard_util_win since it's Windows-only. This patch makes test_shell depend on app as well. There should be no logic change. TEST=none BUG=none Review URL: http://codereview.chromium.org/260003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27937 0039d316-1c4b-4281-b951-d872f2087c98
* A new page about hosting extensions (i.e. serving the right HTTP headers).kathyw@google.com2009-10-034-4/+506
| | | | | | | TBR=aa Review URL: http://codereview.chromium.org/243085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27936 0039d316-1c4b-4281-b951-d872f2087c98
* Move the JPEG and PNG codecs from base/gfx to app/gfx/codec. Move the classesbrettw@chromium.org2009-10-031-4/+4
| | | | | | | | | | | | | | | into the gfx namespace. Combine the PNGEncoder and PNGDecoder. There were separate when we had different executables for the browser and renderer, and linked the encoder only in one of them (which saved us some space used by libpng). This hasn't been the case for years, so combining them (again) makes sense. TEST=none BUG=none Review URL: http://codereview.chromium.org/243076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27930 0039d316-1c4b-4281-b951-d872f2087c98
* Add a Clear() function to MRUCache. This will be useful in my MemoryPurger ↵pkasting@chromium.org2009-10-022-2/+28
| | | | | | | | | | class. Technically you can call ShrinkToSize(0), but that's both less clear and slower. BUG=23400 TEST=none Review URL: http://codereview.chromium.org/257024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27892 0039d316-1c4b-4281-b951-d872f2087c98
* Add simple popup support to browser actions. This will create a popup HTML ↵erikkay@chromium.org2009-10-025-1/+59
| | | | | | | | | | | window that extends below a browser action button when the browser is clicked. When it loses focus, it is automatically dismissed. BUG=23596 TEST=none Review URL: http://codereview.chromium.org/258011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27889 0039d316-1c4b-4281-b951-d872f2087c98
* Restore plumbing for the spelling panel on Mac.darin@chromium.org2009-10-021-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | It turns out this is reached through a very awkward code path. We send an IPC to the renderer so that it can call WebFrame::executeCommand passing it the "ToggleSpellingPanel" command. That is intercepted in our code--in WebFrameImpl--and results in calling a method on Editor that just turns around and calls EditorClient. EditorClient is again our code, which just pokes the embedder via WebViewClient to get it to send an IPC back to the browser so that it can show the spelling panel. I would have just short-circuited all of this plumbing if it weren't for the side-effect that this code has of triggering an update to the spelling panel. That way it can show the correct word. I think that could be done a simpler way, but for now, I'm content to just restore the way things were. R=pinkerton BUG=23543 TEST=manual test: right click on a misspelled word and select the option on Mac Chrome to show the spelling panel. you should see it appear :) Review URL: http://codereview.chromium.org/246071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27848 0039d316-1c4b-4281-b951-d872f2087c98
* Add some initial code for the top sites service. This will be a replacement forbrettw@chromium.org2009-10-023-21/+104
| | | | | | | | | | | | | | | | | | | | | | | | | | | the thumbnail database, and will also replace the ThumbnailStore which was the previous replacement we didn't ship. This component will be very much like the ThumbnailStore wtih the addition of the actual most visited data (not just thumbnails) and that it is threadsafe. This class is designed to be called on any thread. When it is complete, thumbnails will be added to it from the UI thread of the browser. Requests for thumbnails and the most visited data can be serviced directly on the I/O thread without going through the UI thread, and since the data is cached, the request won't also have to go through the history thread. The current state is that it cqan store and update the the most visited list and thumbnails. There are unit tests covering this behavior. I also added support for redirect ranking to ThumbnailScore. This is to duplicated the ranking function in history currently, where it prefers thumbnails closer to the end of a redirect chain. Since we won't be using the history service and are only storing thumbnails for the most visited items, we have to track the redirect index ourselves. BUG=none TEST=covered by unit tests (hopefully!) Review URL: http://codereview.chromium.org/251002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27824 0039d316-1c4b-4281-b951-d872f2087c98
* Add some debugging junk to ExtensionMessageService to track down a crash.mpcomplete@chromium.org2009-10-011-0/+4
| | | | | | | | | BUG=21201 TEST=no Review URL: http://codereview.chromium.org/256029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27798 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up wifi menu button UI to ChromeOS shared library.chocobo@google.com2009-10-011-1/+1
| | | | | | | | BUG=none TEST=23090 Review URL: http://codereview.chromium.org/246057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27779 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 27756.jorlow@chromium.org2009-10-011-8/+0
| | | | | | Review URL: http://codereview.chromium.org/249058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27759 0039d316-1c4b-4281-b951-d872f2087c98
* Another stab at the Chromium side of storage events. The WebKit side can be ↵jorlow@chromium.org2009-10-011-0/+8
| | | | | | | | | | | found here: https://bugs.webkit.org/show_bug.cgi?id=29655 TEST=Manually inspected that storage events fired. Will turn on more layout tests in a subsequent patch. BUG=19972 Review URL: http://codereview.chromium.org/223013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27756 0039d316-1c4b-4281-b951-d872f2087c98
* Fix several issues around fullscreen Mac plugins:amanda@chromium.org2009-10-011-0/+28
| | | | | | | | | | * Keystrokes are now properly sent to plugins in fullscreen mode * When a plugin creates a fullscreen window, we hide the menu bar and restore it when the window is closed BUG=19534,21020 TEST=Open a page with plugins that can go full screen (example: flash video players). Enter full screen mode and verify that esc, arrow keys, spacebar, etc. work as expected. Verify that the menu bar is hidden when the plugin goes fullscreen and is restored when it exits fullscreen mode. Review URL: http://codereview.chromium.org/257008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27755 0039d316-1c4b-4281-b951-d872f2087c98
* Add framework of MemoryPurger, a class to dump memory from everywhere ↵pkasting@chromium.org2009-10-012-0/+8
| | | | | | | | | | | | possible. Currently does nothing. This also adds a "Purge memory" button to the task manager when run with --purge-memory-button, which can be used to test the functionality. BUG=23400 TEST=Run with --purge-memory-button, open the task manager and see a new button. Click it to toggle it to "Reset purge", and click again to toggle back. Review URL: http://codereview.chromium.org/259003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27751 0039d316-1c4b-4281-b951-d872f2087c98
* Add chrome.browserAction.setName and .setIcon.mpcomplete@chromium.org2009-10-015-0/+40
| | | | | | | | | BUG=23379 TEST=Load the print_browser_action extension from the samples test dir and click it. The icon and name should update. Review URL: http://codereview.chromium.org/242081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27741 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Don't call MemoryDetails::Release() from AboutMemoryHandler's constructor.shess@chromium.org2009-10-011-6/+5
| | | | | | Review URL: http://codereview.chromium.org/252008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27731 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the indenting in chrome_switches.cc to be consistent.pkasting@chromium.org2009-10-011-51/+52
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/249053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27727 0039d316-1c4b-4281-b951-d872f2087c98
* Minor copyedits to packaging to provide better context.kathyw@google.com2009-10-012-12/+22
| | | | | | | | TBR=aa Review URL: http://codereview.chromium.org/255033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27701 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: improve app mode .desktop file creation.estade@chromium.org2009-10-011-2/+7
| | | | | | | | | | | 1) pass --user-data-dir when appropriate 2) don't overwrite old .desktop files that share the same name. BUG=23353 Review URL: http://codereview.chromium.org/255016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27700 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Remove a check for >= 0 because it is always true. Type is ↵jhawkins@chromium.org2009-09-301-1/+1
| | | | | | | | | | | unsigned int. CID=573 BUG=none TEST=none Review URL: http://codereview.chromium.org/256019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27682 0039d316-1c4b-4281-b951-d872f2087c98
* Remove all MemoryModel-related code, since we're unlikely to use it again. ↵pkasting@chromium.org2009-09-303-8/+0
| | | | | | | | | | | | Also changes some sample code to use a random generic name ("PruningAlgorithm") instead of MemoryModel in hopes that no one will be confused. This does not remove IdleTimer, even though it now has no users. I do plan to remove it, but I want to do that in a separate commit so it's easy to reference and revert if at some later point we want this functionality. BUG=none TEST=none Review URL: http://codereview.chromium.org/242079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27652 0039d316-1c4b-4281-b951-d872f2087c98
* Added command line argument --enable-webgl to facilitate turning onkbr@google.com2009-09-303-1/+8
| | | | | | | | | | | | ENABLE_3D_CANVAS in development builds. Currently this argument also requires disabling the sandbox. BUG=http://crbug.com/21852 TEST=none (runs preexisting WebGL layout tests; more coming) Review URL: http://codereview.chromium.org/246042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27637 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some unused code.darin@chromium.org2009-09-301-4/+0
| | | | | | | | | | R=pinkerton BUG=none TEST=none Review URL: http://codereview.chromium.org/256005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27615 0039d316-1c4b-4281-b951-d872f2087c98
* Integrate browser actions with the wrench menu. Browseraa@chromium.org2009-09-304-20/+35
| | | | | | | | | | | | actions always show up in a submenu of the wrench menu, and if they have an icon, they also show up in the toolbar area. BUG=23380,22883 TEST=Added new automated tests for the command handling, but we need to test that the menu items show up manually. To do that, run with no extension installed, you should see "extensions" in the wrench menu. Add an extension that adds a browser action, you should now see an "extensions" submenu with "manage extensions" and the browser action(s) in the submenu. Review URL: http://codereview.chromium.org/246037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27599 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 27389.darin@chromium.org2009-09-301-2/+2
| | | | | | Review URL: http://codereview.chromium.org/246027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27594 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Make InfoBubble use an override-redirect (popup) window.derat@chromium.org2009-09-302-0/+41
| | | | | | | | | | | | | This makes it work correctly in ion3 and other window managers that don't expect clients to try to move top-level windows themselves. This implementation grabs the pointer and keyboard. By doing this and using an override-redirect window, we should be able to avoid worrying about interactions with different window managers. The only downside (alluded to in the previous code) is that window manager keybindings don't make it through until the user dismisses the bubble by clicking outside of it or hitting Enter or Escape. I don't think this will be a problem; it's no different from what happens when you open a context menu in an app. BUG=20523 TEST=tested first-run and bookmark bubbles in Metacity, ion3, Fluxbox, KDE4, and the WM that I'm working on Review URL: http://codereview.chromium.org/198016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27578 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize the os_event struct members to 0 in the constructor.jhawkins@chromium.org2009-09-291-0/+1
| | | | | | | | | CID=1642 BUG=none TEST=none Review URL: http://codereview.chromium.org/255013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27554 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize type_ in the constructor.jhawkins@chromium.org2009-09-291-1/+2
| | | | | | | | | CID=2287 BUG=none TEST=none Review URL: http://codereview.chromium.org/242065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27548 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize test_funcs_.test_make_request in the constructor.jhawkins@chromium.org2009-09-291-0/+1
| | | | | | | | | CID=5447 BUG=none TEST=none Review URL: http://codereview.chromium.org/243037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27538 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize all member variables in the default constructor.jhawkins@chromium.org2009-09-291-0/+3
| | | | | | | | | CID=1315 BUG=none TEST=none Review URL: http://codereview.chromium.org/243029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27515 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid potential "NULL used as int" warnings by changing ASSERT_EQ(NULL, ...) ↵pkasting@chromium.org2009-09-292-9/+9
| | | | | | | | | to ASSERT_TRUE(... == NULL). Patch by Jacob Mandelson (see http://codereview.chromium.org/202057 ), r=me. BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27511 0039d316-1c4b-4281-b951-d872f2087c98
* Wires up views on linux dialogs to use gtk ones.sky@chromium.org2009-09-291-5/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/254007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27484 0039d316-1c4b-4281-b951-d872f2087c98
* Add kMDItemWhereFroms metadata attribute to downloaded files. Combine with ↵pinkerton@chromium.org2009-09-292-112/+0
| | | | | | | | | | quarantine utility function and move into chrome/browser/cocoa, since common/ is not the right place for browser code. BUG=22289 TEST=file downloading Review URL: http://codereview.chromium.org/220037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27483 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the enable-sync flag from the Chrome command line and enable sync by ↵brg@chromium.com2009-09-292-3/+3
| | | | | | | | | | default. BUG=none Test=Sync my bookmarks should be enabled by default. Review URL: http://codereview.chromium.org/248024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27472 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of the need for cross process events in order to get plugin ↵jam@chromium.org2009-09-292-13/+6
| | | | | | | | | | processes to run nested message loops when a dialog is shown. Instead use an async message that's broadcast from the renderer to all plugin processes that are connected to it, and which is dispatched on the plugin IO thread to set a process-local waitable event. This fixes showModalDialog on Linux/Mac. BUG=15891 TEST=covered by UI tests, undef's them for POSIX Review URL: http://codereview.chromium.org/242043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27456 0039d316-1c4b-4281-b951-d872f2087c98
* First step towards NaCl-Chrome integration:1. NaCl plugin becomes a built-in ↵gregoryd@google.com2009-09-298-0/+78
| | | | | | | | | | | plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. Command line flag "--internal-nacl" is required to enable the built-in NaCl plugin. NaCl still cannot run in Chrome sandbox, the flag automatically disables the sandboxCommitted: http://src.chromium.org/viewvc/chrome?view=rev&revision=27315 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27324 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27397 Review URL: http://codereview.chromium.org/153002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27445 0039d316-1c4b-4281-b951-d872f2087c98
* Fix deadlock when plugin puts an alert and right afterwards the browser ↵jam@chromium.org2009-09-283-51/+4
| | | | | | | | | | process makes a win32 call that ends up waiting on the plugin. Since the plugin thread is blocked, the Windows message doesn't get dispatched and the browser ui thread deadlocks. The message from the renderer would make the plugin run a nested message loop but it doesn't get run on the browser ui thread since it's blocked. The fix is to set the event that runs nested message loop in the renderer process. BUG=23147 TEST=ui tests already cover nested message loops and plugins. This particular scenario is hard to write a test case for because it's a race condition involving the browser. Review URL: http://codereview.chromium.org/243018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27421 0039d316-1c4b-4281-b951-d872f2087c98
* Add section about the Ruby script to the packaging page.kathyw@google.com2009-09-282-6/+43
| | | | | | | | TBR=aa Review URL: http://codereview.chromium.org/244025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27414 0039d316-1c4b-4281-b951-d872f2087c98
* Moving ContextualAction class to common/extensions and in the process ↵finnur@chromium.org2009-09-285-77/+77
| | | | | | | | | | | | | renaming it ExtensionAction. No code change. BUG=None TEST=Page actions and browser actions should work as before (no change) Review URL: http://codereview.chromium.org/242035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27406 0039d316-1c4b-4281-b951-d872f2087c98
* Implement about:ipc dialog for Mac.jrg@chromium.org2009-09-287-18/+79
| | | | | | | | | Convert IPC logging trigger from x-process waitable event to a messages sent to all processes. Review URL: http://codereview.chromium.org/192070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27405 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 27397 - First step towards NaClChrome integration:1. NaCl plugin ↵gregoryd@google.com2009-09-288-78/+0
| | | | | | | | | | | | | becomes a builtin plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. Command line flag "internalnacl" is required to enable the builtin NaCl plugin. NaCl still cannot run in Chrome sandbox, the flag automatically disables the sandboxCommitted: http://src.chromium.org/viewvc/chrome?view=rev&revision=27315 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27324 Review URL: http://codereview.chromium.org/153002 TBR=gregoryd@google.com Review URL: http://codereview.chromium.org/235042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27400 0039d316-1c4b-4281-b951-d872f2087c98
* Pulls ActiveWindowWatcher into app so that we can use it insky@chromium.org2009-09-281-4/+0
| | | | | | | | | | | | | views. Converts from using notification server to observer as notification service is chrome only. Also changes the pointer type used by window_gtk to be a left arrow. BUG=none TEST=none Review URL: http://codereview.chromium.org/245016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27398 0039d316-1c4b-4281-b951-d872f2087c98
* First step towards NaCl-Chrome integration:1. NaCl plugin becomes a built-in ↵gregoryd@google.com2009-09-288-0/+78
| | | | | | | | | plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. Command line flag "--internal-nacl" is required to enable the built-in NaCl plugin. NaCl still cannot run in Chrome sandbox, the flag automatically disables the sandboxCommitted: http://src.chromium.org/viewvc/chrome?view=rev&revision=27315 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27324 Review URL: http://codereview.chromium.org/153002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27397 0039d316-1c4b-4281-b951-d872f2087c98
* Implementing chrome.i18n.getMessage call, that loads message from the ↵cira@chromium.org2009-09-288-7/+913
| | | | | | | | | | | | | | | | | | | extension catalog, and if necessary replaces placeholders (up to 9). I have 3 forms of getMessage call: getMessage("name") for simple messages without placeholders. getMessage("name", "one param") for messages with only one placeholder. getMessage("name", ["one", "two"]) for messages with only one or more placeholders. getMessage returns string. BUG=12131 TEST=Load samples/i18n extension (switch Chrome to sr locale) and observe ext. name, description and toolstrip texts should be in Serbian. Review URL: http://codereview.chromium.org/225009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27393 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 27379, in hopes of fixing browser_tests.senorblanco@chromium.org2009-09-281-2/+2
| | | | | | | | TBR=darin Review URL: http://codereview.chromium.org/248021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27389 0039d316-1c4b-4281-b951-d872f2087c98
* Assert that thread-safe reference counting is used withdarin@chromium.org2009-09-281-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | cross-thread NewRunnableMethod. This assertion caught such an error in VisitedLinkMaster! My approach, modify RunnableMethodTraits<T> to assert that when ReleaseCallee happens on a different thread from RetainCallee that the type supports thread-safe reference counting. I do this by adding a static method to both RefCounted<T> and RefCountedThreadSafe<T>. This results in a little ugliness in cases where people implement AddRef and Release by hand (to make the no-ops). There may be a nicer way to deal with those few cases. R=brettw BUG=none TEST=none Review URL: http://codereview.chromium.org/251012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27379 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-31 01:54:54 +0000