summaryrefslogtreecommitdiffstats
path: root/chrome/common
Commit message (Collapse)AuthorAgeFilesLines
* [Mac] Use Linux WorkerPool code.shess@chromium.org2010-11-052-0/+8
| | | | | | | | | | | | | | | | | Adapts things to use the Linux WorkerPool code by default, with --disable-linux-workerpool to switch back to the old version. The old implementation uses NSOperationQueue, which is implemented in terms of pthread workqueues. These are implicated by the stack traces from the recent unit test flakiness. This change attempts to influence that flakiness. BUG=20471, 60426 TEST=Tree green. Review URL: http://codereview.chromium.org/4595001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65273 0039d316-1c4b-4281-b951-d872f2087c98
* Add the ability for NotificationRegistrar users to check if a particular ↵pkasting@chromium.org2010-11-052-8/+21
| | | | | | | | | | notification is registered. BUG=54274 TEST=none Review URL: http://codereview.chromium.org/4574002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65233 0039d316-1c4b-4281-b951-d872f2087c98
* Add a command line switch for unlimited quota (for testing).jorlow@chromium.org2010-11-052-0/+6
| | | | | | | | | BUG=60577 TEST=--unlimited-quota-for-indexeddb results in you being able to put more than 5MB in IndexedDB per origin Review URL: http://codereview.chromium.org/4190012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65195 0039d316-1c4b-4281-b951-d872f2087c98
* Implement onCompleted event for the webNavigation APIjochen@chromium.org2010-11-052-0/+9
| | | | | | | | | BUG=50943 TEST=browser_tests:*.WebNavigationEvents* Review URL: http://codereview.chromium.org/4448003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65182 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 63447 - sync: enable password sync by default.tim@chromium.org2010-11-042-4/+4
| | | | | | | | | | | | | | BUG=none TEST=Enable sync, notice passwords is an option / enabled. unit_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=63223 Review URL: http://codereview.chromium.org/3913005 TBR=tim@chromium.org Review URL: http://codereview.chromium.org/4543001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65142 0039d316-1c4b-4281-b951-d872f2087c98
* Sanitize checkdeps-checked DEPS a bit.evan@chromium.org2010-11-041-1/+1
| | | | | | | | | - Move dependencies closer to where they're used. - Remove redundant comments. Review URL: http://codereview.chromium.org/4511001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65134 0039d316-1c4b-4281-b951-d872f2087c98
* net: add certificate provenance checking.agl@chromium.org2010-11-042-0/+6
| | | | | | | | | BUG=none TEST=none http://codereview.chromium.org/4448001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65116 0039d316-1c4b-4281-b951-d872f2087c98
* Add flags for page prerendering.cbentzel@chromium.org2010-11-042-0/+4
| | | | | | | | | | | Contributed by: tburkard@chromium.org TEST=trybot BUG=61745 Review URL: http://codereview.chromium.org/4226002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65093 0039d316-1c4b-4281-b951-d872f2087c98
* Removed Media Cache Enabled Flagatwilson@chromium.org2010-11-042-4/+0
| | | | | | | | | | | Removed methods for querying and enabling media cache as the cache has been stable enough we shouldn't have to worry about checking anymore. BUG=None. TEST=No specific test as this flag hasn't been used. Review URL: http://codereview.chromium.org/4266001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65077 0039d316-1c4b-4281-b951-d872f2087c98
* Turn on file access checks on Win.jam@chromium.org2010-11-041-0/+3
| | | | | | | | | BUG=60211 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64960 Review URL: http://codereview.chromium.org/4222005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65075 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the in memory db update keyword search terms.sky@chromium.org2010-11-041-0/+8
| | | | | | | | | BUG=61518 TEST=none Review URL: http://codereview.chromium.org/4449002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65065 0039d316-1c4b-4281-b951-d872f2087c98
* Integrate ETW with VLOG logging.siggi@chromium.org2010-11-041-2/+3
| | | | | | | | | | | | | This change extends the log severities into the negative for VLOG verbosities. It also keeps track of file/line information and passes it to any registered log handler. The log level is naturally controlled by translating ETW log levels to the severities. BUG=none TEST=none Review URL: http://codereview.chromium.org/4164011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65062 0039d316-1c4b-4281-b951-d872f2087c98
* Implement new SearchBox API along side existing API.tonyg@chromium.org2010-11-042-2/+22
| | | | | | | | | Add some tests. BUG=none TEST=interactive_ui_tests --gtest_filter=InstantTest.* git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65061 0039d316-1c4b-4281-b951-d872f2087c98
* Update kEnableCrashReporter comment.mnissler@chromium.org2010-11-041-2/+0
| | | | | | | | | | | This flag does not take effect when passed to browser processes, remove the comment lines saying otherwise. BUG=None TEST=compiles Review URL: http://codereview.chromium.org/4213001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65046 0039d316-1c4b-4281-b951-d872f2087c98
* Policy to silently install extensionsgfeher@chromium.org2010-11-041-4/+5
| | | | | | | | | | | | | | | Separate the parts of ExternalPrefExtensionProvider that store the list of external extensions and the parts that parse the preference file. This makes it possible for other providers to reuse the storage code. Also make it possible to have external extensions from update URLs with locations other than Extension::EXTERNAL_PREF_DOWNLOAD, by making it a parameter of OnExternalExtensionUpdateUrlFound. Add new provider (ExternalPolicyExtensionProvider) to provide external extensions from policies. BUG=59782 TEST=ExtensionsServiceTest.ExternalPrefProvider,ExternalPolicyExtensionProvider.* Review URL: http://codereview.chromium.org/3826008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65040 0039d316-1c4b-4281-b951-d872f2087c98
* Implement onDOMContentLoaded event of the webNavigation API.jochen@chromium.org2010-11-042-2/+9
| | | | | | | | | BUG=50943 TEST=browser_tests:*.WebNavigationEvents*,unit_tests:FrameNavigationStateTest.* Review URL: http://codereview.chromium.org/4381001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65034 0039d316-1c4b-4281-b951-d872f2087c98
* Implement DOM UI version of keyboard overlay.mazda@chromium.org2010-11-042-0/+4
| | | | | | | | | | | Add a URL chrome://keyboardoverlay/ for keyboard overlay. BUG=chromium-os:6268 TEST=manually on the net book Review URL: http://codereview.chromium.org/4226001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65028 0039d316-1c4b-4281-b951-d872f2087c98
* Allow histograms in cache stats.cc to bypass corruption checksjar@chromium.org2010-11-031-1/+17
| | | | | | | | | | | | | | | | This is a relanding of http://codereview.chromium.org/4174002 The change in this CL is that I've made the function to look for errors virtual, and over-rode it in StatsHistograms. The current override doesn't actually check for inconsistencies, so that the UMA checks (and renderer-to-histogram checks) won't complain and refuse to transport the histograms. BUG=61281 r=rvargas Review URL: http://codereview.chromium.org/4364001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64990 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 64828 - "Revert 64493 - These are files need to be added to ↵tessamac@google.com2010-11-034-0/+586
| | | | | | | | | | | | | | | benchmarks extension." This reverts commit fbf3155bc7b82cbf56c9e6bdbd806a81daf2f2ce. Also update docs. BUG=61650 TEST=Successfully ran build.py Review URL: http://codereview.chromium.org/4421001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64979 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 64960 - Turn on file access checks on Win.rafaelw@chromium.org2010-11-031-3/+0
| | | | | | | | | | BUG=60211 Review URL: http://codereview.chromium.org/4222005 TBR=jam@chromium.org Review URL: http://codereview.chromium.org/4431001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64974 0039d316-1c4b-4281-b951-d872f2087c98
* Kill Extension::RuntimeData and move its guts to ExtensionsService.mpcomplete@chromium.org2010-11-032-88/+17
| | | | | | | | | | | | ImageCache remains on Extension, on the expectation that it will eventually be loaded at startup. BUG=56558 TEST=no functional change Review URL: http://codereview.chromium.org/4132005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64973 0039d316-1c4b-4281-b951-d872f2087c98
* Turn on file access checks on Win.jam@chromium.org2010-11-031-0/+3
| | | | | | | BUG=60211 Review URL: http://codereview.chromium.org/4222005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64960 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Add a confirm to quit experiment to about:flags.rsesek@chromium.org2010-11-032-0/+4
| | | | | | | | | BUG=27786,60591 TEST=Enable 'Confirm to Quit' in about:flags. When you press Cmd+Q, it brings up the floaty panel telling you to hold the key combo. When you do, it quits after 1.5 seconds. Review URL: http://codereview.chromium.org/4220005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64920 0039d316-1c4b-4281-b951-d872f2087c98
* Remove duplicate entry from ExtensionInfo structjochen@chromium.org2010-11-031-4/+0
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/4146012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64919 0039d316-1c4b-4281-b951-d872f2087c98
* C++ readability review for dannodanno@chromium.org2010-11-032-2/+2
| | | | | | | | | | | | | | | I wrote much of the cross-platform policy-providing mechanism for Chrome. Much of the policy code is cross platform, so I would like to apply for a Linux C++ readability review. However, my submitted CLs also contain Windows-specific code, so I'm unsure if Windows readability is more appropriate. * Implementation of managed policy abstraction on top of a preference store. This is the CL that is the initial preparation for implementing platform-specific policy - http://codereview.chromium.org/1692011 * Implement core mechanism to honor Windows Group Policy on top of initial CL - http://codereview.chromium.org/2119005 * Dynamic refresh of policy without restarting Chrome including Windows-specific code - http://codereview.chromium.org/2858060 BUG=none TEST=none Review URL: http://codereview.chromium.org/3774003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64897 0039d316-1c4b-4281-b951-d872f2087c98
* Added ability to propogate create to suggest whether or not filesystem's ↵kkanetkar@chromium.org2010-11-033-4/+7
| | | | | | | | | | | | | root should be created if the path doesn't exist. BUG=None TEST=None Review URL: http://codereview.chromium.org/4350001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64862 0039d316-1c4b-4281-b951-d872f2087c98
* base: Remove 'using' declaration of StringPrintV.tfarina@chromium.org2010-11-031-2/+2
| | | | | | | | | | | Callers should append base:: when calling StringPrintV now. BUG=None TEST=locally and trybots Review URL: http://codereview.chromium.org/4296004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64861 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 64845 - Add convert_web_app.*, a utility to convert web apps declaredaa@chromium.org2010-11-021-0/+1
| | | | | | | | | | | | | | | in pure HTML into the extension-based web apps used internally by Chrome. BUG=49233 TEST=unit_tests --gtest_filter=ExtensionFromWebApp.* Review URL: http://codereview.chromium.org/4139008 TBR=aa@chromium.org Review URL: http://codereview.chromium.org/4326002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64851 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 64687 - Try to detect internal corruption of histogram instances.jar@chromium.org2010-11-021-17/+1
| | | | | | | | | | | | | | | | | | | | | | | | Corruptions can include changes in bucket boundaries, large changes in sample counts (in a bucket), etc. We now detect problems, and don't forward the corrupt data any further. This means it won't exit the renderer and go to the browser if corrupt, and it won't exit the browser and be sent up via UMA if corrupt. IF the would-be corruption is caused by a race to snapshot the data, then a later snapshot should get the clean copy, and all data (across the precluded period) will be sent onward. BUG=61281 r=mbelshe Review URL: http://codereview.chromium.org/4174002 TBR=jar@chromium.org Review URL: http://codereview.chromium.org/4349002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64846 0039d316-1c4b-4281-b951-d872f2087c98
* Add convert_web_app.*, a utility to convert web apps declaredaa@chromium.org2010-11-021-1/+0
| | | | | | | | | | | | in pure HTML into the extension-based web apps used internally by Chrome. BUG=49233 TEST=unit_tests --gtest_filter=ExtensionFromWebApp.* Review URL: http://codereview.chromium.org/4139008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64845 0039d316-1c4b-4281-b951-d872f2087c98
* Disable DOMUI menu by default. a part of reverting 6497 feature.oshima@chromium.org2010-11-022-3/+3
| | | | | | | | | BUG=chromium-os:6497,chromium-os:8574 TEST=all tests should still pass. Review URL: http://codereview.chromium.org/4273003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64841 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 64493 - These are files need to be added to benchmarks extension.aa@chromium.org2010-11-023-580/+0
| | | | | | | | | | | | | | | | These files should be part of http://codereview.chromium.org/4123001/, but were missed during the original patch. Contributed by Jianxia Ning <jning@google.com>. BUG=none TEST=none TBR=lzheng@chromium.org Review URL: http://codereview.chromium.org/4349001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64828 0039d316-1c4b-4281-b951-d872f2087c98
* This moves log output for ChromeOS to safer locations.gspencer@chromium.org2010-11-024-8/+41
| | | | | | | | | | | | | | | | | | | For BWSI (incognito) mode, we want to make sure that we don't leak private information between sessions, so we need to have chrome write log output to the tmpfs created for that mode. Also, the chrome log in "logged in" mode should reside in the "log" subdir instead of in the user data dir. BUG=http://crosbug.com/6908 TEST=Ran on device in incognito and regular modes, and watched where log output ended up. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64638 Review URL: http://codereview.chromium.org/4194005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64826 0039d316-1c4b-4281-b951-d872f2087c98
* Cloud Print Dialog work.scottbyer@google.com2010-11-022-1/+7
| | | | | | | | | | | | Allow an HTML dialog to suppress the title bar in a Chromium OS bubble window. For the Cloud Print dialog, remember the last size requested by the contents. BUG=chromium-os:8494 TEST=none Review URL: http://codereview.chromium.org/4110010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64824 0039d316-1c4b-4281-b951-d872f2087c98
* Moving Entry from base::file_util_proxy namespace to within class ↵kkanetkar@chromium.org2010-11-028-25/+12
| | | | | | | | | | | | base::FileUtilProxy BUG=None TEST=None Review URL: http://codereview.chromium.org/4261001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64806 0039d316-1c4b-4281-b951-d872f2087c98
* Unrevert r64676 "Part 4/4 of immutable Extension refactor: Kill ↵mpcomplete@chromium.org2010-11-023-369/+291
| | | | | | | | | | | | | | | | | Extension::StaticData and put" Original CL: Part 4/4 of immutable Extension refactor: Kill Extension::StaticData and put its guts into Extension. BUG=56558 TEST=no functional change Review URL: http://codereview.chromium.org/4200005 Review URL: http://codereview.chromium.org/4277002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64767 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Refactor sandbox profile construction.jeremy@chromium.org2010-11-024-86/+239
| | | | | | | | | | | | * Introduce primitive variable substituion, this is useful since it greatly simplifies the calling code (you don't need to escape strings at the callsite). * Construct the output profile in an std::string rather than an NSString, since there is no contract that the sandbox profile must be valid utf-8. The only guarantee we have is that paths in the profile must be able to be passed verbatum to OS file access functions. Bug=60917 Test=Chrome on Mac should start up, installing extensions and themes should continue to work. Review URL: http://codereview.chromium.org/4153008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64725 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r64676 "Part 4/4 of immutable Extension refactor: Kill ↵mpcomplete@chromium.org2010-11-023-291/+369
| | | | | | | | | | | | | | | | | | | Extension::StaticData and put" Original CL: Part 4/4 of immutable Extension refactor: Kill Extension::StaticData and put its guts into Extension. BUG=56558 TEST=no functional change Review URL: http://codereview.chromium.org/4200005 TBR=nirnimesh Review URL: http://codereview.chromium.org/4274001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64692 0039d316-1c4b-4281-b951-d872f2087c98
* Try to detect internal corruption of histogram instances.jar@chromium.org2010-11-011-1/+17
| | | | | | | | | | | | | | | | | | | | | Corruptions can include changes in bucket boundaries, large changes in sample counts (in a bucket), etc. We now detect problems, and don't forward the corrupt data any further. This means it won't exit the renderer and go to the browser if corrupt, and it won't exit the browser and be sent up via UMA if corrupt. IF the would-be corruption is caused by a race to snapshot the data, then a later snapshot should get the clean copy, and all data (across the precluded period) will be sent onward. BUG=61281 r=mbelshe Review URL: http://codereview.chromium.org/4174002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64687 0039d316-1c4b-4281-b951-d872f2087c98
* In the webstore login api, we need to provide the gaia auth token to allow ↵johnnyg@chromium.org2010-11-013-2/+12
| | | | | | | | | | | token-based authentication, not the chromiumsync token. BUG=61490 TEST=webstore integration Review URL: http://codereview.chromium.org/4106016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64685 0039d316-1c4b-4281-b951-d872f2087c98
* Part 4/4 of immutable Extension refactor: Kill Extension::StaticData and putmpcomplete@chromium.org2010-11-013-369/+291
| | | | | | | | | | | its guts into Extension. BUG=56558 TEST=no functional change Review URL: http://codereview.chromium.org/4200005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64676 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the ability to show verbatim instant results rather thansky@chromium.org2010-11-012-5/+8
| | | | | | | | | | | predictive results. More work is needed if we decide this is the direction to go, but it's good enough for us to play with. BUG=61378 TEST=none Review URL: http://codereview.chromium.org/4196009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64662 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 64638 - This moves log output for ChromeOS to safer locations.gspencer@chromium.org2010-11-014-34/+6
| | | | | | | | | | | | | | | | | | | | For BWSI (incognito) mode, we want to make sure that we don't leak private information between sessions, so we need to have chrome write log output to the tmpfs created for that mode. Also, the chrome log in "logged in" mode should reside in the "log" subdir instead of in the user data dir. BUG=http://crosbug.com/6908 TEST=Ran on device in incognito and regular modes, and watched where log output ended up. Review URL: http://codereview.chromium.org/4194005 TBR=gspencer@chromium.org Review URL: http://codereview.chromium.org/4089014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64655 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Refactor automation messages." due to mysterious problems on mac.erg@google.com2010-11-016-2189/+0
| | | | | | | | | | | | | This reverts commit c1c1fed998ee4d839bfe256150e5e59220ebc0ef (r64637). TBR=nirnimesh@ BUG=51409 TEST=none Review URL: http://codereview.chromium.org/4194007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64644 0039d316-1c4b-4281-b951-d872f2087c98
* This moves log output for ChromeOS to safer locations.gspencer@chromium.org2010-11-014-6/+34
| | | | | | | | | | | | | | | | | For BWSI (incognito) mode, we want to make sure that we don't leak private information between sessions, so we need to have chrome write log output to the tmpfs created for that mode. Also, the chrome log in "logged in" mode should reside in the "log" subdir instead of in the user data dir. BUG=http://crosbug.com/6908 TEST=Ran on device in incognito and regular modes, and watched where log output ended up. Review URL: http://codereview.chromium.org/4194005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64638 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor automation messages.erg@google.com2010-11-016-0/+2189
| | | | | | | | | | | | | | | | | automation_messages used to live in chrome/test/automation, when it's needed by browser and chrome_frame. When I started lifting code out of headers and into implementation files, I was getting link errors and temporarily solved the problem by compiling the cc files manually into libbrowser.a. Now this is part of chrome/common/ which is included by all targets needed. While doing this, discover that automation IPC redefines the ContextMenuParams struct. Rename it to MiniContextMenuParams. BUG=51409 TEST=none Review URL: http://codereview.chromium.org/4200007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64637 0039d316-1c4b-4281-b951-d872f2087c98
* Language tag for speech.leandrogracia@chromium.org2010-11-011-3/+4
| | | | | | | | | | | | | | | | | | | | This is the 3rd in a 4-sided patch to add language attribute support to speech input. The other patches can be found here: 1st - http://codereview.chromium.org/3615005/show 2nd - https://bugs.webkit.org/show_bug.cgi?id=47089 4th - https://bugs.webkit.org/show_bug.cgi?id=47420 This patch will be submitted once the webkit change has been rolled into chromium DEPS. Also, a last webkit cleanup patch will be submitted at any point after the 2nd patch. BUG=53598 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64466 Review URL: http://codereview.chromium.org/3595018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64596 0039d316-1c4b-4281-b951-d872f2087c98
* Convert implicit scoped_refptr constructor calls to explicit ones, part 1thakis@chromium.org2010-11-013-11/+11
| | | | | | | | | | | This CL was created automatically by this clang rewriter: http://codereview.appspot.com/2776043/ . I manually fixed a few rough spots of the rewriter output (doh1-3) and fixed all presubmit errors. BUG=28083 TEST=None Review URL: http://codereview.chromium.org/4192012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64573 0039d316-1c4b-4281-b951-d872f2087c98
* chrome/common: Append base:: in the StringPrintf calls.tfarina@chromium.org2010-10-3117-101/+105
| | | | | | | | | | | (Note: This is a TODO in string_util.h) BUG=None TEST=trybots Review URL: http://codereview.chromium.org/4111011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64567 0039d316-1c4b-4281-b951-d872f2087c98
* Remove dead page info placement preference.tfarina@chromium.org2010-10-302-5/+0
| | | | | | | | | BUG=59030 TEST=trybots Review URL: http://codereview.chromium.org/4143012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64537 0039d316-1c4b-4281-b951-d872f2087c98