| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Start Oauth2 login token fetch when "lso" auth token is fetched successfully.
- Store the refresh and access login tokens.
- Generate a token available notification for login token.
- Add tests.
Review URL: http://codereview.chromium.org/8680019
TBR=munjal@chromium.org
Review URL: http://codereview.chromium.org/8725037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=mpcomplete@chromium.org
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8681008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
- Start Oauth2 login token fetch when "lso" auth token is fetched successfully.
- Store the refresh and access login tokens.
- Generate a token available notification for login token.
- Add tests.
Review URL: http://codereview.chromium.org/8680019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
client secret)
so that it can be used to refresh any OAuth2 access token, not just the login scoped token.
Review URL: http://codereview.chromium.org/8720001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111869 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- It's UDP-only.
- It has only APIs for UDP sending, as well as some concepts of TCP connection. It has nothing related to receiving data.
- It does no actual work, instead returning "42" as the new socket ID.
So why bother checking this in? As stated above, it's getting large for a single review, and I'd like to start the process of getting feedback on these APIs.
+asargent to review changes to test utilities
BUG=none
TEST=Added several unit and functional tests.
Review URL: http://codereview.chromium.org/8590038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
danger state.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8680030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=arv@chromium.org
BUG=62079
TEST=none
Review URL: http://codereview.chromium.org/8578009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111693 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The actual changes here are to `.../template/api_template.html` and `.../js/api_page_generator.js`. Everything else is just generated from those two files.
As a drive-by, this also changes `api_page_generator.js` to allow for more than one `prerenderjs` block in each template. Each should be evaluate in the order in which they're discovered on the page.
BUG=105105
TEST=
Review URL: http://codereview.chromium.org/8638011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111688 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moving the savePageAsMTML API out of experimental and renaming it per Kathy
suggestion to pageCapture.saveAsMhtml.
BUG=None
TEST=The API should still work.
Review URL: http://codereview.chromium.org/8682013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111678 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=105212
TEST=*ExtensionSetting* (unit_tests, browser_tests)
Review URL: http://codereview.chromium.org/8695009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make sure that:
- shebang is only present for executable files
- shebang is #!/usr/bin/env python
- __main__ is only present for executable files
- file's executable bit is coherent
Also fix EOF LF to be only one.
Minor python style fixes.
TBR=nirnimesh@chromium.org
BUG=105108
TEST=
Review URL: http://codereview.chromium.org/8680018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts r105855, since event.clipboardData.setData is properly implemented.
BUG=102565
TEST=compiles
Review URL: http://codereview.chromium.org/8662033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also, move all mac sandbox unittests to content
BUG=90443
TEST=content_unittests
Review URL: http://codereview.chromium.org/8589001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111614 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
As a drive-by, this CL also regenerates the `experimental.settings` docs, which someone apparently forgot to do after committing. :)
BUG=92644
TEST=
Review URL: http://codereview.chromium.org/8698003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111588 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
|const char* kFoo| marks the memory pointed to by kFoo as constant, but
the pointer itself can be changed - some function might do `kFoo = "me!";`.
Because of that, every global that's initialized with `myglobal = kFoo;` needs
a static initializer. Fix this by making the pointer const as well.
BUG=94925
TEST=none
Review URL: http://codereview.chromium.org/8693005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111559 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Patterns with file scheme and non empty host
- File patterns that user a wildcard '*' symbol in their path
- "file:///"
- Patterns with an IP address and a domain wildcard.
Add tests to check that "[*.]", "http://[*.]", ... are valid patterns.
BUG=104414
TEST=ContentSettingsPattern*
Review URL: http://codereview.chromium.org/8676020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111546 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and separate the API into a "sync" and a "local" namespace. Make calls into
the "local" namespace not synced.
BUG=103863
TEST=*ExtensionSetting* (browser_tests, unit_tests)
Review URL: http://codereview.chromium.org/8670012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The original CL was:
http://src.chromium.org/viewvc/chrome?view=rev&revision=111270
Codereview:
http://codereview.chromium.org/8632005/
Review URL: http://codereview.chromium.org/8662002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For now, Chromium have five same code in various place to handle JobObject
as KILL_ON_JOB_CLOSE.
This change provide a common utility function to be used by them.
BUG=n/a
TEST=n/a; run existing unit tests because this is just a refactoring change
Review URL: http://codereview.chromium.org/8667006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111441 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Applied patch from http://codereview.chromium.org/8665006/
BUG=none
TEST=duh
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/8677014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111403 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=91241
TEST=
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111254
Review URL: http://codereview.chromium.org/8587023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
screen by reversing flag.
Reverses the description/meaning of the --webui-lock-screen flag to use the WebUI lock screen by default but allow disabling it to maintain support for the old lock screen.
BUG=97980
TEST=None
Review URL: http://codereview.chromium.org/8648002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111370 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
that content include from chrome. We change a bool to it, only to change it back to a bool, so no need for it.
BUG=98716
Review URL: http://codereview.chromium.org/8667004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111363 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=64155
TEST=none
Review URL: http://codereview.chromium.org/8396001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=92107
TEST=see bug
Review URL: http://codereview.chromium.org/8515017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8633024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111308 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add a couple of more flow methods to GaiaAuthFetcher.
- Add a new fetcher class to get a new access token from refresh token.
- Full set o tests.
Review URL: http://codereview.chromium.org/8632005
TBR=munjal@chromium.org
Review URL: http://codereview.chromium.org/8669010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111277 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
- Add a couple of more flow methods to GaiaAuthFetcher.
- Add a new fetcher class to get a new access token from refresh token.
- Full set o tests.
Review URL: http://codereview.chromium.org/8632005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111270 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=91241
TEST=
Review URL: http://codereview.chromium.org/8587023
TBR=sail@chromium.org
Review URL: http://codereview.chromium.org/8673003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111261 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=91241
TEST=
Review URL: http://codereview.chromium.org/8587023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL makes the first parameter of the experimental savePage.saveAsMHTML API
a dictionary, so the API can easily be extended in the future.
BUG=None
TEST=browser_tests should pass.
Review URL: http://codereview.chromium.org/8631017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the first attempt at moving some of the Autofill logic out of the
autofillagent in the renderer and into the external delegate in the browser.
I just focused on OnSuggestionsReturned, so the browser side should be able to
correcrtly create the list of suggestions to show. There are still features that
need to be moved, such as the ability to select an item, which I will address in
future cls.
BUG=51644
TEST=
Review URL: http://codereview.chromium.org/8488011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111240 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=existing
Review URL: http://codereview.chromium.org/8637019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=ivankr@chromium.org
BUG=102765
TEST=Check that Protector is enabled by default.
Review URL: http://codereview.chromium.org/8632014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
They are stored in chrome/test/data/layout_tests/LayoutTests in svn or old
git workflow. and in third_party/WebKit/LayoutTests in new git workflow.
This change adds new query key chrome::DIR_LAYOUT_TESTS to
PathService::Get(). Using this interface, each test easily get suitable path
for their layout tests.
BUG=105104
TEST=browser_tests; ui_tests
Review URL: http://codereview.chromium.org/8641002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We now delete the temporary file created when generating MHTML from the
extension API.
BUG=97489
TEST=The MHTML extension API should still work.
Review URL: http://codereview.chromium.org/8530003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8558015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111164 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. experimental.metrics is now metricsPrivate
2. metricsPrivate is available to component extensions only
3. removed getEnabled/setEnabled functions as useless/harmful.
BUG=
TEST=
Review URL: http://codereview.chromium.org/8548013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:20009
TEST=None
Review URL: http://codereview.chromium.org/8558014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Valid states are normal, minimized and maximized. Actual behavior depends on OS and window type.
BUG=10828
TEST=ExtensionApiTest.UpdateWindowShowState
Review URL: http://codereview.chromium.org/8586045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was split out of http://codereview.chromium.org/8588067/.
BUG=none
TEST=none, but this does make testing easier.
Review URL: http://codereview.chromium.org/8561031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
currying, and use less types.
The main API change IgnoreResult() and fully currying. See unittest for what the new API looks like. The rest of the changes are done to support that.
Previously, IgnoreReturn could not be used with WeakPtr<> Bind()s as it was applied after the fact to the Callback object. Now, IgnoreResult() wraps the function like Unretained().
As an incidental benefit, the new implementation gave us fully currying for free.
Also, the new implementation scales better when supporting higher arities of functions. The new type growth is:
(n^2 + 20n) / 2
as opposed to
(3n^2 + 17n) / 2
where n == arity.
For n = 6 and n=10, the new implementation has 81 and 155 templates respectively.
The old implementation had 105 and 235 templates respectively.
BUG=35233,98919,98542
TEST=existing unittests
Review URL: http://codereview.chromium.org/8483003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=104314
TEST=no change
Review URL: http://codereview.chromium.org/8551009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110941 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=mpcomplete@chromium.org
BUG=chromium-os:23194
TEST=Run browser_tests --gtest_filter="ExtensionApiTest.InputImeApiBasic"
Review URL: http://codereview.chromium.org/8558013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
based classes that are obsoleted by Aura. Also remove a bunch of Wayland stuff, since any future Wayland integration is likely done as an implementation detail of Aura, not Views.
Specifically:
- views-desktop (classes and NativeWidgetView[s])
- NativeWidgetViews subclasses in Chrome (Constrained Windows, NTCVV, NTCCV, BrowserFrameViews et al).
- RWHVV, NWKEV
- NativeViewHostViews
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8598024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110832 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=104039
R=ben@chromium.org
Review URL: http://codereview.chromium.org/8566052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=97388
TEST=none
Review URL: http://codereview.chromium.org/8536022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Admins can specify the URL, name, and icon to be used for the enterprise
web store. The app itself is implemented as a component extension, with
some of the manifest values being specified by policy.
BUG=88464
TEST=New ComponentLoaderTest class added to unit_tests. Additional
manual testing: set "EnterpriseWebStoreURL" policy to a valid URL and
start up Chrome. Verify that there is an app on the new tab page that
links to the specified URL. If possible, try installing an extension from
somewhere on that URL, and ensure that no warning is shown before
showing the permission dialog.
Review URL: http://codereview.chromium.org/8477005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Two new policies added:
DiskCacheSize (general cache size)
MediaCacheSize (cache size for media files)
BUG=100549
TEST=unit_tests *Policy*
Review URL: http://codereview.chromium.org/8572006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:23058
TEST=None
Review URL: http://codereview.chromium.org/8570026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110655 0039d316-1c4b-4281-b951-d872f2087c98
|