summaryrefslogtreecommitdiffstats
path: root/chrome/common
Commit message (Collapse)AuthorAgeFilesLines
* Implement mediaGalleriesPrivate api to notify extensions about gallery ↵kmadhusu@chromium.org2013-01-071-0/+23
| | | | | | | | | | | | changed events. BUG=144491 TEST=none Review URL: https://chromiumcodereview.appspot.com/11535008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175347 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ActiveTab sample extension (extension version in manifest needs to be a ↵finnur@chromium.org2013-01-071-1/+1
| | | | | | | | | | string). BUG=None TEST=The sample extension for activeTab should not fail to load unpacked. Review URL: https://codereview.chromium.org/11777015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175345 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: Disable Drive metadata prefetchhashimoto@chromium.org2013-01-072-0/+4
| | | | | | | | | BUG=167722 TEST=unit_tests --gtest_filter="DriveSystemServiceTest.InitialFeedFetch" Review URL: https://codereview.chromium.org/11775014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175319 0039d316-1c4b-4281-b951-d872f2087c98
* Document the limitations on chrome.alarms timing.jyasskin@chromium.org2013-01-051-1/+16
| | | | | | Review URL: https://chromiumcodereview.appspot.com/11761031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175277 0039d316-1c4b-4281-b951-d872f2087c98
* Enable Pepper threading on all channels.shess@chromium.org2013-01-051-7/+1
| | | | | | | | | | | | | | Revision 170633 added --disable-pepper-threading and enabled threading for canary channel only. Enable on all channels, remove --enable-pepper-threading, but keep the --disable flag for now for debugging purposes. BUG=161286 Review URL: https://chromiumcodereview.appspot.com/11659032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175263 0039d316-1c4b-4281-b951-d872f2087c98
* Make ~FormFieldData() not virtual.viettrungluu@chromium.org2013-01-051-2/+2
| | | | | | | | | No one ever subclasses FormFieldData, and it has no (other) virtual methods. Review URL: https://chromiumcodereview.appspot.com/11737034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175253 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a mysterious manual deletion of the (sync message) reply deserializer.viettrungluu@chromium.org2013-01-051-1/+0
| | | | | | | | | | | The message is deleted on the following line. (And GetReplyDeserializer() does nothing other than release and return a scoped_ptr member. And yes, Messages have virtual destructors.) Review URL: https://chromiumcodereview.appspot.com/11720005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175243 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Fix a bunch of lint errors in chrome.thestig@chromium.org2013-01-041-2/+1
| | | | | | Review URL: https://chromiumcodereview.appspot.com/11745025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175221 0039d316-1c4b-4281-b951-d872f2087c98
* Move the InputComponents out of extensions entirely.ncj674@motorola.com2013-01-044-174/+259
| | | | | | | | | | BUG=159265 TEST=ExtensionApiTest.InputImeApiBasic TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/11611004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175192 0039d316-1c4b-4281-b951-d872f2087c98
* Use an explicit PID for duplicating Pepper handles rather than the Channel's.brettw@chromium.org2013-01-041-1/+2
| | | | | | | | | | | | When the browser process launches the plugin, it explicitly tells each side the PID of the other side, and we now use this PID for sharing handles. Previously we'd use the PID from the IPC channel. Using the PID from the IPC channel creates a race condition because the PID isn't set until the "hello" message from the opposite side is processed, which isn't guaranteed at any particular time. BUG=168222 Review URL: https://codereview.chromium.org/11722017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175190 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 175155 - PreferenceApi tests failingrlarocque@chromium.org2013-01-041-1/+1
| | | | | | | | | | | | | | | | I suspect this is the cause of http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%282%29/builds/10666 > "platforms" in privacy.json should be "chromeos" not "cros". > > R=asargent@chromium.org > BUG=156311 > > Review URL: https://codereview.chromium.org/11744034 TBR=kalman@chromium.org Review URL: https://codereview.chromium.org/11776002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175168 0039d316-1c4b-4281-b951-d872f2087c98
* "platforms" in privacy.json should be "chromeos" not "cros".kalman@chromium.org2013-01-041-1/+1
| | | | | | | | | R=asargent@chromium.org BUG=156311 Review URL: https://codereview.chromium.org/11744034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175155 0039d316-1c4b-4281-b951-d872f2087c98
* Try 2 [Media Gallery] Move chrome/browser/media_transfer_protocol code to ↵kmadhusu@chromium.org2013-01-041-0/+1
| | | | | | | | | | | | | | src/device. BUG=156929 TEST=none Original CL: https://chromiumcodereview.appspot.com/11744014 Review URL: https://chromiumcodereview.appspot.com/11744030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175150 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 175073 because it fails to compile on Linux.alexeypa@google.com2013-01-041-1/+0
| | | | | | | | | | | | | | | | | http://build.chromium.org/p/chromium.linux/buildstatus?builder=Linux%20Builder%20x64&number=65699 > [Media Gallery] Move chrome/browser/media_transfer_protocol code to src/device. > > BUG=156929 > TEST=none > > > Review URL: https://chromiumcodereview.appspot.com/11744014 TBR=kmadhusu@chromium.org Review URL: https://codereview.chromium.org/11722025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175075 0039d316-1c4b-4281-b951-d872f2087c98
* [Media Gallery] Move chrome/browser/media_transfer_protocol code to src/device.kmadhusu@chromium.org2013-01-041-0/+1
| | | | | | | | | | BUG=156929 TEST=none Review URL: https://chromiumcodereview.appspot.com/11744014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175073 0039d316-1c4b-4281-b951-d872f2087c98
* Extension docs server: assume everything is "trunk" if the branch can't bekalman@chromium.org2013-01-041-2/+10
| | | | | | | | determined (e.g. omahaproxy down). Review URL: https://codereview.chromium.org/11744027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175068 0039d316-1c4b-4281-b951-d872f2087c98
* Fix times in chrome.downloads extension API to use ISO8601 instead of ↵benjhayden@chromium.org2013-01-041-19/+21
| | | | | | | | | | | | int32s, which are too small. Also implement DownloadItem.endTime, DownloadQuery.endTime/endedBefore/endedAfter, DownloadQuery.orderBy='endTime'. BUG=12133 Review URL: https://chromiumcodereview.appspot.com/11593010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175062 0039d316-1c4b-4281-b951-d872f2087c98
* Add ability to click an element to FormAutofillUtilahutter@chromium.org2013-01-032-0/+39
| | | | | | | | | BUG=167101 Review URL: https://chromiumcodereview.appspot.com/11649040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175050 0039d316-1c4b-4281-b951-d872f2087c98
* Implement chrome.downloads.drag()benjhayden@chromium.org2013-01-031-2/+2
| | | | | | | | | | PS1@r172879 BUG=12133 Review URL: https://chromiumcodereview.appspot.com/11566012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175043 0039d316-1c4b-4281-b951-d872f2087c98
* Add search_terms_replacement_key field to TemplateURL.beaudoin@chromium.org2013-01-032-0/+5
| | | | | | | | | | | This CL is the first step in removing the hardcoded "espv" parameter used by instant-extended to detect when to perform search term replacement in the omnibox. The search_terms_replacement_key has beed added to prepopulated_engines, TemplateURL, policy, web_database, prefs, and sync. BUG=161602 Review URL: https://chromiumcodereview.appspot.com/11552020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175014 0039d316-1c4b-4281-b951-d872f2087c98
* Use tree status page that doesn't require a chromium.org login.wittman@chromium.org2013-01-032-18/+12
| | | | | | | | | | | | | Fixes display of "?" badge when not logged in or in incognito mode. R=kalman@chromium.org BUG=168059 Review URL: https://chromiumcodereview.appspot.com/11762002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175013 0039d316-1c4b-4281-b951-d872f2087c98
* Pass load events from prerenders to launching elements.gavinp@chromium.org2013-01-031-0/+4
| | | | | | | | | | | | The event is already on the webkit side, this patch plumbs it through. Note that this patch is downstream from https://codereview.chromium.org/11551003/ and so it can't land until after that one. R=mmenke@chromium.org,jschuh@chromium.org BUG=None Review URL: https://chromiumcodereview.appspot.com/11571037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175011 0039d316-1c4b-4281-b951-d872f2087c98
* Replace all uses of base/mac/crash_logging.h with base/debug/crash_logging.h.rsesek@chromium.org2013-01-033-10/+74
| | | | | | | | | | This also centralizes most crash keys into a constants file. BUG=77656 Review URL: https://codereview.chromium.org/11734011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174985 0039d316-1c4b-4281-b951-d872f2087c98
* Make server2 support complex features introduced in 173345.kalman@chromium.org2013-01-032-10/+28
| | | | | | | | | R=yoz@chromium.org BUG=168185 Review URL: https://codereview.chromium.org/11743021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174983 0039d316-1c4b-4281-b951-d872f2087c98
* Create a fresh sync datatype for Synced Notificationspetewil@chromium.org2013-01-032-0/+2
| | | | | | | | | BUG=164313 Review URL: https://chromiumcodereview.appspot.com/11441005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174927 0039d316-1c4b-4281-b951-d872f2087c98
* Create a cross-platform crash key system in base/debug/crash_logging.h.rsesek@chromium.org2013-01-033-120/+104
| | | | | | | | | | | | | | This is a direct port of the Mac-specific one, and that has been reimplemented on top of the new cross-platform one. Currently only the Mac implementation is hooked up. BUG=77656 TEST=Built official and caused some crashes, verified report data in upload. Review URL: https://chromiumcodereview.appspot.com/11635030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174911 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor first_run, very few things should depend on whether the First Run ↵gab@chromium.org2013-01-024-12/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | sentinel itself was present... (i.e. most tasks should not be on if flags such as --no-first-run are present). This is a prerequisite for issue 165048 as we want to be able to launch Chrome with --no-first-run and have two guarantees: 1) No first run tasks happen 2) First Run sentinel is set so that first run never happens for this new Chrome. This also removes PreInteractiveFirstRunInit() and PostInteractiveFirstRunInit() from BrowserMainParts as I just realized AutoImport is now silent and it is thus no longer necessary to split this in two :)! Moved everything to first_run::PostImportTasks(). This CL also buffs --first-run to --force-first-run (to be more explicit); --first-run now overrides --no-first-run as far as first run tasks are concerned (i.e. as far as everything first run related is concerned; except code that specifically looks for --no-first-run on the command line) -- kNoFirstRun used to state it would override kFirstRun, but that wasn't true anyways ans it makes more sense/is more useful the other way around. Now a browser test may specify --force-first-run and get the full first run experience even if the underlying test harness specifies --no-first-run for all tests :). --no-first-run is otherwise unaffected (i.e. same behavior as before) if --force-first-run is not present BUG=165048 TEST= 1) Run chrome.exe --force-first-run from build output and see First Run flow although First Run beacon is present. 2) Delete "First Run" beacon and ensure that chrome.exe --no-first-run both skips the first run and creates the beacon. 3) Ensure that chrome.exe --force-first-run --no-first-run acts the same as chrome.exe --force-first-run. Review URL: https://chromiumcodereview.appspot.com/11636031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174809 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused Flash-related code:yzshen@chromium.org2012-12-288-87/+8
| | | | | | | | | | | | | - field trial code for Pepper Flash. - registration and component-update code for NPAPI Flash. TEST=None BUG=None Review URL: https://chromiumcodereview.appspot.com/11615034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174741 0039d316-1c4b-4281-b951-d872f2087c98
* Resolve TODO: pass back replaceId in notification events.miket@chromium.org2012-12-271-8/+5
| | | | | | | | | BUG=164249 Review URL: https://chromiumcodereview.appspot.com/11668027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174696 0039d316-1c4b-4281-b951-d872f2087c98
* [cros] Clear RLZ data when switching RLZ enabled/disabled state.ivankr@chromium.org2012-12-242-0/+3
| | | | | | | | | | BUG=167425 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174575 Review URL: https://chromiumcodereview.appspot.com/11649038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174588 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 174575bryeung@chromium.org2012-12-242-3/+0
| | | | | | | | | | | | | | > [cros] Clear RLZ data when switching RLZ enabled/disabled state. > > > BUG=167425 > > Review URL: https://chromiumcodereview.appspot.com/11649038 TBR=ivankr@chromium.org Review URL: https://codereview.chromium.org/11665024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174582 0039d316-1c4b-4281-b951-d872f2087c98
* [cros] Clear RLZ data when switching RLZ enabled/disabled state.ivankr@chromium.org2012-12-242-0/+3
| | | | | | | | BUG=167425 Review URL: https://chromiumcodereview.appspot.com/11649038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174575 0039d316-1c4b-4281-b951-d872f2087c98
* extensions: Remove duplicated HelloLicenseServlet.java.tfarina@chromium.org2012-12-2414-316/+0
| | | | | | | | | | | | This fixed checkdeps.py warning. TEST=run tools/checkdeps/checkdeps.py, it should say SUCCESS without WARNING. R=kalman@chromium.org Review URL: https://chromiumcodereview.appspot.com/11663017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174570 0039d316-1c4b-4281-b951-d872f2087c98
* Implement declarativeWebRequest.SendMessageToExtension actionbattre@chromium.org2012-12-222-0/+42
| | | | | | | | | BUG=112155, 135613 Review URL: https://chromiumcodereview.appspot.com/11265031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174537 0039d316-1c4b-4281-b951-d872f2087c98
* Renames getFaviconURL to getFaviconUrl.dbeam@chromium.org2012-12-221-1/+1
| | | | | | | | | | | | | R=pedrosimonetti@chromium.org TBR=mkwst@chromium.org BUG=None TEST=no regressions NOTRY=true Review URL: https://chromiumcodereview.appspot.com/11645059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174492 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: No more FLAKY_ .phajdan.jr@chromium.org2012-12-211-1/+1
| | | | | | | | | | | | | | | | | | | | | | | Please note that FLAKY_ tests have been ignored anyway. When tests started crashing, people just flipped that to DISABLED_ . Why not go straight to DISABLED_ then, so that we avoid wasting time on stupid test prefix games? With DISABLED_ it is clear to everyone that there is no coverage from given test. FLAKY_ creates an illusion of coverage, while in fact the test is still ignored. If a FLAKY_ test fails and nobody notices, does it still make a sound? ;-) Finally, note that gtest has a --gtest_also_run_disabled_tests if you need to run tests manually. TBR=jam BUG=none Review URL: https://codereview.chromium.org/11664013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174472 0039d316-1c4b-4281-b951-d872f2087c98
* Send information about all nodes which are touched by the user on the page ↵ananta@chromium.org2012-12-212-6/+8
| | | | | | | | | | | | | | | | | | from the renderer. The ChromeViewHostMsg_FocusedEditableNodeTouched IPC has been renamed to ChromeViewHostMsg_FocusedNodeTouched with a bool parameter indicating if the node is editable. The NOTIFICATION_FOCUSED_EDITABLE_NODE_TOUCHED notification on the browser side has been renamed to NOTIFICATION_FOCUSED_NODE_TOUCHED with a bool indicating if the node is editable. This is done to be able to dismiss the On screen keyboard on Windows 8 if the user touches outside the editable field on the page. BUG=166516 R=jam Review URL: https://codereview.chromium.org/11636055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174426 0039d316-1c4b-4281-b951-d872f2087c98
* Added new articles: API Reference for GCM Service and Google Cloud Messaging ↵mkearney@google.com2012-12-219-498/+707
| | | | | | | | | | | | for Chrome. Abbreviated API reference for pushMessaging (added new table). Fixed a few small bugs in docs. Review URL: https://codereview.chromium.org/11567021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174425 0039d316-1c4b-4281-b951-d872f2087c98
* Actually disable the script bubble by default.yoz@chromium.org2012-12-211-1/+1
| | | | | | | | BUG=153137 Review URL: https://codereview.chromium.org/11624026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174418 0039d316-1c4b-4281-b951-d872f2087c98
* Buildbox extension -> version 0.7.8.kalman@chromium.org2012-12-211-1/+1
| | | | | | | | TBR=cduvall@chromium.org Review URL: https://codereview.chromium.org/11665009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174411 0039d316-1c4b-4281-b951-d872f2087c98
* [Fixit Dec-2012] Fix suppress_first_run_bubble master preference.gab@chromium.org2012-12-212-3/+3
| | | | | | | | | | | | | | | | | The preference was correctly calling SetShowFirstRunBubblePref(false) (although that was the default anyways); which was later set to true anyways... It was impossible to test whether the local state preference had been set to false or was just still at its default value. I made the local state pref an enum FIRST_RUN_BUBBLE_DONT_SHOW (default), FIRST_RUN_BUBBLE_SUPPRESS (prevents FIRST_RUN_BUBBLE_SHOW from being set), and FIRST_RUN_BUBBLE_SHOW which allows us to do the intended logic correctly. BUG=166872 TEST="suppress_first_run_bubble":true in distribution{} section removes the first run bubble First run bubble still shows when it's not specified (provided there is no first run promo). First run bubble doesn't show in subsequent runs (i.e. only on first run). Review URL: https://chromiumcodereview.appspot.com/11639022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174397 0039d316-1c4b-4281-b951-d872f2087c98
* [Spellcheck, Security] Filter against invalid locales.groby@chromium.org2012-12-211-17/+24
| | | | | | | | | | | Prevents passing up of garbage strings from renderer (and thus, prevents opening of arbitrary files) BUG=167122 Review URL: https://chromiumcodereview.appspot.com/11618046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174304 0039d316-1c4b-4281-b951-d872f2087c98
* Do not load extension system in the Profile import process.tapted@chromium.org2012-12-212-0/+4
| | | | | | | | | | | | | | | Also, defer loading component extensions with background pages until the import process is complete, so that the renderer host does not compete for the database lock. This also adds a regression test for http://crbug.com/163925. BUG=163925,107636 TEST=Test first-run flows and profile import after uninstalling chrome and removing AppData/Local/Google/Chrome directory Review URL: https://chromiumcodereview.appspot.com/11572036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174302 0039d316-1c4b-4281-b951-d872f2087c98
* Added introductory tables to Chrome apps APIs.mkearney@google.com2012-12-2121-129/+456
| | | | | | | | | | | | These tables include a description, when the API is available, the permissions, and links to learn more (both docs and GDL sessions). BUG=163374 BUG=163413 Review URL: https://codereview.chromium.org/11635032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174282 0039d316-1c4b-4281-b951-d872f2087c98
* Reland revision 174161 (reverted in 174163 because it broke the build).dzhioev@chromium.org2012-12-202-0/+10
| | | | | | | | | | | | Implemented tray notifications for enterprise enrolled devices. BUG=chromium-os:35755 TBR=nkostylev,sadrul,ben Review URL: https://chromiumcodereview.appspot.com/11637042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174248 0039d316-1c4b-4281-b951-d872f2087c98
* Move the fileBrowserPrivate API out of extensions entirely.yoz@chromium.org2012-12-205-619/+0
| | | | | | | | | BUG=159265 TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/11572058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174247 0039d316-1c4b-4281-b951-d872f2087c98
* Implement the formerly stubbed-out event-style NotificationDelegate methods ↵miket@chromium.org2012-12-201-0/+11
| | | | | | | | | | | | by mapping them to newly defined notification.* events. A big TODO I identified during this work was that ApiResourceEventNotifier can probably be removed. I'll do that next. BUG=164249 Review URL: https://chromiumcodereview.appspot.com/11618030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174229 0039d316-1c4b-4281-b951-d872f2087c98
* Convert all uses of InfoBarTabHelper -> InfoBarService. Make InfoBarTabHelperpkasting@chromium.org2012-12-201-15/+14
| | | | | | | | | | an implementation detail by declaring all its functions private. BUG=none TEST=none Review URL: https://codereview.chromium.org/11442041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174196 0039d316-1c4b-4281-b951-d872f2087c98
* Make avatar menu "New user" option open the create user Web UI.asvitkine@chromium.org2012-12-202-0/+2
| | | | | | | | | | BUG=134904 TEST=From avatar menu, choose "New Profile". The create profile Web UI should be shown and should work as expected. Review URL: https://chromiumcodereview.appspot.com/11348322 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174177 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 174161erikwright@chromium.org2012-12-202-10/+0
| | | | | | | | | | | | | | | | | | | | | | | | | > Implemented tray notifications for enterprise enrolled devices. > > > BUG=chromium-os:35755 > TBR=ben > > Review URL: https://chromiumcodereview.appspot.com/11594009 http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASAN%20Builder/builds/2567/steps/compile/logs/stdio In file included from ../../ash/system/tray/system_tray_delegate.cc:7: ../../ash/system/tray/test_system_tray_delegate.h:33:17: error: [chromium-style] Overriding method must be marked with OVERRIDE. virtual const string16 GetEnterpriseMessage() const; In file included from ../../ash/system/tray/test_system_tray_delegate.cc:5: ../../ash/system/tray/test_system_tray_delegate.h:33:17: error: [chromium-style] Overriding method must be marked with OVERRIDE. virtual const string16 GetEnterpriseMessage() const; TBR=dzhioev@chromium.org Review URL: https://codereview.chromium.org/11639044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174163 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-18 17:17:52 +0000