| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
Aura doesn't do plug-ins, and Mac and Gtk already use in-renderer placeholders.
TBR=jam@chromium.org
BUG=62079
TEST=none
Review URL: http://codereview.chromium.org/8689001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111590 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Aura doesn't do plug-ins, and Mac and Gtk already use in-renderer placeholders.
BUG=62079
TEST=none
Review URL: http://codereview.chromium.org/8679004
TBR=bauerb@chromium.org
Review URL: http://codereview.chromium.org/8676038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111521 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Aura doesn't do plug-ins, and Mac and Gtk already use in-renderer placeholders.
BUG=62079
TEST=none
Review URL: http://codereview.chromium.org/8679004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111519 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=none
Review URL: http://codereview.chromium.org/8603007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Using the initializer list construct = {0} allows the object to be linker initialized.
Modify the LazyInstance class design to make it a pod aggregate type that can be linker initialized this way. Also combines the instance and state members, in line with the Singleton<> class design.
Introduces a new LAZY_INSTANCE_INITIALIZER macro specifically for using to init all lazy instances + modify all existing callsites to use it. (Old code would no longer compile)
BUG=94925
TEST=existing tests pass. http://build.chromium.org/f/chromium/perf/linux-release/sizes/report.html?history=150&header=chrome-si&graph=chrome-si&rev=-1 should step downward.
TBR=jam@chromium.org,rvargas@chromium.org,darin@chromium.org,ben@chromium.org,apatrick@chromium.org,akalin@chromium.org
Review URL: http://codereview.chromium.org/8491043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
subdirectories.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8491036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=103216
TEST=see bug
Review URL: http://codereview.chromium.org/8494008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=101821
TEST=see bug
Review URL: http://codereview.chromium.org/8473001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Update base::Thread documentation, fix all subclasses I could find
that had a problem, and remove no-longer-necessary suppressions.
BUG=102134
Review URL: http://codereview.chromium.org/8427007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108296 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
namespace. Also move content_costants to content/public/common.
BUG=98716
Review URL: http://codereview.chromium.org/8413051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=99362
TEST=None
Review URL: http://codereview.chromium.org/8226001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104805 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ChromePluginMessageFilter.
This functionality is currently being used the NPAPI plugin installer on Windows.
Fix is to use the request context from the BrowserContext object from the RenderProcessHost instance
corresponding to the plugin instance.
To retrieve the RenderProcessHost instance we pass the renderer process id from the plugin while
initiating the download.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=97743
BUG=97743
TEST=no change in functionality.
Review URL: http://codereview.chromium.org/8016009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/93947
TEST=none
R=sadrul
TBR=jabdelmalek for the content/webkit stubs
Review URL: http://codereview.chromium.org/7841012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99993 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is not a third party file.
On my machine, this speeds up a full recompile of the 'chrome' target
in Debug mode by about 18%.
BUG=none
TEST=it builds, existing tests pass
Review URL: http://codereview.chromium.org/7706011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/93947
TEST=none
Review URL: http://codereview.chromium.org/7839002
Review URL: http://codereview.chromium.org/7839002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99830 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
with USE_AURA.
http://crbug.com/93947
TEST=none
Review URL: http://codereview.chromium.org/7839002
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/7840010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99813 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/93947
TEST=none
Review URL: http://codereview.chromium.org/7839002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99810 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
out of content
into Chrome.
1. PluginProcessHostMsg_GetPluginFinderUrl
2. PluginProcessHostMsg_MissingPluginStatus
3. PluginProcessHostMsg_DownloadUrl
These messages are prefixed with Chrome. Removed the InstallMissingPlugin and OnInstallMissingPlugin
handlers from the NPAPI plugin sources and from our webkit plugin implementation. The plugin infobar
no longer sends over an IPC message to initiate installation of the third party plugin. It sends over
a windows message which is handled in the plugin installer for Windows. This functionality is not
implemented for the mac and linux as before.
To display the plugin installation infobar the PluginProcessHostMsg_MissingPluginStatus message
sent by the plugin needs the routing id and the renderer process id. This information is now
passed along with the plugin instantiation parameters in NPP_New. These parameters are only read
by the default plugin.
This is a continuation of the fixes to ensure that IPC's don't span across content and chrome.
BUG=87335
Review URL: http://codereview.chromium.org/7812020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the current context was ever nil, sending a "restore" message would be a no-op and would likely leave an out-of-scope context as current.
BUG=90140
TEST=repeatedly select items in an open file dialog in column mode; no crash
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95611
Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=95631
Review URL: http://codereview.chromium.org/7572031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95686 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the current context was ever nil, sending a "restore" message would be a no-op and would likely leave an out-of-scope context as current.
BUG=90140
TEST=repeatedly select items in an open file dialog in column mode; no crash
Review URL: http://codereview.chromium.org/7572031
TBR=avi@chromium.org
Review URL: http://codereview.chromium.org/7541043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
If the current context was ever nil, sending a "restore" message would be a no-op and would likely leave an out-of-scope context as current.
BUG=90140
TEST=repeatedly select items in an open file dialog in column mode; no crash
Review URL: http://codereview.chromium.org/7572031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These were added in r28089 (http://codereview.chromium.org/256059) but
are unnecessary bloat for everyone to carry around, even those that don't
use emacs or vim.
In an earlier change, I added editor config files in src/tools/emacs/
and src/tools/vim/ so users of the appropriate editor can source those
instead.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7310019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=72317
TEST=None
R=rsesek@chromium.org
Review URL: http://codereview.chromium.org/7218065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=28727
Review URL: http://codereview.chromium.org/7191022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90243 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=ui_unittests
Review URL: http://codereview.chromium.org/6995155
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome\renderer\chrome_renderer_glue.cc
to content\renderer. This helps reduce some of the implicit dependencies of content on chrome and will help in building
it as a dll.
There is just one function GetProductVersion remaining in chrome_renderer_glue. This function is used to build
the user agent string in the embedder. This functionality will be moved to the ContentRendererClient object in a
subsequent CL.
Moved the PPAPI PDF plugin implementation to chrome renderer. This interface is returned by the PPAPI factory
which is registered by the renderer during startup.
BUG=82454
Review URL: http://codereview.chromium.org/6995119
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88742 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
than ResourceDispatcherHost was the plugin installer. It doesn't really matter which process the request for downloading a plugin (which is very infrequent) shows up for, and arguably, it's better to show up under the browser process.
BUG=76697
Review URL: http://codereview.chromium.org/7054023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86324 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We provided <(library) as a variable to support a peculiar
build configuration on Linux. We no longer support that build
configuration, so we can simplify this code to no longer use
a variable.
Review URL: http://codereview.chromium.org/7051014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86004 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
and use_x11 for the gyp files. For lists of source files that use a mix of POSIX and Gtk APIs, toolkit_uses_gtk was given precedence. I also added Solaris to the remaining grit files.
Patch by ruben (chromium@hybridsource.org).
Review URL: http://codereview.chromium.org/7011032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
src\content as a dll. This CL
removes the IsDefaultPluginEnabled function in the webkit_glue namespace. This function has been replaced
by a flag in the PluginList instance which is set when the default plugin is registered as an internal plugin.
The webkit_glue.cc file now implements the GetApplicationDirectory and GetExeDirectory functions in the webkit_glue
namespace. Previously these functions were implemented in common_glue.cc and in test_shell.
Removed the IsPluginRunningInRendererProcess function from webkit_glue and fixed the callers to not depend on this
functionality.
BUG=82454
Review URL: http://codereview.chromium.org/6975028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
of chrome specific messages to a chrome IPC filter.
Review URL: http://codereview.chromium.org/7036025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
functionality provided by plugin_thread.cc
to the default_plugin which is the only caller. Removed the unused AppendToLog function from the webkit_glue
namespace.
BUG=82326
Review URL: http://codereview.chromium.org/7012004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
use base.dll from chrome.
BUG=76996
TEST=none
Review URL: http://codereview.chromium.org/6877053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add two gypi files to src/build for the boilerplate added to targets and actions
- Update grit_info to also support the -E flag so it can share more of the grit build commandline
- switch over all but the webkit and webkit glue grd files to use the common support
BUG=22247
TEST=everything still localized correctly
Review URL: http://codereview.chromium.org/6705030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79548 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
raw_scoped_refptr_mismatch_checker.h
ref_counted.cc
ref_counted.h
ref_counted_memory.cc
ref_counted_memory.h
ref_counted_unittest.cc
scoped_callback_factory.h
scoped_comptr_win.h
scoped_handle.h
scoped_native_library.cc
scoped_native_library.h
scoped_native_library_unittest.cc
scoped_nsobject.h
scoped_open_process.h
scoped_ptr.h
scoped_ptr_unittest.cc
scoped_temp_dir.cc
scoped_temp_dir.h
scoped_temp_dir_unittest.cc
scoped_vector.h
singleton.h
singleton_objc.h
singleton_unittest.cc
linked_ptr.h
linked_ptr_unittest.cc
weak_ptr.cc
weak_ptr.h
weak_ptr_unittest.cc
BUG=None
TEST=Compile
Review URL: http://codereview.chromium.org/6714032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6676120
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79353 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are a couple of cases where we either redirect to a generic Java info page (http://java.com/) or
to a locale-specific page.
http://java.com/download does OS and locale detection automatically, so we should redirect users there.
The page does not handle linux specially, so I left the URL alone for Linux in plugin_list.cc.
BUG= http://bugs.chromium.org/76634
TEST= On a Windows machine without Java installed or with an out of date version of Java, going to a site that uses the Java plugin
should show the missing plugin link and link to http://java.com/download... never http://java.com/
R=jam@chromium.org, darin@chromium.org, ananta@chromium.org, panayiotis@google.com
Review URL: http://codereview.chromium.org/6709057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79013 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Gives 'out of the box' compatability with VC2008 express - i.e. no modifications needed to system headers or .gyp* files or related hacks. Just set the GYP_MSVS_VERSION to 200Xe (e for express, same as the linked blog on the issue and first google hit as well).
1) Changes to build\common.gypi to turn off to define COMPILER_MSVC_EXPRESS if a express is detected (through the GYP_MSVC_VERSION environment variable), turn off the _SECURE_ATL define (which is flagged as an error with WinDDK's ATL, _SECURE_ATL adds [more] CRT checks to other ATL versions) and hard to link to the atl stdthunk library with express editions. Also, explicitly link to the base WinSDK libraries in common.gypi and mini_installer.gypi for MSVC 2005 express.
2) Fixes a few .cc files that have the wrong include order with the ATL headers when using the Windows DDK ATL. The Windows DDK ATL brings in intsafe.h (WinSDK, not WinDDK) with atlwin.h and generates multiple INTXX_MIN/MAX def warnings which get
flagged as errors with the warnings as errors flag if not included before other libraries that have the same definitions like ICU.
3) Changes to .rc files to avoid pulling in afxres.h (an MFC header -
it's available in the WinDDK) and winres.h which VCExpress doesn't have (it's available in a WinSDK sample, but that kind of the purpose of it). The main Chromium .rc files are already structured this way, I just changed the rest and changed the output of grit to do the same.
4) Removes the memset obj file linking in mini_installer.gyp and simply implements memset for mini_installer.cc.
Only changes to the chromium branch now. There are some .rc files in the Python26, Native Client, and Angle in samples that could #3 changes. They are not required for Chromium, however.
------
VC2005SP1 can be downloaded at
http://www.microsoft.com/downloads/en/details.aspx?FamilyId=7B0B0339-613A-46E6-AB4D-080D4D4A8C4E&displaylang=en
(or non-SP1 at http://download.microsoft.com/download/8/3/a/83aad8f9-38ba-4503-b3cd-ba28c360c27b/ENU/vcsetup.exe)
VC2008SP1 can be downloaded at
http://www.microsoft.com/downloads/en/details.aspx?FamilyId=F3FBB04E-92C2-4701-B4BA-92E26E408569&displaylang=en
currently.
The base developer instructions work fine afterwards with a couple tweaks for express versions:
http://www.chromium.org/developers/how-tos/build-instructions-windows
Under "Additional (free) downloads" under step 2:
X) Only the first 3 Non-SP KB Patches are needed for express. Don't forget to forget GYP_MSVS_VERSION environment as appropriate - 2008e for Visual C++ 2008 Express, for example.
Under "Additional (free) downloads" after step 5
[These only apply to 2008 express, 2005 works fine out of the box]:
6A) Download the WinDDK for the atl headers and libs -
http://msdn.microsoft.com/en-us/windows/hardware/gg487463.aspx. It works fine, but you do not need to install the whole DDK. In the WDK directory just install headers.msi, libs_x86fre.msi, and libs_x64fre.msi; just grab the atl headers and atl*.lib libs; right click the installers and uninstall afterwards. Add the appropriate include and lib paths to your global settings.
6B) To build x64 targets (x64 Native Client) download:
http://www.cppblog.com/Files/xcpp/VCE64BIT_WIN7SDK.zip
Follow the readme instructions.
Further information behind that and x64 target building with express:
- http://jenshuebel.wordpress.com/2009/02/12/visual-c-2008-express-edition-and-64-bit-targets/
- http://www.cppblog.com/xcpp/archive/2009/09/09/vc2008express_64bit_win7sdk.html
----------------
BUG=1433, 5026, 72885
TEST=Compiles in both Debug and Release mode in Visual C++ Express 2008/2005 and does not effect other build setups. In addition, the WinDDK ATL compiles with the secure_atl=0 in the GYP_DEFINES environment variable on non-express versions of MSVC.
Review URL: http://codereview.chromium.org/6676030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=76112
Review URL: http://codereview.chromium.org/6695008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
a webkit_glue function that can update the peer. No point sending the boolean flag from the browser since the same check is done in the renderer.
Review URL: http://codereview.chromium.org/6628006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76957 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=49597
TEST=Set the policy to true and the default plugin should not offer to install missing plugins.
Review URL: http://codereview.chromium.org/6475011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76043 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This changes the definition of GetNativeImageNamed to return a gfx::Image and
adds GetImageNamed in addition. GetBitmapNamed now goes through that method. On
Linux, GetNativeImageNamed will load directly into a GdkPixbuf-backed Image. Mac
will still first load through Skia (a future CL will load directly into an
NSImage). All other platforms use Skia natively, so GetNativeImageNamed is the
same as GetImageNamed.
Mac was the only platform that used the old GetNativeImageNamed, so this also
transitions a bunch of Mac files by including ui/gfx/image.h.
This also obviates the need for platform-specific image caches in the
ResourceBundle, so there's some additional cleanup around that.
BUG=carnitas
TEST=All UI images in Chromium show up as before.
Review URL: http://codereview.chromium.org/6541031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75605 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=73100
TEST=trybots
Review URL: http://codereview.chromium.org/6538008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=71063
TEST=compiled
Review URL: http://codereview.chromium.org/6312156
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=brettw
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/6263008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/6254011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/5991010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We weren't passing in the grit defines to grit_info.py, so we
weren't getting the dependencies behind <if> blocks included
in the Makefile.
BUG=68028
Review URL: http://codereview.chromium.org/6109003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70822 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
have to repeat the logic for it in a bunch of different places.
I had to add another level of variables{} so I could use use_titlecase_in_grd_files in a condition. I also removed some quotes around default values since that seems to be the more common way to express boolean values.
BUG=68028
Review URL: http://codereview.chromium.org/6070011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70757 0039d316-1c4b-4281-b951-d872f2087c98
|