summaryrefslogtreecommitdiffstats
path: root/chrome/installer/setup
Commit message (Collapse)AuthorAgeFilesLines
* Merge 32597 - Go back to a single toast flavor.laforge@chromium.org2009-11-201-5/+2
| | | | | | | | | | | | | | | | We have picked a winner, code can go back to being simple. result codes are now TFxx TEST=launch setup with inactiveusertoast BUG=none Review URL: http://codereview.chromium.org/416002 TBR=cpu@chromium.org Review URL: http://codereview.chromium.org/418014 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@32635 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes almost all of the rest of lint errors in the chrome/ directory (minus ↵erg@google.com2009-11-131-1/+1
| | | | | | | | the really hard ones which will need actual review instead of rubber-stamping.) Review URL: http://codereview.chromium.org/386026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31932 0039d316-1c4b-4281-b951-d872f2087c98
* Correctly schedule empty parent directories for deletion when Chrome Frame ↵robertshield@chromium.org2009-11-121-4/+32
| | | | | | | | | | | is uninstalled while in use. BUG=27483,23999 TEST=Uninstall Chrome Frame while it is in use. Verify that all Chrome Frame folders are removed. Review URL: http://codereview.chromium.org/392013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31853 0039d316-1c4b-4281-b951-d872f2087c98
* A large number of style nits in preparation for turning on automated cpplint.py.erg@google.com2009-11-111-1/+1
| | | | | | Review URL: http://codereview.chromium.org/385023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31669 0039d316-1c4b-4281-b951-d872f2087c98
* Correct update-while-in-use installer regression. The rename command being ↵robertshield@chromium.org2009-11-101-0/+6
| | | | | | | | | | | | | stored in the registry eroneously did not have --chrome-frame appended to it, so the chrome.exe <-> new_chrome.exe was broken. Note that since Chrome Frame uses system installs, Omaha must be present on the system for upgrades to work. "Manual" upgrades while Chrome Frame is running do not work. TEST=Upgrade installs while an old Chrome Frame is running should now correctly replace versions. BUG=27181 Review URL: http://codereview.chromium.org/389002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31560 0039d316-1c4b-4281-b951-d872f2087c98
* Continue to remove CHROME_FRAME_BUILD define from code that goes into ↵robertshield@chromium.org2009-11-043-70/+78
| | | | | | | | | | | | | | | | | | | | | chrome.dll. This reworks the browser distribution code to use the ChromeFrameBrowserDistribution iff --chrome-frame is present on the command line. Also, * At startup, chrome.exe now uses the BrowserDistribution code to determine where the Chromium version key resides (instead of hard coding it). * The installer now propagates the presence of --verbose-logging to uninstalls. * The chrome_launcher now allows the --chrome-frame switch through to chrome. * The installer now accepts a --chrome-frame switch. * Remove almost all occurences of the CHROME_FRAME_BUILD define from the installer. BUG=26012, 26603 TEST=Chrome Frame still builds and runs correctly. Chrome Frame builds built without 'branding'='Chrome' now install correctly. Review URL: http://codereview.chromium.org/345021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31015 0039d316-1c4b-4281-b951-d872f2087c98
* Add a confirmation dialog confirming the completion of uninstallation for ↵robertshield@chromium.org2009-11-031-4/+14
| | | | | | | | | | | Chrome Frame. BUG=http://crbug.com/23995 TEST=Uninstall Chrome Frame in such a way that a reboot is not required. Verify that a confirmation dialog appears. Review URL: http://codereview.chromium.org/355002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30780 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the Chrome Frame preprocessor define in chrome_constants.cc and deal ↵robertshield@chromium.org2009-10-281-5/+15
| | | | | | | | | | | | with resulting fallout. Also, remove several instances of Chrome Frame using wstrings instead of FilePaths. The main goal of this patch is to move towards ensuring that Chrome Frame and Google Chrome share binary-identical exes and dlls except for setup.exe and mini_installer.exe. Review URL: http://codereview.chromium.org/338025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30290 0039d316-1c4b-4281-b951-d872f2087c98
* Remove deprecated CommandLine(std::wstring) ctor.evan@chromium.org2009-10-261-2/+1
| | | | | | | | | | | Add a ctor for creating a CommandLine for carrying arguments; convert all the users to either that or the FilePath version. BUG=24672 Review URL: http://codereview.chromium.org/329017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30117 0039d316-1c4b-4281-b951-d872f2087c98
* Make GetDistroBooleanPreference return troolean value.kuchhal@chromium.org2009-10-193-32/+60
| | | | | | | | | BUG=23649 TEST=installer_util_unittests, setup_unittests Review URL: http://codereview.chromium.org/269107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29423 0039d316-1c4b-4281-b951-d872f2087c98
* Add a compile time assert to ensure that Google Chrome Frame builds of the ↵robertshield@chromium.org2009-10-191-0/+5
| | | | | | | | | | | | | installer have successfully picked up the presence of the Chrome Frame Dll at build time. This is to avoid project dependency regressions along the lines of http://crbug.com/25074 which cause Chrome Frame to build fine, but not be registered at install time. BUG=http://crbug.com/25074 TEST=Compile of setup.exe must fail if CHROME_FRAME_BUILD is defined and the chrome frame dll is not present in the build directory. Review URL: http://codereview.chromium.org/292013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29416 0039d316-1c4b-4281-b951-d872f2087c98
* Re-try r29078: Remove some deprecated file_util wstring functions.estade@chromium.org2009-10-152-9/+11
| | | | | | | | | | | | | With the previous patch, the try bots failed with mysterious messages, so I ignored them, patched it into my windows box and tested it there manually, and found no problems. As it turns out, the try failures were real :(. But nsylvain and I found the problem: the behavior of file_util::GetDirectoryFromPath() differs from DirName() when the path is empty (officially, GetDirectoryFromPath is not supposed to support non-absolute paths, but that is not enforced). Here is a green win try result: http://build.chromium.org/buildbot/try-server/builders/win/builds/3705 mac: http://build.chromium.org/buildbot/try-server/builders/mac/builds/3491 linux: http://build.chromium.org/buildbot/try-server/builders/linux/builds/3466 I also applied this patch locally in Windows to test that it doesn't break the chrome frame compile or tests, since that's not covered by the trybots yet. Review URL: http://codereview.chromium.org/271099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29094 0039d316-1c4b-4281-b951-d872f2087c98
* Revert wstring patch (r29078 and follow up commits). It is causing failures ↵estade@chromium.org2009-10-152-11/+9
| | | | | | | | | | on the buildbots. TBR=nsylvain Review URL: http://codereview.chromium.org/280004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29085 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some deprecated file_util wstring functions.estade@chromium.org2009-10-152-9/+11
| | | | | | | | | | | death to the wstring TEST=trybots BUG=none Review URL: http://codereview.chromium.org/276016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29078 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some mroe includes.brettw@chromium.org2009-10-091-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28581 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 27880 which was itself a revert of 27876.Original codereview at ↵robertshield@chromium.org2009-10-043-16/+104
| | | | | | | | http://codereview.chromium.org/235060/show.There was a small problem with a unittest EXPECT_TRUE condition being dependent on system state, which is now fixed. No other changes have been made from the original CL and now the trybots are up again, this looks to pass.TBR=tommi Review URL: http://codereview.chromium.org/251079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27970 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 27876.robertshield@chromium.org2009-10-023-104/+16
| | | | | | Review URL: http://codereview.chromium.org/256043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27880 0039d316-1c4b-4281-b951-d872f2087c98
* Improving Chrome Frame uninstall process:robertshield@chromium.org2009-10-023-16/+104
| | | | | | | | | | | | | 1) Don't kill chrome.exe when uninstalling. This leads to immediate breakage of any running Chrome Frame windows and is also annoying if the user also happens to be using Google Chrome or some variant thereof. 2) If files are in use at uninstall time, schedule them for deletion and prompt the user to reboot. 3) Remember to remove any pending scheduled deletes at install time. Review URL: http://codereview.chromium.org/235060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27876 0039d316-1c4b-4281-b951-d872f2087c98
* Cleaning up after the initial Chrome Frame commit.robertshield@chromium.org2009-09-281-2/+2
| | | | | | Review URL: http://codereview.chromium.org/242025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27367 0039d316-1c4b-4281-b951-d872f2087c98
* Change the manifest so VS2008 does not get confusedcpu@chromium.org2009-09-241-2/+1
| | | | | | | | | | | | | - setup.exe or mini_installer.exe don't run if compiled in VS2008 - VS2008 is repeating the 'as_invoker' element. BUG=none TEST=compile setup.exe or ministaller with vs2008, now you can run them. Review URL: http://codereview.chromium.org/220023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27034 0039d316-1c4b-4281-b951-d872f2087c98
* <html>aa@chromium.org2009-09-213-14/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | <style type="text/css"> <!-- body { font-family: arial,sans-serif; background-color: #fff; margin-top: 2; } .c { width: 4; height: 4; } a:link { color: #00c; } a:visited { color: #551a8b; } a:active { color: #f00; } .form-noindent { background-color: #fff; border: 1px solid #c3d9ff; } --> </style> <style type="text/css"><!-- .gaia.le.lbl { font-family: Arial, Helvetica, sans-serif; font-size: smaller; } .gaia.le.fpwd { font-family: Arial, Helvetica, sans-serif; font-size: 70%; } .gaia.le.chusr { font-family: Arial, Helvetica, sans-serif; font-size: 70%; } .gaia.le.val { font-family: Arial, Helvetica, sans-serif; font-size: smaller; } .gaia.le.button { font-family: Arial, Helvetica, sans-serif; font-size: smaller; } .gaia.le.rem { font-family: Arial, Helvetica, sans-serif; font-size: smaller; } .gaia.captchahtml.desc { font-family: arial, sans-serif; font-size: smaller; } .gaia.captchahtml.cmt { font-family: arial, sans-serif; font-size: smaller; font-style: italic; } --></style> <head> <title>Google Accounts</title> <style type="text/css"><!-- body { font-family: arial, sans-serif; margin: 0; padding: 13px 15px 15px; } .body { margin: 0; } div.errorbox-good {} div.errorbox-bad {} div.errormsg { color: red; font-size: smaller; font-family: arial,sans-serif;} font.errormsg { color: red; font-size: smaller; font-family: arial,sans-serif;} div.topbar { font-size:smaller; margin-right: -5px; text-align:right; white-space:nowrap; } div.header { margin-bottom: 9px; margin-left: -2px; position:relative; zoom: 1 } div.header img.logo { border: 0; float:left; } div.header div.headercontent { float:right; margin-top:17px; } div.header:after{ content:"."; display:block; height:0; clear:both; visibility:hidden; } div.pagetitle { font-weight:bold; } .footer { color: #666; font-size: smaller; margin-top: 40px; text-align: center; } table#signupform { left: -5px; top: -7px; position:relative; } table#signupform td{ padding: 7px 5px; } table#signupform td table td{ padding: 1px; } hr { border: 0; background-color:#DDDDDD; height: 1px; width: 100%; text-align: left; margin: 5px; } --></style> </head> <body dir="ltr" onLoad= "gaia_setFocus();" > <div id="main"> <?sc # for new logo transition ?> <div class=header> <a href='https://www.google.com/accounts/'> <img class=logo src='https://www.google.com/intl/en/images/logos/accounts_logo.gif' alt="Google" /> </img> </a> </div> <div id=maincontent> <table border="0" width="100%" cellpadding=0 cellspacing=0> <tr> <td width="75%" valign="top"> <h3> Chromium Code Reviews uses Google Accounts for Sign In. </h3> <p><font size=-1> Google is not affiliated with the contents of <b>Chromium Code Reviews</b> or its owners. If you sign in, Google will share your email address with <b>Chromium Code Reviews</b>, but not your password or any other personal information. </font></p> <p><font size=-1> <b>Chromium Code Reviews</b> may use your email address to personalize your experience on their website. </font></p> </td> <td style="padding-left: 10px;" valign="top" align="center"> <div id="rhs"> <div id="rhs_login_signup_box"> <script><!-- function gaia_onLoginSubmit() { if (window.gaiacb_onLoginSubmit) { return gaiacb_onLoginSubmit(); } else { return true; } } function gaia_setFocus() { var f = null; if (document.getElementById) { f = document.getElementById("gaia_loginform"); } else if (window.gaia_loginform) { f = window.gaia_loginform; } if (f) { if (f.Email && (f.Email.value == null || f.Email.value == "")) { f.Email.focus(); } else if (f.Passwd) { f.Passwd.focus(); } } } --></script> <style type="text/css"><!-- div.errormsg { color: red; font-size: smaller; font-family:arial,sans-serif; } font.errormsg { color: red; font-size: smaller; font-family:arial,sans-serif; } --></style> <style type="text/css"><!-- .gaia.le.lbl { font-family: Arial, Helvetica, sans-serif; font-size: smaller; } .gaia.le.fpwd { font-family: Arial, Helvetica, sans-serif; font-size: 70%; } .gaia.le.chusr { font-family: Arial, Helvetica, sans-serif; font-size: 70%; } .gaia.le.val { font-family: Arial, Helvetica, sans-serif; font-size: smaller; } .gaia.le.button { font-family: Arial, Helvetica, sans-serif; font-size: smaller; } .gaia.le.rem { font-family: Arial, Helvetica, sans-serif; font-size: smaller; } .gaia.captchahtml.desc { font-family: arial, sans-serif; font-size: smaller; } .gaia.captchahtml.cmt { font-family: arial, sans-serif; font-size: smaller; font-style: italic; } --></style> <form id="gaia_loginform" action="https://www.google.com/accounts/ServiceLoginAuth?service=ah&amp;sig=d71ef8b8d6150b23958ad03b3bf546b7" method="post" onsubmit= "return(gaia_onLoginSubmit());" > <div id="gaia_loginbox"> <table class="form-noindent" cellspacing="3" cellpadding="5" width="100%" border="0"> <tr> <td valign="top" style="text-align:center" nowrap="nowrap" bgcolor="#e8eefa"> <input type="hidden" name="ltmpl" value="gm"> <div class="loginBox"> <table id="gaia_table" align="center" border="0" cellpadding="1" cellspacing="0"> <tr> <td colspan="2" align="center"> <font size="-1"> Sign in with your </font> <table> <tr> <td valign="top"> <img src="google_transparent.gif" alt="Google"> </img> </td> <td valign="middle"> <font size="+0"><b>Account</b></font> </td> </tr> </table> </td> </tr> <script type="text/javascript"><!-- function onPreCreateAccount() { return true; } function onPreLogin() { if (window["onlogin"] != null) { return onlogin(); } else { return true; } } --></script> <tr> <td colspan="2" align="center"> </td> </tr> <tr> <td nowrap="nowrap"> <div align="right"> <span class="gaia le lbl"> Email: </span> </div> </td> <td> <input type="hidden" name="continue" id="continue" value="http://codereview.chromium.org/_ah/login?continue=http://codereview.chromium.org/210007/description" /> <input type="hidden" name="service" id="service" value="ah" /> <input type="hidden" name="ltmpl" id="ltmpl" value="gm" /> <input type="hidden" name="ltmpl" id="ltmpl" value="gm" /> <input type="hidden" name="ahname" id="ahname" value="Chromium Code Reviews" /> <input type="hidden" name="GALX" value="LfA4LnZj1gM" /> <input type="text" name="Email" id="Email" size="18" value="" class='gaia le val' /> </td> </tr> <tr> <td></td> <td align="left"> </td> </tr> <tr> <td align="right" nowrap="nowrap"> <span class="gaia le lbl"> Password: </span> </td> <td> <input type="password" name="Passwd" id="Passwd" size="18" class="gaia le val" /> </td> </tr> <tr> <td> </td> <td align="left"> </td> </tr> <tr> <td align="right" valign="top"> <input type="checkbox" name="PersistentCookie" id="PersistentCookie" value="yes" checked='checked' /> <input type="hidden" name='rmShown' value="1" /> </td> <td> <label for="PersistentCookie" class="gaia le rem"> Stay signed in </label> </td> </tr> <tr> <td> </td> <td align="left"> <input type="submit" class="gaia le button" name="signIn" value="Sign in" /> </td> </tr> <tr id="ga-fprow"> <td colspan="2" height="33.0" class="gaia le fpwd" align="center" valign="bottom"> <a href="http://www.google.com/support/accounts/bin/answer.py?answer=48598&amp;hl=en&amp;ctx=ch_ServiceLogin&amp;p=ah&amp;fpUrl=https%3A%2F%2Fwww.google.com%2Faccounts%2FForgotPasswd%3FfpOnly%3D1%26continue%3Dhttp%253A%252F%252Fcodereview.chromium.org%252F_ah%252Flogin%253Fcontinue%253Dhttp%253A%252F%252Fcodereview.chromium.org%252F210007%252Fdescription%26service%3Dah%26ltmpl%3Dgm" target=_top> Can&#39;t access your account? </a> </td> </tr> </table> </div> </td> </tr> </table> </div> <input type="hidden" name="asts" id="asts" value=""> </form> <form id="gaia_universallogin" action="https://www.google.com/accounts/ServiceLoginAuth?service=ah&amp;sig=d71ef8b8d6150b23958ad03b3bf546b7" method="post" onsubmit="return(gaia_onLoginSubmit());"> <input type="hidden" name="continue" id="continue" value="http://codereview.chromium.org/_ah/login?continue=http://codereview.chromium.org/210007/description" /> <input type="hidden" name="service" id="service" value="ah" /> <input type="hidden" name="ltmpl" id="ltmpl" value="gm" /> <input type="hidden" name="ltmpl" id="ltmpl" value="gm" /> <input type="hidden" name="ahname" id="ahname" value="Chromium Code Reviews" /> <input type="hidden" name="ltmpl" id="ltmpl" value="gm" /> </form> <br/> <table class="form-noindent" border="0" cellpadding="6" cellspacing="3" width="100%"> <tr> <td bgcolor="#e8eefa" align="center" style="font-size:83%"> <b>Don't have a Google Account? </b><br/> <a href='https://www.google.com/accounts/NewAccount?continue=http%3A%2F%2Fcodereview.chromium.org%2F_ah%2Flogin%3Fcontinue%3Dhttp%3A%2F%2Fcodereview.chromium.org%2F210007%2Fdescription&amp;service=ah&amp;ltmpl=gm&amp;sig=909f6cca8e55250406f8bfbd303ab4a9' > <b>Create an account now</b> </a> </td> </tr> </table> </div> <br/> </div> </td> </tr> </table> </div> <div class="footer"> &copy;2009 Google - <a href='http://www.google.com/'>Google Home</a> - <a href='https://www.google.com/accounts/TOS?hl=en'>Terms of Service</a> - <a href='http://www.google.com/intl/en/privacy.html'>Privacy Policy</a> - <a href='http://www.google.com/support/accounts?hl=en'>Help</a> </div> </div> </body> </html> Review URL: http://codereview.chromium.org/210007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26685 0039d316-1c4b-4281-b951-d872f2087c98
* Add a new flag to the installer to prevent registering for a Google Update ↵robertshield@chromium.org2009-09-152-1/+14
| | | | | | | | launch. Review URL: http://codereview.chromium.org/194118 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26255 0039d316-1c4b-4281-b951-d872f2087c98
* Cause experimental builds to delete profile information on uninstall.robertshield@chromium.org2009-09-151-0/+4
| | | | | | Review URL: http://codereview.chromium.org/201115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26226 0039d316-1c4b-4281-b951-d872f2087c98
* Cause experimental builds to uninstall unconditionally with no UI.robertshield@chromium.org2009-09-141-0/+12
| | | | | | Review URL: http://codereview.chromium.org/203059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26179 0039d316-1c4b-4281-b951-d872f2087c98
* Do not delete old version directory if 'opv' key still points to it.kuchhal@chromium.org2009-09-142-141/+154
| | | | | | | | BUG=21600 Review URL: http://codereview.chromium.org/200100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26150 0039d316-1c4b-4281-b951-d872f2087c98
* Fix to use FilePath in more unittests.phajdan.jr@chromium.org2009-09-141-9/+6
| | | | | | | | | | | Landing patch for Thiago Farina, original review: http://codereview.chromium.org/187005 BUG=None TEST=run unit_tests.exe, base_unittests.exe. Review URL: http://codereview.chromium.org/193101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26142 0039d316-1c4b-4281-b951-d872f2087c98
* Second part of the multi-toast experimentcpu@chromium.org2009-09-111-3/+6
| | | | | | | | | | | | | | | | There are 4 flavors of the toast, if the user qualfies use coin toss to show one of them. - Accordingly we have now four experiment sets: TAxx, TBxx, TCxx, TDxx. BUG=b/1484308 TEST= see bug for instructions Review URL: http://codereview.chromium.org/200092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26025 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a --do-not-create-shortcuts command line switch to the installer to ↵robertshield@chromium.org2009-09-102-13/+21
| | | | | | | | prevent it from trying to create Chrome desktop shortcuts. Review URL: http://codereview.chromium.org/196068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25870 0039d316-1c4b-4281-b951-d872f2087c98
* Fix to use FilePath::DirName instead of FileUtil::UpOneDirectoryOrEmpty.kuchhal@chromium.org2009-09-041-4/+5
| | | | | | | | | | BUG=None TEST=run installer_util_unittests.exe Review URL: http://codereview.chromium.org/173042 Patch from Thiago Farina <thiago.farina@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25464 0039d316-1c4b-4281-b951-d872f2087c98
* Try to cleanup temporary directories created during install operations.kuchhal@chromium.org2009-08-251-0/+1
| | | | | | | | BUG=18635 Review URL: http://codereview.chromium.org/174418 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24369 0039d316-1c4b-4281-b951-d872f2087c98
* Fix log message during install.kuchhal@chromium.org2009-08-201-2/+1
| | | | | | | | BUG=19745 Review URL: http://codereview.chromium.org/174084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23835 0039d316-1c4b-4281-b951-d872f2087c98
* Renames the function CreateTemporaryFilename to CreateTemporaryFile and ↵erikkay@chromium.org2009-08-182-13/+17
| | | | | | | | | | | | | | track down all callers, also removes the deprecated function that uses std::wstring. BUG=3078 (http://crbug.com/3078) TEST=run base_unittests, installer_util_unittests, net_unittests, setup_unittests, and unit_tests. Review URL: http://codereview.chromium.org/164537 Patch from Thiago Farina. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23631 0039d316-1c4b-4281-b951-d872f2087c98
* Do not delete default browser entries for other users when uninstalling it ↵kuchhal@chromium.org2009-08-141-20/+34
| | | | | | | | | | | for one user. BUG=19222 TEST=Install and set Chrome as default for two different users on the same machine. Uninstall for one user and make sure the default browser still works for the second user. Review URL: http://codereview.chromium.org/164454 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23496 0039d316-1c4b-4281-b951-d872f2087c98
* Add unit tests for unpacking and patching methods.kuchhal@chromium.org2009-08-057-169/+125
| | | | | | | | | BUG=12849 TEST=none Review URL: http://codereview.chromium.org/160623 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22535 0039d316-1c4b-4281-b951-d872f2087c98
* Add some unit tests for master preferences parsing code.kuchhal@chromium.org2009-08-054-42/+121
| | | | | | | | | BUG=12849 TEST=none Review URL: http://codereview.chromium.org/160560 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22493 0039d316-1c4b-4281-b951-d872f2087c98
* Use alternate icon for Chrome shortcuts if specified in master preferences.kuchhal@chromium.org2009-08-033-22/+24
| | | | | | | | | | | This change depends on change 159539 that is currently under review and a new chrome2.ico that is yet to be added to the repository. BUG=12701 TEST=Specify an alternate icon in --installerdata file and make sure that icon is used for shortcuts and it not changed later by updates. Review URL: http://codereview.chromium.org/159618 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22314 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring of master preferences parsing before adding a new preference.kuchhal@chromium.org2009-08-033-103/+101
| | | | | | | | | | | | | Currently we are parsing master preferences file three time on startup. Since we only return an int bit mask flag after parsing preferences, it can not handle any preference other than boolean and we end up reading it again for first run tabs and ping delay. This change refactors all the preferences parsing logic to directly pass around DictionaryValue object around in Chrome as well as installer. No functional change but this will make adding a new preference for new icon more logical since we will not read the preferences file once again. BUG=12701 TEST=Make sure all the distribution preferences still work as before. Review URL: http://codereview.chromium.org/159539 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22284 0039d316-1c4b-4281-b951-d872f2087c98
* Revert changes from r22198 to r22204 and r22194. None of these changes werekuchhal@chromium.org2009-07-313-101/+103
| | | | | | | | | supposed to be commited. Seems like git took all the temporary commits from the base branch and uploaded them to svn. Review URL: http://codereview.chromium.org/159736 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22206 0039d316-1c4b-4281-b951-d872f2087c98
* Fix distribution key bug.kuchhal@chromium.org2009-07-311-23/+18
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22202 0039d316-1c4b-4281-b951-d872f2087c98
* cleanupkuchhal@chromium.org2009-07-312-14/+10
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22200 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring of master preferences parsing before adding a new preference.kuchhal@chromium.org2009-07-313-97/+104
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22198 0039d316-1c4b-4281-b951-d872f2087c98
* Allow two user level installs of Chrome to have default browser settings.kuchhal@chromium.org2009-07-234-24/+60
| | | | | | | | | | | | | | | | | | | | | | This change will allow two Windows users to install thier own copy of Chrome and set it as default browser. There is a bunch of refactoring in this change. - Divided the registry entries into three categories: * Entries that are only read from HKLM * Entries that actually tie file/protocol associations to Chrome. This will almost always be in HKCU (except when it is a OEM install). * Entries that we can create in HKCU if we fail to create them in HKLM. - For single user machine nothing should change. - For two users on the same machine (each with a different user level Chrome installed), the second user's default browser will get renamed to Chromium.<user> and the required registry entries will also be renamed so that they do not overwrite first users's registry entries. BUG=3641 TEST=Install and set Chromium as default browser from two different logins on the same machine for various combinations of XP/Vista, admin users/non admin user, user-level install/system-level install. Review URL: http://codereview.chromium.org/159172 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21428 0039d316-1c4b-4281-b951-d872f2087c98
* Update mini_installer and setup manifest for Windows 7 to silence PCA.kuchhal@chromium.org2009-07-201-8/+16
| | | | | | | | | | | | | Apparently in Windows 7 we need to define supportedOS to make Program Compatibility Assistant happy ( http://msdn.microsoft.com/en-us/library/dd371711(VS.85).aspx). BUG=9431 TEST=Install/uninstall Chromium on windows 7 without elevation and UAC enabled and make sure PAC dialog doesn't show up. Review URL: http://codereview.chromium.org/159045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21075 0039d316-1c4b-4281-b951-d872f2087c98
* Do not set/unset magic string during setup.exe patching step.kuchhal@chromium.org2009-07-161-7/+0
| | | | | | | | | BUG=NONE TEST=Make 3 stage updater fail by deleting <chrome>\Application\Installer\chrome.7z file and make sure "ap" key still contains "-full". Review URL: http://codereview.chromium.org/149776 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20912 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes the character encoding in the EULA outer frames (sets them to utf-8)gwilson@google.com2009-07-0142-1938/+1980
| | | | | | | | | | BUG=15691 R=cpu TEST=Set language to 'ru', run setup.exe with --show-eula Review URL: http://codereview.chromium.org/150126 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19730 0039d316-1c4b-4281-b951-d872f2087c98
* Fixit: Remove bunch of coverity warnings from chrome/installer/*.kuchhal@chromium.org2009-06-302-7/+11
| | | | | | | | BUg=12849 Review URL: http://codereview.chromium.org/151101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19668 0039d316-1c4b-4281-b951-d872f2087c98
* Add error message to help debug install status inconsistency from logs.kuchhal@chromium.org2009-06-241-1/+7
| | | | | | Review URL: http://codereview.chromium.org/146097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19186 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor setup. No code change.kuchhal@chromium.org2009-06-235-279/+260
| | | | | | | | | | | I am not sure why we had split install.h functions into setup.cc and install.cc. I think we only need install.{h|cc} just like we have uninstall.{h|cc}. BUG=12849 Review URL: http://codereview.chromium.org/147016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19058 0039d316-1c4b-4281-b951-d872f2087c98
* Toast experiment: I need to re-laucnh chrome because google_update likes ↵cpu@google.com2009-06-231-2/+5
| | | | | | | | | | | | | setup to finish fast. - Added new cmd line flag to setup.exe: --inactive-user-toast BUG= b/1484308 TEST = see the bug Review URL: http://codereview.chromium.org/144015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19044 0039d316-1c4b-4281-b951-d872f2087c98
* Add experiment support in setupcpu@google.com2009-06-171-1/+7
| | | | | | | | | | | | - Adds the inactive user toast logic - Some refactoring of helper functions BUG=b/1484308 TEST=see the bug Review URL: http://codereview.chromium.org/125234 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18640 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-19 12:10:45 +0000