summaryrefslogtreecommitdiffstats
path: root/chrome/installer/util/shell_util.cc
Commit message (Collapse)AuthorAgeFilesLines
* Suffix Chrome's appid on user-level installsgrt@chromium.org2012-06-191-8/+65
| | | | | | | | | | | | | | | | | | ShellIntegration::GetAppId() --> ShellIntegration::GetProfileAppId() for clarity (i.e. having two functions called "GetAppId" is confusing imo). Patch From Gabriel Charette <gab@chromium.org> BUG=125362, 133173 TEST=Make sure 125362 doesn't repro. http://goo.gl/ZZ7gE ShellIntegrationTest.GetAppModelIdForProfileTest ShellUtilTest.BuildAppModelId* SessionRestoreTest.RestoreAfterClosingTabbedBrowserWithAppAndLaunching AppModeTest.EnableAppModeTest Review URL: https://chromiumcodereview.appspot.com/10542031 Patch from Gabriel Charette <gab@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142909 0039d316-1c4b-4281-b951-d872f2087c98
* Make chrome the default browser interactively if possible, register it if not.grt@chromium.org2012-06-181-1/+6
| | | | | | | | | | | | This will pop the Greg dialog on Win8 when the installer is run as an interactive user with --make-chrome-default. BUG=133119,113326 TEST=on win8: install chrome with --make-chrome-default 1) at user-level, 2) at system-level as a regular user, 3) at system-level as SYSTEM. 1 and 2 should show the default browser dialog, whereas 3 should just register it so that a user can make it the default without uac. on win7: everything should work as before. Review URL: https://chromiumcodereview.appspot.com/10558015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142727 0039d316-1c4b-4281-b951-d872f2087c98
* Make all registrations in HKCU for user-level installs on Win8gab@chromium.org2012-06-171-37/+63
| | | | | | | | | | BUG=124013,125362, 133173 TEST=No UAC on first run for user-level installs on Win8. http://goo.gl/ZZ7gE Review URL: https://chromiumcodereview.appspot.com/10399054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142648 0039d316-1c4b-4281-b951-d872f2087c98
* Abstract suffixing logic away from GetApplicationNamegab@chromium.org2012-06-171-14/+18
| | | | | | | | | BUG=124013, 125362, 133173 TEST=http://goo.gl/ZZ7gE Review URL: https://chromiumcodereview.appspot.com/10446111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142641 0039d316-1c4b-4281-b951-d872f2087c98
* Always suffix ChromeHTML entries on Windows for user-level installs.gab@chromium.org2012-06-171-123/+208
| | | | | | | | | | | | | This also adds the same suffixing to Chrome's appname for Default Programs registration (this suffix is not user-facing though as we don't suffix the actual string representing Chrome in the UI... obviously!) Design doc: https://docs.google.com/a/chromium.org/document/d/1qmcV3uYBh3JwvXhYkI7asg0nN7KfVMWVOzND4p0jQ3E/edit BUG=125362,124013,133173 TEST=http://goo.gl/ZZ7gE Review URL: https://chromiumcodereview.appspot.com/10451074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142634 0039d316-1c4b-4281-b951-d872f2087c98
* Fix all hardcoded Windows registry lookups.gab@chromium.org2012-06-131-17/+27
| | | | | | | | | | | | Some of our registry lookups were wrong based on how the "new" (Win7+) Windows operates. BUG=None TEST=None Review URL: https://chromiumcodereview.appspot.com/10535057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141903 0039d316-1c4b-4281-b951-d872f2087c98
* Fix RegisterChromeBrowser definition and usage in shell_utilgab@chromium.org2012-06-111-5/+2
| | | | | | | | | | BUG=122756 TEST=None Review URL: https://chromiumcodereview.appspot.com/10512026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141488 0039d316-1c4b-4281-b951-d872f2087c98
* The CL adds to ShellUtil and ShellIntegration and adjusts invocations of the ↵motek@chromium.org2012-06-081-11/+44
| | | | | | | | | | | | latter whenever necessary. R=grt@chromium.org, sky@chromium.org BUG=113326, 129232 TEST=N/A Review URL: https://chromiumcodereview.appspot.com/10453041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141172 0039d316-1c4b-4281-b951-d872f2087c98
* Add version check to only register the DelegateExecute verb handler if Win8 ↵gab@chromium.org2012-05-241-2/+32
| | | | | | | | | | | | | | build is 8370 or higher. This prevents us from launching Metro chrome on unsupported builds (launching from Start Screen simply defaults to desktop Chrome). BUG=None TEST=Chrome launches in Desktop from Start Screen on 8250 and to Metro in 8370. Review URL: https://chromiumcodereview.appspot.com/10441012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138919 0039d316-1c4b-4281-b951-d872f2087c98
* Always do DelegateExecute handler COM registration and make set dual mode ↵grt@chromium.org2012-05-181-0/+1
| | | | | | | | | | | | | | prop on shortcuts. This is in support of the pre-win8 -> win8 upgrade scenario. BUG=128131,127734 TEST=manual: install on pre-win8 and confirm that the COM registration for the DelegateExecute handler is present in HKCR (Google Chrome: {5C65F4B0-3651-4514-B207-D10CB699B14B} or Chromium: {A2DF06F9-A21A-44A8-8A99-8B9C84F29160}) and that the start menu shortcut has the dual mode juju. Review URL: https://chromiumcodereview.appspot.com/10386167 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137863 0039d316-1c4b-4281-b951-d872f2087c98
* Don't register or use the DelegateExecute verb handler if it isn't present.grt@chromium.org2012-04-251-2/+47
| | | | | | | | | BUG=124666,123994 TEST=install canary on a win8 box and note that the DelegateExecute verb handler isn't registered in HKCR and that registration for shell verbs don't refer to it. Review URL: http://codereview.chromium.org/10213010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133995 0039d316-1c4b-4281-b951-d872f2087c98
* HKCR/ChromeHTML Win8 registry requirementsgab@chromium.org2012-04-211-189/+281
| | | | | | | | | | | | This CL also takes care of adding necessary registry entry for DelegateExecute to open Metro mode in Windows 8 (as well as packaging the necessary new files and installing them in the correct places). BUG=119242 TEST=Verify all necessary prog id registry keys are correctly placed on a Win8 install. Verify DelegateExecute binaries, pngs, and VisualElementsManifest.xml land where they belond after running the installer. Review URL: http://codereview.chromium.org/9918012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133333 0039d316-1c4b-4281-b951-d872f2087c98
* Win 8 Start Menu shortcut changesgab@chromium.org2012-04-061-30/+33
| | | | | | | | | BUG=119242 TEST=Test DualModeApp properties are correctly set in Windows 8 on Start Menu shortcut. Review URL: http://codereview.chromium.org/9837120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131163 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused include of installer_util_strings.h.tony@chromium.org2012-03-271-2/+0
| | | | | | | | | | These files don't use any localized strings. BUG=None Review URL: https://chromiumcodereview.appspot.com/9861022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129234 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove calls to deprecated file_util::AppendToPath() in ↵thestig@chromium.org2012-03-091-4/+8
| | | | | | | | | | | chrome/installer. BUG=24672 TEST=install Chrome and make it the default browser. verify that filetype (double-click an .html file) and protocol registrations (enter http://www.google.com/ in the Run... dialog) still work. Review URL: http://codereview.chromium.org/9616046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125834 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove some deprecated file_util methods.thestig@chromium.org2012-02-241-24/+28
| | | | | | | | | BUG=24672 TEST=none Review URL: http://codereview.chromium.org/9442038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123551 0039d316-1c4b-4281-b951-d872f2087c98
* Use IApplicationAssociationRegistrationUI::LaunchAdvancedAssociationUI to ↵cpu@chromium.org2012-02-091-6/+31
| | | | | | | | | | | | | set the default browser This is for windows 8. BUG=113326 TEST=see bug Review URL: https://chromiumcodereview.appspot.com/9370008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121335 0039d316-1c4b-4281-b951-d872f2087c98
* windows: Fix a few things clang complains about.thakis@chromium.org2012-01-231-9/+9
| | | | | | | | | | | | No functionality change. BUG=82385 TEST=none Review URL: http://codereview.chromium.org/9200009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118725 0039d316-1c4b-4281-b951-d872f2087c98
* Badge Windows profile shortcuts with multi-user avatar.stevet@chromium.org2011-12-061-7/+20
| | | | | | | | | BUG=105110 TEST=Ensure that when Chrome on Windows creates a desktop icon for a new Profile, the icon image has the user avatar in it. Ensure that changing the Avatar changes the image in the icon. TBR=rsesek Review URL: http://codereview.chromium.org/8785006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113104 0039d316-1c4b-4281-b951-d872f2087c98
* Add Windows desktop shortcut for multiple profiles.mirandac@chromium.org2011-11-221-13/+49
| | | | | | | | BUG=87770 TEST=new unit tests added with this CL. Review URL: http://codereview.chromium.org/8502033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111156 0039d316-1c4b-4281-b951-d872f2087c98
* Fix default browser registration for simplified chinese installs.grt@chromium.org2011-11-021-63/+90
| | | | | | | | | | | | | http://crrev.com/13341 and http://crrev.com/13906, which fixed http://crbug.com/9697, switched from using chrome.exe as the canonical name of Chrome (for purposes of shell registration) to using the localized application name (e.g., "Chromium" or "Google Chrome"). This is problematic since there are differences between the various locales as to what the app name is. This change switches to using a non-localized version of the product name. The right thing to do would really be to switch back to using the executable name (as prescribed by MSDN), except for the case of Chromium builds, where "chromium.exe" could be used. Making that change now would mean potentially re-prompting users to make Chrome their default browser, which would be bad. BUG=92445 TEST=Verify that Google Chrome and Chromium builds can coexist, and that each can be made the default browser. Furthermore, ensure that, for user-level and system-level installs, all of the usual shell registration things work: the Start Menu's "Internet" link (icon and action), running "chrome.exe" (without path) from the Run... dialog, clicking a link in some other program, typeing a URL into the Run... dialog, "Set your default programs" control panel, "Set program access and computer defaults" control panel. Also, verify that if Chrome is installed using zn-CH locale and made the default, that switching to another locale (like en-US) doesn't cause Chrome to prompt to become the default browser. Review URL: http://codereview.chromium.org/8384038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108297 0039d316-1c4b-4281-b951-d872f2087c98
* Update Windows install to add capabilities for currently whitelisted rph schemesbenwells@chromium.org2011-09-011-1/+2
| | | | | | | | | | | | | | The white list for registerProtocolHandlers schemes has been updated. This change makes Chrome register as capable of handling all white listed schemes to minimise elevation dialogs coming up when accepting new handlers. BUG=94584 TEST=Manual testing performed Review URL: http://codereview.chromium.org/7791014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99158 0039d316-1c4b-4281-b951-d872f2087c98
* Keep going with Vista default browser registration if there is a failure.benwells@chromium.org2011-07-261-10/+13
| | | | | | | | | | | | | | Keep going if there is a failure as rolling back is complicated and relies on undocumented Windows behaviour. Log any problems and return false from registration function. BUG=90372 TEST=Manual testing performed Review URL: http://codereview.chromium.org/7491039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94034 0039d316-1c4b-4281-b951-d872f2087c98
* some cleanup for base/stl_utildilmah@chromium.org2011-07-191-1/+1
| | | | | | | | | | | | | removed unused/irrelevant functions removed irrelevant comments Moved stl_util-inl.h => stl_util.h BUG=None TEST=None Review URL: http://codereview.chromium.org/7342047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93110 0039d316-1c4b-4281-b951-d872f2087c98
* Allow chrome to become the os default handler for arbitrary protocols on ↵koz@chromium.org2011-05-261-36/+229
| | | | | | | | | | | | | | | mac/win. Note this is unused currently, but will be hooked up to navigator.registerProtocolHandler in a subsequent change. BUG=83556 TEST=Manual Review URL: http://codereview.chromium.org/6961013 Patch from Ben Wells <benwells@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86793 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a regression in the creation or updating of the Chrome desktop shortcut.robertshield@chromium.org2011-04-151-1/+1
| | | | | | | | BUG=78938,78143 TEST=Icon updates correctly between versions and is created correctly on first install. Review URL: http://codereview.chromium.org/6865004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81744 0039d316-1c4b-4281-b951-d872f2087c98
* Move some files from base to base/memory.levin@chromium.org2011-03-281-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | raw_scoped_refptr_mismatch_checker.h ref_counted.cc ref_counted.h ref_counted_memory.cc ref_counted_memory.h ref_counted_unittest.cc scoped_callback_factory.h scoped_comptr_win.h scoped_handle.h scoped_native_library.cc scoped_native_library.h scoped_native_library_unittest.cc scoped_nsobject.h scoped_open_process.h scoped_ptr.h scoped_ptr_unittest.cc scoped_temp_dir.cc scoped_temp_dir.h scoped_temp_dir_unittest.cc scoped_vector.h singleton.h singleton_objc.h singleton_unittest.cc linked_ptr.h linked_ptr_unittest.cc weak_ptr.cc weak_ptr.h weak_ptr_unittest.cc BUG=None TEST=Compile Review URL: http://codereview.chromium.org/6714032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
* Correct the duplicate creation of desktop shortcuts that can occur when ↵robertshield@chromium.org2011-03-241-28/+35
| | | | | | | | | | system-level chrome creates a shortcut in the user's current desktop. BUG=5073 TEST=Install system-level Chrome, observe a Chrome shortcut is created in the All Users desktop. Run Chrome, observe that no duplicate shortcut is created. Review URL: http://codereview.chromium.org/6731018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79297 0039d316-1c4b-4281-b951-d872f2087c98
* Pure pedantry: Replace all ".size() == 0" with ".empty()".erg@google.com2011-03-021-1/+1
| | | | | | | | | BUG=carnitas TEST=compiles; existing unit tests. Review URL: http://codereview.chromium.org/6602049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76467 0039d316-1c4b-4281-b951-d872f2087c98
* Regkey functions return error code instead of boolamit@chromium.org2011-01-191-9/+10
| | | | | | | | | | | | | | | | | | | | | | Change the Regkey helper to consistently use and return LONG instead of bool. Fix RegKey usage all over the code base and get rid of workarounds due to lack of return value. Reviewers: brettw: everything (skip parts for other reviewers if you wish) robertshield,grt: chrome_frame, installer siggi: ceee BUG=none TEST=covered by existing tests Review URL: http://codereview.chromium.org/6090006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71768 0039d316-1c4b-4281-b951-d872f2087c98
* Use FilePath::DirName instead of the deprecated file_util::GetDirectoryFromPath.tfarina@chromium.org2011-01-071-1/+1
| | | | | | | | | | | Fix the callers and remove the deprecated function. BUG=24672 TEST=trybots Review URL: http://codereview.chromium.org/6111003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70705 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 69167, itself a revert of 69165 - Merge the installer, installer_util ↵robertshield@chromium.org2010-12-151-8/+8
| | | | | | | | | | | | and setup_util namespaces into a single installer namespace. BUG=61609 TEST=NONE Review URL: http://codereview.chromium.org/5738009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69256 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 69165 - Merge the installer, installer_util and setup_util namespaces ↵robertshield@chromium.org2010-12-141-8/+8
| | | | | | | | | | | | | | into a single installer namespace. BUG=61609 TEST=NONE Review URL: http://codereview.chromium.org/5729004 TBR=robertshield@chromium.org Review URL: http://codereview.chromium.org/5756007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69167 0039d316-1c4b-4281-b951-d872f2087c98
* Merge the installer, installer_util and setup_util namespaces into a single ↵robertshield@chromium.org2010-12-141-8/+8
| | | | | | | | | | | installer namespace. BUG=61609 TEST=NONE Review URL: http://codereview.chromium.org/5729004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69165 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the installer to support multi-install.tommi@chromium.org2010-12-011-56/+64
| | | | | | | | | | | | | | | | | | The installer now does its work based on distributions and target installation paths. Each distribution has exactly one target installation path but each installation path can have more than one distribution. In the absense of the --multi-install switch, the installer should continue to work as before. The biggest difference here is that we don't rely on a single global distribution object that controls the entire installation flow and we have a few classes for the new abstractions instead of global functions. It's far from perfect, but it's a step towards separating the core file package required for all distributions from the distributions themselves. Additionally, there are tons of little changes here such as consistant usage of FilePath and CommandLine instead of mixing them with std::wstring. TEST=Install, uninstall, upgrade, etc. Everything install related. BUG=61609 Review URL: http://codereview.chromium.org/5172011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67818 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to reland http://codereview.chromium.org/4928002/tommi@chromium.org2010-11-151-15/+12
| | | | | | | | | | | | | | | | | | | | | | | | For some reason the Win bot failed to compile the sandbox unit test. Trybots and my machines don't have these build problems, so I'm going to try again, unchanged. Original description: Changing the installer switches from wchar_t[] to char[]. Because of this I'm also refactoring some code that before was using wstring to build command lines by hand instead of using the CommandLine class. Now we use CommandLine. To get this to work correctly, I also needed to fix CommandLine::AppendArguments so I added a little test for it. TEST=There should be no changes in functionality. Run all installer tests. BUG=61609 TBR=robertshield Review URL: http://codereview.chromium.org/4989001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66096 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 66088 - Changing the installer switches from wchar_t[] to char[].tommi@chromium.org2010-11-151-12/+15
| | | | | | | | | | | | | | | | | | Because of this I'm also refactoring some code that before was using wstring to build command lines by hand instead of using the CommandLine class. Now we use CommandLine. To get this to work correctly, I also needed to fix CommandLine::AppendArguments so I added a little test for it. TEST=There should be no changes in functionality. Run all installer tests. BUG=61609 Review URL: http://codereview.chromium.org/4928002 TBR=tommi@chromium.org Review URL: http://codereview.chromium.org/4988001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66089 0039d316-1c4b-4281-b951-d872f2087c98
* Changing the installer switches from wchar_t[] to char[].tommi@chromium.org2010-11-141-15/+12
| | | | | | | | | | | | | | | Because of this I'm also refactoring some code that before was using wstring to build command lines by hand instead of using the CommandLine class. Now we use CommandLine. To get this to work correctly, I also needed to fix CommandLine::AppendArguments so I added a little test for it. TEST=There should be no changes in functionality. Run all installer tests. BUG=61609 Review URL: http://codereview.chromium.org/4928002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66088 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring the master_preferences functions.tommi@chromium.org2010-11-031-5/+4
| | | | | | | | | | | | | | | | | | | | | * Now there's a class named MasterPreferences that owns the json dictionary and supports methods that previously were global. * There's now a global object for the current process' master preference object, which avoids parsing the preference file multiple times. * Refactored the tests to be more data driven TEST=Run the installer util unit tests. Set the filter to *MasterPref* if you only want to run the tests affected by this change. BUG=none Review URL: http://codereview.chromium.org/4342001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64945 0039d316-1c4b-4281-b951-d872f2087c98
* base: Move CaseInsensitiveCompare traits into the base namespace.tfarina@chromium.org2010-11-031-3/+4
| | | | | | | | | | | | | | | This should fix conflicts like: 2>d:\src\chromium_src2\src\base/string_util.h(480) : error C2904: 'CaseInsensitiveCompare' : name already used for a template in the current scope 2> d:\src\chromium_src2\src\third_party\xulrunner-sdk\win\include\xpcom\nsStringAPI.h(1406) : see declaration of 'CaseInsensitiveCompare' Reported-by: Jeff Timanus <twiz@google.com> BUG=None TEST=trybots Review URL: http://codereview.chromium.org/4366001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64877 0039d316-1c4b-4281-b951-d872f2087c98
* Convert LOG(INFO) to VLOG(1) - chrome/installer/.pkasting@chromium.org2010-10-201-1/+1
| | | | | | | | | | Also remove some extra {}s, avoid "else" after "return"/use some early returns, and simplify some code. BUG=none TEST=none Review URL: http://codereview.chromium.org/3931004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63258 0039d316-1c4b-4281-b951-d872f2087c98
* Move pe_image and registry from base to base/win and use the namespace. It ↵brettw@chromium.org2010-10-171-2/+5
| | | | | | | | | | | | removes windows_message_list which isn't used. This keeps a stub for registry in the old location until we can update that. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3836005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62888 0039d316-1c4b-4281-b951-d872f2087c98
* Move windows version-related stuff out of base/win_util and into ↵brettw@chromium.org2010-10-151-4/+4
| | | | | | | | | | | | | | base/win/windows_version. Many files now only need to include this instead of all of win_util. Remove a bunch of unused code from base/win_util. There was a surprising amount. Replace the AppUserModel property key with the one from the SDK now that we use the Win7 SDK. Move GetLogonSessionOnlyDACL from win_util to ipc since it's only used in that one place. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3823002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62694 0039d316-1c4b-4281-b951-d872f2087c98
* CommandLine: remove wstring-based program() accessorevan@chromium.org2010-10-141-8/+10
| | | | | | | | | | | | | | This was already removed on non-Windows, so this change modifies the remaining Windows-specific usage. In a few places I converted use of wstring paths into FilePath, but in general for Windows-specific code I don't think it's too important to use FilePath everywhere, because it is equivalent on Windows and the current code already works. BUG=23581 Review URL: http://codereview.chromium.org/3817001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62637 0039d316-1c4b-4281-b951-d872f2087c98
* base: Move SplitString functions into the base namespace and update the callers.tfarina@chromium.org2010-10-141-2/+2
| | | | | | | | | BUG=None TEST=trybots Review URL: http://codereview.chromium.org/3750001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62483 0039d316-1c4b-4281-b951-d872f2087c98
* base: Finish moving the SplitString functions from string_util.h to ↵tfarina@chromium.org2010-09-241-0/+1
| | | | | | | | | | | string_split.h BUG=None TEST=trybos Review URL: http://codereview.chromium.org/3447008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60422 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup Registry API: part 3.tfarina@chromium.org2010-08-141-8/+8
| | | | | | | | | | | | - Remove the default arguments from the constructor. - Add a empty constructor to handle the case of the default arguments were used. BUG=44644 TEST=trybots Review URL: http://codereview.chromium.org/3172009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56123 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Remove unneeded headers from base/ (part 4)thestig@chromium.org2010-08-071-0/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2819094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55345 0039d316-1c4b-4281-b951-d872f2087c98
* Remove GetSwitchValue() from chrome/* where easy.evan@chromium.org2010-08-061-2/+4
| | | | | | Review URL: http://codereview.chromium.org/3057033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55176 0039d316-1c4b-4281-b951-d872f2087c98
* Add #include utf_string_conversions.h to all files that use ASCIIToWide andbrettw@chromium.org2010-08-031-0/+1
| | | | | | | | | | | | | | | ASCIIToUTF16. I removed string_util includes from a few places where it obviously wasn't needed. In a separate pass, I'm going to remove ASCIITo* from string_util, then I'm going to do an even later pass to find the unnecessary string_util.h includes and remove them. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3058027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54746 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-05-12 17:25:34 +0000