summaryrefslogtreecommitdiffstats
path: root/chrome/installer/util
Commit message (Collapse)AuthorAgeFilesLines
* Do not delete default browser entries for other users when uninstalling it ↵kuchhal@chromium.org2009-08-142-29/+22
| | | | | | | | | | | for one user. BUG=19222 TEST=Install and set Chrome as default for two different users on the same machine. Uninstall for one user and make sure the default browser still works for the second user. Review URL: http://codereview.chromium.org/164454 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23496 0039d316-1c4b-4281-b951-d872f2087c98
* Chance the toast experiment from TS to TTcpu@chromium.org2009-08-131-10/+14
| | | | | | | | | | | | | - The TS data is not meaningful, we don't want to mix it - The base group moved from TS00 to TS80, since omaha does not show 00 - A better random number generator is used BUG=b/1484308 TEST=see bug for instructions Review URL: http://codereview.chromium.org/164513 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23377 0039d316-1c4b-4281-b951-d872f2087c98
* Add unit tests for unpacking and patching methods.kuchhal@chromium.org2009-08-054-18/+205
| | | | | | | | | BUG=12849 TEST=none Review URL: http://codereview.chromium.org/160623 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22535 0039d316-1c4b-4281-b951-d872f2087c98
* Add some unit tests for master preferences parsing code.kuchhal@chromium.org2009-08-053-123/+236
| | | | | | | | | BUG=12849 TEST=none Review URL: http://codereview.chromium.org/160560 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22493 0039d316-1c4b-4281-b951-d872f2087c98
* Use alternate icon for Chrome shortcuts if specified in master preferences.kuchhal@chromium.org2009-08-033-28/+35
| | | | | | | | | | | This change depends on change 159539 that is currently under review and a new chrome2.ico that is yet to be added to the repository. BUG=12701 TEST=Specify an alternate icon in --installerdata file and make sure that icon is used for shortcuts and it not changed later by updates. Review URL: http://codereview.chromium.org/159618 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22314 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring of master preferences parsing before adding a new preference.kuchhal@chromium.org2009-08-038-230/+187
| | | | | | | | | | | | | Currently we are parsing master preferences file three time on startup. Since we only return an int bit mask flag after parsing preferences, it can not handle any preference other than boolean and we end up reading it again for first run tabs and ping delay. This change refactors all the preferences parsing logic to directly pass around DictionaryValue object around in Chrome as well as installer. No functional change but this will make adding a new preference for new icon more logical since we will not read the preferences file once again. BUG=12701 TEST=Make sure all the distribution preferences still work as before. Review URL: http://codereview.chromium.org/159539 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22284 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing space to command line that registers Chrome on Windows.kuchhal@chromium.org2009-08-031-1/+1
| | | | | | | | | | | | | So instead of --register-chrome-browser="<path>\chrome.exe"--register-chrome-browser-suffix=".<user>" it is actually --register-chrome-browser="<path>\chrome.exe" --register-chrome-browser-suffix=".<user>". BUG=3641 TBR=huanr Committed: http://src.chromium.org/viewvc/22194 Review URL: http://codereview.chromium.org/160481 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22282 0039d316-1c4b-4281-b951-d872f2087c98
* Revert changes from r22198 to r22204 and r22194. None of these changes werekuchhal@chromium.org2009-07-319-188/+231
| | | | | | | | | supposed to be commited. Seems like git took all the temporary commits from the base branch and uploaded them to svn. Review URL: http://codereview.chromium.org/159736 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22206 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing space to command line that registers Chrome on Windows.kuchhal@chromium.org2009-07-311-1/+1
| | | | | | | | | | | So instead of --register-chrome-browser="<path>\chrome.exe"--register-chrome-browser-suffix=".<user>" it is actually --register-chrome-browser="<path>\chrome.exe" --register-chrome-browser-suffix=".<user>". BUG=3641 TBR=huanr Review URL: http://codereview.chromium.org/160481 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22204 0039d316-1c4b-4281-b951-d872f2087c98
* fix unit testskuchhal@chromium.org2009-07-311-27/+50
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22203 0039d316-1c4b-4281-b951-d872f2087c98
* Fix distribution key bug.kuchhal@chromium.org2009-07-312-3/+22
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22202 0039d316-1c4b-4281-b951-d872f2087c98
* eols cleanupkuchhal@chromium.org2009-07-312-10/+10
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22201 0039d316-1c4b-4281-b951-d872f2087c98
* cleanupkuchhal@chromium.org2009-07-312-95/+72
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22200 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring of master preferences parsing before adding a new preference.kuchhal@chromium.org2009-07-317-162/+100
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22198 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unreferenced .vcproj files.sgk@google.com2009-07-281-218/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/159534 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21917 0039d316-1c4b-4281-b951-d872f2087c98
* Remove *.vsprops files that are no longer referenced (or only havesgk@google.com2009-07-281-11/+0
| | | | | | | | | references to each other) anywhere in the Chromium code base. BUG=none TEST=rebuild Review URL: http://codereview.chromium.org/159523 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21873 0039d316-1c4b-4281-b951-d872f2087c98
* Fixit: Coverity check return value.kuchhal@chromium.org2009-07-241-3/+6
| | | | | | Review URL: http://codereview.chromium.org/159320 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21488 0039d316-1c4b-4281-b951-d872f2087c98
* Change the toasting to 60 dayscpu@google.com2009-07-231-2/+2
| | | | | | | | | | | - same deal GB only BUG=1484308 TEST=see the bug Review URL: http://codereview.chromium.org/160044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21461 0039d316-1c4b-4281-b951-d872f2087c98
* Allow two user level installs of Chrome to have default browser settings.kuchhal@chromium.org2009-07-234-365/+447
| | | | | | | | | | | | | | | | | | | | | | This change will allow two Windows users to install thier own copy of Chrome and set it as default browser. There is a bunch of refactoring in this change. - Divided the registry entries into three categories: * Entries that are only read from HKLM * Entries that actually tie file/protocol associations to Chrome. This will almost always be in HKCU (except when it is a OEM install). * Entries that we can create in HKCU if we fail to create them in HKLM. - For single user machine nothing should change. - For two users on the same machine (each with a different user level Chrome installed), the second user's default browser will get renamed to Chromium.<user> and the required registry entries will also be renamed so that they do not overwrite first users's registry entries. BUG=3641 TEST=Install and set Chromium as default browser from two different logins on the same machine for various combinations of XP/Vista, admin users/non admin user, user-level install/system-level install. Review URL: http://codereview.chromium.org/159172 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21428 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity fixit changessra@chromium.org2009-07-222-11/+13
| | | | | | | | | | | | | | None of these fix known bugs * pass string by reference * initialize _int_value field (even though guarded by _is_string) BUG=none TEST=none Review URL: http://codereview.chromium.org/155838 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21265 0039d316-1c4b-4281-b951-d872f2087c98
* Add unit test for chrome\installer\util\versionsra@chromium.org2009-07-211-0/+82
| | | | | | | | | BUG=none TEST=this Review URL: http://codereview.chromium.org/155842 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21229 0039d316-1c4b-4281-b951-d872f2087c98
* The default ping delay should be 90 seconds.kuchhal@chromium.org2009-07-071-0/+3
| | | | | | | | BUG=1953127 Review URL: http://codereview.chromium.org/149220 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19995 0039d316-1c4b-4281-b951-d872f2087c98
* Add a ping delay time master preference.kuchhal@chromium.org2009-07-062-8/+43
| | | | | | | | BUG=1953127 Review URL: http://codereview.chromium.org/149135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19978 0039d316-1c4b-4281-b951-d872f2087c98
* Make default browser path check case insensitive.kuchhal@chromium.org2009-07-061-2/+4
| | | | | | | | BUG=15449 Review URL: http://codereview.chromium.org/149136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19976 0039d316-1c4b-4281-b951-d872f2087c98
* Fixit: Remove bunch of coverity warnings from chrome/installer/*.kuchhal@chromium.org2009-06-3020-138/+185
| | | | | | | | BUg=12849 Review URL: http://codereview.chromium.org/151101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19668 0039d316-1c4b-4281-b951-d872f2087c98
* Fix mistake on spwaning setup againcpu@google.com2009-06-271-2/+1
| | | | | | | | | | | | - I mean to spawn setup.exe --flag but it does setup.exe --uninstall - sweet overloaded functions also let you shoot yourself in the foot BUG=b/1484308 TEST=see the bug Review URL: http://codereview.chromium.org/147253 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19452 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug when launching chromecpu@google.com2009-06-262-5/+4
| | | | | | | | | | | | - Toast experiment was missing a space before "--" - Quote the first param (exe path) because it can contain spaces BUG= none TEST=chrome should uninstall as usual (launches chrome to confirm user action) Review URL: http://codereview.chromium.org/149048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19373 0039d316-1c4b-4281-b951-d872f2087c98
* Toast experiment control groupcpu@google.com2009-06-241-1/+9
| | | | | | | | | | | | | - The analisis team needs a control group; these are users that qualify don't get the experiment. - Select 50 % at random BUG= b/1484308 TEST = see the bug Review URL: http://codereview.chromium.org/147057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19147 0039d316-1c4b-4281-b951-d872f2087c98
* Adding ..\ClientState\<ChromeGuid>\client key to the uninstall metrics for ↵robertshield@google.com2009-06-231-0/+9
| | | | | | | | | | | | | | Google Chrome build. Note that the inclusion of this value is contingent upon the user having opted to send up anonymous usage information. BUG=b/1484308 TEST=Verify uninstall survey URL contains &client=<client-string> Review URL: http://codereview.chromium.org/146014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19046 0039d316-1c4b-4281-b951-d872f2087c98
* Toast experiment: I need to re-laucnh chrome because google_update likes ↵cpu@google.com2009-06-236-6/+37
| | | | | | | | | | | | | setup to finish fast. - Added new cmd line flag to setup.exe: --inactive-user-toast BUG= b/1484308 TEST = see the bug Review URL: http://codereview.chromium.org/144015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19044 0039d316-1c4b-4281-b951-d872f2087c98
* Finish the wiring of the inactive user toast experimentcpu@google.com2009-06-195-23/+101
| | | | | | | | | | | | | | - Adds read-write to the client key of google_update - Adds the logic to track experiment outcome - Some new geric exitc codes (non error codes) BUG= b/1484308 TEST= see the bug Review URL: http://codereview.chromium.org/132058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18871 0039d316-1c4b-4281-b951-d872f2087c98
* Add experiment support in setupcpu@google.com2009-06-178-4/+117
| | | | | | | | | | | | - Adds the inactive user toast logic - Some refactoring of helper functions BUG=b/1484308 TEST=see the bug Review URL: http://codereview.chromium.org/125234 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18640 0039d316-1c4b-4281-b951-d872f2087c98
* Adding ap key inclusion to uninstall metrics.robertshield@google.com2009-06-161-0/+9
| | | | | | | | BUG=http://crbug.com/14007 TEST=Uninstall a build with this patch and verify that the uninstall survey window has ap=XXXX in the URL. Review URL: http://codereview.chromium.org/126154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18495 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the ability to import the home page of the default browser. The import ↵gwilson@google.com2009-06-113-2/+10
| | | | | | | | | | | | always existed, but was never hooked up to an installerdata preference. R=cpu BUG=13752 TEST=Run the installer with a line in the distribution block of the installerdata that reads: "import_home_page" : true. The home page of the previous default browser should be imported. Review URL: http://codereview.chromium.org/118512 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18210 0039d316-1c4b-4281-b951-d872f2087c98
* Remove checked-in .vcproj files that have been converted to gyp.sgk@google.com2009-06-102-408/+0
| | | | | | | | BUG=none TEST=successful build Review URL: http://codereview.chromium.org/119411 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18044 0039d316-1c4b-4281-b951-d872f2087c98
* Trying to re-land r17758 (http://codereview.chromium.org/118247) but with ↵kuchhal@chromium.org2009-06-093-19/+19
| | | | | | | | | | name installer_util_unittests instead of util_unittests. BUG=12849 Review URL: http://codereview.chromium.org/119322 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17916 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 17758.kuchhal@chromium.org2009-06-053-19/+19
| | | | | | Review URL: http://codereview.chromium.org/118324 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17770 0039d316-1c4b-4281-b951-d872f2087c98
* Renamed installer_unittests to util_unittests and added setup_unitests ↵kuchhal@chromium.org2009-06-053-6/+6
| | | | | | | | | | | project with only one unit test for now. BUG=12849 TEST=none Review URL: http://codereview.chromium.org/118247 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17758 0039d316-1c4b-4281-b951-d872f2087c98
* gyp generation of installer_util.lib (renamed from util.lib)sgk@chromium.org2009-06-052-3/+3
| | | | | | | | | and installer_util_strings.{rc,h}. BUG=none TEST=successful build Review URL: http://codereview.chromium.org/118284 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17713 0039d316-1c4b-4281-b951-d872f2087c98
* setup.exe changes for 3 stage updates.kuchhal@chromium.org2009-06-013-1/+14
| | | | | | | | | | BUG=12832 TEST=Either test new command line options (update-setup-exe, new-setup-exe) of setup.exe individually or get a mini_installer that has setup.exe patch only and make sure the installer still works. Review URL: http://codereview.chromium.org/115866 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17320 0039d316-1c4b-4281-b951-d872f2087c98
* Commit for Miranda. glen@chromium.org2009-05-192-2/+8
| | | | | | | | | | | | | | | | | | | | | | | | | http://codereview.chromium.org/115265 Original text: """ This addresses 3 of the 4 issues described in Issue 9223: 1) Creates a new streamlined bubble with less text. 2) Incorporates a close [x]. 3) Driven by configuration option in master_preferences file; this alternate bubble will be used only if "oem_bubble": true is set. Requested longer linger time feature will involve mucking with the focus manager; this change will be uploaded separately. BUG=9223 TEST=Add "oem_bubble": true to master_preferences file. Run chrome with --first-run option. Alternate, smaller OEM bubble should appear over the Chrome browser in the place of the standard first-run bubble. """ git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16438 0039d316-1c4b-4281-b951-d872f2087c98
* Revert the first run bubble change because of Mac/Linux failures.glen@chromium.org2009-05-162-8/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16245 0039d316-1c4b-4281-b951-d872f2087c98
* Recommit for MirandaC of Smaller alternate first run bubble. ↵glen@chromium.org2009-05-162-2/+8
| | | | | | http://codereview.chromium.org/115265 BUG=9223 TBR=mirandac git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16243 0039d316-1c4b-4281-b951-d872f2087c98
* rollback of r 162411glen@chromium.org2009-05-162-8/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16242 0039d316-1c4b-4281-b951-d872f2087c98
* Commit for MirandaC of Smaller alternate first run bubble. ↵glen@chromium.org2009-05-162-2/+8
| | | | | | | | | | | http://codereview.chromium.org/115265 BUG=9223 TBR=mirandac Review URL: http://codereview.chromium.org/113504 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16241 0039d316-1c4b-4281-b951-d872f2087c98
* Rework the gyp hierarchy under chrome\installer to usesgk@google.com2009-05-152-127/+0
| | | | | | | | | | | | | | | chrome\installer.gyp as a single entry point for installer-related targets, incorporating what used to be in chrome\installer\util\util.gyp and chrome\installer\util\prebuild\util_prebuild.gyp. Adjust the dependency in chrome\chrome.gyp that pulls in installer_util. Add the newly-generated .sln and .vcproj files to svn:ignore. Updates lzma_sdk.gyp with some dependent settings that used to duplicated by hand in installer\util\util.gyp. Review URL: http://codereview.chromium.org/115404 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16194 0039d316-1c4b-4281-b951-d872f2087c98
* Add a 'cygwin' target to execute setup_mount.bat explicitly as asgk@google.com2009-05-111-0/+5
| | | | | | | | dependency of targets that need it (that is, any target with 'rules' or 'actions'). Review URL: http://codereview.chromium.org/115154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15774 0039d316-1c4b-4281-b951-d872f2087c98
* Re-re-write the logic to elevate uninstaller.kuchhal@chromium.org2009-05-062-2/+6
| | | | | | | | | | | | | | BUG=7178 TEST=Test install/uninstall in various combinations as described below and make sure that files or registry keys are not left behind: Distribution: {Chromium|Google Chrome} Install Level: {system|user} Delete Profile Option: {Selected|Not selected} Default Browser: {set|not set} Review URL: http://codereview.chromium.org/109037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15412 0039d316-1c4b-4281-b951-d872f2087c98
* Add first_run_tabs to the master prefs filecpu@google.com2009-05-063-6/+76
| | | | | | | | | | | | | - Updated unit test BUG=http://code.google.com/p/chromium/issues/detail?id=9706 TEST=none. Unit test included. Review URL: http://codereview.chromium.org/100364 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15358 0039d316-1c4b-4281-b951-d872f2087c98
* Fix missing assignment in helper_unittest.thestig@chromium.org2009-05-051-1/+1
| | | | | | TBR=tony git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15336 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-04 01:19:18 +0000