summaryrefslogtreecommitdiffstats
path: root/chrome/installer/util
Commit message (Collapse)AuthorAgeFilesLines
* Write "did run" value to multi-install client state key as well, if it exists.robertshield@chromium.org2011-03-142-0/+12
| | | | | | | | | BUG=61609 TEST=Did run value gets written to the multi-install clientstate key as well as to the product client state key. Review URL: http://codereview.chromium.org/6648008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78057 0039d316-1c4b-4281-b951-d872f2087c98
* Change DeleteRegistryKey to not require opening root keys with RegKey.tommi@chromium.org2011-03-132-10/+4
| | | | | | | | BUG=none Review URL: http://codereview.chromium.org/6679007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77979 0039d316-1c4b-4281-b951-d872f2087c98
* Delete chrome.7z archives in the current installation when doing an upgrade ↵grt@chromium.org2011-03-121-11/+16
| | | | | | | | | | | to save some disk space. BUG=none TEST=do an upgrade and see that the chrome.7z in the old version folder is gone. Review URL: http://codereview.chromium.org/6683005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77935 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Gears from Chrome.aa@chromium.org2011-03-112-5/+0
| | | | | | | | | | There are probably a few more bits and pieces that can be removed, but I think this is the majority of it. BUG=51934 Review URL: http://codereview.chromium.org/6576020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77888 0039d316-1c4b-4281-b951-d872f2087c98
* Code for stable channel is "", not "stable". Fix in PromoResourceService. ↵mirandac@chromium.org2011-03-111-1/+3
| | | | | | | | | | | Also add check for multi-install Chrome, and update comment for GoogleUpdateSettings::GetChromeChannel to indicate "-m" tags on multi-install channels. BUG=75783 TEST=promo shows up correctly for stable build, not where it shouldn't. Review URL: http://codereview.chromium.org/6685003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77850 0039d316-1c4b-4281-b951-d872f2087c98
* Add -stage:ID modifier to products' Google Update "ap" values to better ↵grt@chromium.org2011-03-1110-32/+412
| | | | | | | | | | | track installation failures. BUG=none TEST=Normal install/uninstall scenarios all function as before. Any that crash leave a "-stage:ID" modifier on the "ap" value. Review URL: http://codereview.chromium.org/6612068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77831 0039d316-1c4b-4281-b951-d872f2087c98
* Various fixes to make Chrome compile under VS2010.jeanluc@chromium.org2011-03-082-2/+2
| | | | | | | | BUG=71145 Review URL: http://codereview.chromium.org/6624097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77360 0039d316-1c4b-4281-b951-d872f2087c98
* Slight cleanup to get rid of unneeded registry access and silence a warning ↵grt@chromium.org2011-03-083-48/+42
| | | | | | | | | | | for a state that wasn't bad. BUG=none TEST=installation and uninstallation still work Review URL: http://codereview.chromium.org/6625063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77210 0039d316-1c4b-4281-b951-d872f2087c98
* When handling --rename-chrome-exe, leave in-use chrome.exe in old_chrome.exe ↵grt@chromium.org2011-03-071-3/+6
| | | | | | | | | | | rather than in a Temp dir. BUG=74723 TEST=Follow the steps in the bug. After closing chrome, no Temp directory is left behind. Review URL: http://codereview.chromium.org/6628059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77191 0039d316-1c4b-4281-b951-d872f2087c98
* Add brand-code migration to the Chrome installer when creating the new ↵robertshield@chromium.org2011-03-068-48/+94
| | | | | | | | | | | | | | | | multi-install app guid. When upgrading a product from single to multi, the installer will now check if a Chrome install at that level (user/system) had a brand code, and if so it will copy the brand code to the ClientState key for the multi-install. Also, some yak de-hairing: alter InstallationState such that it can be queried for partial ProductStates for products that are in the process of being installed. This can be used to query e.g. the ap value and the brand code, but not the version (since a product won't have a version until its first install is complete). This removes the need to go and manually re-query the registry in a couple of places, makes the installer's actions based solely on the original InstallationState and generally removes some hackiness. BUG=61609 TEST=setup_unittests.exe, also when upgrading from single to multi, observe that brand codes are copied over. Review URL: http://codereview.chromium.org/6604010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77089 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for the quick-enable-cf command to the installer. This encompases:grt@chromium.org2011-03-0314-77/+797
| | | | | | | | | | | | | - Adding facilities for new-style Google Update commands (ProductCommand, ProductCommands) - Adding support to the validator to validate the quick-enable-cf command - Adding juju to the installation and uninstallation flows to put the command into place when installing/upgrading Chrome in multi-install mode when CF is either not installed or is in ready-mode, and making sure the command is not there when Chrome Frame is installed. BUG=none TEST=Install Chrome in multi-install mode and see if the Google Update version key for the binaries (app guid {4DC8B4CA-1BDA-483e-B5FA-D3C12E15B62D}) contains a key named "quick-enable-cf" that has a CommandLine value indicating setup.exe w/ --multi-install [ --system-level ] --quick-enable-cf, a SendsPings value of 1, and a WebAccessible value of 1. Then try the other variations, like install CF in ready-mode and make sure that quick-enable-cf is still there. Make sure that installing CF causes it to be removed, etc. Review URL: http://codereview.chromium.org/6588003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76783 0039d316-1c4b-4281-b951-d872f2087c98
* Allow --chrome in a single-install's uninstall and rename commands so that ↵grt@chromium.org2011-03-021-3/+3
| | | | | | | | | | | mini installer tests don't cry when they evaluate M10 builds. BUG=74561 TEST=make sure this works: mini_installer_test.exe -clean -force --build=10.0.648.119 --gtest_filter=*FullInstallerUser Review URL: http://codereview.chromium.org/6602086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76536 0039d316-1c4b-4281-b951-d872f2087c98
* Fix sorting of the installer strings .h and .rc files. Resources that were ↵grt@chromium.org2011-03-021-5/+8
| | | | | | | | | | | | | substrings of others (IDS_INSTALL_HIGHER_VERSION and IDS_INSTALL_HIGHER_VERSION_CF, for example) were being sorted incorrectly. Now they aren't. As a bonus, installer_util_strings now depends on create_string_py, so changes to the scipt no longer require a clobber. Yay BUG=73884 TEST=build installer_util_strings then look at the generated .h and .rc files and notice that they are sorted properly Review URL: http://codereview.chromium.org/6594108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76534 0039d316-1c4b-4281-b951-d872f2087c98
* Disable TestUndeletableKey unit test. Flaky test on windows.rtenneti@chromium.org2011-03-021-1/+3
| | | | | | | | | | BUG=74654 TEST=install test TBR=dpolukhin Review URL: http://codereview.chromium.org/6602080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76511 0039d316-1c4b-4281-b951-d872f2087c98
* Add rollback support to DeleteRegKeyWorkItem.grt@chromium.org2011-03-024-19/+493
| | | | | | | | | BUG=none TEST=new test added to installer_util_unittests.exe Review URL: http://codereview.chromium.org/6598065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76496 0039d316-1c4b-4281-b951-d872f2087c98
* Pure pedantry: Replace all ".size() == 0" with ".empty()".erg@google.com2011-03-022-2/+2
| | | | | | | | | BUG=carnitas TEST=compiles; existing unit tests. Review URL: http://codereview.chromium.org/6602049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76467 0039d316-1c4b-4281-b951-d872f2087c98
* Fix in-use updates where %TMP% is on a volume other than %USERPROFILE% ↵grt@chromium.org2011-02-248-3/+322
| | | | | | | | | | | and/or %SystemRoot%. We now do temp work on the same volume as the eventual install. In the case of system-level installs, this has the nice side-effect of allowing us to move the install into place rather than copy it, which should also speed up system-level installs. BUG=70368 TEST=Set TMP and TEMP env vars to some volume other than the one holding %USERPROFILE% (for user-level installs) or %SystemRoot% (for system-level installs), then see if in-use updates work. Review URL: http://codereview.chromium.org/6538091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75899 0039d316-1c4b-4281-b951-d872f2087c98
* Add product-specific flags to the rename command in the registry. This ↵grt@chromium.org2011-02-182-8/+11
| | | | | | | | | | | fixes a regression that prevented in-place upgrades of Chrome Frame from working. BUG=73329 TEST=Follow the steps in the bug. Between steps 4 and 5, check that the "cmd" registry value in HKLM\Software\Google\Update\Clients\{8BA986DA-5100-405E-AA35-86F34A02ACBF} contains "--chrome-frame". Review URL: http://codereview.chromium.org/6541029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75412 0039d316-1c4b-4281-b951-d872f2087c98
* Temp dir cleanup:grt@chromium.org2011-02-1815-179/+226
| | | | | | | | | | | | | | | | - use ScopedTempDir in work items that need backup space for rollback - all work items that need backup space take a parent dir in which they create temp dirs - use ScopedTempDir in a few other places - renamed some parameters in certain functions so that the same name is used everywhere While I was at it, I couldn't help but replace Append(UTF8ToWide(version.GetString())) with the more pleasing AppendASCII(version.GetString()) BUG=70368 TEST=existing tests in installer_util_unittests cover the changes Review URL: http://codereview.chromium.org/6538025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75392 0039d316-1c4b-4281-b951-d872f2087c98
* Switch from wcsftime to GetDateFormat to avoid crash in setup.tommi@chromium.org2011-02-173-0/+36
| | | | | | | | | TEST=Fix for crash in setup. See bug for details. BUG=73212 Review URL: http://codereview.chromium.org/6533009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75305 0039d316-1c4b-4281-b951-d872f2087c98
* New installation validator machinery to check the machine state. This CL ↵grt@chromium.org2011-02-162-0/+181
| | | | | | | | | | | contains the third and final part of the validator: helper functions to cause the firing of nonfatal test failures for violations. These are to be used by other tests that mutate the machine state. BUG=none TEST=none Review URL: http://codereview.chromium.org/6499010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75059 0039d316-1c4b-4281-b951-d872f2087c98
* New installation validator machinery to check the machine state. This CL ↵grt@chromium.org2011-02-143-0/+885
| | | | | | | | | | | | | | | | contains the first two parts of the validator: 1. installer::InstallationValidator class, used by setup.exe to confirm that all is well following an installer operation. Violations are logged at ERROR level. 2. validate_installation.exe, used by humans to check the overall state of a machine. The third part, in which violations fire nonfatal test failures for use in other tests, will follow in a subsequent CL. BUG=none TEST=Run validate_installation.exe on machine(s) containing all conceivable permutations of Chrome and Chrome Frame, and see if it reports any violations. Review URL: http://codereview.chromium.org/6490024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74819 0039d316-1c4b-4281-b951-d872f2087c98
* Fix *RegValueWorkItem to handle a case where previous value is empty.amit@chromium.org2011-02-114-20/+70
| | | | | | | | | | | Not handling correctly caused a crash. Added unit tests to cover those cases. BUG=71953 TEST=covered by installer util unit tests Review URL: http://codereview.chromium.org/6485026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74675 0039d316-1c4b-4281-b951-d872f2087c98
* Fix user-to-system-level installation delegation. This looks to have been ↵robertshield@chromium.org2011-02-113-15/+16
| | | | | | | | | | | | broken since r66096. BUG=72620 TEST=Install user level Chrome then system level Chrome. Observer that user level Chrome removes itself and delegates to system level. Review URL: http://codereview.chromium.org/6490008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74609 0039d316-1c4b-4281-b951-d872f2087c98
* Keep a track of which directories are being created when expanding the ↵tommi@chromium.org2011-02-102-4/+24
| | | | | | | | | | | | | installation archive. This is mostly to keep the noise level in the log down (the "directory already exists" entries were over half of the verbose log). TEST=The only change should be that the verbose installer log should be smaller. BUG=none Review URL: http://codereview.chromium.org/6484009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74480 0039d316-1c4b-4281-b951-d872f2087c98
* Support for --quick-enable-cf in the installer.tommi@chromium.org2011-02-072-0/+6
| | | | | | | | | | | | | After installing chrome with multi-install, you can run setup from the Installer folder with --quick-enable-cf to install Chrome Frame from the same location (using the same binaries). The operation is quick since all the shared binaries are already there and only need to be registered. NOTE: The switch needs to be coupled with --system-level for system installs and always requires --multi-install. TEST=After installing Chrome with --multi-install, run setup from the Installer folder with --quick-enable-cf --multi-install. For system installations also remember to include --system-level. Chrome Frame should then be installed as well from the same folder in multi mode. BUG=none Review URL: http://codereview.chromium.org/6349098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74000 0039d316-1c4b-4281-b951-d872f2087c98
* Calling set_ignore_failure(true) in NoRollbackWorkItemList.tommi@chromium.org2011-02-041-0/+1
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/6286105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73806 0039d316-1c4b-4281-b951-d872f2087c98
* Unconditionally remove "-multifail" from "ap" values. Previously, ↵grt@chromium.org2011-02-0313-111/+120
| | | | | | | | | | | "-multifail" was added if a --multi-install run failed for any reason. Now, setup.exe always removes it. As a result, it is only left behind when setup.exe crashes (it is added by mini_installer.exe). BUG=70878 TEST=run a mini_installer.exe with --multi-install (e.g., --multi-install --system-level --chrome --verbose-logging) and try two things: 1) kill setup.exe and make sure that -multifail is left in an "ap" value; 2) cause setup.exe to fail in a non-crash way (e.g., bump up "pv" in Chrome's Clients key so that setup.exe exits with HIGHER_VERSION_EXISTS) then make sure that -multifail is not left in any "ap" value. Review URL: http://codereview.chromium.org/6286044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73648 0039d316-1c4b-4281-b951-d872f2087c98
* Register the Chrome Frame elevation policy in the installer.tommi@chromium.org2011-02-032-0/+2
| | | | | | | | | TEST=Run unit test. Verify that there's an elevation policy registered after install and that it gets properly removed on uninstall (ping me for more details). BUG=none Review URL: http://codereview.chromium.org/6368043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73568 0039d316-1c4b-4281-b951-d872f2087c98
* Change UTF8ToUTF16 to accept const StringPiece&.suzhe@google.com2011-01-281-0/+2
| | | | | | | | | BUG=70936 TEST=All unit tests should pass. Review URL: http://codereview.chromium.org/6317016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72921 0039d316-1c4b-4281-b951-d872f2087c98
* wstring: use a few more FilePaths to remove Hack functionsevan@chromium.org2011-01-279-55/+52
| | | | | | | | BUG=69467 Review URL: http://codereview.chromium.org/6332018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72884 0039d316-1c4b-4281-b951-d872f2087c98
* wstring: use a few more FilePaths to remove Hack functionsevan@chromium.org2011-01-276-68/+80
| | | | | | | | BUG=69467 Review URL: http://codereview.chromium.org/6377011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72728 0039d316-1c4b-4281-b951-d872f2087c98
* More installer refactoring in the interest of fixing some bugs and cleaning ↵grt@chromium.org2011-01-2551-1751/+2536
| | | | | | | | | | | | | | | | | | | | | | | | | things up: - Introduced ProductOperations: an interface implemented for each product that takes care of product-specific functions. Each Product owns an instance and delegates certain operations to it. - Removed the use of MasterPreferences by BrowserDistribution so that the former isn't needed outside of the installer. - Replaced PackageProperties with a new BrowserDistribution type (CHROME_BINARIES) - Plumbed the concept of InstallerState more thoroughly through installer - Removed ProductPackageMapping and Package - Moved more registry read ops into ProductState - Validation of products to be installed is now done in CheckPreInstallConditions - Ignore --chrome-frame --ready-mode if chrome is also being installed/updated and a SxS GCF is found (chrome is updated). - Migrates existing single-install Chrome to multi-install where appropriate. - Fixes update to Chrome's uninstallation arguments when Chrome Frame is uninstalled. - Removed dead code from install.cc. - Added code to update products' "ap" values when ready-mode is accepted. - Skip post-install things such as launching the browser when Chrome was implicitly added to the install/upgrade process by virtue of being part of a multi-install. BUG=61609 TEST=run the installer, see it work. existing tests in installer_util_unittests have been updated; new tests are included for ProductState, ChannelInfo, etc. Review URL: http://codereview.chromium.org/6288009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72497 0039d316-1c4b-4281-b951-d872f2087c98
* A new string for setup.exe safeguards.grt@chromium.org2011-01-241-0/+1
| | | | | | | | BUG=61609 TEST=none Review URL: http://codereview.chromium.org/6260017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72334 0039d316-1c4b-4281-b951-d872f2087c98
* Remove obsolete base/lock.h and fix up callers to use the new header file andbrettw@chromium.org2011-01-211-1/+0
| | | | | | | | | | | the base namespace. Fix several files including lock.h unnecessarily. BUG=none TEST=none Original review=http://codereview.chromium.org/6142009/ Patch by leviw@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72106 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug introduced by RegKey change and corresponding unit test.amit@chromium.org2011-01-201-1/+1
| | | | | | | | | BUG=70092 TEST=GoogleUpdateTest.StatsConsent Review URL: http://codereview.chromium.org/6339005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71913 0039d316-1c4b-4281-b951-d872f2087c98
* Regkey functions return error code instead of boolamit@chromium.org2011-01-1926-447/+388
| | | | | | | | | | | | | | | | | | | | | | Change the Regkey helper to consistently use and return LONG instead of bool. Fix RegKey usage all over the code base and get rid of workarounds due to lack of return value. Reviewers: brettw: everything (skip parts for other reviewers if you wish) robertshield,grt: chrome_frame, installer siggi: ceee BUG=none TEST=covered by existing tests Review URL: http://codereview.chromium.org/6090006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71768 0039d316-1c4b-4281-b951-d872f2087c98
* Some new strings for setup.exe safeguard.grt@chromium.org2011-01-191-0/+1
| | | | | | | | BUG=61609 TEST=none Review URL: http://codereview.chromium.org/6310011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71764 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor out of install.cc the set of functions that operate on a work item ↵robertshield@chromium.org2011-01-145-64/+39
| | | | | | | | | | | | | | list for better testability. Write preliminary test framework for testing these functions. BUG=61609 TEST=setup_unittests.exe Review URL: http://codereview.chromium.org/6153003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71473 0039d316-1c4b-4281-b951-d872f2087c98
* Integrate the Ready Mode prompt with IE and Chrome Frame. In Ready Mode, ↵erikwright@chromium.org2011-01-1215-70/+199
| | | | | | | | | | prompts are displayed when the user browses to GCF-enabled sites, allowing the user to permanently activate, permanently decline, or temporarily decline Chrome Frame. BUG=None TEST=chrome_frame_unittests --gtest_filter=Ready* && chrome_frame_unittests --gtest_filter=Infobar* && setup.exe --chrome-frame --ready-mode --multi-install --system--level --chrome Review URL: http://codereview.chromium.org/6040003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71215 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of FilePath::FromWStringHack from google_chrome_distribution.[cc,h].tfarina@chromium.org2011-01-123-12/+14
| | | | | | | | | BUG=24672 TEST=trybots Review URL: http://codereview.chromium.org/6152003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71113 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a SelfRegWorkItem bug that causes it to ignore the ignore_failures_ flag.robertshield@chromium.org2011-01-112-5/+3
| | | | | | | | | BUG=68877 TEST=Installing Chrome with --multi and then Chrome Frame with --multi works. Review URL: http://codereview.chromium.org/6109006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71042 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded includes of chrome_switches.h.thestig@chromium.org2011-01-111-2/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6086003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70978 0039d316-1c4b-4281-b951-d872f2087c98
* Made logging not look up --enable-dcheck from command lineakalin@chromium.org2011-01-111-4/+6
| | | | | | | | | | | | | | | | Made --enable-dcheck a parameter to InitLogging() and fixed up all callsites. BUG=62736 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70782 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70920 Review URL: http://codereview.chromium.org/6070006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70977 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 70920 - Made logging not look up --enable-dcheck from command lineakalin@chromium.org2011-01-101-6/+4
| | | | | | | | | | | | | | | | | Made --enable-dcheck a parameter to InitLogging() and fixed up all callsites. BUG=62736 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70782 Review URL: http://codereview.chromium.org/6070006 TBR=akalin@chromium.org Review URL: http://codereview.chromium.org/6099012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70923 0039d316-1c4b-4281-b951-d872f2087c98
* Made logging not look up --enable-dcheck from command lineakalin@chromium.org2011-01-101-4/+6
| | | | | | | | | | | | | | Made --enable-dcheck a parameter to InitLogging() and fixed up all callsites. BUG=62736 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70782 Review URL: http://codereview.chromium.org/6070006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70920 0039d316-1c4b-4281-b951-d872f2087c98
* Reland "Remove base/scoped_handle_win.h."tfarina@chromium.org2011-01-092-8/+6
| | | | | | | | | | | | | | | Fixed the problem with rlz library. Now should be fine to land this again. This reverts commit 3620d9501af7bff688862c54fdd60f7eb41797f3. Original Review URL: http://codereview.chromium.org/6126002/ BUG=None TEST=trybots Review URL: http://codereview.chromium.org/6110005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70861 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Remove base/scoped_handle_win.h stub and fix up all callers to use ↵thakis@chromium.org2011-01-072-6/+8
| | | | | | | | | | the new location and namespace." This reverts r 70795, it broke the build. TBR=vandebo git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70802 0039d316-1c4b-4281-b951-d872f2087c98
* Remove base/scoped_handle_win.h stub and fix up all callers to use the new ↵tfarina@chromium.org2011-01-072-8/+6
| | | | | | | | | | | location and namespace. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/6126002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70795 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 70782 - Made logging not look up --enable-dcheck from command lineakalin@chromium.org2011-01-071-6/+4
| | | | | | | | | | | | | | | Made --enable-dcheck a parameter to InitLogging() and fixed up all callsites. BUG=62736 TEST=Manual Review URL: http://codereview.chromium.org/6070006 TBR=akalin@chromium.org Review URL: http://codereview.chromium.org/6100007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70783 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-15 05:41:39 +0000