| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
- rolling back http://codereview.chromium.org/48120/
- it turns out the launch behaviour is now specified in the tag
Review URL: http://codereview.chromium.org/42381
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12073 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- According to docs we should not be writing InstallerSuccessLaunchCmdLine
- Might affect gcapi
BUG=1719600
Review URL: http://codereview.chromium.org/48120
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Removing the (not really needed) dependency on chrome\VERSION which works on the try server but breaks on buildbot.
Review URL: http://codereview.chromium.org/42289
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This reverts r11864 - it broke the tree.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11867 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Add the ability to register / unregister dlls at installation / uninstallation time.
Review URL: http://codereview.chromium.org/43138
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11864 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
to ~400.
Review URL: http://codereview.chromium.org/46039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Feedback from ddorwin:
1- Use the right set of permisions for the reg key
2- Only touch the key if user acepted the eula
BUG=1594565
Review URL: http://codereview.chromium.org/42168
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11610 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42155
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11593 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
- reg key lives in hklm but we can write it
BUG=b/1594565
Review URL: http://codereview.chromium.org/43061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11469 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Normalize end of file newlines in chrome/. All files end in a single newline.
Review URL: http://codereview.chromium.org/42015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Fix files with lines > 80 cols. Part 2.
Review URL: http://codereview.chromium.org/40226
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Got app and unit_tests linking with gyp under windows.
Still missing pieces (things don't run).
Review URL: http://codereview.chromium.org/39319
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11302 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Added google_update and install utils.
Review URL: http://codereview.chromium.org/39204
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=1184319,8218
Review URL: http://codereview.chromium.org/39048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=8310
Review URL: http://codereview.chromium.org/39087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10895 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
uninstall time via the uninstall survey page.These uninstall metrics are collected according to the same opt-in policy as the existing UMA code. They are stored along with other prefs in the browser's Local State file. At uninstall time, the Local State file is copied to a temporary location during the file deletion stage and then read to extract the uninstall metrics. If the user selected to have metrics reported, the uninstall metrics are then sent up to the uninstall survey page that is currently opened.
Review URL: http://codereview.chromium.org/27092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Not complete since we are waiting for translations
- For chromium the tooltip says "Browse the internet"
BUG=b/1522969
Review URL: http://codereview.chromium.org/28272
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(or can be deleted).
BUG=7176
Review URL: http://codereview.chromium.org/27258
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
incorrectly.
bug:7802
Review URL: http://codereview.chromium.org/28128
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
for ChromeHTML. This removes the feature where you
can launch Chrome using chromehtml: links in e.g. IE.
BUG=5825
Review URL: http://codereview.chromium.org/21477
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
- Simplified ParseDistributionPreferences a bit
- Added test for new pref
Review URL: http://codereview.chromium.org/27077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
in-application EULA dialog.
Review URL: http://codereview.chromium.org/21437
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9989 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In r9694, nsylvain changed win_util::GetWinVersion to return more specific
values for Windows 6.0 and later.
InstallUtil::IsOSSupported() needs to handle these new enums.
BUG= 7732
R= kuchhal
TEST= None
Review URL: http://codereview.chromium.org/21384
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Versions before 11MR3 crash chrome
- Still need to wire the code.
BUG=38
Review URL: http://codereview.chromium.org/24015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
R=tony (looked over my shoulder before I committed)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
cleanup.
- Stupid bug where we were failing if there was a space or '-' in the path to setup.exe
- Some application still read default browser from Software\Classes\http even on Vista so set that
- Some refactoring of apppaths changes to make a method private that doesn't need to be public.
- Move constants in shell_util where rest of the shell related constants are.
- Remove duplicate attempts to create ChromeHTML key
BUG=7568,6732,6504
Review URL: http://codereview.chromium.org/21259
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add entries for 8 Indian languages to grd files (<translations> section)
* Change the default spellcheck language for new languages to en-US for now. They'll be switched back to
the UI language when we have spell check dictionaries for them
* Add entries for 8 languages to installer's string offset table.
This change will go in after http://codereview.chromium.org/19545 goes in with DEPS file for ICU updated.
BUG=4473
Review URL: http://codereview.chromium.org/19761
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome.exe.
URL=http://codereview.chromium.org/18560/show
BUG=5686
Review URL: http://codereview.chromium.org/19758
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Have files of that type automatically download and open.
Review URL: http://codereview.chromium.org/19403
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: http://codereview.chromium.org/19717
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- The first run import will trigger the eula again : this requires changes in browser_main.cc
so the master prefs are not processed again by the importer process
- The launch of setup.exe to show the eula was using a path that only works on developer builds
this requires relocating a constant from setup_constants to util_constants
BUG=1468838
Review URL: http://codereview.chromium.org/19680
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Collected in setup.exe passed to chrome via return code
- Depends on an updated oem.html and JS code by Glen
BUG=1468838
Review URL: http://codereview.chromium.org/19649
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
checked to accept the EULA.
Review URL: http://codereview.chromium.org/19436
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8839 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Only the ones required at this point
- Requires official build
BUG=1468838
Review URL: http://codereview.chromium.org/19416
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8791 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
- as pointed by huanr
TBR=huanr
Review URL: http://codereview.chromium.org/19032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- html, css and js to live in the installer as resources. The right combo of resources is selected based on system lang
- currently the approach is to have chrome show the eula by spawing setup.exe --show-eula
BUG=1468838
Review URL: http://codereview.chromium.org/18732
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix minor stylistic inconsistencies in some .vcproj files:
* /> tag termination:
net\net_resources.vcproj
* Add empty <ToolFiles>, <References> and <Globals> sections:
net\net_resources.vcproj
third_party\zlib\zlib.vcproj
third_party\libpng\libpng.vcproj
chrome\tools\test\image_diff\image_diff.vcproj
* Remove .\ on file names where its use is inconsistent with the rest
of the file names in the .vcproj:
net\build\net.vcproj
net\build\net_unittests.vcproj
chrome\installer\util\util.vcproj
* Add explicit RootNamespace attribute:
chrome\test\automation\automation.vcproj
testing\gtest.vcproj
* Fix file order in four locales that don't match other locale .vcproj files:
chrome\app\locales\da.vcproj
chrome\app\locales\he.vcproj
chrome\app\locales\zh-TW.vcproj
chrome\app\locales\en-US.vcproj
* Remove duplicate files from the list:
chrome\browser\views\browser_views.vcproj (event_utils.[ch])
Review URL: http://codereview.chromium.org/18555
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8577 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
- Add basic tests for distro params parsing
Review URL: http://codereview.chromium.org/18470
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Path name translation (/ to \) of various MSVSTool attributes.
* Explicit keyword= arguments to MSVSProject. This will likely
go away eventually in favor of uniform behavior.
* Add a relative_path_substitutions array that can be used
to substitute in Visual Studio variable like $(OutDir).
* Add a local_directory_prefix that can be set to './' to only
affect files in the current directory.
* Additional Keyword ordering in Tool attributes to continue to
match the default order Visual Studio generates.
* Add a Derived() proxy class that can wrap a File node to tell
the .vcproj generation that we want the derived file, not its
source(s), in the file list.
* In the individual *.scons files, add the necessary files (mostly
.h files) to file lists, and update MSVSProject() calls with
the additional necessary information.
Result is identical .vcproj files modulo the following differences:
* Four locales .vcproj files (da, en-US, he and zh-TW) with
source file orders that don't match the other locale .vcproj
files have re-ordered file lists to match the rest.
* Cosmetic XML changes (white space, ending tags) in:
chrome/app/chrome_dll.vcproj
chrome/app/generated_resources.vcproj
net/build/net_resources.vcproj
* Removal or addition of ./ prefixes from various files that don't
match the other file specifications within their individual
.vcproj files:
chrome/installer/util/util.vcproj
net/build/net.vcproj
net/build/net_unittests.vcproj
* Add missing empty sections (<ToolFiles>, <References>, <Globals>)
for consistency with other .vcproj files:
chrome/tools/test/image_diff/image_diff.vcproj
third_party/libpng/libpng.vcproj
third_party/zlib/zlib.vcproj
* Add missing RootNameSpace attribute:
chrome/test/automation/automation.vcproj
testing/gtest.vcproj
* Use && instead of \r\n as a command separator, to sidestep
XML-generation problems:
chrome/app/chrome_exe.vcproj
* Remove unnecessary (?) duplicate files in the file list:
chrome/browser/views/browser_views.vcproj
(event_utils.cc and event_utils.h were duplicated)
Review URL: http://codereview.chromium.org/17603
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8253 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
possibly crashes) in ObserverListTest.BUG=6286
This CL has expanded to include some cleanup and refactoring of test_suite and related files, so that this logging change (and other improvements) are applied to all unit tests.
Review URL: http://codereview.chromium.org/18003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
to match where the .vcproj file lives.
Review URL: http://codereview.chromium.org/17349
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
When we updated gtest, this method became private
(GTEST_FATAL_FAILURE_). Use the public methods instead.
This is only a problem on official builds.
Review URL: http://codereview.chromium.org/17440
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Is not needed after that point
BUG = 1517308
Review URL: http://codereview.chromium.org/16552
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
methods to be more friendly to use with scoped_ptr. Change
all the callsites.
Review URL: http://codereview.chromium.org/16270
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
updated ICU dep that uses it as well.
Add a SHARED scons command-line flag to build shared libraries.
Review URL: http://codereview.chromium.org/16477
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(project files still to come). To wit:
* Solution file configuration is in *_sln.scons files (base\base_sln.scons,
chrome\chrome_sln.scons).
* Individual Project file configuration is in the the .scons file for
the relevant target (base\base_unittests.scons,
third_party\libxml\libxml.scons, etc.)--that is, where their file
lists will live.
* MSVSProject() calls are currently placeholders that establish
the existence of Project Nodes (and Project dependencies) but don't yet
have actual Project configuration information (file lists, .vsprops, etc.).
* Configuraiton is very manual. In particular, the entries in the .sln
file will be written out in exactly the order specified in the
configuration(s). The current ordering is taken from our existing
.sln files, so we can generate virtually the same configurations
on output.
* Generated solution files are nearly byte-for-byte identical
with our existing .sln files, modulo:
* net\dump_cache has a WebsiteProperties sections (making that
configurable per project isn't important right now);
* sandbox\sandbox.sln was missing a dependency of base.vcproj on
on debug_message.vcproj (present in other .sln files)
* webkit\webkit.sln was missing dependencies of WebCore.vcproj on
libxml_config.vcproj and libxslt_config.vcproj (present in
chrome.sln);
* add a handful of other miscellaneous missing dependencies on various
.vcproj definitions in chrome.sln (present in other .sln files).
* remove stats_viewer.csproj from chrome.sln (sorry, mbelshe),
which was complicating the solution configuration with unnecessary
(for us) "Mixed Platform" types;
* All MSVSFolder(), MSVSProject() and MSVSSolution() calls have
hard-wired guid= values taken from our existing configuration,
so we can: 1) verify generation of working configs; 2) minimize
diffs when checking in generated .sln files. We can remove
these in the future in favor of extracting them from existing
.sln files if we wish.
* Add ChromeMSVSFolder(), ChromeMSVSProject() and ChromeMSVSSolution()
wrappers to chromium_builders.py, that gate the underlying call to
the env.MSVS*() builders based on whether env.Bit('msvs') is set
(i.e., we're in --mode=msvs).
* Remove platform-specific gating of to-be-ported .scons files that we
now need to load on any platform to generate coheren MSVS files.
Move the env.Bit('windows') tests for actually building their
executables into the individual .scons files.
Review URL: http://codereview.chromium.org/14472
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7297 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Patch fails otherwise on non-Windows platforms.
Review URL: http://codereview.chromium.org/14478
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/14012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13685
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6655 0039d316-1c4b-4281-b951-d872f2087c98
|