summaryrefslogtreecommitdiffstats
path: root/chrome/installer/util
Commit message (Collapse)AuthorAgeFilesLines
* FBTF: Remove unneeded headers from base/ (part 4)thestig@chromium.org2010-08-073-0/+3
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2819094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55345 0039d316-1c4b-4281-b951-d872f2087c98
* Remove GetSwitchValue() from chrome/* where easy.evan@chromium.org2010-08-067-30/+33
| | | | | | Review URL: http://codereview.chromium.org/3057033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55176 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Remove unneeded headers from base/ (part 1)thestig@chromium.org2010-08-051-1/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3071012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55034 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Remove GetSwitchValue() from chrome/* where easy."evan@chromium.org2010-08-043-12/+10
| | | | | | | | This reverts commit r54966. Meant to try it, not commit it, sorry everyone. :( git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54969 0039d316-1c4b-4281-b951-d872f2087c98
* Remove GetSwitchValue() from chrome/* where easy.evan@chromium.org2010-08-043-10/+12
| | | | | | Review URL: http://codereview.chromium.org/3057033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54966 0039d316-1c4b-4281-b951-d872f2087c98
* Add #include utf_string_conversions.h to all files that use ASCIIToWide andbrettw@chromium.org2010-08-031-0/+1
| | | | | | | | | | | | | | | ASCIIToUTF16. I removed string_util includes from a few places where it obviously wasn't needed. In a separate pass, I'm going to remove ASCIITo* from string_util, then I'm going to do an even later pass to find the unnecessary string_util.h includes and remove them. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3058027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54746 0039d316-1c4b-4281-b951-d872f2087c98
* Move ASCIIToWide and ASCIIToUTF16 to utf_string_conversions.h. I've found itbrettw@chromium.org2010-07-311-1/+3
| | | | | | | | | | | | | | | | | | | | | | | weird that UTF8ToWide is in utf_string_conversions, but ASCIIToWide is in string_util.h. This should help some dependencies since string_util changes much more frequently than utf_string_conversions and fewer files will now need string_utils. Since this requires a lot of changes, this keeps a forward-declaration in string_util so I can update the entire project incrementally. This change updates base and net only. I removed some includes of string_util from header files in net. In particular, url_request_context which involved creating a new .cc file to implement a function (already virtual so there's no speed penalty). It turns out a lot of files were getting string_util from this include, so I had to update a bunch of random files to now explicitly include string_util.h TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3076013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54456 0039d316-1c4b-4281-b951-d872f2087c98
* Convert more callers of the integer/string functions to usingbrettw@chromium.org2010-07-315-13/+25
| | | | | | | | | | string_number_conversions.h TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3013046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54454 0039d316-1c4b-4281-b951-d872f2087c98
* Convert DictionaryValue's keys to std::string (from wstring).viettrungluu@chromium.org2010-07-301-4/+5
| | | | | | | | | | | | Everything now needs to be changed to avoid the deprecated wstring methods; this includes the unit tests. BUG=23581 TEST=all our tests still pass Review URL: http://codereview.chromium.org/3075010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54359 0039d316-1c4b-4281-b951-d872f2087c98
* Drop usage of IntToWString in switch values; we can use ASCII now.evan@chromium.org2010-07-301-1/+1
| | | | | | Review URL: http://codereview.chromium.org/3037034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54286 0039d316-1c4b-4281-b951-d872f2087c98
* base/ header cleanup. Forward declaration instead of including.erg@google.com2010-07-282-0/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3068004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53969 0039d316-1c4b-4281-b951-d872f2087c98
* Fix line ending with white spaces in some files.tfarina@chromium.org2010-07-281-2/+2
| | | | | | | | | | | BUG=50266 TEST=None Signed-off-by: Thiago Farina <tfarina@chromium.org> Review URL: http://codereview.chromium.org/3046028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53956 0039d316-1c4b-4281-b951-d872f2087c98
* Add undeclared virtual destructors part 2ziadh@chromium.org2010-07-271-1/+5
| | | | | | | | | | | | | Preventative maintainance for abstract classes that do not declare virtual destructors. Base classes that do not declare their destructors as virtual could potentially lead to memory leaks. r=jar BUG=47469 Review URL: http://codereview.chromium.org/3032024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53831 0039d316-1c4b-4281-b951-d872f2087c98
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-2630-0/+30
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Use FRIEND_TEST_ALL_PREFIXES some more.phajdan.jr@chromium.org2010-07-261-3/+2
| | | | | | | | | TEST=compile BUG=44549 Review URL: http://codereview.chromium.org/3032025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53706 0039d316-1c4b-4281-b951-d872f2087c98
* Windows: Add --organic flag to simulate an organic install for testing purposes.estade@chromium.org2010-07-231-1/+7
| | | | | | | | | BUG=none TEST=run with --organic --first-run Review URL: http://codereview.chromium.org/3047011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53546 0039d316-1c4b-4281-b951-d872f2087c98
* TBR: revert r53542. It was committed with the wrong commit message.estade@chromium.org2010-07-231-7/+1
| | | | | | TBR=asargent git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53544 0039d316-1c4b-4281-b951-d872f2087c98
* First cut at content settings exceptions lists.estade@chromium.org2010-07-231-1/+7
| | | | | | | | | | | This only shows the existing exceptions (doesn't allow you to add or remove them). It also only works for image exceptions. It always shows the exceptions, instead of hiding/showing them when you press the exceptions button. BUG=48862 TEST=manual Review URL: http://codereview.chromium.org/2856058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53542 0039d316-1c4b-4281-b951-d872f2087c98
* Remove <iostream> where possible.erg@google.com2010-07-205-5/+0
| | | | | | | | | | | | | <iostream> creates a static initializer. Most people don't need <iostream> anyway--they really need <ostream> for operator<< overloads. <iostream> should *never* be included in a header file; <iosfwd> exists for that purpose. BUG=none TEST=none Review URL: http://codereview.chromium.org/3014015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53083 0039d316-1c4b-4281-b951-d872f2087c98
* Update daily channel name from "canary" to "canary build".huanr@chromium.org2010-07-141-1/+1
| | | | | | | | | BUG=38334,48921 TEST="mini_installer --chrome-sxs", check about box, about:version, start menu shortcut name Review URL: http://codereview.chromium.org/2931018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52401 0039d316-1c4b-4281-b951-d872f2087c98
* file_util: Move deprecated function UpOneDirectoryOrEmpty into an anonymous ↵tfarina@chromium.org2010-07-091-2/+18
| | | | | | | | | | | | | | namespace. This function is used in one place and is deprecated, so would be good to move it there so no one can make other uses of it. BUG=24672 TEST=trybots Review URL: http://codereview.chromium.org/2809049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51963 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor check for organic install into GoogleUpdateSettings, for use elsewhere.mirandac@google.com2010-07-022-0/+20
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2836041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51564 0039d316-1c4b-4281-b951-d872f2087c98
* Allow suppression of first run bubble from master preferences.mirandac@google.com2010-06-242-4/+7
| | | | | | | | | BUG=18185 TEST= add "suppress_first_run_bubble:true" to distribution section of master_preferences. run as first_run, and watch bubble not appear. Review URL: http://codereview.chromium.org/2812022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50734 0039d316-1c4b-4281-b951-d872f2087c98
* Allow randomized search engines in selection dialog.mirandac@google.com2010-06-162-2/+6
| | | | | | | | | | | | | | | | | | | | Add an option in the master_preferences to randomize the order of logos in the search engine selection screen. This allows us to cull out a small subset of users to take part in a test of the effects of logo position on search engine choice. I also filed http://crbug.com/46606 to remind me to revert this change when testing is complete. BUG=46302 TEST=Add the following options to master_preferences: "distribution": { "search_engine_experiment": true, "search_engine_experiment_randomize": true } Run a few times as --first-run, and see search engines appear in random order in the selection box. Review URL: http://codereview.chromium.org/2808006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49950 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid a crash when installed version info is not obtainable.estade@chromium.org2010-06-151-0/+1
| | | | | | | | | | | I'm pretty sure the problem is due to users downgrading to versions where --product-version is not available. See the bug for more details. BUG=46547 TEST=none Review URL: http://codereview.chromium.org/2813005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49824 0039d316-1c4b-4281-b951-d872f2087c98
* Resubmit of r49346 that caused mysterious test failures on the bot.robertshield@chromium.org2010-06-129-279/+288
| | | | | | | | | | | | | | | | | | | Original change: Fix problem whereby the "-full" magic value is removed from the "ap" value when a differential update for CF fails (it should remain unless the update succeeds). Also, fix problem with installer return codes being squashed. This was a regression introduced in http://src.chromium.org/viewvc/chrome?view=rev&revision=41322. BUG=46051,40607 TEST=Cause a differential update to fail, observe that the "ap" value contains a "-full". TBR=ananta Review URL: http://codereview.chromium.org/2737006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49636 0039d316-1c4b-4281-b951-d872f2087c98
* Win: Use different AppUserModelID for SxS installs.mattm@chromium.org2010-06-117-16/+37
| | | | | | | | | BUG=44572 TEST=see bug Review URL: http://codereview.chromium.org/2616002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49477 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting this as it caused installer_unit_tests to fail. Please fix and reland.ananta@chromium.org2010-06-108-284/+277
| | | | | | | | | | | | | | | | | Revert 49346 - Fix problem whereby the "-full" magic value is removed from the "ap" value when a differential update for CF fails (it should remain unless the update succeeds). Also, fix problem with installer return codes being squashed. This was a regression introduced in http://src.chromium.org/viewvc/chrome?view=rev&revision=41322. BUG=46051,40607 TEST=Cause a differential update to fail, observe that the "ap" value contains a "-full". Review URL: http://codereview.chromium.org/2773002 TBR=robertshield@chromium.org Review URL: http://codereview.chromium.org/2725007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49359 0039d316-1c4b-4281-b951-d872f2087c98
* Update SxS/Exp channel name to final name "Canary".mattm@chromium.org2010-06-101-1/+1
| | | | | | | | | BUG=37129,38334 TEST=install sxs, check about box, about:version, start menu shortcut name Review URL: http://codereview.chromium.org/2753003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49352 0039d316-1c4b-4281-b951-d872f2087c98
* Fix problem whereby the "-full" magic value is removed from the "ap" value ↵robertshield@chromium.org2010-06-108-277/+284
| | | | | | | | | | | | | | when a differential update for CF fails (it should remain unless the update succeeds). Also, fix problem with installer return codes being squashed. This was a regression introduced in http://src.chromium.org/viewvc/chrome?view=rev&revision=41322. BUG=46051,40607 TEST=Cause a differential update to fail, observe that the "ap" value contains a "-full". Review URL: http://codereview.chromium.org/2773002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49346 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a couple of issues with MSI support through upgrades:robertshield@chromium.org2010-06-072-0/+39
| | | | | | | | | | | | | | 1) When installing from an msi, remove any uninstall shortcuts currently present for that type (system/per-user) of install. 2) When uninstalling, proactively delete the MSI marker from the Omaha ClientState key to avoid an uninstall-reinstall scenario which can cause a reinstall of a non-msi build to be tagged as being msi-managed. BUG=45252,45273 TEST=Install non-MSI GCF, then install MSI GCF. Observe only a single ARP dialog entry. Then uninstall MSI GCF and quickly reinstall non-MSI GCF, again observe a single ARP dialog entry. Review URL: http://codereview.chromium.org/2459003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49069 0039d316-1c4b-4281-b951-d872f2087c98
* Use DISALLOW_COPY_AND_ASSIGN instead of DISALLOW_EVIL_CONSTRUCTORS in chrome ↵tfarina@chromium.org2010-06-061-2/+2
| | | | | | | | | | | directory. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/2657003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49024 0039d316-1c4b-4281-b951-d872f2087c98
* Win SxS: Creating a new shortcut with enable-udd-profiles uses wrong icon.mattm@chromium.org2010-06-035-13/+9
| | | | | | | | | BUG=44847 TEST=see bug Review URL: http://codereview.chromium.org/2557001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48871 0039d316-1c4b-4281-b951-d872f2087c98
* Linux/GTK: implement update notification.estade@chromium.org2010-06-032-16/+15
| | | | | | | | | BUG=45148 TEST=compile chrome with PRODUCT_VERSION manually set to something higher than the current version (e.g. 7.0.0.0), and manually set the upgrade detector time to something short (like 10 seconds). Launch chrome and wait a short time for the update notification to appear. The update notification should pulse every few seconds, and should stop pulsing when the user opens the wrench menu. The about menu item should launch a dialog that allows the user to restart chrome, restoring the current session. Review URL: http://codereview.chromium.org/2365003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48795 0039d316-1c4b-4281-b951-d872f2087c98
* Separate version env variable for different distributions.huanr@chromium.org2010-05-285-1/+13
| | | | | | | | BUG=26819 Review URL: http://codereview.chromium.org/2339001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48495 0039d316-1c4b-4281-b951-d872f2087c98
* Enable the spdy A/B test for SxS installations. npn_with_http and npn_with_spdy lzheng@chromium.org2010-05-272-2/+8
| | | | | | | | | | | | will be enabled at 50% of chance. BUG=45022 TEST=Use command-line flag --chrome-sxs to force the browser as SxS, go to gmail.com, login/logout, check about:histograms, you should see xx_spdytrial_xxx histograms. Review URL: http://codereview.chromium.org/2188001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48404 0039d316-1c4b-4281-b951-d872f2087c98
* Enable warning 4389 as an error on windows builds. This will make mbelshe@chromium.org2010-05-271-2/+2
| | | | | | | | | | | | windows builds more similar to linux/mac, which already treat signed/ unsigned equality comparisons as warnings (and hence errors). BUG=44471 TEST=none Review URL: http://codereview.chromium.org/2222002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48395 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Another dependency the bbot missed!!!"rafaelw@chromium.org2010-05-261-2/+2
| | | | | | | | | | | | | | | | | | This reverts commit 161f7fd3bdd425167af9fe26fdc5373a2ff44c98. Revert "Missed a file as part of checkin for r48186" This reverts commit cff86beba5938209393a6c3bccced62a7f3ff36b. Revert "Enable warning 4389 as an error on windows builds. This will make" This reverts commit c78936bcfc65b98edf288191d927a495b0364621. TBR=mbelshe Review URL: http://codereview.chromium.org/2253001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48238 0039d316-1c4b-4281-b951-d872f2087c98
* Another dependency the bbot missed!!!mbelshe@chromium.org2010-05-251-2/+2
| | | | | | | | | BUG=44471 TEST=none Review URL: http://codereview.chromium.org/2201001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48198 0039d316-1c4b-4281-b951-d872f2087c98
* Fix import path for create_string_rc.pytony@chromium.org2010-05-241-0/+1
| | | | | | | | TBR=mark Review URL: http://codereview.chromium.org/2089022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48009 0039d316-1c4b-4281-b951-d872f2087c98
* Reenable nacl_ui_tests on Windows + fix win64 issue.gregoryd@google.com2010-05-201-3/+5
| | | | | | | | | | Some functions in master_preferences_dummy.cc are now called but they are still not relevant for the 64-bit binary. BUG=44371 Review URL: http://codereview.chromium.org/2115011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47825 0039d316-1c4b-4281-b951-d872f2087c98
* Using different Version environment variable for SxS.huanr@chromium.org2010-05-196-3/+11
| | | | | | | | | | | BUG=44474 TEST=mini_installer.exe --chrome-sxs. The first run should start regardless what is set for CHROME_VERSION. Review URL: http://codereview.chromium.org/2101006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47600 0039d316-1c4b-4281-b951-d872f2087c98
* Changes the toast inactive duration to 3000 days to effectively disable it.gwilson@google.com2010-05-121-1/+1
| | | | | | | | | | | BUG=43891 TEST=Trigger toast scenario, it should only appear if user data dir is 3000 days old. R=cpu Review URL: http://codereview.chromium.org/2016009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46994 0039d316-1c4b-4281-b951-d872f2087c98
* Windows: Make file_util::Delete("c:\\foo_dir", false) work correctly. Add ↵thestig@chromium.org2010-05-077-7/+7
| | | | | | | | | | more unit tests for Delete. BUG=42374 TEST=included Review URL: http://codereview.chromium.org/1763008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46725 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 46633 - Windows: Make file_util::Delete("c:\\foo_dir", false) work ↵zork@chromium.org2010-05-077-7/+7
| | | | | | | | | | | | | correctly. Add more unit tests for Delete. BUG=42374 TEST=included Review URL: http://codereview.chromium.org/1763008 TBR=thestig@chromium.org Review URL: http://codereview.chromium.org/2038004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46640 0039d316-1c4b-4281-b951-d872f2087c98
* Windows: Make file_util::Delete("c:\\foo_dir", false) work correctly. Add ↵thestig@chromium.org2010-05-067-7/+7
| | | | | | | | | | more unit tests for Delete. BUG=42374 TEST=included Review URL: http://codereview.chromium.org/1763008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46633 0039d316-1c4b-4281-b951-d872f2087c98
* Escape special characters in installer strings (rc file).tony@chromium.org2010-05-061-1/+5
| | | | | | Review URL: http://codereview.chromium.org/1980006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46549 0039d316-1c4b-4281-b951-d872f2087c98
* Win SxS: Use SxS icon on the shortcuts in start menu, etc.mattm@chromium.org2010-05-051-2/+10
| | | | | | | | | BUG=37119 TEST=build official mini_installer, install with and without --chrome-sxs, check icons of created entries Review URL: http://codereview.chromium.org/1959003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46502 0039d316-1c4b-4281-b951-d872f2087c98
* r46025 reverted r46023 which caused a build break on chromeos.prasadt@chromium.org2010-04-302-6/+0
| | | | | | | | | | | | | | | This change reverts r46025 and fixes the build break which is just a one line change in chrome/browser/first_run_gtk.cc to move the definition of Upgrade::new_command_line_ to be inside a #if. Details on the change and code review feedback for the original CL can be found at http://codereview.chromium.org/1633021. BUG=40975 TEST=none Review URL: http://codereview.chromium.org/1691022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46103 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r46023: "Detect new instance of the browser when running in the ↵willchan@chromium.org2010-04-302-0/+6
| | | | | | | | | | background in persistent" Broke the build. Review URL: http://codereview.chromium.org/1718024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46025 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-31 01:14:21 +0000