| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
<style type="text/css">
<!--
body { font-family: arial,sans-serif; background-color: #fff; margin-top: 2; }
.c { width: 4; height: 4; }
a:link { color: #00c; }
a:visited { color: #551a8b; }
a:active { color: #f00; }
.form-noindent { background-color: #fff; border: 1px solid #c3d9ff; }
-->
</style>
<style type="text/css"><!--
.gaia.le.lbl { font-family: Arial, Helvetica, sans-serif; font-size: smaller; }
.gaia.le.fpwd { font-family: Arial, Helvetica, sans-serif; font-size: 70%; }
.gaia.le.chusr { font-family: Arial, Helvetica, sans-serif; font-size: 70%; }
.gaia.le.val { font-family: Arial, Helvetica, sans-serif; font-size: smaller; }
.gaia.le.button { font-family: Arial, Helvetica, sans-serif; font-size: smaller; }
.gaia.le.rem { font-family: Arial, Helvetica, sans-serif; font-size: smaller; }
.gaia.captchahtml.desc { font-family: arial, sans-serif; font-size: smaller; }
.gaia.captchahtml.cmt { font-family: arial, sans-serif; font-size: smaller; font-style: italic; }
--></style>
<head>
<title>Google Accounts</title>
<style type="text/css"><!--
body {
font-family: arial, sans-serif;
margin: 0;
padding: 13px 15px 15px;
}
.body {
margin: 0;
}
div.errorbox-good {}
div.errorbox-bad {}
div.errormsg { color: red; font-size: smaller; font-family: arial,sans-serif;}
font.errormsg { color: red; font-size: smaller; font-family: arial,sans-serif;}
div.topbar {
font-size:smaller;
margin-right: -5px;
text-align:right;
white-space:nowrap;
}
div.header {
margin-bottom: 9px;
margin-left: -2px;
position:relative;
zoom: 1
}
div.header img.logo {
border: 0;
float:left;
}
div.header div.headercontent {
float:right;
margin-top:17px;
}
div.header:after{
content:".";
display:block;
height:0;
clear:both;
visibility:hidden;
}
div.pagetitle {
font-weight:bold;
}
.footer {
color: #666;
font-size: smaller;
margin-top: 40px;
text-align: center;
}
table#signupform {
left: -5px;
top: -7px;
position:relative;
}
table#signupform td{
padding: 7px 5px;
}
table#signupform td table td{
padding: 1px;
}
hr {
border: 0;
background-color:#DDDDDD;
height: 1px;
width: 100%;
text-align: left;
margin: 5px;
}
--></style>
</head>
<body dir="ltr"
onLoad=
"gaia_setFocus();"
>
<div id="main">
<?sc # for new logo transition ?>
<div class=header>
<a href='https://www.google.com/accounts/'>
<img class=logo
src='https://www.google.com/intl/en/images/logos/accounts_logo.gif'
alt="Google" />
</img>
</a>
</div>
<div id=maincontent>
<table border="0" width="100%" cellpadding=0 cellspacing=0>
<tr>
<td width="75%" valign="top">
<h3>
Chromium Code Reviews
uses Google Accounts for Sign In.
</h3>
<p><font size=-1>
Google is not affiliated with the contents of
<b>Chromium Code Reviews</b>
or its owners. If you sign in, Google will share your email address with
<b>Chromium Code Reviews</b>,
but not your password or any other personal information.
</font></p>
<p><font size=-1>
<b>Chromium Code Reviews</b>
may use your email address to personalize your experience on their website.
</font></p>
</td>
<td style="padding-left: 10px;" valign="top" align="center">
<div id="rhs">
<div id="rhs_login_signup_box">
<script><!--
function gaia_onLoginSubmit() {
if (window.gaiacb_onLoginSubmit) {
return gaiacb_onLoginSubmit();
} else {
return true;
}
}
function gaia_setFocus() {
var f = null;
if (document.getElementById) {
f = document.getElementById("gaia_loginform");
} else if (window.gaia_loginform) {
f = window.gaia_loginform;
}
if (f) {
if (f.Email && (f.Email.value == null || f.Email.value == "")) {
f.Email.focus();
} else if (f.Passwd) {
f.Passwd.focus();
}
}
}
--></script>
<style type="text/css"><!--
div.errormsg { color: red; font-size: smaller; font-family:arial,sans-serif; }
font.errormsg { color: red; font-size: smaller; font-family:arial,sans-serif; }
--></style>
<style type="text/css"><!--
.gaia.le.lbl { font-family: Arial, Helvetica, sans-serif; font-size: smaller; }
.gaia.le.fpwd { font-family: Arial, Helvetica, sans-serif; font-size: 70%; }
.gaia.le.chusr { font-family: Arial, Helvetica, sans-serif; font-size: 70%; }
.gaia.le.val { font-family: Arial, Helvetica, sans-serif; font-size: smaller; }
.gaia.le.button { font-family: Arial, Helvetica, sans-serif; font-size: smaller; }
.gaia.le.rem { font-family: Arial, Helvetica, sans-serif; font-size: smaller; }
.gaia.captchahtml.desc { font-family: arial, sans-serif; font-size: smaller; }
.gaia.captchahtml.cmt { font-family: arial, sans-serif; font-size: smaller; font-style: italic; }
--></style>
<form id="gaia_loginform"
action="https://www.google.com/accounts/ServiceLoginAuth?service=ah&sig=d71ef8b8d6150b23958ad03b3bf546b7" method="post"
onsubmit=
"return(gaia_onLoginSubmit());"
>
<div id="gaia_loginbox">
<table class="form-noindent" cellspacing="3" cellpadding="5" width="100%" border="0">
<tr>
<td valign="top" style="text-align:center" nowrap="nowrap"
bgcolor="#e8eefa">
<input type="hidden" name="ltmpl"
value="gm">
<div class="loginBox">
<table id="gaia_table" align="center" border="0" cellpadding="1" cellspacing="0">
<tr>
<td colspan="2" align="center">
<font size="-1">
Sign in with your
</font>
<table>
<tr>
<td valign="top">
<img src="google_transparent.gif"
alt="Google">
</img>
</td>
<td valign="middle">
<font size="+0"><b>Account</b></font>
</td>
</tr>
</table>
</td>
</tr>
<script type="text/javascript"><!--
function onPreCreateAccount() {
return true;
}
function onPreLogin() {
if (window["onlogin"] != null) {
return onlogin();
} else {
return true;
}
}
--></script>
<tr>
<td colspan="2" align="center">
</td>
</tr>
<tr>
<td nowrap="nowrap">
<div align="right">
<span class="gaia le lbl">
Email:
</span>
</div>
</td>
<td>
<input type="hidden" name="continue" id="continue"
value="http://codereview.chromium.org/_ah/login?continue=http://codereview.chromium.org/210007/description" />
<input type="hidden" name="service" id="service"
value="ah" />
<input type="hidden" name="ltmpl" id="ltmpl"
value="gm" />
<input type="hidden" name="ltmpl" id="ltmpl"
value="gm" />
<input type="hidden" name="ahname" id="ahname"
value="Chromium Code Reviews" />
<input type="hidden"
name="GALX"
value="LfA4LnZj1gM" />
<input type="text" name="Email" id="Email"
size="18" value=""
class='gaia le val'
/>
</td>
</tr>
<tr>
<td></td>
<td align="left">
</td>
</tr>
<tr>
<td align="right" nowrap="nowrap">
<span class="gaia le lbl">
Password:
</span>
</td>
<td>
<input type="password"
name="Passwd" id="Passwd"
size="18"
class="gaia le val"
/>
</td>
</tr>
<tr>
<td>
</td>
<td align="left">
</td>
</tr>
<tr>
<td align="right" valign="top">
<input type="checkbox" name="PersistentCookie" id="PersistentCookie"
value="yes"
checked='checked'
/>
<input type="hidden" name='rmShown' value="1" />
</td>
<td>
<label for="PersistentCookie" class="gaia le rem">
Stay signed in
</label>
</td>
</tr>
<tr>
<td>
</td>
<td align="left">
<input type="submit" class="gaia le button" name="signIn"
value="Sign in"
/>
</td>
</tr>
<tr id="ga-fprow">
<td colspan="2" height="33.0" class="gaia le fpwd"
align="center" valign="bottom">
<a href="http://www.google.com/support/accounts/bin/answer.py?answer=48598&hl=en&ctx=ch_ServiceLogin&p=ah&fpUrl=https%3A%2F%2Fwww.google.com%2Faccounts%2FForgotPasswd%3FfpOnly%3D1%26continue%3Dhttp%253A%252F%252Fcodereview.chromium.org%252F_ah%252Flogin%253Fcontinue%253Dhttp%253A%252F%252Fcodereview.chromium.org%252F210007%252Fdescription%26service%3Dah%26ltmpl%3Dgm"
target=_top>
Can't access your account?
</a>
</td>
</tr>
</table>
</div>
</td>
</tr>
</table>
</div>
<input type="hidden" name="asts"
id="asts"
value="">
</form>
<form id="gaia_universallogin"
action="https://www.google.com/accounts/ServiceLoginAuth?service=ah&sig=d71ef8b8d6150b23958ad03b3bf546b7" method="post"
onsubmit="return(gaia_onLoginSubmit());">
<input type="hidden" name="continue" id="continue"
value="http://codereview.chromium.org/_ah/login?continue=http://codereview.chromium.org/210007/description" />
<input type="hidden" name="service" id="service"
value="ah" />
<input type="hidden" name="ltmpl" id="ltmpl"
value="gm" />
<input type="hidden" name="ltmpl" id="ltmpl"
value="gm" />
<input type="hidden" name="ahname" id="ahname"
value="Chromium Code Reviews" />
<input type="hidden" name="ltmpl" id="ltmpl"
value="gm" />
</form>
<br/>
<table class="form-noindent" border="0" cellpadding="6" cellspacing="3" width="100%">
<tr>
<td bgcolor="#e8eefa" align="center" style="font-size:83%">
<b>Don't have a Google Account?
</b><br/>
<a href='https://www.google.com/accounts/NewAccount?continue=http%3A%2F%2Fcodereview.chromium.org%2F_ah%2Flogin%3Fcontinue%3Dhttp%3A%2F%2Fcodereview.chromium.org%2F210007%2Fdescription&service=ah&ltmpl=gm&sig=909f6cca8e55250406f8bfbd303ab4a9' >
<b>Create an account now</b>
</a>
</td>
</tr>
</table>
</div>
<br/>
</div>
</td>
</tr>
</table>
</div>
<div class="footer">
©2009 Google
-
<a href='http://www.google.com/'>Google Home</a>
-
<a href='https://www.google.com/accounts/TOS?hl=en'>Terms of Service</a>
-
<a href='http://www.google.com/intl/en/privacy.html'>Privacy Policy</a>
-
<a href='http://www.google.com/support/accounts?hl=en'>Help</a>
</div>
</div>
</body>
</html>
Review URL: http://codereview.chromium.org/210007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26685 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
architecture.
BUG=20948
TEST=none
Review URL: http://codereview.chromium.org/215016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/210014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26550 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We statically link this.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/193120
TBR=nick@chromium.org
Review URL: http://codereview.chromium.org/205020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26339 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Why: Simpler build code. If everybody includes it, it should be included automatically.
Why now: The webkit chromium builds need it be specified, since can't default to build/common.gypi.
What was done:
1. build/common.gypi's contents were moved to a new file build/gyp_chromium.gypi
2. tools/gyp/gyp_chromium was moved to build/gyp_chromium and made to automatically include build/gyp_chromium.gypi.
3. lots of gyp files were fixed to not refer to build/common.gypi any more.
4. o3d which also builds independently of chrome, was fixed to have a gyp_o3d that includes gyp_chromium.gypi too.
5. build/common.gypi was left empty, because there are some external projects that still refer to it.
Things that are left to do after this patch is in:
1. The following external files (in other repositories) need to stop include common.gypi
./third_party/hunspell/hunspell.gyp
./third_party/icu/icu.gyp
./v8/tools/gyp/v8.gyp
2. Once nobody refers to common.gypi anymore, delete common.gypi
-or-
Delete gyp_chromium.gypi and move its content back to common.gypi
Tested on mac, win and linux. On win, got a few unit tests errors on chrome bookmarks, which should not be related. I'm running again with clobber to verify.
Review URL: http://codereview.chromium.org/206006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26302 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
We statically link this.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/193120
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26300 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
launch.
Review URL: http://codereview.chromium.org/194118
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/201115
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
method from FileUtil API.
BUG=None
TEST=ran installer_util_unittests.exe
Review URL: http://codereview.chromium.org/202002
Patch from Thiago Farina <thiago.farina@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/203059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=21600
Review URL: http://codereview.chromium.org/200100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Landing patch for Thiago Farina, original review: http://codereview.chromium.org/187005
BUG=None
TEST=run unit_tests.exe, base_unittests.exe.
Review URL: http://codereview.chromium.org/193101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/192076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26036 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are 4 flavors of the toast, if the user qualfies
use coin toss to show one of them.
- Accordingly we have now four experiment sets:
TAxx, TBxx, TCxx, TDxx.
BUG=b/1484308
TEST= see bug for instructions
Review URL: http://codereview.chromium.org/200092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
create_string_rc.py actually creates.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/203031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
experimentation.
Review URL: http://codereview.chromium.org/202049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
mini_installer. Does not cause them to be registered.
Review URL: http://codereview.chromium.org/202044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
prevent it from trying to create Chrome desktop shortcuts.
Review URL: http://codereview.chromium.org/196068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/196067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25775 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
references to third_party/icu38 and icudt38.dll with third_party/icu and icudt42.dll in vsprops and cc files. Also, update the icu data module name and the icu data symbol in icu_util.cc
In addition, add a dummy C++ source file (xmldummy_mac.cc) to libxml to work around an Xcode bug (xmllint and xmlcatalog are linked with gcc rather than g++ even though it's linked to a "C++ library", libicuuc.a).
Also updated is the test results for net_util_unittests.
This will not be landed until deps/third_party/icu42 is ready for all 3 platforms (Windows VS build files are not yet updated there).
BUG=8198
TEST=On all platforms, all the targets are built fine.
Review URL: http://codereview.chromium.org/172031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
It was failing to generate $(OutDir)\obj\global_intermediate\installer_util_strings\installer_util_strings.*
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/196046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25694 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=gregoryd
Review URL: http://codereview.chromium.org/196045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adjusting installer_util_strings to attempt to avoid incredibuild
mysterious failure.
BUG=None
TEST=None
TBR=gregoryd
Review URL: http://codereview.chromium.org/200046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=run installer_util_unittests.exe
Review URL: http://codereview.chromium.org/173042
Patch from Thiago Farina <thiago.farina@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25464 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This follows the Mac model where all the installer binaries are generated at
the same time.
Review URL: http://codereview.chromium.org/181036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
in the source.
Review URL: http://codereview.chromium.org/178011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25072 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=18635
Review URL: http://codereview.chromium.org/174418
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=run installer_util_unittests.exe
Review URL: http://codereview.chromium.org/174189
Patch from Thiago Farina <thiago.farina@gmail.com>.
Review URL: http://codereview.chromium.org/173369
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24320 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also remove the no longer used GTK variable, since the GTK_PATH modification
was a hack for 32-bit binaries on 64-bit distros.
Review URL: http://codereview.chromium.org/173286
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/174003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=14023
TEST=Make sure the option of choosing a different browser shows up during un
Review URL: http://codereview.chromium.org/174194
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/149217
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
allow user to choose another browser as default."
reverting r23841
Review URL: http://codereview.chromium.org/173131
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
browser as default.
BUG=14023
TEST=Make sure the option of choosing a different browser shows up during uninstall (and works as intended) iff chrome is set as default browser.
Review URL: http://codereview.chromium.org/172080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23841 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=19745
Review URL: http://codereview.chromium.org/174084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23835 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
if the binaries are not available. For
a Chrome-branded release, pull the binaries
from elsewhere.
For a release where CHROME_PERSONALIZATION is disabled,
(e.g. Mac and Linux), we needn't build this.
TEST=build and run with a variety of commandline flags + clobber try server
BUG=none
Review URL: http://codereview.chromium.org/171096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
track down all callers, also removes the
deprecated function that uses std::wstring.
BUG=3078 (http://crbug.com/3078)
TEST=run base_unittests, installer_util_unittests, net_unittests, setup_unittests, and unit_tests.
Review URL: http://codereview.chromium.org/164537
Patch from Thiago Farina.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=19440
Review URL: http://codereview.chromium.org/172067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23618 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=19440
Review URL: http://codereview.chromium.org/171069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
for one user.
BUG=19222
TEST=Install and set Chrome as default for two different users on the same machine. Uninstall for one user and make sure the default browser still works for the second user.
Review URL: http://codereview.chromium.org/164454
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23496 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=17581
TEST=Build mini_installer debug build and make sure it has manifest.
Review URL: http://codereview.chromium.org/165474
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- The TS data is not meaningful, we don't want to mix it
- The base group moved from TS00 to TS80, since omaha does not show 00
- A better random number generator is used
BUG=b/1484308
TEST=see bug for instructions
Review URL: http://codereview.chromium.org/164513
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23377 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/165405
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
static pthread lib linked into avcodec.
BUG=17174,18466,16010
TEST=play http://people.xiph.org/~tterribe/tmp/sign_irene_cif-3qi.ogg
Review URL: http://codereview.chromium.org/164165
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22816 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=12849
TEST=none
Review URL: http://codereview.chromium.org/160623
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22535 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=12849
TEST=none
Review URL: http://codereview.chromium.org/160560
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22493 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Purify
Release - no tcmalloc
This is done more pedantically than I'd like,
so I've left in some TODOs. Eventually either gyp needs to support some
notion of inheritance in configurations, or maybe we can make clever use
of includes.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/159362
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change depends on change 159539 that is currently under review and a new chrome2.ico that is yet to be added to the repository.
BUG=12701
TEST=Specify an alternate icon in --installerdata file and make sure that icon is used for shortcuts and it not changed later by updates.
Review URL: http://codereview.chromium.org/159618
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22314 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently we are parsing master preferences file three time on startup. Since we only return an int bit mask flag after parsing preferences, it can not handle any preference other than boolean and we end up reading it again for first run tabs and ping delay. This change refactors all the preferences parsing logic to directly pass around DictionaryValue object around in Chrome as well as installer.
No functional change but this will make adding a new preference for new icon more logical since we will not read the preferences file once again.
BUG=12701
TEST=Make sure all the distribution preferences still work as before.
Review URL: http://codereview.chromium.org/159539
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22284 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
So instead of --register-chrome-browser="<path>\chrome.exe"--register-chrome-browser-suffix=".<user>" it is actually --register-chrome-browser="<path>\chrome.exe" --register-chrome-browser-suffix=".<user>".
BUG=3641
TBR=huanr
Committed: http://src.chromium.org/viewvc/22194
Review URL: http://codereview.chromium.org/160481
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22282 0039d316-1c4b-4281-b951-d872f2087c98
|